Title: bpo-42073: allow classmethod to wrap other classmethod-like descriptors by ambv · Pull Request #27115 · python/cpython · GitHub
Open Graph Title: bpo-42073: allow classmethod to wrap other classmethod-like descriptors by ambv · Pull Request #27115 · python/cpython
X Title: bpo-42073: allow classmethod to wrap other classmethod-like descriptors by ambv · Pull Request #27115 · python/cpython
Description: Patch by Erik Welch. bpo-19072 (#8405) allows classmethod to wrap other descriptors, but this does not work when the wrapped descriptor mimics classmethod. The current PR fixes this. In Python 3.8 and before, one could create a callable descriptor such that this works as expected (see Lib/test/test_decorators.py for examples): class A: @myclassmethod def f1(cls): return cls @classmethod @myclassmethod def f2(cls): return cls In Python 3.8 and before, A.f2() return A. Currently in Python 3.9, it returns type(A). This PR make A.f2() return A again. As of #8405, classmethod calls obj.__get__(type) if obj has __get__. This allows one to chain @classmethod and @property together. When using classmethod-like descriptors, it's the second argument to __get__--the owner or the type--that is important, but this argument is currently missing. Since it is None, the "owner" argument is assumed to be the type of the first argument, which, in this case, is wrong (we want A, not type(A)). This PR updates classmethod to call obj.__get__(type, type) if obj has __get__. Co-authored-by: Erik Welch erik.n.welch@gmail.com Original patch was on the 3.9 branch so I recreated it on main. Passes -uall. https://bugs.python.org/issue42073
Open Graph Description: Patch by Erik Welch. bpo-19072 (#8405) allows classmethod to wrap other descriptors, but this does not work when the wrapped descriptor mimics classmethod. The current PR fixes this. In Python 3.8...
X Description: Patch by Erik Welch. bpo-19072 (#8405) allows classmethod to wrap other descriptors, but this does not work when the wrapped descriptor mimics classmethod. The current PR fixes this. In Python 3.8...
Opengraph URL: https://github.com/python/cpython/pull/27115
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6c24388c-f5b7-3409-a4e1-215d739414c4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 86C2:19C81F:4540A2:5D4D17:6A5A74B8 |
| html-safe-nonce | d44f5030110b0b05c2dd8c16bf53620f928bb0a4d03cbe3a245f8d0ad1e749d3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NkMyOjE5QzgxRjo0NTQwQTI6NUQ0RDE3OjZBNUE3NEI4IiwidmlzaXRvcl9pZCI6IjM5MjA0NDM2NDk5MDIxNDY3NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0a9cb2639cff767e94584b1e57a319c8920f3bf7e49b3eb88df6b5e700a67b9d |
| hovercard-subject-tag | pull_request:689181068 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/27115/files |
| twitter:image | https://avatars.githubusercontent.com/u/55281?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/55281?s=400&v=4 |
| og:image:alt | Patch by Erik Welch. bpo-19072 (#8405) allows classmethod to wrap other descriptors, but this does not work when the wrapped descriptor mimics classmethod. The current PR fixes this. In Python 3.8... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 922bdba685ea48400234d557977f0e32d9adbae6f5125725b4f48cacc6801106 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 0437efb828a4041956ce45d1f7fe69fff38926c7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width