Title: bpo-36027: Fix a potential refcount bug in long_pow by mdickinson · Pull Request #26690 · python/cpython · GitHub
Open Graph Title: bpo-36027: Fix a potential refcount bug in long_pow by mdickinson · Pull Request #26690 · python/cpython
X Title: bpo-36027: Fix a potential refcount bug in long_pow by mdickinson · Pull Request #26690 · python/cpython
Description: This PR fixes a reference counting bug introduced in #13266 and identified by @tim-one in #26662: if we don't set temp to NULL, and if the value it has at this point is retained until the end of the function, then we end up doing an extra decref. I spent some time trying to identify a test-case that exercises this bug, and failed - I couldn't find a code path where temp isn't re-used at some point. Nevertheless, it's a potential point of fragility for maintenance of this code. https://bugs.python.org/issue36027
Open Graph Description: This PR fixes a reference counting bug introduced in #13266 and identified by @tim-one in #26662: if we don't set temp to NULL, and if the value it has at this point is retained until the end o...
X Description: This PR fixes a reference counting bug introduced in #13266 and identified by @tim-one in #26662: if we don't set temp to NULL, and if the value it has at this point is retained until the e...
Opengraph URL: https://github.com/python/cpython/pull/26690
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:f74daf5d-d42d-456c-a077-51eb33507ae5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 85E0:19A853:19DD44:22E255:6A5A6A4A |
| html-safe-nonce | 913b22f61a83475bd1eaceb6ed3c89dfea8aee44947f506a673f3a26e0df90fc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NUUwOjE5QTg1MzoxOURENDQ6MjJFMjU1OjZBNUE2QTRBIiwidmlzaXRvcl9pZCI6IjE0OTY4MzkyMzA3NTk5OTQ3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3324867c854d79c9ba5463e26e0807165ff0b743391a71eb4a3f1376848037c6 |
| hovercard-subject-tag | pull_request:668812134 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/26690/files |
| twitter:image | https://avatars.githubusercontent.com/u/662003?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/662003?s=400&v=4 |
| og:image:alt | This PR fixes a reference counting bug introduced in #13266 and identified by @tim-one in #26662: if we don't set temp to NULL, and if the value it has at this point is retained until the end o... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 922bdba685ea48400234d557977f0e32d9adbae6f5125725b4f48cacc6801106 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 03575fc589c0e2692de839d7ca2b3aa5b5179f52 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width