René's URL Explorer Experiment


Title: bpo-30891: Fix importlib _find_and_load() race condition by vstinner · Pull Request #2646 · python/cpython · GitHub

Open Graph Title: bpo-30891: Fix importlib _find_and_load() race condition by vstinner · Pull Request #2646 · python/cpython

X Title: bpo-30891: Fix importlib _find_and_load() race condition by vstinner · Pull Request #2646 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Rewrite importlib _get_module_lock(): it is now responsible to hold the imp lock directly. _find_and_load() now holds the module lock to check if name is in sys.modules to prevent a race condition

X Description: Rewrite importlib _get_module_lock(): it is now responsible to hold the imp lock directly. _find_and_load() now holds the module lock to check if name is in sys.modules to prevent a race condition

Opengraph URL: https://github.com/python/cpython/pull/2646

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fa43788d-6290-6af5-f28f-a68e95df6034
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDDA0:18BA88:89409BD:BFB16A5:6A506FE3
html-safe-nonce44f2753ac5bc2b599f640175d5b753dfd289e1bf0222222fc03f0696cfc4c071
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEREEwOjE4QkE4ODo4OTQwOUJEOkJGQjE2QTU6NkE1MDZGRTMiLCJ2aXNpdG9yX2lkIjoiODk0MjkxNjc5NzcwNjAzNDkxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac77872da804fb46b281f48c7b0d0aeb346a1bc256a003dad2310e9888631f1630
hovercard-subject-tagpull_request:129717687
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/2646/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2565736239855127251fe55e285aec91812cda4bccc4ba593f0059b9a977f475/python/cpython/pull/2646
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2565736239855127251fe55e285aec91812cda4bccc4ba593f0059b9a977f475/python/cpython/pull/2646
og:image:altRewrite importlib _get_module_lock(): it is now responsible to hold the imp lock directly. _find_and_load() now holds the module lock to check if name is in sys.modules to prevent a race condition
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7ac0ad2f2c7e4b9056617355fd9e33e22b0c8df9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/2646#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2646
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2646
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/2646
Reloadhttps://github.com/python/cpython/pull/2646
Reloadhttps://github.com/python/cpython/pull/2646
Please reload this pagehttps://github.com/python/cpython/pull/2646
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/2646
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
Conversationhttps://github.com/python/cpython/pull/2646
Commits1 (1)https://github.com/python/cpython/pull/2646/commits
Checkshttps://github.com/python/cpython/pull/2646/checks
Files changedhttps://github.com/python/cpython/pull/2646/files
bpo-30891: Fix importlib _find_and_load() race conditionhttps://github.com/python/cpython/pull/2646#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 10, 2017https://github.com/python/cpython/pull/2646#issue-241767015
Please reload this pagehttps://github.com/python/cpython/pull/2646
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
serhiy-storchakahttps://github.com/serhiy-storchaka
July 10, 2017 16:12https://github.com/python/cpython/pull/2646#event-1157118113
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 10, 2017https://github.com/python/cpython/pull/2646#event-1157118160
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 10, 2017 https://github.com/python/cpython/pull/2646#pullrequestreview-48956222
View reviewed changes https://github.com/python/cpython/pull/2646/files
Lib/importlib/_bootstrap.pyhttps://github.com/python/cpython/pull/2646/files#diff-dba786ae26d5505c4c367a93b1179c2f80f2433d983b84bacb9001fb552f0761
vstinnerhttps://github.com/vstinner
Jul 10, 2017https://github.com/python/cpython/pull/2646#discussion_r126469457
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/2646
ncoghlanhttps://github.com/ncoghlan
Jul 11, 2017https://github.com/python/cpython/pull/2646#discussion_r126574323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/2646
vstinnerhttps://github.com/vstinner
Jul 11, 2017https://github.com/python/cpython/pull/2646#discussion_r126621341
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#2665https://github.com/python/cpython/pull/2665
Please reload this pagehttps://github.com/python/cpython/pull/2646
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 10, 2017https://github.com/python/cpython/pull/2646#issuecomment-314157377
Please reload this pagehttps://github.com/python/cpython/pull/2646
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 10, 2017 https://github.com/python/cpython/pull/2646#pullrequestreview-48956666
View reviewed changes https://github.com/python/cpython/pull/2646/files
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/2646#pullrequestreview-48956666
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/2646
Lib/importlib/_bootstrap.pyhttps://github.com/python/cpython/pull/2646/files#diff-dba786ae26d5505c4c367a93b1179c2f80f2433d983b84bacb9001fb552f0761
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 10, 2017https://github.com/python/cpython/pull/2646#discussion_r126469847
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/2646
vstinnerhttps://github.com/vstinner
Jul 10, 2017https://github.com/python/cpython/pull/2646#discussion_r126475782
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/2646
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
brettcannonhttps://github.com/brettcannon
ncoghlanhttps://github.com/ncoghlan
July 10, 2017 16:26https://github.com/python/cpython/pull/2646#event-1157144434
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 10, 2017 https://github.com/python/cpython/pull/2646#pullrequestreview-48960445
View reviewed changes https://github.com/python/cpython/pull/2646/files
Lib/importlib/_bootstrap.pyhttps://github.com/python/cpython/pull/2646/files#diff-dba786ae26d5505c4c367a93b1179c2f80f2433d983b84bacb9001fb552f0761
serhiy-storchakahttps://github.com/serhiy-storchaka
Jul 10, 2017https://github.com/python/cpython/pull/2646#discussion_r126473140
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/2646
vstinnerhttps://github.com/vstinner
Jul 10, 2017https://github.com/python/cpython/pull/2646#discussion_r126473903
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/2646
https://github.com/vstinner
bpo-30891https://bugs.python.org/issue?@action=redirect&bpo=30891
: Fix importlib _find_and_load() race conditionhttps://github.com/python/cpython/pull/2646/commits/2ccc9249c6226a7a7d5ff43efff81be313036891
2ccc924https://github.com/python/cpython/pull/2646/commits/2ccc9249c6226a7a7d5ff43efff81be313036891
https://github.com/brettcannon
brettcannonhttps://github.com/brettcannon
Jul 10, 2017 https://github.com/python/cpython/pull/2646#pullrequestreview-49007673
View reviewed changes https://github.com/python/cpython/pull/2646/files/2ccc9249c6226a7a7d5ff43efff81be313036891
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
4f9a446https://github.com/python/cpython/commit/4f9a446f3fb42f800e73cd9414dd1eccb3ca4fa7
Jul 10, 2017https://github.com/python/cpython/pull/2646#event-1157599457
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
July 10, 2017 20:52https://github.com/python/cpython/pull/2646#event-1157599755
vstinnerhttps://github.com/vstinner
Jul 10, 2017 https://github.com/python/cpython/pull/2646#ref-commit-fe6e686
https://github.com/vstinner
bpo-30891https://bugs.python.org/issue?@action=redirect&bpo=30891
: Fix importlib _find_and_load() race condition (https://github.com/python/cpython/commit/fe6e686c27ce3a3ecdf03803cff7e230dee5530d
#2646https://github.com/python/cpython/pull/2646
) (https://github.com/python/cpython/commit/fe6e686c27ce3a3ecdf03803cff7e230dee5530d
#2651https://github.com/python/cpython/pull/2651
)https://github.com/python/cpython/commit/fe6e686c27ce3a3ecdf03803cff7e230dee5530d
fe6e686https://github.com/python/cpython/commit/fe6e686c27ce3a3ecdf03803cff7e230dee5530d
4f9a446https://github.com/python/cpython/commit/4f9a446f3fb42f800e73cd9414dd1eccb3ca4fa7
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Jul 11, 2017 https://github.com/python/cpython/pull/2646#ref-pullrequest-241960822
bpo-30891: importlib _find_and_load() try/except #2665 https://github.com/python/cpython/pull/2665
https://github.com/tjb900
tjb900https://github.com/tjb900
Feb 6, 2019 https://github.com/python/cpython/pull/2646#ref-pullrequest-356555255
bpo-34572: change _pickle unpickling to use import rather than retrieving from sys.modules #9047 https://github.com/python/cpython/pull/9047
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2646
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/2646/files/eb94e2d1ca4b5bbd59cde2c88823e55064187dbb
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/python/cpython/pull/2646/files/2ccc9249c6226a7a7d5ff43efff81be313036891
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
Please reload this pagehttps://github.com/python/cpython/pull/2646
https://github.com/vstinner
https://github.com/brettcannon
https://github.com/ncoghlan
https://github.com/serhiy-storchaka
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.