René's URL Explorer Experiment


Title: bpo-27334: roll back transaction if sqlite3 context manager fails to commit by erlend-aasland · Pull Request #26202 · python/cpython · GitHub

Open Graph Title: bpo-27334: roll back transaction if sqlite3 context manager fails to commit by erlend-aasland · Pull Request #26202 · python/cpython

X Title: bpo-27334: roll back transaction if sqlite3 context manager fails to commit by erlend-aasland · Pull Request #26202 · python/cpython

Description: https://bugs.python.org/issue27334

Open Graph Description: https://bugs.python.org/issue27334

X Description: https://bugs.python.org/issue27334

Opengraph URL: https://github.com/python/cpython/pull/26202

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:46e75dd9-d85c-bd88-2924-64f7953377b4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC59A:CD10D:174D7F6:1E2A35E:696B27D3
html-safe-nonce5c7daab238ed23dcba1a782c91fcec193f82b30afb3a4d4501f82f859a4e0401
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTlBOkNEMTBEOjE3NEQ3RjY6MUUyQTM1RTo2OTZCMjdEMyIsInZpc2l0b3JfaWQiOiIzMDU5NTc0MDY3MzY3MTkyNTMxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac975fb87b6230671b06adcf31b2e421bb60ec5c786bdaa571a8849387f95abd08
hovercard-subject-tagpull_request:646231223
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/26202/files
twitter:imagehttps://avatars.githubusercontent.com/u/13780613?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/13780613?s=400&v=4
og:image:althttps://bugs.python.org/issue27334
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/26202/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26202%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26202%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/26202/files
Reloadhttps://github.com/python/cpython/pull/26202/files
Reloadhttps://github.com/python/cpython/pull/26202/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/26202/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/26202/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:sqlite-ctx-rollbackhttps://github.com/erlend-aasland/cpython/tree/sqlite-ctx-rollback
Conversation 52 https://github.com/python/cpython/pull/26202
Commits 26 https://github.com/python/cpython/pull/26202/commits
Checks 0 https://github.com/python/cpython/pull/26202/checks
Files changed https://github.com/python/cpython/pull/26202/files
Please reload this pagehttps://github.com/python/cpython/pull/26202/files
bpo-27334: roll back transaction if sqlite3 context manager fails to commit https://github.com/python/cpython/pull/26202/files#top
Show all changes 26 commits https://github.com/python/cpython/pull/26202/files
a1361e6 bpo-27334: sqlite3 context manager now rolls back if commit fails May 15, 2021 https://github.com/python/cpython/pull/26202/commits/a1361e60d23a39bf864b4f2098aae7523f3dd368
7111bba Add NEWS May 17, 2021 https://github.com/python/cpython/pull/26202/commits/7111bba1b94915321d44dc1df4ac18060c89d50e
0b63628 Add explanatory comments to test May 17, 2021 https://github.com/python/cpython/pull/26202/commits/0b63628251816366c165022713e42036c037d351
fce98f1 PEP 8 May 17, 2021 https://github.com/python/cpython/pull/26202/commits/fce98f123aae175d59136246ecce9d4e50f185fa
3edde50 Prevent accidentally clearing the current exception May 19, 2021 https://github.com/python/cpython/pull/26202/commits/3edde50ae639f95db9097ce607734fcbb705f06b
99c4157 ... and clean up May 19, 2021 https://github.com/python/cpython/pull/26202/commits/99c4157ae13e005152f2dfd2cba879658b90ef27
581bc44 Use test.support.SHORT_TIMEOUT to wait for sub-process May 19, 2021 https://github.com/python/cpython/pull/26202/commits/581bc44be6fea5e19866683d0984e7fe8ec78603
31f43fa Adjust comment May 19, 2021 https://github.com/python/cpython/pull/26202/commits/31f43faf454caf6abf0f9dead0c55f6178d4ab55
a66828b Make rollback thread friendly, and use _pysqlite_seterror to check th… May 20, 2021 https://github.com/python/cpython/pull/26202/commits/a66828be335f91d69e73fe6cd5189042000f30a9
cdb0d50 Remove unused variable May 22, 2021 https://github.com/python/cpython/pull/26202/commits/cdb0d50a2f09f16badfe7fee85e58c50d4bc83bd
e5fdaf7 Dedent test script using if 1 trick May 22, 2021 https://github.com/python/cpython/pull/26202/commits/e5fdaf712d8dc8502ed8a6fcc94e1be6f5a29317
f67591c Use test.support.TIMEOUT to adjust connection timeout May 25, 2021 https://github.com/python/cpython/pull/26202/commits/f67591cc421ef1fcac915bda39edd492c1b38d87
4e654d0 Address review: make news entry less low level-ish Jun 2, 2021 https://github.com/python/cpython/pull/26202/commits/4e654d05170dfad8d4bc1d488dca7464ae94bd2a
98d3ada Chain exceptions if rollback also fails Jun 2, 2021 https://github.com/python/cpython/pull/26202/commits/98d3adaf5bc02ce0db2fd93246af9d5d4139a508
195edbe Address review Jun 2, 2021 https://github.com/python/cpython/pull/26202/commits/195edbe7c5c4ee6686305fae1d46eaa7f9f30ad4
da26486 Add managed connection helper Jun 3, 2021 https://github.com/python/cpython/pull/26202/commits/da2648612f3b7be540c3108d8cae13cfb3f9ff7d
e5f9e16 Merge branch 'main' into sqlite-ctx-rollback Jun 3, 2021 https://github.com/python/cpython/pull/26202/commits/e5f9e165937d0d67d99c2fe9d8a6ce31ba2f0ec9
43ea594 Fix tests (cannot use managed_connect() bco. shared access Jun 3, 2021 https://github.com/python/cpython/pull/26202/commits/43ea5944c1620f33a13ff12bf7a1d9c5b751c0ff
1d4bcf9 Revert "Fix tests (cannot use managed_connect() bco. shared access" Jun 3, 2021 https://github.com/python/cpython/pull/26202/commits/1d4bcf9536c59bb952a4e379c1c0496206c8c2eb
a4b388e Fix tests (cannot use managed_connect() bco. shared access Jun 3, 2021 https://github.com/python/cpython/pull/26202/commits/a4b388e5260d265c9ad204e1f68c14049dc2b4a1
b03ee62 Merge branch 'main' into sqlite-ctx-rollback Jun 17, 2021 https://github.com/python/cpython/pull/26202/commits/b03ee627679934ebaaaae0fba4761cb31a605a9b
b4c8d39 Merge branch 'main' into sqlite-ctx-rollback Jun 20, 2021 https://github.com/python/cpython/pull/26202/commits/b4c8d399c3245accf4fb97527bec429f12b1f399
da65db8 Merge branch 'main' into sqlite-ctx-rollback Jun 24, 2021 https://github.com/python/cpython/pull/26202/commits/da65db83b02c38db011d989ce44d8c67da442f99
1c93e9f Rewrite test Jun 25, 2021 https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354
a32943c Restore comments Jun 27, 2021 https://github.com/python/cpython/pull/26202/commits/a32943c836d8e85e9a123e98a825417a445388df
175d4a0 Merge branch 'main' into sqlite-ctx-rollback Aug 8, 2021 https://github.com/python/cpython/pull/26202/commits/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5
Clear filters https://github.com/python/cpython/pull/26202/files
Please reload this pagehttps://github.com/python/cpython/pull/26202/files
Please reload this pagehttps://github.com/python/cpython/pull/26202/files
dbapi.py https://github.com/python/cpython/pull/26202/files#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5
2021-05-18-00-17-21.bpo-27334.32EJZi.rst https://github.com/python/cpython/pull/26202/files#diff-d5b8a36935c54d98a21a1dad1ee21d1b7572093e084106f80650f0665ec04d48
connection.c https://github.com/python/cpython/pull/26202/files#diff-f405d0da477c184cd4afb94ce52dfd7fcd4980500a3a5ffe753d0e8cd57638a2
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L578
Lib/sqlite3/test/dbapi.pyhttps://github.com/python/cpython/pull/26202/files#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5
View file https://github.com/erlend-aasland/cpython/blob/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5/Lib/sqlite3/test/dbapi.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/26202/{{ revealButtonHref }}
https://github.com/python/cpython/pull/26202/files#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5
https://github.com/python/cpython/pull/26202/files#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5
https://github.com/python/cpython/pull/26202/files#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5
Please reload this pagehttps://github.com/python/cpython/pull/26202/files
https://github.com/python/cpython/pull/26202/files#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5
https://github.com/python/cpython/pull/26202/files#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5
Misc/NEWS.d/next/Library/2021-05-18-00-17-21.bpo-27334.32EJZi.rsthttps://github.com/python/cpython/pull/26202/files#diff-d5b8a36935c54d98a21a1dad1ee21d1b7572093e084106f80650f0665ec04d48
View file https://github.com/erlend-aasland/cpython/blob/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5/Misc/NEWS.d/next/Library/2021-05-18-00-17-21.bpo-27334.32EJZi.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/26202/{{ revealButtonHref }}
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L580
Modules/_sqlite/connection.chttps://github.com/python/cpython/pull/26202/files#diff-f405d0da477c184cd4afb94ce52dfd7fcd4980500a3a5ffe753d0e8cd57638a2
View file https://github.com/erlend-aasland/cpython/blob/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5/Modules/_sqlite/connection.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/26202/{{ revealButtonHref }}
https://github.com/python/cpython/pull/26202/files#diff-f405d0da477c184cd4afb94ce52dfd7fcd4980500a3a5ffe753d0e8cd57638a2
https://github.com/python/cpython/pull/26202/files#diff-f405d0da477c184cd4afb94ce52dfd7fcd4980500a3a5ffe753d0e8cd57638a2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.