| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:1834ae65-c4a0-1a4b-0aec-85bfd4c21abc |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D30E:AE2F1:2A5622E:386ECE6:6996C8C8 |
| html-safe-nonce | c105f9d95232bd7c6e706970e9721677b60ef19336fb42c6622488008e28eb6b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzBFOkFFMkYxOjJBNTYyMkU6Mzg2RUNFNjo2OTk2QzhDOCIsInZpc2l0b3JfaWQiOiI5OTk4NzMwMDk2NjUwOTk5NzYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d1d2cea2303cc79a7f8d81c909920e41fee264d22e02b3f23fdf34cd199580d0 |
| hovercard-subject-tag | pull_request:646231223 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
| twitter:image | https://avatars.githubusercontent.com/u/13780613?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/13780613?s=400&v=4 |
| og:image:alt | https://bugs.python.org/issue27334 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5513290f8d09a9ed78de519ab8316ed23b2b0ddd5e91d2420df56691d00827e8 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | e258e32a8c50a12656030b21f3279030a774ec82 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26202%2Fcommits%2F1c93e9f1b0dcdaf8b90261923c9e477222005354 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26202%2Fcommits%2F1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
| Reload | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
| Reload | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| pablogsal | https://github.com/pablogsal |
| python:main | https://github.com/python/cpython/tree/main |
| erlend-aasland:sqlite-ctx-rollback | https://github.com/erlend-aasland/cpython/tree/sqlite-ctx-rollback |
|
Conversation
52
| https://github.com/python/cpython/pull/26202 |
|
Commits
26
| https://github.com/python/cpython/pull/26202/commits |
|
Checks
0
| https://github.com/python/cpython/pull/26202/checks |
|
Files changed
| https://github.com/python/cpython/pull/26202/files |
| Please reload this page | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
bpo-27334: roll back transaction if sqlite3 context manager fails to commit
| https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354#top |
|
Show all changes
26 commits
| https://github.com/python/cpython/pull/26202/files |
|
a1361e6
bpo-27334: sqlite3 context manager now rolls back if commit fails
May 15, 2021
| https://github.com/python/cpython/pull/26202/commits/a1361e60d23a39bf864b4f2098aae7523f3dd368 |
|
7111bba
Add NEWS
May 17, 2021
| https://github.com/python/cpython/pull/26202/commits/7111bba1b94915321d44dc1df4ac18060c89d50e |
|
0b63628
Add explanatory comments to test
May 17, 2021
| https://github.com/python/cpython/pull/26202/commits/0b63628251816366c165022713e42036c037d351 |
|
fce98f1
PEP 8
May 17, 2021
| https://github.com/python/cpython/pull/26202/commits/fce98f123aae175d59136246ecce9d4e50f185fa |
|
3edde50
Prevent accidentally clearing the current exception
May 19, 2021
| https://github.com/python/cpython/pull/26202/commits/3edde50ae639f95db9097ce607734fcbb705f06b |
|
99c4157
... and clean up
May 19, 2021
| https://github.com/python/cpython/pull/26202/commits/99c4157ae13e005152f2dfd2cba879658b90ef27 |
|
581bc44
Use test.support.SHORT_TIMEOUT to wait for sub-process
May 19, 2021
| https://github.com/python/cpython/pull/26202/commits/581bc44be6fea5e19866683d0984e7fe8ec78603 |
|
31f43fa
Adjust comment
May 19, 2021
| https://github.com/python/cpython/pull/26202/commits/31f43faf454caf6abf0f9dead0c55f6178d4ab55 |
|
a66828b
Make rollback thread friendly, and use _pysqlite_seterror to check th…
May 20, 2021
| https://github.com/python/cpython/pull/26202/commits/a66828be335f91d69e73fe6cd5189042000f30a9 |
|
cdb0d50
Remove unused variable
May 22, 2021
| https://github.com/python/cpython/pull/26202/commits/cdb0d50a2f09f16badfe7fee85e58c50d4bc83bd |
|
e5fdaf7
Dedent test script using if 1 trick
May 22, 2021
| https://github.com/python/cpython/pull/26202/commits/e5fdaf712d8dc8502ed8a6fcc94e1be6f5a29317 |
|
f67591c
Use test.support.TIMEOUT to adjust connection timeout
May 25, 2021
| https://github.com/python/cpython/pull/26202/commits/f67591cc421ef1fcac915bda39edd492c1b38d87 |
|
4e654d0
Address review: make news entry less low level-ish
Jun 2, 2021
| https://github.com/python/cpython/pull/26202/commits/4e654d05170dfad8d4bc1d488dca7464ae94bd2a |
|
98d3ada
Chain exceptions if rollback also fails
Jun 2, 2021
| https://github.com/python/cpython/pull/26202/commits/98d3adaf5bc02ce0db2fd93246af9d5d4139a508 |
|
195edbe
Address review
Jun 2, 2021
| https://github.com/python/cpython/pull/26202/commits/195edbe7c5c4ee6686305fae1d46eaa7f9f30ad4 |
|
da26486
Add managed connection helper
Jun 3, 2021
| https://github.com/python/cpython/pull/26202/commits/da2648612f3b7be540c3108d8cae13cfb3f9ff7d |
|
e5f9e16
Merge branch 'main' into sqlite-ctx-rollback
Jun 3, 2021
| https://github.com/python/cpython/pull/26202/commits/e5f9e165937d0d67d99c2fe9d8a6ce31ba2f0ec9 |
|
43ea594
Fix tests (cannot use managed_connect() bco. shared access
Jun 3, 2021
| https://github.com/python/cpython/pull/26202/commits/43ea5944c1620f33a13ff12bf7a1d9c5b751c0ff |
|
1d4bcf9
Revert "Fix tests (cannot use managed_connect() bco. shared access"
Jun 3, 2021
| https://github.com/python/cpython/pull/26202/commits/1d4bcf9536c59bb952a4e379c1c0496206c8c2eb |
|
a4b388e
Fix tests (cannot use managed_connect() bco. shared access
Jun 3, 2021
| https://github.com/python/cpython/pull/26202/commits/a4b388e5260d265c9ad204e1f68c14049dc2b4a1 |
|
b03ee62
Merge branch 'main' into sqlite-ctx-rollback
Jun 17, 2021
| https://github.com/python/cpython/pull/26202/commits/b03ee627679934ebaaaae0fba4761cb31a605a9b |
|
b4c8d39
Merge branch 'main' into sqlite-ctx-rollback
Jun 20, 2021
| https://github.com/python/cpython/pull/26202/commits/b4c8d399c3245accf4fb97527bec429f12b1f399 |
|
da65db8
Merge branch 'main' into sqlite-ctx-rollback
Jun 24, 2021
| https://github.com/python/cpython/pull/26202/commits/da65db83b02c38db011d989ce44d8c67da442f99 |
|
1c93e9f
Rewrite test
Jun 25, 2021
| https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
a32943c
Restore comments
Jun 27, 2021
| https://github.com/python/cpython/pull/26202/commits/a32943c836d8e85e9a123e98a825417a445388df |
|
175d4a0
Merge branch 'main' into sqlite-ctx-rollback
Aug 8, 2021
| https://github.com/python/cpython/pull/26202/commits/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5 |
|
Clear filters
| https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
| Please reload this page | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
| Please reload this page | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
Prev
| https://github.com/python/cpython/pull/26202/commits/da65db83b02c38db011d989ce44d8c67da442f99 |
|
Next
| https://github.com/python/cpython/pull/26202/commits/a32943c836d8e85e9a123e98a825417a445388df |
| Please reload this page | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
| https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L587 |
| Lib/sqlite3/test/dbapi.py | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5 |
|
View file
| https://github.com/erlend-aasland/cpython/blob/1c93e9f1b0dcdaf8b90261923c9e477222005354/Lib/sqlite3/test/dbapi.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/26202/commits/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5 |
|
| https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5 |
| Please reload this page | https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354 |
|
| https://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354#diff-a4b73f9e48ee8e071938f6f86b8bb3f1491d71b6ab0a57f7cc447b020f6164d5 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |