René's URL Explorer Experiment


Title: bpo-27334: roll back transaction if sqlite3 context manager fails to commit by erlend-aasland · Pull Request #26202 · python/cpython · GitHub

Open Graph Title: bpo-27334: roll back transaction if sqlite3 context manager fails to commit by erlend-aasland · Pull Request #26202 · python/cpython

X Title: bpo-27334: roll back transaction if sqlite3 context manager fails to commit by erlend-aasland · Pull Request #26202 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: https://bugs.python.org/issue27334

X Description: https://bugs.python.org/issue27334

Opengraph URL: https://github.com/python/cpython/pull/26202

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:3f873025-bb21-9d2e-0db6-609a0a032bee
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC370:E8423:2962933:369CE44:696B285A
html-safe-nonce1eaaf7f519e0428794797a3cdd75899a9d45892c6c065cd3b1e5e8ef10a21a31
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMzcwOkU4NDIzOjI5NjI5MzM6MzY5Q0U0NDo2OTZCMjg1QSIsInZpc2l0b3JfaWQiOiIyOTQwMzk2NzAwNjU3NDYxMzM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac4edcd3cb711f88e5dfd3bc1cd12d250737c9e1a65f7c6b35ebd01fd4102e4534
hovercard-subject-tagpull_request:646231223
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/26202/commits
twitter:imagehttps://opengraph.githubassets.com/143fa9ef2b32693c3d6c49ae1433e5cdef9b1639c397b00c2383cbba9ab18cb1/python/cpython/pull/26202
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/143fa9ef2b32693c3d6c49ae1433e5cdef9b1639c397b00c2383cbba9ab18cb1/python/cpython/pull/26202
og:image:althttps://bugs.python.org/issue27334
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/26202/commits#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26202%2Fcommits
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26202%2Fcommits
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/26202/commits
Reloadhttps://github.com/python/cpython/pull/26202/commits
Reloadhttps://github.com/python/cpython/pull/26202/commits
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/26202/commits
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/26202/commits
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:sqlite-ctx-rollbackhttps://github.com/erlend-aasland/cpython/tree/sqlite-ctx-rollback
Conversationhttps://github.com/python/cpython/pull/26202
Commits26 (26)https://github.com/python/cpython/pull/26202/commits
Checkshttps://github.com/python/cpython/pull/26202/checks
Files changedhttps://github.com/python/cpython/pull/26202/files
bpo-27334: roll back transaction if sqlite3 context manager fails to commithttps://github.com/python/cpython/pull/26202/commits#top
pablogsalhttps://github.com/pablogsal
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:sqlite-ctx-rollbackhttps://github.com/erlend-aasland/cpython/tree/sqlite-ctx-rollback
bpo-27334: sqlite3 context manager now rolls back if commit failshttps://github.com/python/cpython/pull/26202/commits/a1361e60d23a39bf864b4f2098aae7523f3dd368
berkerpeksaghttps://github.com/python/cpython/commits?author=berkerpeksag
a1361e6https://github.com/python/cpython/pull/26202/commits/a1361e60d23a39bf864b4f2098aae7523f3dd368
https://github.com/python/cpython/tree/a1361e60d23a39bf864b4f2098aae7523f3dd368
Add NEWShttps://github.com/python/cpython/pull/26202/commits/7111bba1b94915321d44dc1df4ac18060c89d50e
7111bbahttps://github.com/python/cpython/pull/26202/commits/7111bba1b94915321d44dc1df4ac18060c89d50e
https://github.com/python/cpython/tree/7111bba1b94915321d44dc1df4ac18060c89d50e
Add explanatory comments to testhttps://github.com/python/cpython/pull/26202/commits/0b63628251816366c165022713e42036c037d351
0b63628https://github.com/python/cpython/pull/26202/commits/0b63628251816366c165022713e42036c037d351
https://github.com/python/cpython/tree/0b63628251816366c165022713e42036c037d351
PEP 8https://github.com/python/cpython/pull/26202/commits/fce98f123aae175d59136246ecce9d4e50f185fa
fce98f1https://github.com/python/cpython/pull/26202/commits/fce98f123aae175d59136246ecce9d4e50f185fa
https://github.com/python/cpython/tree/fce98f123aae175d59136246ecce9d4e50f185fa
Prevent accidentally clearing the current exceptionhttps://github.com/python/cpython/pull/26202/commits/3edde50ae639f95db9097ce607734fcbb705f06b
3edde50https://github.com/python/cpython/pull/26202/commits/3edde50ae639f95db9097ce607734fcbb705f06b
https://github.com/python/cpython/tree/3edde50ae639f95db9097ce607734fcbb705f06b
... and clean uphttps://github.com/python/cpython/pull/26202/commits/99c4157ae13e005152f2dfd2cba879658b90ef27
99c4157https://github.com/python/cpython/pull/26202/commits/99c4157ae13e005152f2dfd2cba879658b90ef27
https://github.com/python/cpython/tree/99c4157ae13e005152f2dfd2cba879658b90ef27
Use test.support.SHORT_TIMEOUT to wait for sub-processhttps://github.com/python/cpython/pull/26202/commits/581bc44be6fea5e19866683d0984e7fe8ec78603
581bc44https://github.com/python/cpython/pull/26202/commits/581bc44be6fea5e19866683d0984e7fe8ec78603
https://github.com/python/cpython/tree/581bc44be6fea5e19866683d0984e7fe8ec78603
Adjust commenthttps://github.com/python/cpython/pull/26202/commits/31f43faf454caf6abf0f9dead0c55f6178d4ab55
31f43fahttps://github.com/python/cpython/pull/26202/commits/31f43faf454caf6abf0f9dead0c55f6178d4ab55
https://github.com/python/cpython/tree/31f43faf454caf6abf0f9dead0c55f6178d4ab55
Make rollback thread friendly, and use _pysqlite_seterror to check the return valuehttps://github.com/python/cpython/pull/26202/commits/a66828be335f91d69e73fe6cd5189042000f30a9
a66828bhttps://github.com/python/cpython/pull/26202/commits/a66828be335f91d69e73fe6cd5189042000f30a9
https://github.com/python/cpython/tree/a66828be335f91d69e73fe6cd5189042000f30a9
Remove unused variablehttps://github.com/python/cpython/pull/26202/commits/cdb0d50a2f09f16badfe7fee85e58c50d4bc83bd
cdb0d50https://github.com/python/cpython/pull/26202/commits/cdb0d50a2f09f16badfe7fee85e58c50d4bc83bd
https://github.com/python/cpython/tree/cdb0d50a2f09f16badfe7fee85e58c50d4bc83bd
Dedent test script using if 1 trickhttps://github.com/python/cpython/pull/26202/commits/e5fdaf712d8dc8502ed8a6fcc94e1be6f5a29317
e5fdaf7https://github.com/python/cpython/pull/26202/commits/e5fdaf712d8dc8502ed8a6fcc94e1be6f5a29317
https://github.com/python/cpython/tree/e5fdaf712d8dc8502ed8a6fcc94e1be6f5a29317
Use test.support.TIMEOUT to adjust connection timeouthttps://github.com/python/cpython/pull/26202/commits/f67591cc421ef1fcac915bda39edd492c1b38d87
f67591chttps://github.com/python/cpython/pull/26202/commits/f67591cc421ef1fcac915bda39edd492c1b38d87
https://github.com/python/cpython/tree/f67591cc421ef1fcac915bda39edd492c1b38d87
Address review: make news entry less low level-ishhttps://github.com/python/cpython/pull/26202/commits/4e654d05170dfad8d4bc1d488dca7464ae94bd2a
4e654d0https://github.com/python/cpython/pull/26202/commits/4e654d05170dfad8d4bc1d488dca7464ae94bd2a
https://github.com/python/cpython/tree/4e654d05170dfad8d4bc1d488dca7464ae94bd2a
Chain exceptions if rollback also failshttps://github.com/python/cpython/pull/26202/commits/98d3adaf5bc02ce0db2fd93246af9d5d4139a508
98d3adahttps://github.com/python/cpython/pull/26202/commits/98d3adaf5bc02ce0db2fd93246af9d5d4139a508
https://github.com/python/cpython/tree/98d3adaf5bc02ce0db2fd93246af9d5d4139a508
Address reviewhttps://github.com/python/cpython/pull/26202/commits/195edbe7c5c4ee6686305fae1d46eaa7f9f30ad4
195edbehttps://github.com/python/cpython/pull/26202/commits/195edbe7c5c4ee6686305fae1d46eaa7f9f30ad4
https://github.com/python/cpython/tree/195edbe7c5c4ee6686305fae1d46eaa7f9f30ad4
Add managed connection helperhttps://github.com/python/cpython/pull/26202/commits/da2648612f3b7be540c3108d8cae13cfb3f9ff7d
da26486https://github.com/python/cpython/pull/26202/commits/da2648612f3b7be540c3108d8cae13cfb3f9ff7d
https://github.com/python/cpython/tree/da2648612f3b7be540c3108d8cae13cfb3f9ff7d
Merge branch 'main' into sqlite-ctx-rollbackhttps://github.com/python/cpython/pull/26202/commits/e5f9e165937d0d67d99c2fe9d8a6ce31ba2f0ec9
e5f9e16https://github.com/python/cpython/pull/26202/commits/e5f9e165937d0d67d99c2fe9d8a6ce31ba2f0ec9
https://github.com/python/cpython/tree/e5f9e165937d0d67d99c2fe9d8a6ce31ba2f0ec9
Fix tests (cannot use managed_connect() bco. shared accesshttps://github.com/python/cpython/pull/26202/commits/43ea5944c1620f33a13ff12bf7a1d9c5b751c0ff
43ea594https://github.com/python/cpython/pull/26202/commits/43ea5944c1620f33a13ff12bf7a1d9c5b751c0ff
https://github.com/python/cpython/tree/43ea5944c1620f33a13ff12bf7a1d9c5b751c0ff
Revert "Fix tests (cannot use managed_connect() bco. shared access"https://github.com/python/cpython/pull/26202/commits/1d4bcf9536c59bb952a4e379c1c0496206c8c2eb
1d4bcf9https://github.com/python/cpython/pull/26202/commits/1d4bcf9536c59bb952a4e379c1c0496206c8c2eb
https://github.com/python/cpython/tree/1d4bcf9536c59bb952a4e379c1c0496206c8c2eb
Fix tests (cannot use managed_connect() bco. shared accesshttps://github.com/python/cpython/pull/26202/commits/a4b388e5260d265c9ad204e1f68c14049dc2b4a1
a4b388ehttps://github.com/python/cpython/pull/26202/commits/a4b388e5260d265c9ad204e1f68c14049dc2b4a1
https://github.com/python/cpython/tree/a4b388e5260d265c9ad204e1f68c14049dc2b4a1
Merge branch 'main' into sqlite-ctx-rollbackhttps://github.com/python/cpython/pull/26202/commits/b03ee627679934ebaaaae0fba4761cb31a605a9b
b03ee62https://github.com/python/cpython/pull/26202/commits/b03ee627679934ebaaaae0fba4761cb31a605a9b
https://github.com/python/cpython/tree/b03ee627679934ebaaaae0fba4761cb31a605a9b
Merge branch 'main' into sqlite-ctx-rollbackhttps://github.com/python/cpython/pull/26202/commits/b4c8d399c3245accf4fb97527bec429f12b1f399
b4c8d39https://github.com/python/cpython/pull/26202/commits/b4c8d399c3245accf4fb97527bec429f12b1f399
https://github.com/python/cpython/tree/b4c8d399c3245accf4fb97527bec429f12b1f399
Merge branch 'main' into sqlite-ctx-rollbackhttps://github.com/python/cpython/pull/26202/commits/da65db83b02c38db011d989ce44d8c67da442f99
da65db8https://github.com/python/cpython/pull/26202/commits/da65db83b02c38db011d989ce44d8c67da442f99
https://github.com/python/cpython/tree/da65db83b02c38db011d989ce44d8c67da442f99
Rewrite testhttps://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354
1c93e9fhttps://github.com/python/cpython/pull/26202/commits/1c93e9f1b0dcdaf8b90261923c9e477222005354
https://github.com/python/cpython/tree/1c93e9f1b0dcdaf8b90261923c9e477222005354
Restore commentshttps://github.com/python/cpython/pull/26202/commits/a32943c836d8e85e9a123e98a825417a445388df
a32943chttps://github.com/python/cpython/pull/26202/commits/a32943c836d8e85e9a123e98a825417a445388df
https://github.com/python/cpython/tree/a32943c836d8e85e9a123e98a825417a445388df
Merge branch 'main' into sqlite-ctx-rollbackhttps://github.com/python/cpython/pull/26202/commits/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5
175d4a0https://github.com/python/cpython/pull/26202/commits/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5
https://github.com/python/cpython/tree/175d4a02e3f63d25f6e6aafc4dcd6adb74571dd5
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.