| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:202570cb-8da5-343a-e262-daebc9b4e62a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E8F2:378C0F:1A640CF:246F470:696AAB4F |
| html-safe-nonce | dea6e262cff1971f78bf36d31a1ff1666f6052341a23f9a876933206bd10e94f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOEYyOjM3OEMwRjoxQTY0MENGOjI0NkY0NzA6Njk2QUFCNEYiLCJ2aXNpdG9yX2lkIjoiOTEzMTg4OTAzMzM1NTExMTI0NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a937d252bdfdb57b4aed1bd11a9e61c71f6da7de46f901a7062ae3e9420320a3 |
| hovercard-subject-tag | pull_request:642129430 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/26046/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/db68e0285a607fb0702e156fcff4aeefec025f4d3a42369450686d078b49f5f2/python/cpython/pull/26046 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/db68e0285a607fb0702e156fcff4aeefec025f4d3a42369450686d078b49f5f2/python/cpython/pull/26046 |
| og:image:alt | Replace list comprehensions with generator expressions inside str.join()
Replace list comprehensions with generator expressions inside str.join() in several places in Lib/_pydecimal.py and Lib/arg... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | zkneupper |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd9a979046e6382bd084e2bd873bf65f797125ff |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/26046#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26046 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26046 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/26046 |
| Reload | https://github.com/python/cpython/pull/26046 |
| Reload | https://github.com/python/cpython/pull/26046 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/26046#issue-comment-box |
| zkneupper | https://github.com/zkneupper |
| python:main | https://github.com/python/cpython/tree/main |
| zkneupper:feature/replace_list_comp_with_generator | https://github.com/zkneupper/cpython/tree/feature/replace_list_comp_with_generator |
|
Feature/replace list comp with generator
| https://github.com/python/cpython/pull/26046#top |
| zkneupper | https://github.com/zkneupper |
| python:main | https://github.com/python/cpython/tree/main |
| zkneupper:feature/replace_list_comp_with_generator | https://github.com/zkneupper/cpython/tree/feature/replace_list_comp_with_generator |
|
Conversation
4
| https://github.com/python/cpython/pull/26046 |
|
Commits
8
| https://github.com/python/cpython/pull/26046/commits |
|
Checks
0
| https://github.com/python/cpython/pull/26046/checks |
|
Files changed
| https://github.com/python/cpython/pull/26046/files |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/zkneupper |
| zkneupper | https://github.com/zkneupper |
| May 11, 2021 | https://github.com/python/cpython/pull/26046#issue-888962140 |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
| May 11, 2021 18:17 | https://github.com/python/cpython/pull/26046#commits-pushed-e0a083c |
| Use generator as argument to str.join() instead of list comprehension | https://github.com/python/cpython/pull/26046/commits/e0a083c06940fac87f6db9c30712b53f18332fb8 |
| e0a083c | https://github.com/python/cpython/pull/26046/commits/e0a083c06940fac87f6db9c30712b53f18332fb8 |
| Use generator as argument to str.join() instead of list comprehension | https://github.com/python/cpython/pull/26046/commits/23bf12024adae694d3d6ef21f7a3161f1c658dd3 |
| 23bf120 | https://github.com/python/cpython/pull/26046/commits/23bf12024adae694d3d6ef21f7a3161f1c658dd3 |
| Use generator as argument to str.join() instead of list comprehension | https://github.com/python/cpython/pull/26046/commits/29fba8da81decd247f1ce6d7efa8bc51f8483cec |
| 29fba8d | https://github.com/python/cpython/pull/26046/commits/29fba8da81decd247f1ce6d7efa8bc51f8483cec |
| Use generator as argument to str.join() instead of list comprehension | https://github.com/python/cpython/pull/26046/commits/5968060f4a562e184cc3445515f50b2035d1c8b1 |
| 5968060 | https://github.com/python/cpython/pull/26046/commits/5968060f4a562e184cc3445515f50b2035d1c8b1 |
| Use generator as argument to str.join() instead of list comprehension | https://github.com/python/cpython/pull/26046/commits/7930116da07b412b00e9e3630364d32f96c9dc4f |
| 7930116 | https://github.com/python/cpython/pull/26046/commits/7930116da07b412b00e9e3630364d32f96c9dc4f |
| Use generator as argument to str.join() instead of list comprehension | https://github.com/python/cpython/pull/26046/commits/128783eb2f198d1763ceab8207570f2d4b654992 |
| 128783e | https://github.com/python/cpython/pull/26046/commits/128783eb2f198d1763ceab8207570f2d4b654992 |
| Use generator as argument to str.join() instead of list comprehension | https://github.com/python/cpython/pull/26046/commits/0408882856ac3b7d78ab9a93b12e224bc2c75f6c |
| 0408882 | https://github.com/python/cpython/pull/26046/commits/0408882856ac3b7d78ab9a93b12e224bc2c75f6c |
| replace for loop with generator expression | https://github.com/python/cpython/pull/26046/commits/44915e151d458298998dbff03577d4aaf8512c1d |
| 44915e1 | https://github.com/python/cpython/pull/26046/commits/44915e151d458298998dbff03577d4aaf8512c1d |
| https://github.com/zkneupper |
| zkneupper | https://github.com/zkneupper |
| isidentical | https://github.com/isidentical |
| rhettinger | https://github.com/rhettinger |
| code owners | https://github.com/python/cpython/blob/23ae2c3bacc167f7bbfea1846bbbc9dde63a1bfd/.github/CODEOWNERS#L92 |
| May 11, 2021 22:40 | https://github.com/python/cpython/pull/26046#event-4732187829 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| May 11, 2021 | https://github.com/python/cpython/pull/26046#event-4732188030 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
| May 11, 2021 | https://github.com/python/cpython/pull/26046#issuecomment-839244765 |
| PSF contributor agreement | https://www.python.org/psf/contrib/contrib-form/ |
| bugs.python.org | https://bugs.python.org/ |
| @zkneupper | https://github.com/zkneupper |
| the steps outlined in the CPython devguide | https://devguide.python.org/pullrequest/#licensing |
| check yourself | https://check-python-cla.herokuapp.com/ |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA not signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22 |
| May 11, 2021 | https://github.com/python/cpython/pull/26046#event-4732188082 |
| https://github.com/erlend-aasland |
| erlend-aasland | https://github.com/erlend-aasland |
| May 12, 2021 | https://github.com/python/cpython/pull/26046#issuecomment-839656770 |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
| #25798 (comment) | https://github.com/python/cpython/pull/25798#discussion_r624637543 |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
| https://github.com/isidentical |
| isidentical | https://github.com/isidentical |
|
May 12, 2021
| https://github.com/python/cpython/pull/26046#pullrequestreview-657729781 |
|
View reviewed changes
| https://github.com/python/cpython/pull/26046/files/44915e151d458298998dbff03577d4aaf8512c1d |
| isidentical | https://github.com/isidentical |
| https://github.com/python/cpython/pull/26046#pullrequestreview-657729781 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| May 12, 2021 | https://github.com/python/cpython/pull/26046#event-4735460443 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| May 12, 2021 | https://github.com/python/cpython/pull/26046#issuecomment-839667970 |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
| https://github.com/isidentical |
| isidentical | https://github.com/isidentical |
| May 12, 2021 | https://github.com/python/cpython/pull/26046#event-4735461074 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F26046 |
|
| https://github.com/isidentical |
|
isidentical
| https://github.com/isidentical |
|
| https://github.com/python/cpython/pull/26046/files/44915e151d458298998dbff03577d4aaf8512c1d |
|
| https://github.com/rhettinger |
|
rhettinger
| https://github.com/rhettinger |
|
awaiting changes
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22 |
| Please reload this page | https://github.com/python/cpython/pull/26046 |
|
| https://github.com/zkneupper |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/erlend-aasland |
|
| https://github.com/bedevere-bot |
|
| https://github.com/isidentical |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |