René's URL Explorer Experiment


Title: gh-88037: Move port validation logic to parsing time by miguendes · Pull Request #25774 · python/cpython · GitHub

Open Graph Title: gh-88037: Move port validation logic to parsing time by miguendes · Pull Request #25774 · python/cpython

X Title: gh-88037: Move port validation logic to parsing time by miguendes · Pull Request #25774 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: https://bugs.python.org/issue43871 Issue: urllib.parse.urlparse doesn't check port #88037

X Description: https://bugs.python.org/issue43871 Issue: urllib.parse.urlparse doesn't check port #88037

Opengraph URL: https://github.com/python/cpython/pull/25774

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:229b3938-6252-e93a-41a6-c930f9015624
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC0C:76F02:469094E:5A042AE:6B0241A5
html-safe-nonce4839cd2e53a4cd720f9f1b11c480d734e16ae0ec136e21ee0d17c53f08f3394c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzBDOjc2RjAyOjQ2OTA5NEU6NUEwNDJBRTo2QjAyNDFBNSIsInZpc2l0b3JfaWQiOiIzODM0MDAyNDEyMjY0Mzc0NjkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac032fd7f61e6dfcde4d6932b98696b4f1f4105597b6318f8be32bb89d8082daeb
hovercard-subject-tagpull_request:628396210
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/25774/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b9689bc486dbffc656bbe75d6296659bacefec0aded42f4b2e4f255852fb5c31/python/cpython/pull/25774
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b9689bc486dbffc656bbe75d6296659bacefec0aded42f4b2e4f255852fb5c31/python/cpython/pull/25774
og:image:althttps://bugs.python.org/issue43871 Issue: urllib.parse.urlparse doesn't check port #88037
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiguendes
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/python/cpython/pull/25774#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25774
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25774
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/25774
Reloadhttps://github.com/python/cpython/pull/25774
Reloadhttps://github.com/python/cpython/pull/25774
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
https://github.com/python/cpython
miguendeshttps://github.com/miguendes
python:mainhttps://github.com/python/cpython/tree/main
miguendes:bpo-43871https://github.com/miguendes/cpython/tree/bpo-43871
Conversationhttps://github.com/python/cpython/pull/25774
Commits1 (1)https://github.com/python/cpython/pull/25774/commits
Checkshttps://github.com/python/cpython/pull/25774/checks
Files changedhttps://github.com/python/cpython/pull/25774/files
gh-88037: Move port validation logic to parsing timehttps://github.com/python/cpython/pull/25774#top
miguendeshttps://github.com/miguendes
python:mainhttps://github.com/python/cpython/tree/main
miguendes:bpo-43871https://github.com/miguendes/cpython/tree/bpo-43871
https://github.com/miguendes
miguendeshttps://github.com/miguendes
May 1, 2021https://github.com/python/cpython/pull/25774#issue-873619133
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://bugs.python.org/issue43871https://bugs.python.org/issue43871
urllib.parse.urlparse doesn't check port #88037https://github.com/python/cpython/issues/88037
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
May 1, 2021https://github.com/python/cpython/pull/25774#event-4673335973
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 1, 2021https://github.com/python/cpython/pull/25774#event-4673335983
https://github.com/miguendes
miguendeshttps://github.com/miguendes
force-pushedhttps://github.com/python/cpython/compare/7cf9ace3f7d4e672ecdfaf9cb610caa6f7c9a169..cf3913e4047929c19055fc26434418b22d1753e3
7cf9acehttps://github.com/python/cpython/commit/7cf9ace3f7d4e672ecdfaf9cb610caa6f7c9a169
cf3913ehttps://github.com/python/cpython/commit/cf3913e4047929c19055fc26434418b22d1753e3
Compare https://github.com/python/cpython/compare/7cf9ace3f7d4e672ecdfaf9cb610caa6f7c9a169..cf3913e4047929c19055fc26434418b22d1753e3
May 1, 2021 12:54https://github.com/python/cpython/pull/25774#event-4673543845
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Jun 3, 2021https://github.com/python/cpython/pull/25774#issuecomment-853466243
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Jun 3, 2021https://github.com/python/cpython/pull/25774#event-4834654336
https://github.com/akulakov
akulakovhttps://github.com/akulakov
Jun 27, 2021 https://github.com/python/cpython/pull/25774#pullrequestreview-693425109
View reviewed changes https://github.com/python/cpython/pull/25774/files
Lib/urllib/parse.pyhttps://github.com/python/cpython/pull/25774/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/akulakov
akulakovhttps://github.com/akulakov
Jun 27, 2021 https://github.com/python/cpython/pull/25774#pullrequestreview-693426965
View reviewed changes https://github.com/python/cpython/pull/25774/files
.python-versionhttps://github.com/python/cpython/pull/25774/files#diff-652bad7c1002badcf13f8de3a5096c2724ce54ae36cd68a21ad280547dff8e87
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/akulakov
akulakovhttps://github.com/akulakov
Jun 27, 2021 https://github.com/python/cpython/pull/25774#pullrequestreview-693427189
View reviewed changes https://github.com/python/cpython/pull/25774/files
Lib/test/test_urllib2.pyhttps://github.com/python/cpython/pull/25774/files#diff-5dcb1946f2eee26a435ec5f5e005ce2f656c6d375b8cd2c4fa789ebb09e75403
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/miguendes
miguendeshttps://github.com/miguendes
force-pushedhttps://github.com/python/cpython/compare/5ebd0997b8b8be8ea93388120590ca8698a2f4e6..3419baa3893ee24021ca43ab6df64af2edf2e583
5ebd099https://github.com/python/cpython/commit/5ebd0997b8b8be8ea93388120590ca8698a2f4e6
3419baahttps://github.com/python/cpython/commit/3419baa3893ee24021ca43ab6df64af2edf2e583
Compare https://github.com/python/cpython/compare/5ebd0997b8b8be8ea93388120590ca8698a2f4e6..3419baa3893ee24021ca43ab6df64af2edf2e583
July 10, 2021 09:03https://github.com/python/cpython/pull/25774#event-5003031126
https://github.com/miguendes
Move port validation logic to parsing timehttps://github.com/python/cpython/pull/25774/commits/343b29989c5e55b774160fe8ff86d3b9f6d63325
343b299https://github.com/python/cpython/pull/25774/commits/343b29989c5e55b774160fe8ff86d3b9f6d63325
https://github.com/miguendes
miguendeshttps://github.com/miguendes
force-pushedhttps://github.com/python/cpython/compare/3419baa3893ee24021ca43ab6df64af2edf2e583..343b29989c5e55b774160fe8ff86d3b9f6d63325
3419baahttps://github.com/python/cpython/commit/3419baa3893ee24021ca43ab6df64af2edf2e583
343b299https://github.com/python/cpython/commit/343b29989c5e55b774160fe8ff86d3b9f6d63325
Compare https://github.com/python/cpython/compare/3419baa3893ee24021ca43ab6df64af2edf2e583..343b29989c5e55b774160fe8ff86d3b9f6d63325
July 10, 2021 09:12https://github.com/python/cpython/pull/25774#event-5003039624
https://github.com/MaxwellDupre
MaxwellDuprehttps://github.com/MaxwellDupre
Jul 13, 2022 https://github.com/python/cpython/pull/25774#pullrequestreview-1037059697
View reviewed changes https://github.com/python/cpython/pull/25774/files/343b29989c5e55b774160fe8ff86d3b9f6d63325
MaxwellDuprehttps://github.com/MaxwellDupre
https://github.com/python/cpython/pull/25774#pullrequestreview-1037059697
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Jul 13, 2022https://github.com/python/cpython/pull/25774#event-6984380993
https://github.com/ezio-melotti
ezio-melottihttps://github.com/ezio-melotti
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jul 13, 2022https://github.com/python/cpython/pull/25774#event-6988865316
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Aug 7, 2022https://github.com/python/cpython/pull/25774#event-7141539012
https://github.com/kenballus
kenballushttps://github.com/kenballus
Aug 16, 2022 https://github.com/python/cpython/pull/25774#ref-issue-1340863065
urlparse does not correctly handle signs, underscores, and whitespace in port numbers #96035 https://github.com/python/cpython/issues/96035
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
September 13, 2022 22:12https://github.com/python/cpython/pull/25774#event-7380426390
https://github.com/kenballus
kenballushttps://github.com/kenballus
Oct 17, 2022 https://github.com/python/cpython/pull/25774#ref-pullrequest-1409996632
gh-96035: Make urllib.parse.urlparse reject non-numeric ports #98273 https://github.com/python/cpython/pull/98273
https://github.com/kenballus
kenballushttps://github.com/kenballus
Jan 26, 2023https://github.com/python/cpython/pull/25774#issuecomment-1404395926
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jan 26, 2023https://github.com/python/cpython/pull/25774#event-8359914696
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Jan 26, 2023https://github.com/python/cpython/pull/25774#event-8359928366
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
Jan 26, 2023https://github.com/python/cpython/pull/25774#event-8359929699
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
May 20, 2023https://github.com/python/cpython/pull/25774#issuecomment-1556041844
@kenballushttps://github.com/kenballus
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/python/cpython/pull/25774
p-alikhttps://github.com/python/cpython/pull/25774
Nov 23, 2023 https://github.com/python/cpython/pull/25774#ref-issue-1199056850
urllib.parse.urlparse doesn't check port #88037 https://github.com/python/cpython/issues/88037
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 9, 2026https://github.com/python/cpython/pull/25774#issuecomment-4211944503
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Apr 9, 2026https://github.com/python/cpython/pull/25774#event-24324487765
https://github.com/orsenthil
orsenthilhttps://github.com/orsenthil
Oct 10, 2026 https://github.com/python/cpython/pull/25774#ref-pullrequest-5791825784
gh-88037 - Move port validation logic to parsing time #159122 https://github.com/python/cpython/pull/159122
https://github.com/orsenthil
orsenthilhttps://github.com/orsenthil
Oct 10, 2026https://github.com/python/cpython/pull/25774#issuecomment-6098227096
#159122https://github.com/python/cpython/pull/159122
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/orsenthil
orsenthilhttps://github.com/orsenthil
Oct 10, 2026https://github.com/python/cpython/pull/25774#event-32943497508
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25774
https://github.com/akulakov
akulakov https://github.com/akulakov
https://github.com/python/cpython/pull/25774/files/cf3913e4047929c19055fc26434418b22d1753e3
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/MaxwellDupre
MaxwellDupre https://github.com/MaxwellDupre
https://github.com/python/cpython/pull/25774/files/343b29989c5e55b774160fe8ff86d3b9f6d63325
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/gpshead
gpshead https://github.com/gpshead
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
stdlib https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astdlib
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
Please reload this pagehttps://github.com/python/cpython/pull/25774
https://github.com/miguendes
https://github.com/kenballus
https://github.com/gpshead
https://github.com/orsenthil
https://github.com/akulakov
https://github.com/MaxwellDupre
https://github.com/the-knights-who-say-ni
https://github.com/ezio-melotti
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.