René's URL Explorer Experiment


Title: bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag by erlend-aasland · Pull Request #25743 · python/cpython · GitHub

Open Graph Title: bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag by erlend-aasland · Pull Request #25743 · python/cpython

X Title: bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag by erlend-aasland · Pull Request #25743 · python/cpython

Description: https://bugs.python.org/issue43908

Open Graph Description: https://bugs.python.org/issue43908

X Description: https://bugs.python.org/issue43908

Opengraph URL: https://github.com/python/cpython/pull/25743

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:425e5efb-d7a2-e6b6-c564-b6e8a3541b13
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A18:193CDB:46FBDF:5D983B:696AE011
html-safe-nonce4470ee6e53950a9d871d430a3f0afd82786af3699ad45afed342cdb4475bad37
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTE4OjE5M0NEQjo0NkZCREY6NUQ5ODNCOjY5NkFFMDExIiwidmlzaXRvcl9pZCI6IjQzNTY4MTU3MjAxODQyMDk0MjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac551d3ab690f14d12b0ea3df68d184d4c36e1cc0e219bbebe61c4725404a69843
hovercard-subject-tagpull_request:627209592
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/25743/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c843fa5fb0a36a23308165b1228f4683bbc45012ebb6f60611ebda179c9802ee/python/cpython/pull/25743
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c843fa5fb0a36a23308165b1228f4683bbc45012ebb6f60611ebda179c9802ee/python/cpython/pull/25743
og:image:althttps://bugs.python.org/issue43908
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3d84d50b3c75fa36755c3cf392edbc09e626f979
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/25743#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25743
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25743
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/25743
Reloadhttps://github.com/python/cpython/pull/25743
Reloadhttps://github.com/python/cpython/pull/25743
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/25743
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/25743
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/25743#issue-comment-box
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
erlend-aasland:set-specialhttps://github.com/erlend-aasland/cpython/tree/set-special
bpo-43908: check_set_special_type_attr() and type_set_annotations() now check for immutable flag https://github.com/python/cpython/pull/25743#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
erlend-aasland:set-specialhttps://github.com/erlend-aasland/cpython/tree/set-special
Conversation 15 https://github.com/python/cpython/pull/25743
Commits 8 https://github.com/python/cpython/pull/25743/commits
Checks 0 https://github.com/python/cpython/pull/25743/checks
Files changed https://github.com/python/cpython/pull/25743/files
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 30, 2021https://github.com/python/cpython/pull/25743#issue-872279660
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://bugs.python.org/issue43908https://bugs.python.org/issue43908
Please reload this pagehttps://github.com/python/cpython/pull/25743
check_set_special_type_attr() now checks for Py_TPFLAGS_IMMUTABLETYPE…https://github.com/python/cpython/pull/25743/commits/ce4113f277f70dcbd011f62764f29bc63df78047
ce4113fhttps://github.com/python/cpython/pull/25743/commits/ce4113f277f70dcbd011f62764f29bc63df78047
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
markshannonhttps://github.com/markshannon
code ownerhttps://github.com/python/cpython/blob/b73b5fb9ea08156991a065c1696e8d8cf7622482/.github/CODEOWNERS#L16
April 30, 2021 10:13https://github.com/python/cpython/pull/25743#event-4668441543
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 30, 2021https://github.com/python/cpython/pull/25743#event-4668441716
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 30, 2021https://github.com/python/cpython/pull/25743#event-4668441723
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 30, 2021https://github.com/python/cpython/pull/25743#issuecomment-829992690
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/25743
type_set_annotations now check for immutable flag iso. heap type flaghttps://github.com/python/cpython/pull/25743/commits/af09ad663e3b82337e40e8d2c35fe36c8cafa6c1
af09ad6https://github.com/python/cpython/pull/25743/commits/af09ad663e3b82337e40e8d2c35fe36c8cafa6c1
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 30, 2021https://github.com/python/cpython/pull/25743#event-4668564837
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2021 https://github.com/python/cpython/pull/25743#pullrequestreview-649093529
View reviewed changes https://github.com/python/cpython/pull/25743/files/af09ad663e3b82337e40e8d2c35fe36c8cafa6c1
Objects/typeobject.chttps://github.com/python/cpython/pull/25743/files/af09ad663e3b82337e40e8d2c35fe36c8cafa6c1#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/25743
April 30, 2021 12:43https://github.com/python/cpython/pull/25743#commits-pushed-392af9c
https://github.com/vstinner
Advertise immutable flag in error messagehttps://github.com/python/cpython/pull/25743/commits/392af9ce44dde2d63b1eabda2ab8ee8a50cd3815
392af9chttps://github.com/python/cpython/pull/25743/commits/392af9ce44dde2d63b1eabda2ab8ee8a50cd3815
Address review: improve commentshttps://github.com/python/cpython/pull/25743/commits/fd929c014bf0620748c25c32378505db69fde58f
fd929c0https://github.com/python/cpython/pull/25743/commits/fd929c014bf0620748c25c32378505db69fde58f
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2021 https://github.com/python/cpython/pull/25743#pullrequestreview-649106624
View reviewed changes https://github.com/python/cpython/pull/25743/files/fd929c014bf0620748c25c32378505db69fde58f
Objects/typeobject.chttps://github.com/python/cpython/pull/25743/files/fd929c014bf0620748c25c32378505db69fde58f#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/25743
Fix formattinghttps://github.com/python/cpython/pull/25743/commits/52795a49b2c607be10efca76dfadf686db9f55eb
52795a4https://github.com/python/cpython/pull/25743/commits/52795a49b2c607be10efca76dfadf686db9f55eb
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2021 https://github.com/python/cpython/pull/25743#pullrequestreview-649123919
View reviewed changes https://github.com/python/cpython/pull/25743/files/52795a49b2c607be10efca76dfadf686db9f55eb
Objects/typeobject.chttps://github.com/python/cpython/pull/25743/files/52795a49b2c607be10efca76dfadf686db9f55eb#diff-1decebeef15f4e0b0ce106c665751ec55068d4d1d1825847925ad4f528b5b872
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.com/vstinner
Update Objects/typeobject.chttps://github.com/python/cpython/pull/25743/commits/817b8cffead36600e61db0edb3bee4408dbbd50f
817b8cfhttps://github.com/python/cpython/pull/25743/commits/817b8cffead36600e61db0edb3bee4408dbbd50f
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Apr 30, 2021https://github.com/python/cpython/pull/25743#event-4668816942
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2021https://github.com/python/cpython/pull/25743#issuecomment-830033666
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2021https://github.com/python/cpython/pull/25743#issuecomment-830033883
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 30, 2021https://github.com/python/cpython/pull/25743#issuecomment-830034878
Please reload this pagehttps://github.com/python/cpython/pull/25743
April 30, 2021 14:19https://github.com/python/cpython/pull/25743#commits-pushed-b464ab5
Don't need quotes when using %Rhttps://github.com/python/cpython/pull/25743/commits/b464ab54daa545f092b315672a6cdf1e4156cb44
b464ab5https://github.com/python/cpython/pull/25743/commits/b464ab54daa545f092b315672a6cdf1e4156cb44
https://github.com/vstinner
Fix test_descrhttps://github.com/python/cpython/pull/25743/commits/10b007174482d88ef4b1f486a5277ebc28464256
10b0071https://github.com/python/cpython/pull/25743/commits/10b007174482d88ef4b1f486a5277ebc28464256
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2021https://github.com/python/cpython/pull/25743#issuecomment-830074871
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 30, 2021https://github.com/python/cpython/pull/25743#issuecomment-830076568
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
6414138https://github.com/python/cpython/commit/64141382ecbad665d5738ff26d15505f3427c724
Apr 30, 2021https://github.com/python/cpython/pull/25743#event-4669373980
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 30, 2021https://github.com/python/cpython/pull/25743#event-4669374285
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Apr 30, 2021https://github.com/python/cpython/pull/25743#issuecomment-830093240
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
April 30, 2021 13:29https://github.com/python/cpython/pull/25743#event-4669395034
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
May 18, 2022 https://github.com/python/cpython/pull/25743#ref-issue-1199057074
array.array should remain immutable: add Py_TPFLAGS_IMMUTABLETYPE flag #88074 https://github.com/python/cpython/issues/88074
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25743
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/25743/files/52795a49b2c607be10efca76dfadf686db9f55eb
https://github.com/markshannon
markshannon https://github.com/markshannon
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/25743
https://github.com/erlend-aasland
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.