| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:74848806-f522-d0bd-51be-7248b2886fe8 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB9C:CB088:AE469:FC180:6A573E74 |
| html-safe-nonce | e706dce74f028161770d0c8980a64d98bea4ffae1bf83631d310bd3ff61f65b5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjlDOkNCMDg4OkFFNDY5OkZDMTgwOjZBNTczRTc0IiwidmlzaXRvcl9pZCI6IjU0MjI1MTcyNDUxNjI1MDM3OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b335605feea19c724422802a3026608d75e4c435032838948f24ea3db473d8bd |
| hovercard-subject-tag | pull_request:626645767 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/25735/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c1c002a15944078e357ee92c66d63a91f487c7703940a45b41b646c5f7a6c705/python/cpython/pull/25735 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c1c002a15944078e357ee92c66d63a91f487c7703940a45b41b646c5f7a6c705/python/cpython/pull/25735 |
| og:image:alt | This fixes validation of complex literal value patterns in the parser and factors out the old compiler_pattern_capture and compiler_pattern_wildcard routines to better match the current AST.
(A few... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | brandtbucher |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2576d1f0198cf1588faf2edf27f1ed120903be10 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/25735#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25735 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25735 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/25735 |
| Reload | https://github.com/python/cpython/pull/25735 |
| Reload | https://github.com/python/cpython/pull/25735 |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
35k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| brandtbucher | https://github.com/brandtbucher |
| python:master | https://github.com/python/cpython/tree/master |
| brandtbucher:patma-parser-cleanup | https://github.com/brandtbucher/cpython/tree/patma-parser-cleanup |
| Conversation | https://github.com/python/cpython/pull/25735 |
| Commits7 (7) | https://github.com/python/cpython/pull/25735/commits |
| Checks | https://github.com/python/cpython/pull/25735/checks |
| Files changed | https://github.com/python/cpython/pull/25735/files |
| bpo-43892: Validate the first term of complex literal value patterns | https://github.com/python/cpython/pull/25735#top |
| brandtbucher | https://github.com/brandtbucher |
| python:master | https://github.com/python/cpython/tree/master |
| brandtbucher:patma-parser-cleanup | https://github.com/brandtbucher/cpython/tree/patma-parser-cleanup |
|
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| Apr 29, 2021 | https://github.com/python/cpython/pull/25735#issue-871639997 |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
| https://bugs.python.org/issue43892 | https://bugs.python.org/issue43892 |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
| brandtbucher | https://github.com/brandtbucher |
| April 29, 2021 15:10 | https://github.com/python/cpython/pull/25735#commits-pushed-3b50aac |
|
| https://github.com/brandtbucher |
| Add more SyntaxError tests | https://github.com/python/cpython/pull/25735/commits/3b50aac1a9f59f8587434459f4e0697c673e3ce5 |
| 3b50aac | https://github.com/python/cpython/pull/25735/commits/3b50aac1a9f59f8587434459f4e0697c673e3ce5 |
|
| https://github.com/brandtbucher |
| Validate the first term of complex value patterns | https://github.com/python/cpython/pull/25735/commits/cb83027a61220914124e2140155c24c5eda03d8f |
| cb83027 | https://github.com/python/cpython/pull/25735/commits/cb83027a61220914124e2140155c24c5eda03d8f |
|
| https://github.com/brandtbucher |
| Fix bad type (minor) | https://github.com/python/cpython/pull/25735/commits/5059e9b7db155599914818a180348722f3d8d86c |
| 5059e9b | https://github.com/python/cpython/pull/25735/commits/5059e9b7db155599914818a180348722f3d8d86c |
|
| https://github.com/brandtbucher |
| Simplify the grammar some more | https://github.com/python/cpython/pull/25735/commits/ecbdbd3e2f27bcbec78eb31b78de70eb8b364b8c |
| ecbdbd3 | https://github.com/python/cpython/pull/25735/commits/ecbdbd3e2f27bcbec78eb31b78de70eb8b364b8c |
|
| https://github.com/brandtbucher |
| Factor out some old pattern compiler routines | https://github.com/python/cpython/pull/25735/commits/d0a46d7d62b264d54b8ff36328dd036260e21100 |
| d0a46d7 | https://github.com/python/cpython/pull/25735/commits/d0a46d7d62b264d54b8ff36328dd036260e21100 |
|
| https://github.com/brandtbucher |
| blurb add | https://github.com/python/cpython/pull/25735/commits/13ed2fe7e09772f94a08bbb2c545d358f36b510d |
| 13ed2fe | https://github.com/python/cpython/pull/25735/commits/13ed2fe7e09772f94a08bbb2c545d358f36b510d |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| ncoghlan | https://github.com/ncoghlan |
| pablogsal | https://github.com/pablogsal |
| April 29, 2021 23:02 | https://github.com/python/cpython/pull/25735#event-4665699755 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| isidentical | https://github.com/isidentical |
| lysnikolaou | https://github.com/lysnikolaou |
| markshannon | https://github.com/markshannon |
| code owners | https://github.com/python/cpython/blob/088a15c49d99ecb4c3bef93f8f40dd513c6cae3b/.github/CODEOWNERS#L22 |
| April 29, 2021 23:02 | https://github.com/python/cpython/pull/25735#event-4665699774 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 29, 2021 | https://github.com/python/cpython/pull/25735#event-4665699963 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Apr 29, 2021 | https://github.com/python/cpython/pull/25735#event-4665699985 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
|
Apr 29, 2021
| https://github.com/python/cpython/pull/25735#pullrequestreview-648761082 |
|
View reviewed changes
| https://github.com/python/cpython/pull/25735/files/13ed2fe7e09772f94a08bbb2c545d358f36b510d |
| pablogsal | https://github.com/pablogsal |
| https://github.com/python/cpython/pull/25735#pullrequestreview-648761082 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Apr 29, 2021 | https://github.com/python/cpython/pull/25735#event-4665940135 |
| https://github.com/pablogsal |
| pablogsal | https://github.com/pablogsal |
| Apr 29, 2021 | https://github.com/python/cpython/pull/25735#issuecomment-829691513 |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
| @brandtbucher | https://github.com/brandtbucher |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
|
| https://github.com/brandtbucher |
| compiler_pattern_constant -> compiler_pattern_singleton | https://github.com/python/cpython/pull/25735/commits/d5a50c50a270d5fdcabbf6d49714781c177e4e47 |
| d5a50c5 | https://github.com/python/cpython/pull/25735/commits/d5a50c50a270d5fdcabbf6d49714781c177e4e47 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| dbe60ee | https://github.com/python/cpython/commit/dbe60ee09dc5a624cfb78dff61ecf050a5b3f105 |
| Apr 30, 2021 | https://github.com/python/cpython/pull/25735#event-4666118492 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Apr 30, 2021 | https://github.com/python/cpython/pull/25735#event-4666118581 |
| https://github.com/brandtbucher |
| brandtbucher | https://github.com/brandtbucher |
| July 21, 2022 20:19 | https://github.com/python/cpython/pull/25735#event-7041206065 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25735 |
|
| https://github.com/pablogsal |
|
pablogsal
| https://github.com/pablogsal |
|
| https://github.com/python/cpython/pull/25735/files/13ed2fe7e09772f94a08bbb2c545d358f36b510d |
|
| https://github.com/ncoghlan |
|
ncoghlan
| https://github.com/ncoghlan |
|
| https://github.com/isidentical |
|
isidentical
| https://github.com/isidentical |
|
| https://github.com/lysnikolaou |
|
lysnikolaou
| https://github.com/lysnikolaou |
|
| https://github.com/markshannon |
|
markshannon
| https://github.com/markshannon |
| Please reload this page | https://github.com/python/cpython/pull/25735 |
|
| https://github.com/brandtbucher |
|
| https://github.com/pablogsal |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/bedevere-bot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |