| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:947386a4-09e3-c161-5eff-25680b248576 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CCC0:28DD5C:FDFC44:154D8FA:696992F0 |
| html-safe-nonce | 0ec842ab4f3249285c41e5c63beff274f0257c6884f384a397f74ceda14b4041 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0MwOjI4REQ1QzpGREZDNDQ6MTU0RDhGQTo2OTY5OTJGMCIsInZpc2l0b3JfaWQiOiI4Mzc5MTk2MDc5MTU1NTQ4OTEyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 2079609efb455a2a06a689b90acd57727780e7468e9740510cbb681a9b0f7a83 |
| hovercard-subject-tag | pull_request:622779594 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/25595/files |
| twitter:image | https://avatars.githubusercontent.com/u/332330?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/332330?s=400&v=4 |
| og:image:alt | bpo-43882: Strip ascii newline and tabs from the url input, following WHATWG specification
Presence newline or tab characters in URL allowed attackers to write scripts in URL, hijack the web-serve... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 3542e147982176a7ebaa23dfb559c8af16f721c03ec560c68c56b64a0f35e751 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | af80af7cc9e3de9c336f18b208a600950a3c187c |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/25595/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25595%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25595%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/25595/files |
| Reload | https://github.com/python/cpython/pull/25595/files |
| Reload | https://github.com/python/cpython/pull/25595/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/25595/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/25595/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| orsenthil | https://github.com/orsenthil |
| python:master | https://github.com/python/cpython/tree/master |
|
Conversation
27
| https://github.com/python/cpython/pull/25595 |
|
Commits
10
| https://github.com/python/cpython/pull/25595/commits |
|
Checks
0
| https://github.com/python/cpython/pull/25595/checks |
|
Files changed
| https://github.com/python/cpython/pull/25595/files |
| Please reload this page | https://github.com/python/cpython/pull/25595/files |
|
bpo-43882 - urllib.parse should sanitize urls containing ASCII newline and tabs.
| https://github.com/python/cpython/pull/25595/files#top |
|
Show all changes
10 commits
| https://github.com/python/cpython/pull/25595/files |
|
60c9b55
issue43882 - urllib.parse should sanitize urls containing ASCII newli…
orsenthil Apr 25, 2021
| https://github.com/python/cpython/pull/25595/commits/60c9b553f29a9854e244ea21e412d7928bd57bcb |
|
ee779d6
Address Code Review Comments.
orsenthil Apr 28, 2021
| https://github.com/python/cpython/pull/25595/commits/ee779d61c8f70f4fd68847f9820cf25e06306f94 |
|
e81f32f
Give link to specification. Reference in WG page in Seealso links.
orsenthil Apr 28, 2021
| https://github.com/python/cpython/pull/25595/commits/e81f32f8bd211ef626eb89d10a92bb0ebbe48770 |
|
ae07b8f
Wording cleanup and ReST editing for NEWS.
gpshead Apr 29, 2021
| https://github.com/python/cpython/pull/25595/commits/ae07b8f2ed2cb9ffbbb5b9587b3b8e7167aada88 |
|
908e744
Update Doc/library/urllib.parse.rst
orsenthil Apr 29, 2021
| https://github.com/python/cpython/pull/25595/commits/908e744a28a2275df39ba6a1402090bf07494ef8 |
|
5f61b9e
Update Misc/NEWS.d/next/Security/2021-04-25-07-46-37.bpo-43882.Jpwx85…
orsenthil Apr 29, 2021
| https://github.com/python/cpython/pull/25595/commits/5f61b9ebf885be41ed19fe605bdc8c5bb599eb9e |
|
4afcf42
Update Doc/library/urllib.parse.rst
orsenthil Apr 29, 2021
| https://github.com/python/cpython/pull/25595/commits/4afcf42c94b96d164e03f1e0fd0bbf35bbdd0f67 |
|
0885aff
Merge branch 'master' into issue43882
orsenthil Apr 29, 2021
| https://github.com/python/cpython/pull/25595/commits/0885afff337e05e1c8e33a831a5d806d030ab8ae |
|
1150995
Merge branch 'issue43882' of github.com:orsenthil/cpython into issue4…
orsenthil Apr 29, 2021
| https://github.com/python/cpython/pull/25595/commits/1150995b7466aafc9171f78d634d289e3d7c9661 |
|
025718e
Merge branch 'master' into issue43882
orsenthil Apr 29, 2021
| https://github.com/python/cpython/pull/25595/commits/025718eac5846195847808844c53ac4a311b3a25 |
|
Clear filters
| https://github.com/python/cpython/pull/25595/files |
| Please reload this page | https://github.com/python/cpython/pull/25595/files |
| Please reload this page | https://github.com/python/cpython/pull/25595/files |
|
urllib.parse.rst
| https://github.com/python/cpython/pull/25595/files#diff-f97a457691dcc7fd019d5f47ddea5cd6166b5b6efffc3d9a04e04455eb2deeba |
|
test_urlparse.py
| https://github.com/python/cpython/pull/25595/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa |
|
parse.py
| https://github.com/python/cpython/pull/25595/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e |
|
2021-04-25-07-46-37.bpo-43882.Jpwx85.rst
| https://github.com/python/cpython/pull/25595/files#diff-30b82135818d8f17b02b01743ab13f0e80a47f0b5677b9e89634c6eaab110d3b |
| Doc/library/urllib.parse.rst | https://github.com/python/cpython/pull/25595/files#diff-f97a457691dcc7fd019d5f47ddea5cd6166b5b6efffc3d9a04e04455eb2deeba |
|
View file
| https://github.com/python/cpython/blob/025718eac5846195847808844c53ac4a311b3a25/Doc/library/urllib.parse.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/25595/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/25595/files#diff-f97a457691dcc7fd019d5f47ddea5cd6166b5b6efffc3d9a04e04455eb2deeba |
|
| https://github.com/python/cpython/pull/25595/files#diff-f97a457691dcc7fd019d5f47ddea5cd6166b5b6efffc3d9a04e04455eb2deeba |
|
| https://github.com/python/cpython/pull/25595/files#diff-f97a457691dcc7fd019d5f47ddea5cd6166b5b6efffc3d9a04e04455eb2deeba |
|
| https://github.com/python/cpython/pull/25595/files#diff-f97a457691dcc7fd019d5f47ddea5cd6166b5b6efffc3d9a04e04455eb2deeba |
|
| https://github.com/python/cpython/pull/25595/files#diff-f97a457691dcc7fd019d5f47ddea5cd6166b5b6efffc3d9a04e04455eb2deeba |
| Lib/test/test_urlparse.py | https://github.com/python/cpython/pull/25595/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa |
|
View file
| https://github.com/python/cpython/blob/025718eac5846195847808844c53ac4a311b3a25/Lib/test/test_urlparse.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/25595/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/25595/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa |
|
| https://github.com/python/cpython/pull/25595/files#diff-bb89d64e7413a637b421609f9a4f532c294037171c3f0150479930acf30425fa |
| Lib/urllib/parse.py | https://github.com/python/cpython/pull/25595/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e |
|
View file
| https://github.com/python/cpython/blob/025718eac5846195847808844c53ac4a311b3a25/Lib/urllib/parse.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/25595/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/25595/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e |
| Please reload this page | https://github.com/python/cpython/pull/25595/files |
|
| https://github.com/python/cpython/pull/25595/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e |
|
| https://github.com/python/cpython/pull/25595/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e |
|
| https://github.com/python/cpython/pull/25595/files#diff-b3712475a413ec972134c0260c8f1eb1deefb66184f740ef00c37b4487ef873e |
| Misc/NEWS.d/next/Security/2021-04-25-07-46-37.bpo-43882.Jpwx85.rst | https://github.com/python/cpython/pull/25595/files#diff-30b82135818d8f17b02b01743ab13f0e80a47f0b5677b9e89634c6eaab110d3b |
|
View file
| https://github.com/python/cpython/blob/025718eac5846195847808844c53ac4a311b3a25/Misc/NEWS.d/next/Security/2021-04-25-07-46-37.bpo-43882.Jpwx85.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/25595/{{ revealButtonHref }} |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |