René's URL Explorer Experiment


Title: bpo-43892: Make match patterns explicit in AST by ncoghlan · Pull Request #25585 · python/cpython · GitHub

Open Graph Title: bpo-43892: Make match patterns explicit in AST by ncoghlan · Pull Request #25585 · python/cpython

X Title: bpo-43892: Make match patterns explicit in AST by ncoghlan · Pull Request #25585 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Separates "pattern" and "expr" nodes in AST Adds a new "Pattern matching" section in the ast docs, separate from the "Control flow" section AST node names ar...

X Description: Separates "pattern" and "expr" nodes in AST Adds a new "Pattern matching" section in the ast docs, separate from the "Control flow&...

Opengraph URL: https://github.com/python/cpython/pull/25585

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f88388c9-156f-cf79-7f18-be92ebc5c859
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8206:2D610E:1333BEB:1A35831:6A571EFB
html-safe-noncecad00d10c1645b21e34e2c511ea4280183afc0fd1bd647e3b6a6620edde0c9e2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MjA2OjJENjEwRToxMzMzQkVCOjFBMzU4MzE6NkE1NzFFRkIiLCJ2aXNpdG9yX2lkIjoiNTI1MjI3NTgwNTM4NDgxMDIzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6cc77489ebf45493cb596088d94c0a062878476709462b7582f300795e3281c5
hovercard-subject-tagpull_request:622724683
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/25585/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/182af8b8792751c1a0602da1f16792917d547cb063b7aa89a6a4e358b4f5af2a/python/cpython/pull/25585
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/182af8b8792751c1a0602da1f16792917d547cb063b7aa89a6a4e358b4f5af2a/python/cpython/pull/25585
og:image:altSeparates "pattern" and "expr" nodes in AST Adds a new "Pattern matching" section in the ast docs, separate from the "Control flow" section AST node names ar...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamencoghlan
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/25585#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25585
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25585
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/25585
Reloadhttps://github.com/python/cpython/pull/25585
Reloadhttps://github.com/python/cpython/pull/25585
Please reload this pagehttps://github.com/python/cpython/pull/25585
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/25585
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
brandtbucherhttps://github.com/brandtbucher
python:masterhttps://github.com/python/cpython/tree/master
ncoghlan:bpo-43892-explicit-pattern-matching-asthttps://github.com/ncoghlan/cpython/tree/bpo-43892-explicit-pattern-matching-ast
Conversationhttps://github.com/python/cpython/pull/25585
Commits43 (43)https://github.com/python/cpython/pull/25585/commits
Checkshttps://github.com/python/cpython/pull/25585/checks
Files changedhttps://github.com/python/cpython/pull/25585/files
bpo-43892: Make match patterns explicit in ASThttps://github.com/python/cpython/pull/25585#top
brandtbucherhttps://github.com/brandtbucher
python:masterhttps://github.com/python/cpython/tree/master
ncoghlan:bpo-43892-explicit-pattern-matching-asthttps://github.com/ncoghlan/cpython/tree/bpo-43892-explicit-pattern-matching-ast
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Apr 25, 2021https://github.com/python/cpython/pull/25585#issue-866952922
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://bugs.python.org/issue43892https://bugs.python.org/issue43892
Please reload this pagehttps://github.com/python/cpython/pull/25585
ncoghlanhttps://github.com/ncoghlan
April 20, 2021 23:40https://github.com/python/cpython/pull/25585#commits-pushed-1d729b4
https://github.com/ncoghlan
WIP bpo-43892: Make match patterns explicit in ASThttps://github.com/python/cpython/pull/25585/commits/1d729b40bc96cd9c931cec3ce3e791b225ddaca9
1d729b4https://github.com/python/cpython/pull/25585/commits/1d729b40bc96cd9c931cec3ce3e791b225ddaca9
https://github.com/ncoghlan
Merge remote-tracking branch 'origin/master' into bpo-43892-explicit-…https://github.com/python/cpython/pull/25585/commits/6f62cc9de518ebbace78f2c1ca30c1df5afd3339
6f62cc9https://github.com/python/cpython/pull/25585/commits/6f62cc9de518ebbace78f2c1ca30c1df5afd3339
https://github.com/ncoghlan
Everything except symtable.c now compileshttps://github.com/python/cpython/pull/25585/commits/2d25ff78cded13238c6eb999d0f3be7ce283d188
2d25ff7https://github.com/python/cpython/pull/25585/commits/2d25ff78cded13238c6eb999d0f3be7ce283d188
https://github.com/ncoghlan
Link to the validator tickethttps://github.com/python/cpython/pull/25585/commits/2a319fd36f0109d1f707453566dbb41bfe62e7a8
2a319fdhttps://github.com/python/cpython/pull/25585/commits/2a319fd36f0109d1f707453566dbb41bfe62e7a8
https://github.com/ncoghlan
Ensure unparsing tests always cover pattern matchinghttps://github.com/python/cpython/pull/25585/commits/14a5b2b69babea8712e2ac2a56bacc16b49d74ea
14a5b2bhttps://github.com/python/cpython/pull/25585/commits/14a5b2b69babea8712e2ac2a56bacc16b49d74ea
https://github.com/ncoghlan
Get symtable.c compilinghttps://github.com/python/cpython/pull/25585/commits/ba2932fc070e7623e96be0df6b75b98cc704e603
ba2932fhttps://github.com/python/cpython/pull/25585/commits/ba2932fc070e7623e96be0df6b75b98cc704e603
https://github.com/ncoghlan
Require end attributes on pattern nodeshttps://github.com/python/cpython/pull/25585/commits/1dccb6fa0c6a8e25446d5f507612a3c8648ea077
1dccb6fhttps://github.com/python/cpython/pull/25585/commits/1dccb6fa0c6a8e25446d5f507612a3c8648ea077
https://github.com/ncoghlan
MatchConstant -> MatchSingletonhttps://github.com/python/cpython/pull/25585/commits/207a43e3e2decb6e834b1003fe22e90a0225ffe5
207a43ehttps://github.com/python/cpython/pull/25585/commits/207a43e3e2decb6e834b1003fe22e90a0225ffe5
https://github.com/ncoghlan
Formatting tweakhttps://github.com/python/cpython/pull/25585/commits/ba104d1dc01fe15ea52a2d5602327f58c9e2cea0
ba104d1https://github.com/python/cpython/pull/25585/commits/ba104d1dc01fe15ea52a2d5602327f58c9e2cea0
https://github.com/ncoghlan
Fix segfault in wildcard name bindingshttps://github.com/python/cpython/pull/25585/commits/7cdb7355224a7a9d1f8b2caafc1b56309eab6967
7cdb735https://github.com/python/cpython/pull/25585/commits/7cdb7355224a7a9d1f8b2caafc1b56309eab6967
https://github.com/ncoghlan
Get test_patma compilinghttps://github.com/python/cpython/pull/25585/commits/efc0f73706ce681c1628001d2c4673e163b352de
efc0f73https://github.com/python/cpython/pull/25585/commits/efc0f73706ce681c1628001d2c4673e163b352de
https://github.com/ncoghlan
Reject matching 0+0 and f-stringshttps://github.com/python/cpython/pull/25585/commits/a0e13dae2ca0e7183b0b3242d1e08afa2dfc3465
a0e13dahttps://github.com/python/cpython/pull/25585/commits/a0e13dae2ca0e7183b0b3242d1e08afa2dfc3465
https://github.com/ncoghlan
Merge remote-tracking branch 'origin/master' into bpo-43892-explicit-…https://github.com/python/cpython/pull/25585/commits/168051349be7b22d3ae8318f675a96a05219d01e
1680513https://github.com/python/cpython/pull/25585/commits/168051349be7b22d3ae8318f675a96a05219d01e
https://github.com/ncoghlan
Dedicated MatchMapping arg for storing remaining keyshttps://github.com/python/cpython/pull/25585/commits/54940a3817df3046da3f9c51d4d426a73b2ec786
54940a3https://github.com/python/cpython/pull/25585/commits/54940a3817df3046da3f9c51d4d426a73b2ec786
https://github.com/ncoghlan
Merge remote-tracking branch 'origin/master' into bpo-43892-explicit-…https://github.com/python/cpython/pull/25585/commits/0b211405b44990b815f7bb5035ad4a1c0dda3e95
0b21140https://github.com/python/cpython/pull/25585/commits/0b211405b44990b815f7bb5035ad4a1c0dda3e95
https://github.com/ncoghlan
Use 'name' for identifier AST fields, not 'target'https://github.com/python/cpython/pull/25585/commits/d6e69f00a9e393fec32ac4eecff9ea3142393e54
d6e69f0https://github.com/python/cpython/pull/25585/commits/d6e69f00a9e393fec32ac4eecff9ea3142393e54
https://github.com/ncoghlan
Implement unparsinghttps://github.com/python/cpython/pull/25585/commits/5a0b4f24b4789227ee6513dd4bdddd8afced4655
5a0b4f2https://github.com/python/cpython/pull/25585/commits/5a0b4f24b4789227ee6513dd4bdddd8afced4655
https://github.com/ncoghlan
Add news entryhttps://github.com/python/cpython/pull/25585/commits/e07781ed7b284160808c9b6421e002a647e239c1
e07781ehttps://github.com/python/cpython/pull/25585/commits/e07781ed7b284160808c9b6421e002a647e239c1
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
brandtbucherhttps://github.com/brandtbucher
April 25, 2021 08:43https://github.com/python/cpython/pull/25585#event-4640911285
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
isidenticalhttps://github.com/isidentical
lysnikolaouhttps://github.com/lysnikolaou
markshannonhttps://github.com/markshannon
pablogsalhttps://github.com/pablogsal
code ownershttps://github.com/python/cpython/blob/8cc3cfa8afab1651c4f6e9ba43a7ab7f10f64c32/.github/CODEOWNERS#L22
April 25, 2021 08:43https://github.com/python/cpython/pull/25585#event-4640911291
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 25, 2021https://github.com/python/cpython/pull/25585#event-4640911336
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Apr 25, 2021https://github.com/python/cpython/pull/25585#event-4640911369
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Apr 25, 2021 https://github.com/python/cpython/pull/25585#ref-pullrequest-864761650
WIP bpo-43892: Make match patterns explicit in AST ncoghlan/cpython#9 https://github.com/ncoghlan/cpython/pull/9
ncoghlanhttps://github.com/ncoghlan
April 26, 2021 21:24https://github.com/python/cpython/pull/25585#commits-pushed-5cb9f0b
https://github.com/ncoghlan
Merge remote-tracking branch 'origin/master' into bpo-43892-explicit-…https://github.com/python/cpython/pull/25585/commits/5cb9f0bcbc9d9ac452c150c537d562da4479078d
5cb9f0bhttps://github.com/python/cpython/pull/25585/commits/5cb9f0bcbc9d9ac452c150c537d562da4479078d
https://github.com/ncoghlan
Update AST documentationhttps://github.com/python/cpython/pull/25585/commits/b17e7f4ade04fe8583bfd0e0c3ecaecb9e610c74
b17e7f4https://github.com/python/cpython/pull/25585/commits/b17e7f4ade04fe8583bfd0e0c3ecaecb9e610c74
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Apr 26, 2021https://github.com/python/cpython/pull/25585#issuecomment-826798670
Please reload this pagehttps://github.com/python/cpython/pull/25585
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/ncoghlan
Update recursion depth for nested patterns in AST optimiserhttps://github.com/python/cpython/pull/25585/commits/466fccf740d7d9c7bd3195b0e18455bd3e862522
466fccfhttps://github.com/python/cpython/pull/25585/commits/466fccf740d7d9c7bd3195b0e18455bd3e862522
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Apr 27, 2021https://github.com/python/cpython/pull/25585#issuecomment-827833229
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Apr 27, 2021https://github.com/python/cpython/pull/25585#issuecomment-827847558
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Apr 27, 2021https://github.com/python/cpython/pull/25585#issuecomment-827895081
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Apr 27, 2021https://github.com/python/cpython/pull/25585#issuecomment-827899293
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Apr 27, 2021 https://github.com/python/cpython/pull/25585#pullrequestreview-646319211
View reviewed changes https://github.com/python/cpython/pull/25585/files/b8add8ab9b849753dbc2500a559c0f49c092a54a
Python/pythonrun.chttps://github.com/python/cpython/pull/25585/files/b8add8ab9b849753dbc2500a559c0f49c092a54a#diff-2ecd9b536bc387479d824dc4b53f89679d6978d25c6b8a28ab21ed03e745e46e
pablogsalhttps://github.com/pablogsal
Apr 27, 2021https://github.com/python/cpython/pull/25585#discussion_r621567937
Please reload this pagehttps://github.com/python/cpython/pull/25585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
brandtbucherhttps://github.com/brandtbucher
Apr 27, 2021https://github.com/python/cpython/pull/25585#discussion_r621572504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
this commenthttps://github.com/python/cpython/pull/25585#issuecomment-826926615
Please reload this pagehttps://github.com/python/cpython/pull/25585
pablogsalhttps://github.com/pablogsal
Apr 27, 2021https://github.com/python/cpython/pull/25585#discussion_r621574139
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
brandtbucherhttps://github.com/brandtbucher
Apr 27, 2021https://github.com/python/cpython/pull/25585#discussion_r621606994
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622091699
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
pablogsalhttps://github.com/pablogsal
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622102975
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622117419
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622124876
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622140735
Please reload this pagehttps://github.com/python/cpython/pull/25585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Apr 27, 2021 https://github.com/python/cpython/pull/25585#pullrequestreview-646322449
View reviewed changes https://github.com/python/cpython/pull/25585/files/b8add8ab9b849753dbc2500a559c0f49c092a54a
Grammar/python.gramhttps://github.com/python/cpython/pull/25585/files/b8add8ab9b849753dbc2500a559c0f49c092a54a#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
pablogsalhttps://github.com/pablogsal
Apr 27, 2021https://github.com/python/cpython/pull/25585#discussion_r621570636
Please reload this pagehttps://github.com/python/cpython/pull/25585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622143649
Please reload this pagehttps://github.com/python/cpython/pull/25585
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
pablogsalhttps://github.com/pablogsal
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622174974
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25585
brandtbucherhttps://github.com/brandtbucher
April 27, 2021 13:56https://github.com/python/cpython/pull/25585#commits-pushed-490db51
https://github.com/brandtbucher
Revert AST validation stephttps://github.com/python/cpython/pull/25585/commits/490db51ec83cd03134541c8ba9f2af7da5675069
490db51https://github.com/python/cpython/pull/25585/commits/490db51ec83cd03134541c8ba9f2af7da5675069
https://github.com/brandtbucher
Reorder testshttps://github.com/python/cpython/pull/25585/commits/ea4ea93e65484fefc52545b334e71fc4108bbfa0
ea4ea93https://github.com/python/cpython/pull/25585/commits/ea4ea93e65484fefc52545b334e71fc4108bbfa0
https://github.com/brandtbucher
Remove overly-aggressive optimizationshttps://github.com/python/cpython/pull/25585/commits/e4cc5d7f32a9b9dd7e611e8e8bfb23999f4a6f05
e4cc5d7https://github.com/python/cpython/pull/25585/commits/e4cc5d7f32a9b9dd7e611e8e8bfb23999f4a6f05
https://github.com/brandtbucher
Numeric literals are validated in the compilerhttps://github.com/python/cpython/pull/25585/commits/4faea477deb32a81ba22951dcc48479710b941dd
4faea47https://github.com/python/cpython/pull/25585/commits/4faea477deb32a81ba22951dcc48479710b941dd
https://github.com/brandtbucher
Validate numeric literals in the compilerhttps://github.com/python/cpython/pull/25585/commits/fe26e14c68baa930a7c73e509903bba57a87220f
fe26e14https://github.com/python/cpython/pull/25585/commits/fe26e14c68baa930a7c73e509903bba57a87220f
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828121242
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828156971
@ncoghlanhttps://github.com/ncoghlan
Please reload this pagehttps://github.com/python/cpython/pull/25585
ncoghlanhttps://github.com/ncoghlan
April 28, 2021 22:09https://github.com/python/cpython/pull/25585#commits-pushed-ac154fa
https://github.com/ncoghlan
Revert to checking subexpressions in the validatorhttps://github.com/python/cpython/pull/25585/commits/ac154facd63f06aeeaccce494de78e4cc9e74e54
ac154fahttps://github.com/python/cpython/pull/25585/commits/ac154facd63f06aeeaccce494de78e4cc9e74e54
https://github.com/ncoghlan
Ensure parser rejects 0+0 in match patternshttps://github.com/python/cpython/pull/25585/commits/3ef2880952e9d1d4df585e5d98a8ccb0f2785a55
3ef2880https://github.com/python/cpython/pull/25585/commits/3ef2880952e9d1d4df585e5d98a8ccb0f2785a55
https://github.com/ncoghlan
Don't add renamed test case backhttps://github.com/python/cpython/pull/25585/commits/8ed9847dd552946b758d0ef52c9fe08a008ac9fe
8ed9847https://github.com/python/cpython/pull/25585/commits/8ed9847dd552946b758d0ef52c9fe08a008ac9fe
https://github.com/ncoghlan
Restore optimisations as compiler is not longer going validationhttps://github.com/python/cpython/pull/25585/commits/46e7895e4ef88fa15bf58733f4f178f148ca994b
46e7895https://github.com/python/cpython/pull/25585/commits/46e7895e4ef88fa15bf58733f4f178f148ca994b
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828416251
@brandtbucherhttps://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/ncoghlan
Move syntax checking helper to pegenhttps://github.com/python/cpython/pull/25585/commits/8ba335e08481758cb61ca6ba20dd3b4e402c5f1e
8ba335ehttps://github.com/python/cpython/pull/25585/commits/8ba335e08481758cb61ca6ba20dd3b4e402c5f1e
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
brandtbucherhttps://github.com/brandtbucher
April 28, 2021 12:49https://github.com/python/cpython/pull/25585#event-4656638301
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828439428
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021 https://github.com/python/cpython/pull/25585#pullrequestreview-647040219
View reviewed changes https://github.com/python/cpython/pull/25585/files/8ba335e08481758cb61ca6ba20dd3b4e402c5f1e
Grammar/python.gramhttps://github.com/python/cpython/pull/25585/files/8ba335e08481758cb61ca6ba20dd3b4e402c5f1e#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
ncoghlanhttps://github.com/ncoghlan
Apr 28, 2021https://github.com/python/cpython/pull/25585#discussion_r622161541
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@brandtbucherhttps://github.com/brandtbucher
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828593398
Please reload this pagehttps://github.com/python/cpython/pull/25585
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828647765
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828660557
@gvanrossumhttps://github.com/gvanrossum
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/gvanrossum
gvanrossumhttps://github.com/gvanrossum
Apr 28, 2021https://github.com/python/cpython/pull/25585#issuecomment-828663476
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
Apr 29, 2021https://github.com/python/cpython/pull/25585#issuecomment-828951001
Please reload this pagehttps://github.com/python/cpython/pull/25585
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/brandtbucher
brandtbucherhttps://github.com/brandtbucher
1e7b858https://github.com/python/cpython/commit/1e7b858575d0ad782939f86aae4a2fa1c29e9f14
Apr 29, 2021https://github.com/python/cpython/pull/25585#event-4660543585
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Apr 29, 2021https://github.com/python/cpython/pull/25585#event-4660543659
https://github.com/ncoghlan
ncoghlanhttps://github.com/ncoghlan
Apr 29, 2021https://github.com/python/cpython/pull/25585#issuecomment-829148970
@brandtbucherhttps://github.com/brandtbucher
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25585
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/25585/files/8ba335e08481758cb61ca6ba20dd3b4e402c5f1e
https://github.com/isidentical
isidentical https://github.com/isidentical
https://github.com/python/cpython/pull/25585/files/aa429c25b82855975e89ff0059c3a1b226fe862b
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/markshannon
markshannon https://github.com/markshannon
https://github.com/brandtbucher
brandtbucher https://github.com/brandtbucher
Please reload this pagehttps://github.com/python/cpython/pull/25585
https://github.com/ncoghlan
https://github.com/isidentical
https://github.com/brandtbucher
https://github.com/pablogsal
https://github.com/gvanrossum
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.