René's URL Explorer Experiment


Title: bpo-37788: Fix a reference leak if a thread is not joined. by shihai1991 · Pull Request #25226 · python/cpython · GitHub

Open Graph Title: bpo-37788: Fix a reference leak if a thread is not joined. by shihai1991 · Pull Request #25226 · python/cpython

X Title: bpo-37788: Fix a reference leak if a thread is not joined. by shihai1991 · Pull Request #25226 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: Add threading.Thread._discard_shutdown_lock() method to ensure that the thread state lock is removed from the _shutdown_locks list when a thread completes. Co-authored-by: Victor Stinner vstinner@p...

X Description: Add threading.Thread._discard_shutdown_lock() method to ensure that the thread state lock is removed from the _shutdown_locks list when a thread completes. Co-authored-by: Victor Stinner vstinner@p...

Mail addresses
vstinner@python.org

Opengraph URL: https://github.com/python/cpython/pull/25226

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e400e064-0582-7584-693b-b93f62548534
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id94BC:1BB425:17D281E:202BBC8:6A535A58
html-safe-nonceb32a0fe5651fc1febe4e6ab4f3c8a6c87e4a442a818c0f445f98315212d5903e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NEJDOjFCQjQyNToxN0QyODFFOjIwMkJCQzg6NkE1MzVBNTgiLCJ2aXNpdG9yX2lkIjoiMzMxNzI2ODU3NDY3OTI5MjUwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf40fa67715299dc49750bab56080e274a92bdbf796172874b0d822349a43bca7
hovercard-subject-tagpull_request:610036462
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/25226/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/620d0dc8ebf23c9a526e1d7f0c177bdf9a661618e7afbe37e895123752ccc0dd/python/cpython/pull/25226
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/620d0dc8ebf23c9a526e1d7f0c177bdf9a661618e7afbe37e895123752ccc0dd/python/cpython/pull/25226
og:image:altAdd threading.Thread._discard_shutdown_lock() method to ensure that the thread state lock is removed from the _shutdown_locks list when a thread completes. Co-authored-by: Victor Stinner vstinner@p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshihai1991
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/25226#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25226
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25226
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/25226
Reloadhttps://github.com/python/cpython/pull/25226
Reloadhttps://github.com/python/cpython/pull/25226
Please reload this pagehttps://github.com/python/cpython/pull/25226
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/25226
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
shihai1991https://github.com/shihai1991
python:mainhttps://github.com/python/cpython/tree/main
shihai1991:bpo_37788https://github.com/shihai1991/cpython/tree/bpo_37788
Conversationhttps://github.com/python/cpython/pull/25226
Commits3 (3)https://github.com/python/cpython/pull/25226/commits
Checkshttps://github.com/python/cpython/pull/25226/checks
Files changedhttps://github.com/python/cpython/pull/25226/files
bpo-37788: Fix a reference leak if a thread is not joined.https://github.com/python/cpython/pull/25226#top
shihai1991https://github.com/shihai1991
python:mainhttps://github.com/python/cpython/tree/main
shihai1991:bpo_37788https://github.com/shihai1991/cpython/tree/bpo_37788
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 6, 2021https://github.com/python/cpython/pull/25226#issue-851650529
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://bugs.python.org/issue37788https://bugs.python.org/issue37788
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
Fix a reference leak if a thread is not joined.https://github.com/python/cpython/pull/25226/commits/5fdb00d3a5b6b7ef65f181c7e1c142f073138ac4
5fdb00dhttps://github.com/python/cpython/pull/25226/commits/5fdb00d3a5b6b7ef65f181c7e1c142f073138ac4
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Apr 6, 2021https://github.com/python/cpython/pull/25226#event-4558177667
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 6, 2021https://github.com/python/cpython/pull/25226#event-4558177825
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 6, 2021https://github.com/python/cpython/pull/25226#issuecomment-814306350
Please reload this pagehttps://github.com/python/cpython/pull/25226
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
vstinnerhttps://github.com/vstinner
April 6, 2021 18:04https://github.com/python/cpython/pull/25226#event-4558316454
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 6, 2021https://github.com/python/cpython/pull/25226#issuecomment-814329340
@vstinnerhttps://github.com/vstinner
#15228https://github.com/python/cpython/pull/15228
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 6, 2021https://github.com/python/cpython/pull/25226#issuecomment-814334455
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 6, 2021https://github.com/python/cpython/pull/25226#event-4558378285
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 6, 2021https://github.com/python/cpython/pull/25226#event-4558378567
https://github.com/zhangyangyu
zhangyangyuhttps://github.com/zhangyangyu
Apr 8, 2021 https://github.com/python/cpython/pull/25226#pullrequestreview-630953906
View reviewed changes https://github.com/python/cpython/pull/25226/files/5fdb00d3a5b6b7ef65f181c7e1c142f073138ac4
Lib/threading.pyhttps://github.com/python/cpython/pull/25226/files/5fdb00d3a5b6b7ef65f181c7e1c142f073138ac4#diff-b250d3d0e0d909784a67083e9069ce507513a67e8514a011e2f364027e25e0b0
zhangyangyuhttps://github.com/zhangyangyu
Apr 8, 2021https://github.com/python/cpython/pull/25226#discussion_r609261595
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25226
shihai1991https://github.com/shihai1991
Apr 8, 2021https://github.com/python/cpython/pull/25226#discussion_r609309995
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/25226
shihai1991https://github.com/shihai1991
Apr 8, 2021https://github.com/python/cpython/pull/25226#discussion_r609585589
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#15228https://github.com/python/cpython/pull/15228
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 8, 2021https://github.com/python/cpython/pull/25226#event-4569957453
https://github.com/shihai1991
add _discard_shutdown_lock() in threading modulehttps://github.com/python/cpython/pull/25226/commits/213cd7727ac8badd6efc4737baee10c463c530ae
213cd77https://github.com/python/cpython/pull/25226/commits/213cd7727ac8badd6efc4737baee10c463c530ae
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 8, 2021https://github.com/python/cpython/pull/25226#issuecomment-816099935
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 11, 2021https://github.com/python/cpython/pull/25226#event-4578698203
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
force-pushedhttps://github.com/python/cpython/compare/036f14b6a42cfc80d4584907c44a135413b440a4..e66be92bcbd82ded03c952bc68af78c19bc9d2f3
036f14bhttps://github.com/python/cpython/commit/036f14b6a42cfc80d4584907c44a135413b440a4
e66be92https://github.com/python/cpython/commit/e66be92bcbd82ded03c952bc68af78c19bc9d2f3
Compare https://github.com/python/cpython/compare/036f14b6a42cfc80d4584907c44a135413b440a4..e66be92bcbd82ded03c952bc68af78c19bc9d2f3
April 11, 2021 16:00https://github.com/python/cpython/pull/25226#event-4578698552
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 11, 2021https://github.com/python/cpython/pull/25226#issuecomment-817331423
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 11, 2021https://github.com/python/cpython/pull/25226#event-4578756359
https://github.com/shihai1991
Merge remote-tracking branch 'origin/master' into bpo_37788https://github.com/python/cpython/pull/25226/commits/f011a5a03dd53ab5121646d978c5cb11be40d0ad
f011a5ahttps://github.com/python/cpython/pull/25226/commits/f011a5a03dd53ab5121646d978c5cb11be40d0ad
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
force-pushedhttps://github.com/python/cpython/compare/e66be92bcbd82ded03c952bc68af78c19bc9d2f3..f011a5a03dd53ab5121646d978c5cb11be40d0ad
e66be92https://github.com/python/cpython/commit/e66be92bcbd82ded03c952bc68af78c19bc9d2f3
f011a5ahttps://github.com/python/cpython/commit/f011a5a03dd53ab5121646d978c5cb11be40d0ad
Compare https://github.com/python/cpython/compare/e66be92bcbd82ded03c952bc68af78c19bc9d2f3..f011a5a03dd53ab5121646d978c5cb11be40d0ad
April 12, 2021 01:16https://github.com/python/cpython/pull/25226#event-4579271551
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 12, 2021https://github.com/python/cpython/pull/25226#issuecomment-817567329
#15228https://github.com/python/cpython/pull/15228
@pitrouhttps://github.com/pitrou
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/zhangyangyu
zhangyangyuhttps://github.com/zhangyangyu
pitrouhttps://github.com/pitrou
April 14, 2021 00:27https://github.com/python/cpython/pull/25226#event-4590824594
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Apr 16, 2021https://github.com/python/cpython/pull/25226#issuecomment-821284050
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 16, 2021https://github.com/python/cpython/pull/25226#issuecomment-821330425
Please reload this pagehttps://github.com/python/cpython/pull/25226
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Apr 16, 2021https://github.com/python/cpython/pull/25226#issuecomment-821405897
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Apr 16, 2021https://github.com/python/cpython/pull/25226#issuecomment-821443215
Please reload this pagehttps://github.com/python/cpython/pull/25226
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Apr 16, 2021https://github.com/python/cpython/pull/25226#issuecomment-821459453
@tim-onehttps://github.com/tim-one
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 18, 2021https://github.com/python/cpython/pull/25226#issuecomment-822014237
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Apr 18, 2021https://github.com/python/cpython/pull/25226#issuecomment-822020604
Please reload this pagehttps://github.com/python/cpython/pull/25226
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/pitrou
pitrouhttps://github.com/pitrou
Apr 19, 2021https://github.com/python/cpython/pull/25226#issuecomment-822343451
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
May 13, 2021https://github.com/python/cpython/pull/25226#issuecomment-840300551
Please reload this pagehttps://github.com/python/cpython/pull/25226
@pitrouhttps://github.com/pitrou
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
May 13, 2021https://github.com/python/cpython/pull/25226#issuecomment-840301433
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
May 13, 2021https://github.com/python/cpython/pull/25226#event-4739985053
https://github.com/pitrou
pitrouhttps://github.com/pitrou
May 13, 2021https://github.com/python/cpython/pull/25226#issuecomment-840712319
#26103https://github.com/python/cpython/pull/26103
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/pitrou
pitrouhttps://github.com/pitrou
May 13, 2021 https://github.com/python/cpython/pull/25226#ref-pullrequest-891226567
bpo-37788: Fix reference leak when Thread is never joined #26103 https://github.com/python/cpython/pull/26103
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F25226
https://github.com/zhangyangyu
zhangyangyu https://github.com/zhangyangyu
https://github.com/python/cpython/pull/25226/files/5fdb00d3a5b6b7ef65f181c7e1c142f073138ac4
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/pitrou
pitrou https://github.com/pitrou
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/25226
https://github.com/shihai1991
https://github.com/pitrou
https://github.com/zhangyangyu
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.