René's URL Explorer Experiment


Title: [3.8] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) by gpshead · Pull Request #24881 · python/cpython · GitHub

Open Graph Title: [3.8] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) by gpshead · Pull Request #24881 · python/cpython

X Title: [3.8] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) by gpshead · Pull Request #24881 · python/cpython

Description: bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from...

Open Graph Description: bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from...

X Description: bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from...

Mail addresses
greg@krypto.org

Opengraph URL: https://github.com/python/cpython/pull/24881

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e0c6f9ad-0a6e-cc02-fb1d-52d03d6cf7e3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9D94:8907F:E91BE0:14918B7:696A6839
html-safe-nonce76e8fdaeaa5b59b93fd39b54aa742e7094eaaf144a07a40b67b4f08edcd285e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RDk0Ojg5MDdGOkU5MUJFMDoxNDkxOEI3OjY5NkE2ODM5IiwidmlzaXRvcl9pZCI6IjIzMjQ0ODkxMDM0MjkwNzk2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb03f3e272b056c27bd02fafefbaf5022be29ba6bfc260bb21161a1600e45aa78
hovercard-subject-tagpull_request:593313138
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/24881/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/4dc64713c278cac0018096abc5fd00e3ec798e8a7891984af558d114e81bdf8d/python/cpython/pull/24881
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4dc64713c278cac0018096abc5fd00e3ec798e8a7891984af558d114e81bdf8d/python/cpython/pull/24881
og:image:altbpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegpshead
hostnamegithub.com
expected-hostnamegithub.com
None6fea32d5b7276b841b7a803796d9715bc6cfb31ed549fdf9de2948ac25d12ba6
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasef2d9f6432a5a115ec709295ae70623f33bb80aee
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/24881#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24881
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24881
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/24881
Reloadhttps://github.com/python/cpython/pull/24881
Reloadhttps://github.com/python/cpython/pull/24881
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/24881
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/24881
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/24881#issue-comment-box
gpsheadhttps://github.com/gpshead
python:3.8https://github.com/python/cpython/tree/3.8
gpshead:backport-0ab152c-3.8https://github.com/gpshead/cpython/tree/backport-0ab152c-3.8
[3.8] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) https://github.com/python/cpython/pull/24881#top
gpsheadhttps://github.com/gpshead
python:3.8https://github.com/python/cpython/tree/3.8
gpshead:backport-0ab152c-3.8https://github.com/gpshead/cpython/tree/backport-0ab152c-3.8
Conversation 5 https://github.com/python/cpython/pull/24881
Commits 1 https://github.com/python/cpython/pull/24881/commits
Checks 0 https://github.com/python/cpython/pull/24881/checks
Files changed https://github.com/python/cpython/pull/24881/files
Please reload this pagehttps://github.com/python/cpython/pull/24881
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 15, 2021https://github.com/python/cpython/pull/24881#issue-832096527
Please reload this pagehttps://github.com/python/cpython/pull/24881
bpo-43285https://bugs.python.org/issue43285
0ab152chttps://github.com/python/cpython/commit/0ab152c6b5d95caa2dc1a30fa96e10258b5f188e
https://bugs.python.org/issue43285https://bugs.python.org/issue43285
Please reload this pagehttps://github.com/python/cpython/pull/24881
https://github.com/gpshead
[3.8] bpo-43285 Make ftplib not trust the PASV response. (https://github.com/python/cpython/pull/24881/commits/6433c5f528a6c69e4011274eae517538e09902a1
pythonGH-24838https://github.com/python/cpython/pull/24838
6433c5fhttps://github.com/python/cpython/pull/24881/commits/6433c5f528a6c69e4011274eae517538e09902a1
https://github.com/python/cpython/pull/24838
0ab152chttps://github.com/gpshead/cpython/commit/0ab152c6b5d95caa2dc1a30fa96e10258b5f188e
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460510399
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460510569
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 15, 2021 https://github.com/python/cpython/pull/24881#ref-pullrequest-830882995
bpo-43285 Make ftplib not trust the PASV response. #24838 https://github.com/python/cpython/pull/24838
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460510878
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460518106
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
664d1d1https://github.com/python/cpython/commit/664d1d16274b47eea6ec92572e1ebf3939a6fa0c
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460578141
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 15, 2021https://github.com/python/cpython/pull/24881#issuecomment-799677163
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/24881
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460578321
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 15, 2021https://github.com/python/cpython/pull/24881#issuecomment-799677191
@gpsheadhttps://github.com/gpshead
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/24881
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 15, 2021https://github.com/python/cpython/pull/24881#issuecomment-799677314
GH-24882https://github.com/python/cpython/pull/24882
3.6 branchhttps://github.com/python/cpython/tree/3.6
Please reload this pagehttps://github.com/python/cpython/pull/24881
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.6 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.6%22
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460579250
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460580620
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Mar 15, 2021https://github.com/python/cpython/pull/24881#issuecomment-799677583
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/24881
miss-islingtonhttps://github.com/miss-islington
Mar 15, 2021 https://github.com/python/cpython/pull/24881#ref-commit-8759ca4
https://github.com/gpshead
https://github.com/miss-islington
[3.8] bpo-43285 Make ftplib not trust the PASV response. (https://github.com/miss-islington/cpython/commit/8759ca414288bea03f3c41287aa8db698aa1c7c8
pythonGH-24838https://github.com/python/cpython/pull/24838
8759ca4https://github.com/miss-islington/cpython/commit/8759ca414288bea03f3c41287aa8db698aa1c7c8
https://github.com/python/cpython/pull/24838
pythonGH-24881https://github.com/python/cpython/pull/24881
0ab152chttps://github.com/miss-islington/cpython/commit/0ab152c6b5d95caa2dc1a30fa96e10258b5f188e
664d1d1https://github.com/miss-islington/cpython/commit/664d1d16274b47eea6ec92572e1ebf3939a6fa0c
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Mar 15, 2021https://github.com/python/cpython/pull/24881#issuecomment-799677671
GH-24883https://github.com/python/cpython/pull/24883
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/24881
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Mar 15, 2021https://github.com/python/cpython/pull/24881#event-4460581869
miss-islingtonhttps://github.com/miss-islington
Mar 15, 2021 https://github.com/python/cpython/pull/24881#ref-commit-a27bc4f
https://github.com/gpshead
https://github.com/miss-islington
[3.8] bpo-43285 Make ftplib not trust the PASV response. (https://github.com/miss-islington/cpython/commit/a27bc4f9ea1601cde98c8c0f48ed1987f06b4526
pythonGH-24838https://github.com/python/cpython/pull/24838
a27bc4fhttps://github.com/miss-islington/cpython/commit/a27bc4f9ea1601cde98c8c0f48ed1987f06b4526
https://github.com/python/cpython/pull/24838
pythonGH-24881https://github.com/python/cpython/pull/24881
0ab152chttps://github.com/miss-islington/cpython/commit/0ab152c6b5d95caa2dc1a30fa96e10258b5f188e
664d1d1https://github.com/miss-islington/cpython/commit/664d1d16274b47eea6ec92572e1ebf3939a6fa0c
ned-deilyhttps://github.com/ned-deily
Mar 16, 2021 https://github.com/python/cpython/pull/24881#ref-commit-4134f15
https://github.com/miss-islington
https://github.com/gpshead
[3.6]https://github.com/python/cpython/commit/4134f154ae2f621f25c5d698cc0f1748035a1b88
bpo-43285https://bugs.python.org/issue?@action=redirect&bpo=43285
Make ftplib not trust the PASV response. (https://github.com/python/cpython/commit/4134f154ae2f621f25c5d698cc0f1748035a1b88
GH-24838https://github.com/python/cpython/pull/24838
) (https://github.com/python/cpython/commit/4134f154ae2f621f25c5d698cc0f1748035a1b88
G…https://github.com/python/cpython/pull/24881
4134f15https://github.com/python/cpython/commit/4134f154ae2f621f25c5d698cc0f1748035a1b88
…H-24881https://github.com/python/cpython/pull/24881
GH-24882https://github.com/python/cpython/pull/24882
0ab152chttps://github.com/python/cpython/commit/0ab152c6b5d95caa2dc1a30fa96e10258b5f188e
664d1d1https://github.com/python/cpython/commit/664d1d16274b47eea6ec92572e1ebf3939a6fa0c
ned-deilyhttps://github.com/ned-deily
Mar 16, 2021 https://github.com/python/cpython/pull/24881#ref-commit-7937395
https://github.com/miss-islington
https://github.com/gpshead
[3.7]https://github.com/python/cpython/commit/79373951b3eab585d42e0f0ab83718cbe1d0ee33
bpo-43285https://bugs.python.org/issue?@action=redirect&bpo=43285
Make ftplib not trust the PASV response. (https://github.com/python/cpython/commit/79373951b3eab585d42e0f0ab83718cbe1d0ee33
GH-24838https://github.com/python/cpython/pull/24838
) (https://github.com/python/cpython/commit/79373951b3eab585d42e0f0ab83718cbe1d0ee33
G…https://github.com/python/cpython/pull/24881
7937395https://github.com/python/cpython/commit/79373951b3eab585d42e0f0ab83718cbe1d0ee33
…H-24881https://github.com/python/cpython/pull/24881
GH-24883https://github.com/python/cpython/pull/24883
0ab152chttps://github.com/python/cpython/commit/0ab152c6b5d95caa2dc1a30fa96e10258b5f188e
664d1d1https://github.com/python/cpython/commit/664d1d16274b47eea6ec92572e1ebf3939a6fa0c
gentoo-bothttps://github.com/gentoo-bot
Apr 3, 2021 https://github.com/python/cpython/pull/24881#ref-commit-fe31479
https://github.com/miss-islington
https://github.com/mgorny
[3.6] bpo-43285 Make ftplib not trust the PASV response. (https://github.com/gentoo/cpython/commit/fe31479be5ea4e611bd485516e48c0ce46be987c
pythonGH-24838https://github.com/python/cpython/pull/24838
fe31479https://github.com/gentoo/cpython/commit/fe31479be5ea4e611bd485516e48c0ce46be987c
https://github.com/python/cpython/pull/24838
pythonGH-24881https://github.com/python/cpython/pull/24881
pythonGH-24882https://github.com/python/cpython/pull/24882
0ab152chttps://github.com/gentoo/cpython/commit/0ab152c6b5d95caa2dc1a30fa96e10258b5f188e
664d1d1https://github.com/gentoo/cpython/commit/664d1d16274b47eea6ec92572e1ebf3939a6fa0c
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24881
https://github.com/gpshead
gpshead https://github.com/gpshead
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Please reload this pagehttps://github.com/python/cpython/pull/24881
https://github.com/gpshead
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.