Title: [3.9] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) by miss-islington · Pull Request #24880 · python/cpython · GitHub
Open Graph Title: [3.9] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) by miss-islington · Pull Request #24880 · python/cpython
X Title: [3.9] bpo-43285 Make ftplib not trust the PASV response. (GH-24838) by miss-islington · Pull Request #24880 · python/cpython
Description: bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. For the rare user who wants this ugly behavior, set a trust_server_pasv_ipv4_address attribute on your ftplib.FTP instance to True. (cherry picked from commit 0ab152c) Co-authored-by: Gregory P. Smith greg@krypto.org https://bugs.python.org/issue43285 Automerge-Triggered-By: GH:gpshead
Open Graph Description: bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from...
X Description: bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from...
Opengraph URL: https://github.com/python/cpython/pull/24880
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:85f38f8c-4ddd-9545-ce5a-b9fdbaae759b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8E2:3651F6:200AE87:29E6204:696B484F |
| html-safe-nonce | ef4e239dac0abd6c0ac6065cc1cdd82d54f6751e531761f4e81345765a26505f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEUyOjM2NTFGNjoyMDBBRTg3OjI5RTYyMDQ6Njk2QjQ4NEYiLCJ2aXNpdG9yX2lkIjoiMTA5MjMwNTQwMDI3MTQyMzU2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c0488ddf84d5014d0f994bb504cec164e5145a2102b153b7db9737fce77ad242 |
| hovercard-subject-tag | pull_request:593306704 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/24880/files |
| twitter:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| og:image:alt | bpo-43285: Make ftplib not trust the PASV response. The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width