René's URL Explorer Experiment


Title: bpo-43285 Make ftplib not trust the PASV response. by gpshead · Pull Request #24838 · python/cpython · GitHub

Open Graph Title: bpo-43285 Make ftplib not trust the PASV response. by gpshead · Pull Request #24838 · python/cpython

X Title: bpo-43285 Make ftplib not trust the PASV response. by gpshead · Pull Request #24838 · python/cpython

Description: The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port combinations on the client network. Instead of using the returned address, we use the IP address we're already connected to. This is the strategy other ftp clients adopted, and matches the only strategy available for the modern IPv6 EPSV command where the server response must return a port number and nothing else. https://bugs.python.org/issue43285

Open Graph Description: The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port c...

X Description: The IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port c...

Opengraph URL: https://github.com/python/cpython/pull/24838

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:50fd312e-09f4-cf08-39fb-ef350af31add
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8BF8:74E61:30F7AC:44DC11:696A1328
html-safe-nonce4d6d671ae54cba6687066d4ccb748b68aadfe1d595537db68f91399be92ef88f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QkY4Ojc0RTYxOjMwRjdBQzo0NERDMTE6Njk2QTEzMjgiLCJ2aXNpdG9yX2lkIjoiNTgzOTUzNjI5NDYyNTMyOTA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac7eced936a18f130136273aaa9f8e83eec2a85625083f04184265c500d0c29db3
hovercard-subject-tagpull_request:592351297
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/24838/files
twitter:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/68491?s=400&v=4
og:image:altThe IPv4 address value returned from the server in response to the PASV command should not be trusted. This prevents a malicious FTP server from using the response to probe IPv4 address and port c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None699227a00bbb7fe1eec276d2ae1c3a93068bc5ba483bd9dc4b2a27a8f4f2f595
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7266b2d935baa1c6474b16dd9feaa5ca30607261
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/24838/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24838%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24838%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/24838/files
Reloadhttps://github.com/python/cpython/pull/24838/files
Reloadhttps://github.com/python/cpython/pull/24838/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/24838/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/24838/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gpsheadhttps://github.com/gpshead
python:masterhttps://github.com/python/cpython/tree/master
gpshead:ftplib_issue43285https://github.com/gpshead/cpython/tree/ftplib_issue43285
Conversation 8 https://github.com/python/cpython/pull/24838
Commits 2 https://github.com/python/cpython/pull/24838/commits
Checks 0 https://github.com/python/cpython/pull/24838/checks
Files changed https://github.com/python/cpython/pull/24838/files
Please reload this pagehttps://github.com/python/cpython/pull/24838/files
bpo-43285 Make ftplib not trust the PASV response. https://github.com/python/cpython/pull/24838/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/24838/files
4b397c1 bpo-43285 Make ftplib not trust the PASV response. gpshead Mar 13, 2021 https://github.com/python/cpython/pull/24838/commits/4b397c1b90df633187c6161615531437fe564f8c
6003e2f Rename the legacy behavior attribute and mention it in NEWS. gpshead Mar 13, 2021 https://github.com/python/cpython/pull/24838/commits/6003e2f6672696e415bc5023ce7a47a4b03488bd
Clear filters https://github.com/python/cpython/pull/24838/files
Please reload this pagehttps://github.com/python/cpython/pull/24838/files
Please reload this pagehttps://github.com/python/cpython/pull/24838/files
ftplib.py https://github.com/python/cpython/pull/24838/files#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0
test_ftplib.py https://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
2021-03-13-03-48-14.bpo-43285.g-Hah3.rst https://github.com/python/cpython/pull/24838/files#diff-d8771987e0579141c27978b8d9958d44b768575234b9d0e618127d9254af2043
Lib/ftplib.pyhttps://github.com/python/cpython/pull/24838/files#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0
View file https://github.com/gpshead/cpython/blob/6003e2f6672696e415bc5023ce7a47a4b03488bd/Lib/ftplib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24838/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24838/files#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0
https://github.com/python/cpython/pull/24838/files#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0
https://github.com/python/cpython/pull/24838/files#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0
https://github.com/python/cpython/pull/24838/files#diff-14623a6f9f5b7c4acd8d258609b07bbba40ca65a9d3ab4d260b10e5540ac1ab0
Lib/test/test_ftplib.pyhttps://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
View file https://github.com/gpshead/cpython/blob/6003e2f6672696e415bc5023ce7a47a4b03488bd/Lib/test/test_ftplib.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24838/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
https://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
https://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
https://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
https://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
https://github.com/python/cpython/pull/24838/files#diff-a8c5efe8da26e420d823388f4b2f5f6325ecff8d34e132f4ce2b2b31fb8223a3
Misc/NEWS.d/next/Security/2021-03-13-03-48-14.bpo-43285.g-Hah3.rsthttps://github.com/python/cpython/pull/24838/files#diff-d8771987e0579141c27978b8d9958d44b768575234b9d0e618127d9254af2043
View file https://github.com/gpshead/cpython/blob/6003e2f6672696e415bc5023ce7a47a4b03488bd/Misc/NEWS.d/next/Security/2021-03-13-03-48-14.bpo-43285.g-Hah3.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24838/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.