Title: bpo-29585: Fix sysconfig.get_config_var("PYTHONFRAMEWORK") by methane · Pull Request #2483 · python/cpython · GitHub
Open Graph Title: bpo-29585: Fix sysconfig.get_config_var("PYTHONFRAMEWORK") by methane · Pull Request #2483 · python/cpython
X Title: bpo-29585: Fix sysconfig.get_config_var("PYTHONFRAMEWORK") by methane · Pull Request #2483 · python/cpython
Description: After GH-136 merged, PYTHONFRAMEWORK config variable are in Makefile and pyconfig.h. When reading string variable from Makefile, quote is removed. But when reading them from pyconfig.h, quote is not removed. And config variables in pyconfig.h override config variables in Makefile. So sysconfig.get_config_var("PYTHONFRAMEWORK") was changed '' to '""' in non framework build, and 'PYTHON' to '"PYTHON"' in framework build. I thought about unquoting string config variables in pyconfig.h, but there is one string variables already and it may cause unintentional backward incompatibility. (sysconfig.get_config_var('PY_FORMAT_SIZE_T') is '"z"'). So this pull request just rename PYTHONFRAMEWORK to _PYTHONFRAMEWORK in pyconfig.h. Variables which name starts with _ is not exported to sysconfig.
Open Graph Description: After GH-136 merged, PYTHONFRAMEWORK config variable are in Makefile and pyconfig.h. When reading string variable from Makefile, quote is removed. But when reading them from pyconfig.h, quote is no...
X Description: After GH-136 merged, PYTHONFRAMEWORK config variable are in Makefile and pyconfig.h. When reading string variable from Makefile, quote is removed. But when reading them from pyconfig.h, quote is no...
Opengraph URL: https://github.com/python/cpython/pull/2483
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ac117ad9-54a5-191a-a48c-45b4a721f613 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9E18:174FB1:1671E4C:1DFF6B8:696AE2D9 |
| html-safe-nonce | 5ca3652e968907e9eb87f058f476d3cb3889b44f91d44f2392241e4a6f3ee1bb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RTE4OjE3NEZCMToxNjcxRTRDOjFERkY2Qjg6Njk2QUUyRDkiLCJ2aXNpdG9yX2lkIjoiODk4MDc5ODMyODc2NDI5Mzg0OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 70beeba4b56612072ec28ffb8edfcc774499ce0794b3b9057d51299500ec82f7 |
| hovercard-subject-tag | pull_request:128074538 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/2483/files |
| twitter:image | https://avatars.githubusercontent.com/u/199592?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199592?s=400&v=4 |
| og:image:alt | After GH-136 merged, PYTHONFRAMEWORK config variable are in Makefile and pyconfig.h. When reading string variable from Makefile, quote is removed. But when reading them from pyconfig.h, quote is no... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3d84d50b3c75fa36755c3cf392edbc09e626f979 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width