René's URL Explorer Experiment


Title: gh-84649: Make TimedRotatingFileHandler use CTIME instead of MTIME by martonivan · Pull Request #24660 · python/cpython · GitHub

Open Graph Title: gh-84649: Make TimedRotatingFileHandler use CTIME instead of MTIME by martonivan · Pull Request #24660 · python/cpython

X Title: gh-84649: Make TimedRotatingFileHandler use CTIME instead of MTIME by martonivan · Pull Request #24660 · python/cpython

Description: The TimedRotatingFileHandler previously used MTIME attribute of the log file to detect whether it has to be rotate yet or not. In cases when the file is changed within the rotation period the MTIME is also updated to the current time and the rotation never happens. It's more appropriate to check the file creation time (CTIME) instead. https://bugs.python.org/issue40469 Issue: gh-84649

Open Graph Description: The TimedRotatingFileHandler previously used MTIME attribute of the log file to detect whether it has to be rotate yet or not. In cases when the file is changed within the rotation period the MTIME...

X Description: The TimedRotatingFileHandler previously used MTIME attribute of the log file to detect whether it has to be rotate yet or not. In cases when the file is changed within the rotation period the MTIME...

Opengraph URL: https://github.com/python/cpython/pull/24660

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d32d0e59-10f0-4740-7284-aa1dc12546a2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDEAC:22F65E:776B4:9ED6A:6A516C1E
html-safe-nonce223de29530a97c93667d262200bc7035021e24d81a7410826003eeed58451e97
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUFDOjIyRjY1RTo3NzZCNDo5RUQ2QTo2QTUxNkMxRSIsInZpc2l0b3JfaWQiOiI2ODc4ODA5NTc3MTI4ODE1NjQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc65cc909ed3db5a138de8a537345a5810688a6afefbeb755081a74b2868ab9ee
hovercard-subject-tagpull_request:580801871
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/24660/files
twitter:imagehttps://avatars.githubusercontent.com/u/790608?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/790608?s=400&v=4
og:image:altThe TimedRotatingFileHandler previously used MTIME attribute of the log file to detect whether it has to be rotate yet or not. In cases when the file is changed within the rotation period the MTIME...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release60eaaf6d4dbaa817031b556aebd8a0a7eeb81b97
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/24660/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24660%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24660%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/24660/files
Reloadhttps://github.com/python/cpython/pull/24660/files
Reloadhttps://github.com/python/cpython/pull/24660/files
Please reload this pagehttps://github.com/python/cpython/pull/24660/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/24660/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.7k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:mainhttps://github.com/python/cpython/tree/main
martonivan:fix-issue-40469https://github.com/martonivan/cpython/tree/fix-issue-40469
Conversation 20 https://github.com/python/cpython/pull/24660
Commits 4 https://github.com/python/cpython/pull/24660/commits
Checks 50 https://github.com/python/cpython/pull/24660/checks
Files changed https://github.com/python/cpython/pull/24660/files
Please reload this pagehttps://github.com/python/cpython/pull/24660/files
gh-84649: Make TimedRotatingFileHandler use CTIME instead of MTIME https://github.com/python/cpython/pull/24660/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/24660/files
39d9f1f Add missing NEWS item about the change martonivan Mar 1, 2024 https://github.com/python/cpython/pull/24660/commits/39d9f1f0588c9fed7763e0b076acf33dd8f44b8b
6731309 gh-84649: Make TimedRotatingFileHandler use CTIME instead of MTIME martonivan Mar 1, 2024 https://github.com/python/cpython/pull/24660/commits/67313093f1c16b0db72f48e2733ad3d2326bfe49
3464624 Merge branch 'main' into fix-issue-40469 serhiy-storchaka Jun 4, 2026 https://github.com/python/cpython/pull/24660/commits/3464624a8387dff9408b2e1ed38e063fd17002f3
6e588d4 Re-wrap long lines. serhiy-storchaka Jun 4, 2026 https://github.com/python/cpython/pull/24660/commits/6e588d4b75c5934b7b4903afef990c5d9e4ee3d4
Clear filters https://github.com/python/cpython/pull/24660/files
Please reload this pagehttps://github.com/python/cpython/pull/24660/files
Please reload this pagehttps://github.com/python/cpython/pull/24660/files
handlers.py https://github.com/python/cpython/pull/24660/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
__init__.py https://github.com/python/cpython/pull/24660/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
test_logging.py https://github.com/python/cpython/pull/24660/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
ACKS https://github.com/python/cpython/pull/24660/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
2021-02-26-13-17-57.bpo-40469.yJHeQg.rst https://github.com/python/cpython/pull/24660/files#diff-c751c02a0fe483af00c086fc22b016f3374c121df7f03ccab7b24c2607e3de5f
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L526
Lib/logging/handlers.pyhttps://github.com/python/cpython/pull/24660/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
View file https://github.com/martonivan/cpython/blob/6e588d4b75c5934b7b4903afef990c5d9e4ee3d4/Lib/logging/handlers.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24660/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24660/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
https://github.com/python/cpython/pull/24660/files#diff-0798fd5bd555ae6d7713d10e5266a8bcd7a9800f1fd38d74f09e7bda68a79ebe
Lib/test/support/__init__.pyhttps://github.com/python/cpython/pull/24660/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
View file https://github.com/martonivan/cpython/blob/6e588d4b75c5934b7b4903afef990c5d9e4ee3d4/Lib/test/support/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24660/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24660/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/pull/24660/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/pull/24660/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/pull/24660/files#diff-d925268c057737ba320c489ca302fd5125f14840d22e50cfe226bdb5bb88ba8d
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L527
Lib/test/test_logging.pyhttps://github.com/python/cpython/pull/24660/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
View file https://github.com/martonivan/cpython/blob/6e588d4b75c5934b7b4903afef990c5d9e4ee3d4/Lib/test/test_logging.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24660/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24660/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
https://github.com/python/cpython/pull/24660/files#diff-bc15bb717afb8343ceee4cd4219559dc397092dcde20271f6e8708c2b132976f
Misc/ACKShttps://github.com/python/cpython/pull/24660/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
View file https://github.com/martonivan/cpython/blob/6e588d4b75c5934b7b4903afef990c5d9e4ee3d4/Misc/ACKS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24660/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24660/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
https://github.com/python/cpython/pull/24660/files#diff-d1243956feb505c5459fc05387e194609efb5c350cee202942be47ed30d7d7d0
Misc/NEWS.d/next/Library/2021-02-26-13-17-57.bpo-40469.yJHeQg.rsthttps://github.com/python/cpython/pull/24660/files#diff-c751c02a0fe483af00c086fc22b016f3374c121df7f03ccab7b24c2607e3de5f
View file https://github.com/martonivan/cpython/blob/6e588d4b75c5934b7b4903afef990c5d9e4ee3d4/Misc/NEWS.d/next/Library/2021-02-26-13-17-57.bpo-40469.yJHeQg.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24660/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/24660/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.