René's URL Explorer Experiment


Title: [WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements by erlend-aasland · Pull Request #24492 · python/cpython · GitHub

Open Graph Title: [WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements by erlend-aasland · Pull Request #24492 · python/cpython

X Title: [WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements by erlend-aasland · Pull Request #24492 · python/cpython

Description: Fixes #81040

Open Graph Description: Fixes #81040

X Description: Fixes #81040

Opengraph URL: https://github.com/python/cpython/pull/24492

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:1e4ebd3c-2b52-c4c7-bfe9-f6a6e88705e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEAE4:D209A:66FDC4:84C48E:696B121A
html-safe-noncebb57c85e22ee8f84eaa7354de9666b74aa3ea6d58e7d633000bb4d8d9c2dc341
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQUU0OkQyMDlBOjY2RkRDNDo4NEM0OEU6Njk2QjEyMUEiLCJ2aXNpdG9yX2lkIjoiODI2MjYzMzg3NTA4Mjc3NzExNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac745dc95cbe1ef98cd6ad170ef31d74bdb2f8f1d298e3d33a44b6c6fd500c4a92
hovercard-subject-tagpull_request:570349416
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/24492/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aabe9a3ab26919f84ea786982fb2e7fe2229e715e0f04f1e03f299cd5869a16c/python/cpython/pull/24492
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aabe9a3ab26919f84ea786982fb2e7fe2229e715e0f04f1e03f299cd5869a16c/python/cpython/pull/24492
og:image:altFixes #81040
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/24492#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24492
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24492
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/24492
Reloadhttps://github.com/python/cpython/pull/24492
Reloadhttps://github.com/python/cpython/pull/24492
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/24492
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/24492
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/24492#issue-comment-box
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:bpo-36859https://github.com/erlend-aasland/cpython/tree/bpo-36859
[WIP] gh-81040: use sqlite3_stmt_readonly() to detect DML statements https://github.com/python/cpython/pull/24492#top
erlend-aaslandhttps://github.com/erlend-aasland
python:mainhttps://github.com/python/cpython/tree/main
erlend-aasland:bpo-36859https://github.com/erlend-aasland/cpython/tree/bpo-36859
Conversation 4 https://github.com/python/cpython/pull/24492
Commits 15 https://github.com/python/cpython/pull/24492/commits
Checks 0 https://github.com/python/cpython/pull/24492/checks
Files changed 3 https://github.com/python/cpython/pull/24492/files
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Feb 9, 2021https://github.com/python/cpython/pull/24492#issue-804611328
Please reload this pagehttps://github.com/python/cpython/pull/24492
#81040https://github.com/python/cpython/issues/81040
Please reload this pagehttps://github.com/python/cpython/pull/24492
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
berkerpeksaghttps://github.com/berkerpeksag
code ownerhttps://github.com/python/cpython/blob/da21f7b6e1fd5bd3e78931a06c5eb694f6335233/.github/CODEOWNERS#L95
February 9, 2021 14:38https://github.com/python/cpython/pull/24492#event-4309526346
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Feb 9, 2021https://github.com/python/cpython/pull/24492#event-4309526617
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Feb 9, 2021https://github.com/python/cpython/pull/24492#event-4309526788
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Feb 9, 2021https://github.com/python/cpython/pull/24492#issuecomment-775988105
#13216https://github.com/python/cpython/pull/13216
@berkerpeksaghttps://github.com/berkerpeksag
@coleiferhttps://github.com/coleifer
@serhiy-storchakahttps://github.com/serhiy-storchaka
Please reload this pagehttps://github.com/python/cpython/pull/24492
coleiferhttps://github.com/coleifer
March 2, 2021 10:13https://github.com/python/cpython/pull/24492#commits-pushed-11e9829
https://github.com/coleifer
Use sqlite3_stmt_readonly API to determine is statement is DML.https://github.com/python/cpython/pull/24492/commits/11e982936fb015be47e0e9fc5665e5dbefa44257
11e9829https://github.com/python/cpython/pull/24492/commits/11e982936fb015be47e0e9fc5665e5dbefa44257
https://github.com/coleifer
Skip dml detection + sql comment for old sqlite.https://github.com/python/cpython/pull/24492/commits/29a7e2056aeb6cca710b8c88be495dd979884c07
29a7e20https://github.com/python/cpython/pull/24492/commits/29a7e2056aeb6cca710b8c88be495dd979884c07
https://github.com/coleifer
Add news item.https://github.com/python/cpython/pull/24492/commits/f20d41b7ccbc8828794f719fc7bea0a4fe6facdf
f20d41bhttps://github.com/python/cpython/pull/24492/commits/f20d41b7ccbc8828794f719fc7bea0a4fe6facdf
https://github.com/coleifer
Address review comments, additional regression test.https://github.com/python/cpython/pull/24492/commits/868b97a55215c4c1968d4509b8c53b77a2982dd2
868b97ahttps://github.com/python/cpython/pull/24492/commits/868b97a55215c4c1968d4509b8c53b77a2982dd2
https://github.com/berkerpeksag
Fix rest markuphttps://github.com/python/cpython/pull/24492/commits/a13fb7136ea145f19bcaa9dd3d6a6f4f1302d9d6
a13fb71https://github.com/python/cpython/pull/24492/commits/a13fb7136ea145f19bcaa9dd3d6a6f4f1302d9d6
https://github.com/berkerpeksag
cosmetic fixeshttps://github.com/python/cpython/pull/24492/commits/6e1cf0669400420c3b7db393e3534e689b4654c1
6e1cf06https://github.com/python/cpython/pull/24492/commits/6e1cf0669400420c3b7db393e3534e689b4654c1
https://github.com/coleifer
Ensure all non-DML statements that write are covered.https://github.com/python/cpython/pull/24492/commits/013e43b4ffd680a099316bd638f138cb04be56a0
013e43bhttps://github.com/python/cpython/pull/24492/commits/013e43b4ffd680a099316bd638f138cb04be56a0
https://github.com/coleifer
Move DML detection tests into transactions test module.https://github.com/python/cpython/pull/24492/commits/6e6f2a02eda06efa5e2a77925bb1f79b2ebf4e7a
6e6f2a0https://github.com/python/cpython/pull/24492/commits/6e6f2a02eda06efa5e2a77925bb1f79b2ebf4e7a
https://github.com/coleifer
Fix version-check for sqlite3_stmt_readonly availability.https://github.com/python/cpython/pull/24492/commits/09cac6c3953060af25df002cc1168603c5b65280
09cac6chttps://github.com/python/cpython/pull/24492/commits/09cac6c3953060af25df002cc1168603c5b65280
Sync withhttps://github.com/python/cpython/pull/24492/commits/d1efa55e0b8630715219161b627f6f928f635da5
pythonGH-24106https://github.com/python/cpython/pull/24106
d1efa55https://github.com/python/cpython/pull/24492/commits/d1efa55e0b8630715219161b627f6f928f635da5
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
March 2, 2021 09:15https://github.com/python/cpython/pull/24492#event-4394628479
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
Apr 2, 2021https://github.com/python/cpython/pull/24492#issuecomment-812244619
Please reload this pagehttps://github.com/python/cpython/pull/24492
https://github.com/apps/github-actions
github-actionshttps://github.com/apps/github-actions
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
Apr 2, 2021https://github.com/python/cpython/pull/24492#event-4543848302
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
May 18, 2021https://github.com/python/cpython/pull/24492#event-4759391633
June 5, 2021 21:00https://github.com/python/cpython/pull/24492#commits-pushed-3645ccc
Merge branch 'main' into bpo-36859https://github.com/python/cpython/pull/24492/commits/3645cccb91045bd39984a260445d2a80dff575f8
3645ccchttps://github.com/python/cpython/pull/24492/commits/3645cccb91045bd39984a260445d2a80dff575f8
PEP 7https://github.com/python/cpython/pull/24492/commits/dce7ada0f8b5917de854b4397f9f5a42b76a4a1d
dce7adahttps://github.com/python/cpython/pull/24492/commits/dce7ada0f8b5917de854b4397f9f5a42b76a4a1d
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
force-pushedhttps://github.com/python/cpython/compare/ba8d1e6c701e0541e1cd9e17aff594ebb92ecdd6..dce7ada0f8b5917de854b4397f9f5a42b76a4a1d
ba8d1e6https://github.com/python/cpython/commit/ba8d1e6c701e0541e1cd9e17aff594ebb92ecdd6
dce7adahttps://github.com/python/cpython/commit/dce7ada0f8b5917de854b4397f9f5a42b76a4a1d
Compare https://github.com/python/cpython/compare/ba8d1e6c701e0541e1cd9e17aff594ebb92ecdd6..dce7ada0f8b5917de854b4397f9f5a42b76a4a1d
June 5, 2021 21:27https://github.com/python/cpython/pull/24492#event-4847211770
June 8, 2021 22:36https://github.com/python/cpython/pull/24492#commits-pushed-7c01d5a
Merge branch 'main' into bpo-36859https://github.com/python/cpython/pull/24492/commits/7c01d5ad58dae03b60632db6f8c27d52f914c437
7c01d5ahttps://github.com/python/cpython/pull/24492/commits/7c01d5ad58dae03b60632db6f8c27d52f914c437
Improve namespacehttps://github.com/python/cpython/pull/24492/commits/6eb6ec98402efc2a3b7441c4a32d5756224c824a
6eb6ec9https://github.com/python/cpython/pull/24492/commits/6eb6ec98402efc2a3b7441c4a32d5756224c824a
Merge branch 'main' into bpo-36859https://github.com/python/cpython/pull/24492/commits/1bdefdde21cc3145fce0a040f6ec31d852a37dd9
1bdefddhttps://github.com/python/cpython/pull/24492/commits/1bdefdde21cc3145fce0a040f6ec31d852a37dd9
https://github.com/MaxwellDupre
MaxwellDuprehttps://github.com/MaxwellDupre
Apr 4, 2022 https://github.com/python/cpython/pull/24492#pullrequestreview-930189858
View reviewed changes https://github.com/python/cpython/pull/24492/files/1bdefdde21cc3145fce0a040f6ec31d852a37dd9
MaxwellDuprehttps://github.com/MaxwellDupre
https://github.com/python/cpython/pull/24492#pullrequestreview-930189858
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/24492
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Apr 4, 2022https://github.com/python/cpython/pull/24492#event-6362028792
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Apr 10, 2022https://github.com/python/cpython/pull/24492#event-6404702300
https://github.com/python/cpython/pull/24492
coleiferhttps://github.com/python/cpython/pull/24492
May 16, 2022 https://github.com/python/cpython/pull/24492#ref-issue-1199011592
sqlite3 dml statement detection does not account for CTEs #81040 https://github.com/python/cpython/issues/81040
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 27, 2022https://github.com/python/cpython/pull/24492#issuecomment-1167016650
Please reload this pagehttps://github.com/python/cpython/pull/24492
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Jun 27, 2022https://github.com/python/cpython/pull/24492#event-6882917279
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
June 27, 2022 08:01https://github.com/python/cpython/pull/24492#event-6882917643
https://github.com/coleifer
coleiferhttps://github.com/coleifer
Jun 26, 2023 https://github.com/python/cpython/pull/24492#ref-issue-1773550231
Autocommit behaves differently from sqlite3 coleifer/pysqlite3#58 https://github.com/coleifer/pysqlite3/issues/58
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24492
https://github.com/berkerpeksag
berkerpeksag https://github.com/berkerpeksag
https://github.com/MaxwellDupre
MaxwellDupre https://github.com/MaxwellDupre
https://github.com/python/cpython/pull/24492/files/1bdefdde21cc3145fce0a040f6ec31d852a37dd9
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
stale https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Astale
sqlite3 dml statement detection does not account for CTEs https://github.com/python/cpython/issues/81040
Please reload this pagehttps://github.com/python/cpython/pull/24492
https://github.com/erlend-aasland
https://github.com/MaxwellDupre
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/coleifer
https://github.com/berkerpeksag
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.