René's URL Explorer Experiment


Title: bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion by pdonis · Pull Request #24359 · python/cpython · GitHub

Open Graph Title: bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion by pdonis · Pull Request #24359 · python/cpython

X Title: bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion by pdonis · Pull Request #24359 · python/cpython

Description: This PR is a follow-up to PR #17385 for bpo-1812 (now merged). During discussion on that issue the suggestion was made to investigate whether any resources already provided by the io module might be available to do the newline conversion in doctest that was corrected in that PR. It turns out there is: the io.IncrementalNewlineDecoder object does exactly the conversion that is needed. This PR implements using that object in place of the custom newline conversion that was done in the previous PR. The only change is in the relevant code in the doctest module. https://bugs.python.org/issue43049

Open Graph Description: This PR is a follow-up to PR #17385 for bpo-1812 (now merged). During discussion on that issue the suggestion was made to investigate whether any resources already provided by the io module might b...

X Description: This PR is a follow-up to PR #17385 for bpo-1812 (now merged). During discussion on that issue the suggestion was made to investigate whether any resources already provided by the io module might b...

Opengraph URL: https://github.com/python/cpython/pull/24359

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:45a1a54d-c9a6-7e8e-5e36-f8932a131319
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8D1A:237E30:144C83:1B8163:6B006491
html-safe-nonce099359e6324b0841c91447ce5c4e6c2a3dc3b0067a8ea08b7147d120297d4d9d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RDFBOjIzN0UzMDoxNDRDODM6MUI4MTYzOjZCMDA2NDkxIiwidmlzaXRvcl9pZCI6Ijg1OTU2NzMwNDgwNTk3NjU5MDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1558ddb8fabb44e904c054e9ceafaa588bb62966f6263edf569815e92914cb5f
hovercard-subject-tagpull_request:562925455
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/24359/files
twitter:imagehttps://avatars.githubusercontent.com/u/1264258?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1264258?s=400&v=4
og:image:altThis PR is a follow-up to PR #17385 for bpo-1812 (now merged). During discussion on that issue the suggestion was made to investigate whether any resources already provided by the io module might b...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None25854482a1773a7c1ebb8be3d2bc1c6e61d82d78126be63b5044474a86d44d9e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee4f5c239e31f1f680e6bbc419ff92d774da616ec
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/24359/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24359%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24359%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/24359/files
Reloadhttps://github.com/python/cpython/pull/24359/files
Reloadhttps://github.com/python/cpython/pull/24359/files
pythonhttps://github.com/python
cpythonhttps://github.com/python/cpython
Codehttps://github.com/python/cpython
Issues5k+ (5k+)https://github.com/python/cpython/issues
Pull requests2.4k (2.4k)https://github.com/python/cpython/pulls
Actionshttps://github.com/python/cpython/actions
Projectshttps://github.com/python/cpython/projects
Security and qualityhttps://github.com/python/cpython/security
Insightshttps://github.com/python/cpython/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
zwarehttps://github.com/zware
python:masterhttps://github.com/python/cpython/tree/master
pdonis:doctest-incremental-decoderhttps://github.com/pdonis/cpython/tree/doctest-incremental-decoder
Conversation 7 https://github.com/python/cpython/pull/24359
Commits 1 https://github.com/python/cpython/pull/24359/commits
Checks 0 https://github.com/python/cpython/pull/24359/checks
Files changed https://github.com/python/cpython/pull/24359/files
Please reload this pagehttps://github.com/python/cpython/pull/24359/files
bpo-43049: Use io.IncrementalNewlineDecoder for doctest newline conversion https://github.com/python/cpython/pull/24359/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/24359/files
6487496 Use io.IncrementalNewlineDecoder for doctest newline conversion. pdonis Jan 28, 2021 https://github.com/python/cpython/pull/24359/commits/64874960a26eeea806d4118f23f72dceccb2e756
Clear filters https://github.com/python/cpython/pull/24359/files
Please reload this pagehttps://github.com/python/cpython/pull/24359/files
Please reload this pagehttps://github.com/python/cpython/pull/24359/files
Lib/doctest.pyhttps://github.com/python/cpython/pull/24359/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
View file https://github.com/pdonis/cpython/blob/64874960a26eeea806d4118f23f72dceccb2e756/Lib/doctest.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24359/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24359/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com/python/cpython/pull/24359/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com/python/cpython/pull/24359/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com/python/cpython/pull/24359/files#diff-ecfd94d9d59a476cc6a2027adf6ec5468dcaaa9c8ad5c6e007ba195ce471db70
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.