René's URL Explorer Experiment


Title: bpo-42927: Inline cache for slots by gvanrossum · Pull Request #24216 · python/cpython · GitHub

Open Graph Title: bpo-42927: Inline cache for slots by gvanrossum · Pull Request #24216 · python/cpython

X Title: bpo-42927: Inline cache for slots by gvanrossum · Pull Request #24216 · python/cpython

Description: This is a modification of the LOAD_ATTR inline cache that landed a few months ago (PR 22803). The design overloads the hint field: if it is negative, it indicates a slot. Slots are created using __slots__, but some builtin types that use PyMemberDescrObject descriptors (with the type set to T_OBJECT_EX) will also benefit. I've tried to keep the code style similar to the existing LOAD_ATTR cache (happy path first) but I had to make some compromises, e.g. the cache initialization code can no longer skip everything if tp_dictoffset is zero (since it will be zero for classes with only slots). https://bugs.python.org/issue42927

Open Graph Description: This is a modification of the LOAD_ATTR inline cache that landed a few months ago (PR 22803). The design overloads the hint field: if it is negative, it indicates a slot. Slots are created using __...

X Description: This is a modification of the LOAD_ATTR inline cache that landed a few months ago (PR 22803). The design overloads the hint field: if it is negative, it indicates a slot. Slots are created using __...

Opengraph URL: https://github.com/python/cpython/pull/24216

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9fdd329a-57e9-e7a3-c44b-1c58c0e3f7af
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8AA2:2A8696:11FC3EB:17DA57C:6A542535
html-safe-noncea0e1cf565d1a054c632599fd039522cacf172c7f14bd8a025955a2b595864def
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUEyOjJBODY5NjoxMUZDM0VCOjE3REE1N0M6NkE1NDI1MzUiLCJ2aXNpdG9yX2lkIjoiODI2MzQ1ODI4MTE4NTYxNzIwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaa283843da3c2f5c78b1b0c3b0db4cef5c40dfeefdcd5d7a690b65ef71b5a523
hovercard-subject-tagpull_request:554642745
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/24216/files
twitter:imagehttps://avatars.githubusercontent.com/u/2894642?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2894642?s=400&v=4
og:image:altThis is a modification of the LOAD_ATTR inline cache that landed a few months ago (PR 22803). The design overloads the hint field: if it is negative, it indicates a slot. Slots are created using __...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/24216/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24216%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24216%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/24216/files
Reloadhttps://github.com/python/cpython/pull/24216/files
Reloadhttps://github.com/python/cpython/pull/24216/files
Please reload this pagehttps://github.com/python/cpython/pull/24216/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/24216/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
gvanrossumhttps://github.com/gvanrossum
python:masterhttps://github.com/python/cpython/tree/master
gvanrossum:slotscachehttps://github.com/gvanrossum/cpython/tree/slotscache
Conversation 38 https://github.com/python/cpython/pull/24216
Commits 7 https://github.com/python/cpython/pull/24216/commits
Checks 0 https://github.com/python/cpython/pull/24216/checks
Files changed https://github.com/python/cpython/pull/24216/files
Please reload this pagehttps://github.com/python/cpython/pull/24216/files
bpo-42927: Inline cache for slots https://github.com/python/cpython/pull/24216/files#top
Show all changes 7 commits https://github.com/python/cpython/pull/24216/files
aca2939 Implement inline cache for slots gvanrossum Jan 14, 2021 https://github.com/python/cpython/pull/24216/commits/aca2939fdd502048b70f51fcbcf0029bb63f8415
e334e53 Comment out debug print gvanrossum Jan 15, 2021 https://github.com/python/cpython/pull/24216/commits/e334e53b3bb53a22a6a8ccdad70caae9f8c5e434
ec0a590 Fall through to slow path if slot is NULL gvanrossum Jan 15, 2021 https://github.com/python/cpython/pull/24216/commits/ec0a5908679a57aba95cdd37ba0424713b84ea72
b725a65 📜🤖 Added by blurb_it. blurb-it[bot] Jan 15, 2021 https://github.com/python/cpython/pull/24216/commits/b725a65cc22453f4f30d32e14a87c655fdc9a7c2
4c2eb69 Fix the buildbot test failure (I hope). gvanrossum Jan 28, 2021 https://github.com/python/cpython/pull/24216/commits/4c2eb693ae1ce9bf06771129598ba98159d64209
17c8a95 Merge remote-tracking branch 'origin/master' into slotscache gvanrossum Jan 28, 2021 https://github.com/python/cpython/pull/24216/commits/17c8a95f36ef94b79f64dfe23af4ac58117e4d2b
86c4b39 Improve comment gvanrossum Jan 28, 2021 https://github.com/python/cpython/pull/24216/commits/86c4b391f7014dab38edf633056cc8aa0500fc8a
Clear filters https://github.com/python/cpython/pull/24216/files
Please reload this pagehttps://github.com/python/cpython/pull/24216/files
Please reload this pagehttps://github.com/python/cpython/pull/24216/files
2021-01-15-20-05-56.bpo-42927.GI-l-7.rst https://github.com/python/cpython/pull/24216/files#diff-547b5205f046377d4f5fc5faaf4d0dc26a72e27efcc23df37ea655d91843fd6a
ceval.c https://github.com/python/cpython/pull/24216/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
Misc/NEWS.d/next/Core and Builtins/2021-01-15-20-05-56.bpo-42927.GI-l-7.rsthttps://github.com/python/cpython/pull/24216/files#diff-547b5205f046377d4f5fc5faaf4d0dc26a72e27efcc23df37ea655d91843fd6a
View file https://github.com/gvanrossum/cpython/blob/86c4b391f7014dab38edf633056cc8aa0500fc8a/Misc/NEWS.d/next/Core%20and%20Builtins/2021-01-15-20-05-56.bpo-42927.GI-l-7.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24216/{{ revealButtonHref }}
Python/ceval.chttps://github.com/python/cpython/pull/24216/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
View file https://github.com/gvanrossum/cpython/blob/86c4b391f7014dab38edf633056cc8aa0500fc8a/Python/ceval.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/24216/{{ revealButtonHref }}
https://github.com/python/cpython/pull/24216/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/24216/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com/python/cpython/pull/24216/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
1st1https://github.com/1st1
Jan 28, 2021https://github.com/python/cpython/pull/24216/files#r566359072
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/24216/files
gvanrossumhttps://github.com/gvanrossum
Jan 28, 2021https://github.com/python/cpython/pull/24216/files#r566360852
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/24216/files
https://github.com/python/cpython/pull/24216/files#diff-c22186367cbe20233e843261998dc027ae5f1f8c0d2e778abfa454ae74cc59de
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.