René's URL Explorer Experiment


Title: bpo-41818: Close file descriptors in test_openpty by encukou · Pull Request #24119 · python/cpython · GitHub

Open Graph Title: bpo-41818: Close file descriptors in test_openpty by encukou · Pull Request #24119 · python/cpython

X Title: bpo-41818: Close file descriptors in test_openpty by encukou · Pull Request #24119 · python/cpython

Description: When stdin is a TTY, the test added in commit c13d899 is expected to fail. However, when it failed, it did not close its file descriptors. This is flagged by the refleak tests (but only when stdin ...

Open Graph Description: When stdin is a TTY, the test added in commit c13d899 is expected to fail. However, when it failed, it did not close its file descriptors. This is flagged by the refleak tests (but only when stdin ...

X Description: When stdin is a TTY, the test added in commit c13d899 is expected to fail. However, when it failed, it did not close its file descriptors. This is flagged by the refleak tests (but only when stdin ...

Opengraph URL: https://github.com/python/cpython/pull/24119

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fd4055c7-ca0d-a64d-cdf4-2d38da689aeb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA0CC:199660:F03910:14F9C16:696A3336
html-safe-nonceb94d64d1c8bf6bf2bf97dca01569301b3a0d6cd49fb47e96724b183d0e0d225a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMENDOjE5OTY2MDpGMDM5MTA6MTRGOUMxNjo2OTZBMzMzNiIsInZpc2l0b3JfaWQiOiI5MDI3MDE5ODE2MzUzMjY3NzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac2a83d4b2c9e5f504d9b59ee731a45038ac2f0aeb20f93815864da046f46ecc93
hovercard-subject-tagpull_request:549178847
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/24119/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/04ff612405e6e306bbd8f7896e899d4205ac1a855345756748d93dc24d579656/python/cpython/pull/24119
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/04ff612405e6e306bbd8f7896e899d4205ac1a855345756748d93dc24d579656/python/cpython/pull/24119
og:image:altWhen stdin is a TTY, the test added in commit c13d899 is expected to fail. However, when it failed, it did not close its file descriptors. This is flagged by the refleak tests (but only when stdin ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/24119#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24119
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24119
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/24119
Reloadhttps://github.com/python/cpython/pull/24119
Reloadhttps://github.com/python/cpython/pull/24119
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/24119
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/24119
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/24119#issue-comment-box
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:pty_refleakhttps://github.com/encukou/cpython/tree/pty_refleak
bpo-41818: Close file descriptors in test_openpty https://github.com/python/cpython/pull/24119#top
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:pty_refleakhttps://github.com/encukou/cpython/tree/pty_refleak
Conversation 7 https://github.com/python/cpython/pull/24119
Commits 3 https://github.com/python/cpython/pull/24119/commits
Checks 0 https://github.com/python/cpython/pull/24119/checks
Files changed https://github.com/python/cpython/pull/24119/files
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Jan 5, 2021https://github.com/python/cpython/pull/24119#issue-779183813
Please reload this pagehttps://github.com/python/cpython/pull/24119
c13d899https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136
https://bugs.python.org/issue41818https://bugs.python.org/issue41818
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.com/encukou
bpo-41818: Close file descriptors in test_openptyhttps://github.com/python/cpython/pull/24119/commits/c24e78d49211f6b47773685709268bbac9dc37bb
c24e78dhttps://github.com/python/cpython/pull/24119/commits/c24e78d49211f6b47773685709268bbac9dc37bb
c13d899https://github.com/encukou/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136
https://github.com/encukou
encukouhttps://github.com/encukou
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Jan 5, 2021https://github.com/python/cpython/pull/24119#event-4170425302
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Jan 5, 2021https://github.com/python/cpython/pull/24119#event-4170425577
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 5, 2021https://github.com/python/cpython/pull/24119#event-4170425740
https://github.com/encukou
Sign in to viewhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24119
https://github.com/zware
zwarehttps://github.com/zware
Jan 5, 2021 https://github.com/python/cpython/pull/24119#pullrequestreview-561905182
View reviewed changes https://github.com/python/cpython/pull/24119/files/c24e78d49211f6b47773685709268bbac9dc37bb
Lib/test/test_pty.pyhttps://github.com/python/cpython/pull/24119/files/c24e78d49211f6b47773685709268bbac9dc37bb#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.com/encukou
Instead of the big indent, use self.addCleanuphttps://github.com/python/cpython/pull/24119/commits/b7eb9e8d4360fadf04bc5fa9fd5a22c664e1c5e3
b7eb9e8https://github.com/python/cpython/pull/24119/commits/b7eb9e8d4360fadf04bc5fa9fd5a22c664e1c5e3
https://github.com/zware
zwarehttps://github.com/zware
Jan 5, 2021 https://github.com/python/cpython/pull/24119#pullrequestreview-561936667
View reviewed changes https://github.com/python/cpython/pull/24119/files/b7eb9e8d4360fadf04bc5fa9fd5a22c664e1c5e3
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Jan 5, 2021https://github.com/python/cpython/pull/24119#event-4170711822
https://github.com/8vasu
8vasuhttps://github.com/8vasu
Jan 5, 2021https://github.com/python/cpython/pull/24119#issuecomment-754746132
@encukouhttps://github.com/encukou
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.com/encukou
Clean up also in test_master_read and test_forkhttps://github.com/python/cpython/pull/24119/commits/494fd7b9f4e52ef8f2dd54acbb8822ea04dc8c6d
494fd7bhttps://github.com/python/cpython/pull/24119/commits/494fd7b9f4e52ef8f2dd54acbb8822ea04dc8c6d
https://github.com/encukou
encukouhttps://github.com/encukou
Jan 12, 2021https://github.com/python/cpython/pull/24119#issuecomment-758711081
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.com/zware
zwarehttps://github.com/zware
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 12, 2021https://github.com/python/cpython/pull/24119#event-4196593512
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Jan 12, 2021https://github.com/python/cpython/pull/24119#issuecomment-758747693
@zwarehttps://github.com/zware
494fd7bhttps://github.com/python/cpython/commit/494fd7b9f4e52ef8f2dd54acbb8822ea04dc8c6d
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
🔨 test-with-buildbots https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22
Jan 12, 2021https://github.com/python/cpython/pull/24119#event-4196593698
https://github.com/encukou
encukouhttps://github.com/encukou
Jan 19, 2021https://github.com/python/cpython/pull/24119#issuecomment-762824543
Please reload this pagehttps://github.com/python/cpython/pull/24119
bpo-41701https://bugs.python.org/issue41701
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.com/encukou
encukouhttps://github.com/encukou
65cf1adhttps://github.com/python/cpython/commit/65cf1ad6723b6b4489fa7dda04283bb2466be531
Jan 19, 2021https://github.com/python/cpython/pull/24119#event-4222427442
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Jan 19, 2021https://github.com/python/cpython/pull/24119#event-4222427674
https://github.com/encukou
encukouhttps://github.com/encukou
January 19, 2021 13:03https://github.com/python/cpython/pull/24119#event-4222427893
adorilsonhttps://github.com/adorilson
Mar 13, 2021 https://github.com/python/cpython/pull/24119#ref-commit-67f0fd6
https://github.com/encukou
https://github.com/adorilson
bpo-41818: Close file descriptors in test_openpty (#https://github.com/adorilson/cpython/commit/67f0fd68082fd153df56e2d276afbcb720ff3ac6
pythonGH-24119https://github.com/python/cpython/pull/24119
)https://github.com/adorilson/cpython/commit/67f0fd68082fd153df56e2d276afbcb720ff3ac6
67f0fd6https://github.com/adorilson/cpython/commit/67f0fd68082fd153df56e2d276afbcb720ff3ac6
c13d899https://github.com/adorilson/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136
https://github.com/python/cpython/pull/24119
8vasuhttps://github.com/python/cpython/pull/24119
May 5, 2022 https://github.com/python/cpython/pull/24119#ref-issue-1199043825
Lib/pty.py major revision #85984 https://github.com/python/cpython/issues/85984
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F24119
https://github.com/zware
zware https://github.com/zware
https://github.com/python/cpython/pull/24119/files/b7eb9e8d4360fadf04bc5fa9fd5a22c664e1c5e3
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
tests https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests
Please reload this pagehttps://github.com/python/cpython/pull/24119
https://github.com/encukou
https://github.com/8vasu
https://github.com/bedevere-bot
https://github.com/zware
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.