René's URL Explorer Experiment


Title: bpo-42721: Improve using simple dialogs without root window by serhiy-storchaka · Pull Request #23897 · python/cpython · GitHub

Open Graph Title: bpo-42721: Improve using simple dialogs without root window by serhiy-storchaka · Pull Request #23897 · python/cpython

X Title: bpo-42721: Improve using simple dialogs without root window by serhiy-storchaka · Pull Request #23897 · python/cpython

Description: When simple query dialogs (tkinter.simpledialog), message boxes (tkinter.messagebox) or color choose dialog (tkinter.colorchooser) are created without arguments master and parent, and the default root window is not yet created, a new temporary hidden root window will be created automatically. It will not be set as the default root window and will be destroyed right after closing the dialog window. It will help to use these simple dialog windows in programs which do not need other GUI. Previously, message boxes and color chooser created the blank root window and left it after closing the dialog window, and query dialogs just raised an exception. https://bugs.python.org/issue42721

Open Graph Description: When simple query dialogs (tkinter.simpledialog), message boxes (tkinter.messagebox) or color choose dialog (tkinter.colorchooser) are created without arguments master and parent, and the default r...

X Description: When simple query dialogs (tkinter.simpledialog), message boxes (tkinter.messagebox) or color choose dialog (tkinter.colorchooser) are created without arguments master and parent, and the default r...

Opengraph URL: https://github.com/python/cpython/pull/23897

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:19295d29-4deb-34cf-88a6-400ffe3743e2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD0BA:2BFC3F:25BB15:345E62:6A546CE2
html-safe-nonce8e9c72924119eb0e861cd1b36594ea86e0cce7d4e39063d95e1c20d13689841d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMEJBOjJCRkMzRjoyNUJCMTU6MzQ1RTYyOjZBNTQ2Q0UyIiwidmlzaXRvcl9pZCI6IjQzNzY2OTk0NDczOTAwMDY0OTgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac43c36444042a0bad1861dd7c2d5d0786a9ac05e49b88c700b73ad3b3f6e1c7a7
hovercard-subject-tagpull_request:544368901
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/23897/files
twitter:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/3659035?s=400&v=4
og:image:altWhen simple query dialogs (tkinter.simpledialog), message boxes (tkinter.messagebox) or color choose dialog (tkinter.colorchooser) are created without arguments master and parent, and the default r...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release6d28624802c2f7d9500239dd6870ed7031b7353b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/23897/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23897%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23897%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/23897/files
Reloadhttps://github.com/python/cpython/pull/23897/files
Reloadhttps://github.com/python/cpython/pull/23897/files
Please reload this pagehttps://github.com/python/cpython/pull/23897/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/23897/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 35k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
serhiy-storchakahttps://github.com/serhiy-storchaka
python:masterhttps://github.com/python/cpython/tree/master
serhiy-storchaka:simple-common-dialog-temporary-roothttps://github.com/serhiy-storchaka/cpython/tree/simple-common-dialog-temporary-root
Conversation 9 https://github.com/python/cpython/pull/23897
Commits 4 https://github.com/python/cpython/pull/23897/commits
Checks 0 https://github.com/python/cpython/pull/23897/checks
Files changed https://github.com/python/cpython/pull/23897/files
Please reload this pagehttps://github.com/python/cpython/pull/23897/files
bpo-42721: Improve using simple dialogs without root window https://github.com/python/cpython/pull/23897/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/23897/files
2460120 bpo-42721: Improve using simple dialogs without root window serhiy-storchaka Dec 22, 2020 https://github.com/python/cpython/pull/23897/commits/2460120fd196ab8b3ae23c55b196d4b74b186dc4
2611e2b Update Lib/tkinter/commondialog.py serhiy-storchaka Dec 24, 2020 https://github.com/python/cpython/pull/23897/commits/2611e2b425f2ca11695b39eaf26611d2c8ecafb8
2dac97c Update the NEWS entry for NoDefaultRoot() and rewrite implementation … serhiy-storchaka Dec 24, 2020 https://github.com/python/cpython/pull/23897/commits/2dac97c451a9e6b02e89c9d86b6be3d7c8003f74
08c7fd8 Merge branch 'master' into simple-common-dialog-temporary-root serhiy-storchaka Dec 25, 2020 https://github.com/python/cpython/pull/23897/commits/08c7fd8d6833e347e40ec39a388488f4a9bef1ac
Clear filters https://github.com/python/cpython/pull/23897/files
Please reload this pagehttps://github.com/python/cpython/pull/23897/files
Please reload this pagehttps://github.com/python/cpython/pull/23897/files
__init__.py https://github.com/python/cpython/pull/23897/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
commondialog.py https://github.com/python/cpython/pull/23897/files#diff-de47286a179bfc51df1aa4fdd671d736c4cb630f2eb31673944812e050196de8
simpledialog.py https://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
test_colorchooser.py https://github.com/python/cpython/pull/23897/files#diff-cbd7feecccd86510927a177ccf8ec563ab8d476ad4f0ed0601beab8b44236fc8
test_messagebox.py https://github.com/python/cpython/pull/23897/files#diff-905454bb412eca410df9741b594d93602a4f14c23286f8dd816d193c5a5b95df
test_simpledialog.py https://github.com/python/cpython/pull/23897/files#diff-04ae9b8af7cfe7d1e4a26a2741c8fab611338f93f9509f1d9d6cd40659948164
2020-12-22-22-47-22.bpo-42721.I5Ai5L.rst https://github.com/python/cpython/pull/23897/files#diff-1cab5c4c10a37936383a796f243e04e70eeb512188cdd77699d9617a140a6ab6
Lib/tkinter/__init__.pyhttps://github.com/python/cpython/pull/23897/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
View file https://github.com/serhiy-storchaka/cpython/blob/08c7fd8d6833e347e40ec39a388488f4a9bef1ac/Lib/tkinter/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/23897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/23897/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
Please reload this pagehttps://github.com/python/cpython/pull/23897/files
https://github.com/python/cpython/pull/23897/files#diff-46c8ee2e6d4e02b7a2839d0cabde53331f5ad74fb09fdd6149b70e9d5cfb2cdd
Lib/tkinter/commondialog.pyhttps://github.com/python/cpython/pull/23897/files#diff-de47286a179bfc51df1aa4fdd671d736c4cb630f2eb31673944812e050196de8
View file https://github.com/serhiy-storchaka/cpython/blob/08c7fd8d6833e347e40ec39a388488f4a9bef1ac/Lib/tkinter/commondialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/23897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/23897/files#diff-de47286a179bfc51df1aa4fdd671d736c4cb630f2eb31673944812e050196de8
https://github.com/python/cpython/pull/23897/files#diff-de47286a179bfc51df1aa4fdd671d736c4cb630f2eb31673944812e050196de8
Lib/tkinter/simpledialog.pyhttps://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
View file https://github.com/serhiy-storchaka/cpython/blob/08c7fd8d6833e347e40ec39a388488f4a9bef1ac/Lib/tkinter/simpledialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/23897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
https://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
https://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
https://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
https://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
https://github.com/python/cpython/pull/23897/files#diff-643651beb28ec5597e36c1b2a4f4a1bd797e6619ce8617032edada250556d52b
Lib/tkinter/test/test_tkinter/test_colorchooser.pyhttps://github.com/python/cpython/pull/23897/files#diff-cbd7feecccd86510927a177ccf8ec563ab8d476ad4f0ed0601beab8b44236fc8
View file https://github.com/serhiy-storchaka/cpython/blob/08c7fd8d6833e347e40ec39a388488f4a9bef1ac/Lib/tkinter/test/test_tkinter/test_colorchooser.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/23897/{{ revealButtonHref }}
Lib/tkinter/test/test_tkinter/test_messagebox.pyhttps://github.com/python/cpython/pull/23897/files#diff-905454bb412eca410df9741b594d93602a4f14c23286f8dd816d193c5a5b95df
View file https://github.com/serhiy-storchaka/cpython/blob/08c7fd8d6833e347e40ec39a388488f4a9bef1ac/Lib/tkinter/test/test_tkinter/test_messagebox.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/23897/{{ revealButtonHref }}
Lib/tkinter/test/test_tkinter/test_simpledialog.pyhttps://github.com/python/cpython/pull/23897/files#diff-04ae9b8af7cfe7d1e4a26a2741c8fab611338f93f9509f1d9d6cd40659948164
View file https://github.com/serhiy-storchaka/cpython/blob/08c7fd8d6833e347e40ec39a388488f4a9bef1ac/Lib/tkinter/test/test_tkinter/test_simpledialog.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/23897/{{ revealButtonHref }}
https://github.com/python/cpython/pull/23897/files#diff-04ae9b8af7cfe7d1e4a26a2741c8fab611338f93f9509f1d9d6cd40659948164
https://github.com/python/cpython/pull/23897/files#diff-04ae9b8af7cfe7d1e4a26a2741c8fab611338f93f9509f1d9d6cd40659948164
Misc/NEWS.d/next/Library/2020-12-22-22-47-22.bpo-42721.I5Ai5L.rsthttps://github.com/python/cpython/pull/23897/files#diff-1cab5c4c10a37936383a796f243e04e70eeb512188cdd77699d9617a140a6ab6
View file https://github.com/serhiy-storchaka/cpython/blob/08c7fd8d6833e347e40ec39a388488f4a9bef1ac/Misc/NEWS.d/next/Library/2020-12-22-22-47-22.bpo-42721.I5Ai5L.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/23897/{{ revealButtonHref }}
Please reload this pagehttps://github.com/python/cpython/pull/23897/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.