René's URL Explorer Experiment


Title: bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ by ap-- · Pull Request #23534 · python/cpython · GitHub

Open Graph Title: bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ by ap-- · Pull Request #23534 · python/cpython

X Title: bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ by ap-- · Pull Request #23534 · python/cpython

Description: See: https://bugs.python.org/issue42487 https://bugs.python.org/issue42487

Open Graph Description: See: https://bugs.python.org/issue42487 https://bugs.python.org/issue42487

X Description: See: https://bugs.python.org/issue42487 https://bugs.python.org/issue42487

Opengraph URL: https://github.com/python/cpython/pull/23534

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:57f257ca-90d2-9562-1340-8c07eb4c55b7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id81BE:29B8E2:1DF26F4:2924971:696ABFB4
html-safe-nonce2f07832df64dc85e731924ee0751d97fe6a6db581b0ff474093c83de94d46eb4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MUJFOjI5QjhFMjoxREYyNkY0OjI5MjQ5NzE6Njk2QUJGQjQiLCJ2aXNpdG9yX2lkIjoiNjgxOTg1ODk5MDYwNzU0ODM0MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca0bd2fcbaa2f44811c0c2a227c88bcc535d63f22388ad72a33ade6d3bc805e4e
hovercard-subject-tagpull_request:528825080
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/23534/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0001a168f6012b582da2d0bcb44bfce493cc278219521c18e03c98bba22f4354/python/cpython/pull/23534
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0001a168f6012b582da2d0bcb44bfce493cc278219521c18e03c98bba22f4354/python/cpython/pull/23534
og:image:altSee: https://bugs.python.org/issue42487 https://bugs.python.org/issue42487
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameap--
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/23534#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23534
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23534
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/23534
Reloadhttps://github.com/python/cpython/pull/23534
Reloadhttps://github.com/python/cpython/pull/23534
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/23534
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/23534
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/23534#issue-comment-box
rhettingerhttps://github.com/rhettinger
python:masterhttps://github.com/python/cpython/tree/master
ap--:chainmap-iterhttps://github.com/ap--/cpython/tree/chainmap-iter
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__iter__ https://github.com/python/cpython/pull/23534#top
rhettingerhttps://github.com/rhettinger
python:masterhttps://github.com/python/cpython/tree/master
ap--:chainmap-iterhttps://github.com/ap--/cpython/tree/chainmap-iter
Conversation 7 https://github.com/python/cpython/pull/23534
Commits 3 https://github.com/python/cpython/pull/23534/commits
Checks 0 https://github.com/python/cpython/pull/23534/checks
Files changed https://github.com/python/cpython/pull/23534/files
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/ap--
ap--https://github.com/ap--
Nov 28, 2020https://github.com/python/cpython/pull/23534#issue-752521077
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://bugs.python.org/issue42487https://bugs.python.org/issue42487
https://bugs.python.org/issue42487https://bugs.python.org/issue42487
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/ap--
Do not call __getitem__ on underlying maps in ChainMap.__iter__https://github.com/python/cpython/pull/23534/commits/9aa564d3b87c9fbcd5f3321dec7aa960ff1a5905
9aa564dhttps://github.com/python/cpython/pull/23534/commits/9aa564d3b87c9fbcd5f3321dec7aa960ff1a5905
https://github.com/ap--
ap--https://github.com/ap--
rhettingerhttps://github.com/rhettinger
code ownerhttps://github.com/python/cpython/blob/44ca05afc89c9967f5dbc6c3ad89fc298c460e93/.github/CODEOWNERS#L108
November 28, 2020 01:00https://github.com/python/cpython/pull/23534#event-4047535825
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
Nov 28, 2020https://github.com/python/cpython/pull/23534#issuecomment-735021569
PSF contributor agreementhttps://www.python.org/psf/contrib/contrib-form/
@ap--https://github.com/ap--
the steps outlined in the CPython devguidehttps://devguide.python.org/pullrequest/#licensing
check yourselfhttps://check-python-cla.herokuapp.com/
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Nov 28, 2020https://github.com/python/cpython/pull/23534#event-4047535843
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 28, 2020https://github.com/python/cpython/pull/23534#event-4047535868
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Nov 28, 2020https://github.com/python/cpython/pull/23534#event-4047543241
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 28, 2020https://github.com/python/cpython/pull/23534#event-4047553369
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 28, 2020https://github.com/python/cpython/pull/23534#issuecomment-735024271
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Nov 28, 2020https://github.com/python/cpython/pull/23534#event-4047553371
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Nov 28, 2020 https://github.com/python/cpython/pull/23534#pullrequestreview-540218963
View reviewed changes https://github.com/python/cpython/pull/23534/files/9aa564d3b87c9fbcd5f3321dec7aa960ff1a5905
rhettingerhttps://github.com/rhettinger
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/python/cpython/pull/23534#pullrequestreview-540218963
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
serhiy-storchakahttps://github.com/serhiy-storchaka
November 28, 2020 01:53https://github.com/python/cpython/pull/23534#event-4047569259
ap--https://github.com/ap--
November 28, 2020 04:24https://github.com/python/cpython/pull/23534#commits-pushed-48aa670
https://github.com/ap--
Add test for ChainMap.__iter__https://github.com/python/cpython/pull/23534/commits/48aa6701a7eb91e4611acfd3f2a616624e07b98b
48aa670https://github.com/python/cpython/pull/23534/commits/48aa6701a7eb91e4611acfd3f2a616624e07b98b
https://github.com/ap--
Add blurbhttps://github.com/python/cpython/pull/23534/commits/e732767a77e9d4ad50d6200667ae3a09a7298239
e732767https://github.com/python/cpython/pull/23534/commits/e732767a77e9d4ad50d6200667ae3a09a7298239
https://github.com/ap--
ap--https://github.com/ap--
Nov 28, 2020https://github.com/python/cpython/pull/23534#issuecomment-735034856
Please reload this pagehttps://github.com/python/cpython/pull/23534
@rhettingerhttps://github.com/rhettinger
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/serhiy-storchaka
serhiy-storchakahttps://github.com/serhiy-storchaka
Nov 28, 2020 https://github.com/python/cpython/pull/23534#pullrequestreview-540353407
View reviewed changes https://github.com/python/cpython/pull/23534/files/e732767a77e9d4ad50d6200667ae3a09a7298239
serhiy-storchakahttps://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/23534#pullrequestreview-540353407
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting changes https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20changes%22
Nov 28, 2020https://github.com/python/cpython/pull/23534#event-4047804925
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
Nov 28, 2020https://github.com/python/cpython/pull/23534#event-4048337356
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
Nov 28, 2020 https://github.com/python/cpython/pull/23534#pullrequestreview-540409993
View reviewed changes https://github.com/python/cpython/pull/23534/files/e732767a77e9d4ad50d6200667ae3a09a7298239
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
CLA not signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20not%20signed%22
Nov 30, 2020https://github.com/python/cpython/pull/23534#event-4050395389
https://github.com/rhettinger
rhettingerhttps://github.com/rhettinger
0be9ce3https://github.com/python/cpython/commit/0be9ce305ff2b9e13ddcf15af8cfe28786afb36a
Nov 30, 2020https://github.com/python/cpython/pull/23534#event-4052865284
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 30, 2020https://github.com/python/cpython/pull/23534#issuecomment-735897099
@ap--https://github.com/ap--
@rhettingerhttps://github.com/rhettinger
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 30, 2020https://github.com/python/cpython/pull/23534#event-4052865516
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 30, 2020https://github.com/python/cpython/pull/23534#issuecomment-735897628
GH-23569https://github.com/python/cpython/pull/23569
3.9 branchhttps://github.com/python/cpython/tree/3.9
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
Nov 30, 2020https://github.com/python/cpython/pull/23534#event-4052869477
miss-islingtonhttps://github.com/miss-islington
Nov 30, 2020 https://github.com/python/cpython/pull/23534#ref-commit-3df7f26
https://github.com/ap--
https://github.com/miss-islington
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…https://github.com/miss-islington/cpython/commit/3df7f26c9b569856e5ba8e0bce33f8427c68063a
3df7f26https://github.com/miss-islington/cpython/commit/3df7f26c9b569856e5ba8e0bce33f8427c68063a
pythonGH-23534https://github.com/python/cpython/pull/23534
0be9ce3https://github.com/miss-islington/cpython/commit/0be9ce305ff2b9e13ddcf15af8cfe28786afb36a
rhettingerhttps://github.com/rhettinger
Nov 30, 2020 https://github.com/python/cpython/pull/23534#ref-commit-cf22aa3
https://github.com/miss-islington
bpo-42487https://bugs.python.org/issue?@action=redirect&bpo=42487
: don't call __getitem__ of underlying maps in ChainMap.__it…https://github.com/python/cpython/commit/cf22aa3bc698847459a6bf20c166aa80825b810a
cf22aa3https://github.com/python/cpython/commit/cf22aa3bc698847459a6bf20c166aa80825b810a
GH-23534https://github.com/python/cpython/pull/23534
GH-23569https://github.com/python/cpython/pull/23569
https://github.com/ap--
ap--https://github.com/ap--
November 30, 2020 17:18https://github.com/python/cpython/pull/23534#event-4053069733
adorilsonhttps://github.com/adorilson
Mar 13, 2021 https://github.com/python/cpython/pull/23534#ref-commit-b18ade5
https://github.com/ap--
https://github.com/adorilson
bpo-42487: don't call __getitem__ of underlying maps in ChainMap.__it…https://github.com/adorilson/cpython/commit/b18ade51442a568569341ab63ff451f34ef3861e
b18ade5https://github.com/adorilson/cpython/commit/b18ade51442a568569341ab63ff451f34ef3861e
pythonGH-23534https://github.com/python/cpython/pull/23534
https://github.com/Alexamk
Alexamkhttps://github.com/Alexamk
Jun 2, 2022 https://github.com/python/cpython/pull/23534#ref-issue-1257912364
Iterating over ChainMap.values() and ChainMap.items() updates underlying defaultdicts #93432 https://github.com/python/cpython/issues/93432
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23534
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
https://github.com/python/cpython/pull/23534/files/e732767a77e9d4ad50d6200667ae3a09a7298239
https://github.com/serhiy-storchaka
serhiy-storchaka https://github.com/serhiy-storchaka
https://github.com/python/cpython/pull/23534/files/e732767a77e9d4ad50d6200667ae3a09a7298239
https://github.com/rhettinger
rhettinger https://github.com/rhettinger
Please reload this pagehttps://github.com/python/cpython/pull/23534
https://github.com/ap--
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/miss-islington
https://github.com/rhettinger
https://github.com/serhiy-storchaka
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.