René's URL Explorer Experiment


Title: [3.9] bpo-40791: Make compare_digest more constant-time. (GH-20444) by miss-islington · Pull Request #23436 · python/cpython · GitHub

Open Graph Title: [3.9] bpo-40791: Make compare_digest more constant-time. (GH-20444) by miss-islington · Pull Request #23436 · python/cpython

X Title: [3.9] bpo-40791: Make compare_digest more constant-time. (GH-20444) by miss-islington · Pull Request #23436 · python/cpython

Description: bpo-40791: Make compare_digest more constant-time. The existing volatile left/right pointers guarantee that the reads will all occur, but does not guarantee that they will be used. So a compiler c...

Open Graph Description: bpo-40791: Make compare_digest more constant-time. The existing volatile left/right pointers guarantee that the reads will all occur, but does not guarantee that they will be used. So a compiler c...

X Description: bpo-40791: Make compare_digest more constant-time. The existing volatile left/right pointers guarantee that the reads will all occur, but does not guarantee that they will be used. So a compiler c...

Mail addresses
jeanpierreda@google.com

Opengraph URL: https://github.com/python/cpython/pull/23436

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:6407349d-bf80-f02b-468c-53af082767a0
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD82E:3D113A:192562C:2344400:6970DE25
html-safe-nonce656d73d89dddb576466b5e6fe607ca11dff960d7483d4e034b39b9b294687974
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODJFOjNEMTEzQToxOTI1NjJDOjIzNDQ0MDA6Njk3MERFMjUiLCJ2aXNpdG9yX2lkIjoiMjU4MzcxMzE0MzA3MzU4MjQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf46955092235f1dea45e0ec8f1edec74513f8be0ffc6a84766c4016faa3d0207
hovercard-subject-tagpull_request:525101693
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/23436/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/aa961dc35fe62bf3844b51ab66656e377551ad6314d7286d6411cd46030786b1/python/cpython/pull/23436
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/aa961dc35fe62bf3844b51ab66656e377551ad6314d7286d6411cd46030786b1/python/cpython/pull/23436
og:image:altbpo-40791: Make compare_digest more constant-time. The existing volatile left/right pointers guarantee that the reads will all occur, but does not guarantee that they will be used. So a compiler c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemiss-islington
hostnamegithub.com
expected-hostnamegithub.com
Noneb9203e7efc62065329c3b7015a1e6d16fc14bce440abec7b0d3cbe9e4fb1e2e4
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseeb3c92b74ae48a78cffd8700b8eb5f60bad61528
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/23436#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23436
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23436
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/23436
Reloadhttps://github.com/python/cpython/pull/23436
Reloadhttps://github.com/python/cpython/pull/23436
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/23436
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.2k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/23436
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/23436#issue-comment-box
miss-islingtonhttps://github.com/miss-islington
python:3.9https://github.com/python/cpython/tree/3.9
miss-islington:backport-3172936-3.9https://github.com/miss-islington/cpython/tree/backport-3172936-3.9
[3.9] bpo-40791: Make compare_digest more constant-time. (GH-20444) https://github.com/python/cpython/pull/23436#top
miss-islingtonhttps://github.com/miss-islington
python:3.9https://github.com/python/cpython/tree/3.9
miss-islington:backport-3172936-3.9https://github.com/miss-islington/cpython/tree/backport-3172936-3.9
Conversation 2 https://github.com/python/cpython/pull/23436
Commits 1 https://github.com/python/cpython/pull/23436/commits
Checks 0 https://github.com/python/cpython/pull/23436/checks
Files changed https://github.com/python/cpython/pull/23436/files
Please reload this pagehttps://github.com/python/cpython/pull/23436
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 21, 2020https://github.com/python/cpython/pull/23436#issue-747979082
Please reload this pagehttps://github.com/python/cpython/pull/23436
bpo-40791https://bugs.python.org/issue40791
GH-1https://github.com/python/cpython/pull/1
https://bugs.python.org/issue40791https://bugs.python.org/issue40791
3172936https://github.com/python/cpython/commit/31729366e2bc09632e78f3896dbce0ae64914f28
https://bugs.python.org/issue40791https://bugs.python.org/issue40791
Please reload this pagehttps://github.com/python/cpython/pull/23436
https://github.com/ssbr
https://github.com/miss-islington
bpo-40791: Make compare_digest more constant-time. (https://github.com/python/cpython/pull/23436/commits/0e4ccb3c118e62797f7aa6d02c489ec9e4642e97
pythonGH-20444https://github.com/python/cpython/pull/20444
)https://github.com/python/cpython/pull/23436/commits/0e4ccb3c118e62797f7aa6d02c489ec9e4642e97
0e4ccb3https://github.com/python/cpython/pull/23436/commits/0e4ccb3c118e62797f7aa6d02c489ec9e4642e97
GH-1https://github.com/miss-islington/cpython/pull/1
https://bugs.python.org/issue40791https://bugs.python.org/issue40791
3172936https://github.com/miss-islington/cpython/commit/31729366e2bc09632e78f3896dbce0ae64914f28
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Nov 21, 2020https://github.com/python/cpython/pull/23436#event-4023624884
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Nov 21, 2020https://github.com/python/cpython/pull/23436#event-4023624912
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Nov 21, 2020 https://github.com/python/cpython/pull/23436#ref-pullrequest-625513153
bpo-40791: Make compare_digest more constant-time. #20444 https://github.com/python/cpython/pull/20444
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 21, 2020https://github.com/python/cpython/pull/23436#event-4023625116
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
Nov 21, 2020 https://github.com/python/cpython/pull/23436#pullrequestreview-535951744
View reviewed changes https://github.com/python/cpython/pull/23436/files/0e4ccb3c118e62797f7aa6d02c489ec9e4642e97
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 21, 2020https://github.com/python/cpython/pull/23436#event-4023625922
https://github.com/gpshead
gpsheadhttps://github.com/gpshead
🤖 automerge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Arobot%3A%20automerge%22
Nov 21, 2020https://github.com/python/cpython/pull/23436#event-4023626508
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 21, 2020https://github.com/python/cpython/pull/23436#issuecomment-731552925
@ssbrhttps://github.com/ssbr
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/23436
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
c1bbca5https://github.com/python/cpython/commit/c1bbca5b004b3f74d240ef8a76ff445cc1a27efb
Nov 21, 2020https://github.com/python/cpython/pull/23436#event-4023672997
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 21, 2020https://github.com/python/cpython/pull/23436#event-4023673028
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
November 21, 2020 09:18https://github.com/python/cpython/pull/23436#event-4023673043
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Nov 21, 2020https://github.com/python/cpython/pull/23436#issuecomment-731592929
@ssbrhttps://github.com/ssbr
@gpsheadhttps://github.com/gpshead
Please reload this pagehttps://github.com/python/cpython/pull/23436
https://github.com/python/cpython/pull/23436
ssbrhttps://github.com/python/cpython/pull/23436
Aug 24, 2023 https://github.com/python/cpython/pull/23436#ref-issue-1199037413
hmac.compare_digest could try harder to be constant-time. #84968 https://github.com/python/cpython/issues/84968
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23436
https://github.com/gpshead
gpshead https://github.com/gpshead
https://github.com/python/cpython/pull/23436/files/0e4ccb3c118e62797f7aa6d02c489ec9e4642e97
type-bug https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-bug
type-security https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atype-security
Please reload this pagehttps://github.com/python/cpython/pull/23436
https://github.com/miss-islington
https://github.com/gpshead
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com/ssbr
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.