| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:efddd197-78e4-821f-0d00-2966f90ca9a4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A13E:3CB688:12979A9:19B173D:6A4DE6C7 |
| html-safe-nonce | f1aa4634d7e31e0be792c97814b0e18addfb3b27e4bf94d95c7efb5a3105c875 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTNFOjNDQjY4ODoxMjk3OUE5OjE5QjE3M0Q6NkE0REU2QzciLCJ2aXNpdG9yX2lkIjoiMTA3OTUyNzczOTQzNjY4OTA5NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 2e534c3189730ae0bb698e0071ac3a340d896af74af9af6e222f289b67db5d09 |
| hovercard-subject-tag | pull_request:127133303 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/2343/files |
| twitter:image | https://avatars.githubusercontent.com/u/199592?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199592?s=400&v=4 |
| og:image:alt | https://bugs.python.org/issue15216 |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/2343/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2343%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2343%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/2343/files |
| Reload | https://github.com/python/cpython/pull/2343/files |
| Reload | https://github.com/python/cpython/pull/2343/files |
| Please reload this page | https://github.com/python/cpython/pull/2343/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/2343/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| methane | https://github.com/methane |
| python:master | https://github.com/python/cpython/tree/master |
| methane:reconfigure-encoding | https://github.com/methane/cpython/tree/reconfigure-encoding |
|
Conversation
19
| https://github.com/python/cpython/pull/2343 |
|
Commits
12
| https://github.com/python/cpython/pull/2343/commits |
|
Checks
0
| https://github.com/python/cpython/pull/2343/checks |
|
Files changed
| https://github.com/python/cpython/pull/2343/files |
| Please reload this page | https://github.com/python/cpython/pull/2343/files |
|
bpo-15216: TextIOWrapper support change encoding after creation
| https://github.com/python/cpython/pull/2343/files#top |
|
Show all changes
12 commits
| https://github.com/python/cpython/pull/2343/files |
|
b74d8d6
bpo-15216: TextIOWrapper support set encoding, errors and newline aft…
methane Feb 20, 2017
| https://github.com/python/cpython/pull/2343/commits/b74d8d673b349d4bf4643d0c9821f27b458c8de2 |
|
6213e31
Add note about changing encoding after write
methane Sep 15, 2017
| https://github.com/python/cpython/pull/2343/commits/6213e31bf09c0d4b01a03e44970961db5ee48bac |
|
25a8acf
Add NEWS file
methane Sep 15, 2017
| https://github.com/python/cpython/pull/2343/commits/25a8acf263df2ea486ece0c167de9d12df2576c8 |
|
8d1ca37
Fix TextIOWrapper.reconfigure(newline=None)
methane Sep 16, 2017
| https://github.com/python/cpython/pull/2343/commits/8d1ca379e1f9f3dbc7b74e1965aa342f301a28ed |
|
687e18a
Fix _pyio.TextIOWrapper.reconfigure(encoding=...)
methane Sep 16, 2017
| https://github.com/python/cpython/pull/2343/commits/687e18ab3d965e36d1c3ddc8087ed9ca286bfaf8 |
|
24518bc
Don't detect new encoding is alias of old encoding.
methane Sep 17, 2017
| https://github.com/python/cpython/pull/2343/commits/24518bc18db4759fc3af050d96cd591c74a14520 |
|
ef44458
Merge remote-tracking branch 'origin/master' into reconfigure-encoding
methane Dec 15, 2017
| https://github.com/python/cpython/pull/2343/commits/ef44458ff489f7354794e5aec6cb805dcdc2ae0e |
|
4d09f6d
Doc: Explain keyword only arguments are optional
methane Dec 15, 2017
| https://github.com/python/cpython/pull/2343/commits/4d09f6d945d1f7bfa527dfe2870a2c2de8cda283 |
|
3af545d
test: Add missing assert
methane Dec 15, 2017
| https://github.com/python/cpython/pull/2343/commits/3af545d1341849624e41323771fecb800b20117e |
|
78c9cd5
Fix comments and error message
methane Dec 15, 2017
| https://github.com/python/cpython/pull/2343/commits/78c9cd51a9defca4749b171ce9dce818e45f18ea |
|
b323dcd
prohibit setting newline after first read
methane Dec 15, 2017
| https://github.com/python/cpython/pull/2343/commits/b323dcd44829ee57a7709ad5346e108d5353612e |
|
1018b67
doc: newline can't be changed after read
methane Dec 20, 2017
| https://github.com/python/cpython/pull/2343/commits/1018b67264e2ac3d8851915b57e01c764f133b70 |
|
Clear filters
| https://github.com/python/cpython/pull/2343/files |
| Please reload this page | https://github.com/python/cpython/pull/2343/files |
| Please reload this page | https://github.com/python/cpython/pull/2343/files |
|
io.rst
| https://github.com/python/cpython/pull/2343/files#diff-ccf558cb765d6938e25439f8a40c032f00672f675c8ddc6a5b2be6aef53a0cda |
|
_pyio.py
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
test_io.py
| https://github.com/python/cpython/pull/2343/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f |
|
2017-09-16-02-56-33.bpo-15216.lqXCTT.rst
| https://github.com/python/cpython/pull/2343/files#diff-4fe05a55b38d8de510b29f005a1ee9056f0e9d860cef77c76eddf8663293546e |
|
textio.c.h
| https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
textio.c
| https://github.com/python/cpython/pull/2343/files#diff-f6d1380274f6859688c821fced58fb1c829d8acad44ae252ba988e220e1080b3 |
| Doc/library/io.rst | https://github.com/python/cpython/pull/2343/files#diff-ccf558cb765d6938e25439f8a40c032f00672f675c8ddc6a5b2be6aef53a0cda |
|
View file
| https://github.com/methane/cpython/blob/1018b67264e2ac3d8851915b57e01c764f133b70/Doc/library/io.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/2343/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/2343/files#diff-ccf558cb765d6938e25439f8a40c032f00672f675c8ddc6a5b2be6aef53a0cda |
|
| https://github.com/python/cpython/pull/2343/files#diff-ccf558cb765d6938e25439f8a40c032f00672f675c8ddc6a5b2be6aef53a0cda |
|
| https://github.com/python/cpython/pull/2343/files#diff-ccf558cb765d6938e25439f8a40c032f00672f675c8ddc6a5b2be6aef53a0cda |
| Lib/_pyio.py | https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
View file
| https://github.com/methane/cpython/blob/1018b67264e2ac3d8851915b57e01c764f133b70/Lib/_pyio.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/2343/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
|
| https://github.com/python/cpython/pull/2343/files#diff-bcdfa9cbb0764d7959cda48f9084d79785f87c5ad7460f27ba2678b0bda76e38 |
| Lib/test/test_io.py | https://github.com/python/cpython/pull/2343/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f |
|
View file
| https://github.com/methane/cpython/blob/1018b67264e2ac3d8851915b57e01c764f133b70/Lib/test/test_io.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/2343/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/2343/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f |
| pitrou | https://github.com/pitrou |
| Dec 14, 2017 | https://github.com/python/cpython/pull/2343/files#r156938983 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/2343/files |
|
| https://github.com/python/cpython/pull/2343/files#diff-c6987f6d27855daad275cfbf05fb3684c53fc82ff7146cd157e5838f9ad5f57f |
| Misc/NEWS.d/next/Library/2017-09-16-02-56-33.bpo-15216.lqXCTT.rst | https://github.com/python/cpython/pull/2343/files#diff-4fe05a55b38d8de510b29f005a1ee9056f0e9d860cef77c76eddf8663293546e |
|
View file
| https://github.com/methane/cpython/blob/1018b67264e2ac3d8851915b57e01c764f133b70/Misc/NEWS.d/next/Library/2017-09-16-02-56-33.bpo-15216.lqXCTT.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/2343/{{ revealButtonHref }} |
| Modules/_io/clinic/textio.c.h | https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
View file
| https://github.com/methane/cpython/blob/1018b67264e2ac3d8851915b57e01c764f133b70/Modules/_io/clinic/textio.c.h |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/2343/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
| https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
| https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
| https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
| https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
|
| https://github.com/python/cpython/pull/2343/files#diff-3f9c7f3d55bcd9dd3f3503b1e058b26d56495720f02f4906c9635ca5afcebeb8 |
| Please reload this page | https://github.com/python/cpython/pull/2343/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |