René's URL Explorer Experiment


Title: bpo-40170: Hide implementation detail of Py_TRASHCAN_BEGIN macro by shihai1991 · Pull Request #23235 · python/cpython · GitHub

Open Graph Title: bpo-40170: Hide implementation detail of Py_TRASHCAN_BEGIN macro by shihai1991 · Pull Request #23235 · python/cpython

X Title: bpo-40170: Hide implementation detail of Py_TRASHCAN_BEGIN macro by shihai1991 · Pull Request #23235 · python/cpython

Description: https://bugs.python.org/issue40170

Open Graph Description: https://bugs.python.org/issue40170

X Description: https://bugs.python.org/issue40170

Opengraph URL: https://github.com/python/cpython/pull/23235

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:4bfe656b-982a-1647-517e-e45d1eb1f787
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id845A:8ADEB:36699B:497ECA:6969D4E3
html-safe-nonce05cd42a4dc6443f2525b750970b4d7f98ec5f76f1fe1b940695b32e2721f6e33
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDVBOjhBREVCOjM2Njk5Qjo0OTdFQ0E6Njk2OUQ0RTMiLCJ2aXNpdG9yX2lkIjoiMjU0ODQ2MTQ5MTU4MDQyNTQ0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd38c6625402a760dea6291c191349e21076d7ce0bda54bf08223f14d8e2748d4
hovercard-subject-tagpull_request:518938879
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/23235/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/20306fff18d41aa457b17ae0de1110bd04aa650e2e01d38877442b7972e2cc0c/python/cpython/pull/23235
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/20306fff18d41aa457b17ae0de1110bd04aa650e2e01d38877442b7972e2cc0c/python/cpython/pull/23235
og:image:althttps://bugs.python.org/issue40170
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshihai1991
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/23235#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23235
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23235
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/23235
Reloadhttps://github.com/python/cpython/pull/23235
Reloadhttps://github.com/python/cpython/pull/23235
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/23235
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/23235
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/23235#issue-comment-box
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
shihai1991:bpo_40170_2https://github.com/shihai1991/cpython/tree/bpo_40170_2
bpo-40170: Hide implementation detail of Py_TRASHCAN_BEGIN macro https://github.com/python/cpython/pull/23235#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
shihai1991:bpo_40170_2https://github.com/shihai1991/cpython/tree/bpo_40170_2
Conversation 30 https://github.com/python/cpython/pull/23235
Commits 6 https://github.com/python/cpython/pull/23235/commits
Checks 0 https://github.com/python/cpython/pull/23235/checks
Files changed https://github.com/python/cpython/pull/23235/files
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Nov 11, 2020https://github.com/python/cpython/pull/23235#issue-740453200
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://bugs.python.org/issue40170https://bugs.python.org/issue40170
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/shihai1991
Use PyType_GetSlot() in Py_TRASHCAN_BEGIN macro.https://github.com/python/cpython/pull/23235/commits/8ab6dc81ae9977185836174a44266fbff3427edc
8ab6dc8https://github.com/python/cpython/pull/23235/commits/8ab6dc81ae9977185836174a44266fbff3427edc
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Nov 11, 2020https://github.com/python/cpython/pull/23235#event-3982086626
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 11, 2020https://github.com/python/cpython/pull/23235#event-3982086670
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Nov 11, 2020https://github.com/python/cpython/pull/23235#issuecomment-725208691
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 11, 2020 https://github.com/python/cpython/pull/23235#pullrequestreview-528095959
View reviewed changes https://github.com/python/cpython/pull/23235/files/8ab6dc81ae9977185836174a44266fbff3427edc
Include/cpython/object.hhttps://github.com/python/cpython/pull/23235/files/8ab6dc81ae9977185836174a44266fbff3427edc#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/shihai1991
add the _PyTrash_cond() functionhttps://github.com/python/cpython/pull/23235/commits/b288c3ed8fe67606dc332c1c5e87dc3da2156730
b288c3ehttps://github.com/python/cpython/pull/23235/commits/b288c3ed8fe67606dc332c1c5e87dc3da2156730
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Nov 12, 2020https://github.com/python/cpython/pull/23235#event-3990029794
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 12, 2020 https://github.com/python/cpython/pull/23235#pullrequestreview-529384943
View reviewed changes https://github.com/python/cpython/pull/23235/files/b288c3ed8fe67606dc332c1c5e87dc3da2156730
Include/cpython/object.hhttps://github.com/python/cpython/pull/23235/files/b288c3ed8fe67606dc332c1c5e87dc3da2156730#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
Please reload this pagehttps://github.com/python/cpython/pull/23235
Include/cpython/object.hhttps://github.com/python/cpython/pull/23235/files/b288c3ed8fe67606dc332c1c5e87dc3da2156730#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
Please reload this pagehttps://github.com/python/cpython/pull/23235
Doc/whatsnew/3.10.rsthttps://github.com/python/cpython/pull/23235/files/b288c3ed8fe67606dc332c1c5e87dc3da2156730#diff-a68d5b2117cfed2ddb0b199e367c22ce9c1427d4a016277eafddb551ca4f250c
vstinnerhttps://github.com/vstinner
Nov 12, 2020https://github.com/python/cpython/pull/23235#discussion_r522335108
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
shihai1991https://github.com/shihai1991
Nov 13, 2020https://github.com/python/cpython/pull/23235#discussion_r522619079
Please reload this pagehttps://github.com/python/cpython/pull/23235
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
vstinnerhttps://github.com/vstinner
Nov 13, 2020https://github.com/python/cpython/pull/23235#discussion_r522914786
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
shihai1991https://github.com/shihai1991
Nov 13, 2020https://github.com/python/cpython/pull/23235#discussion_r522988906
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
https://github.com/python/cpython/blob/master/Misc/NEWS.d/3.9.0a5.rsthttps://github.com/python/cpython/blob/master/Misc/NEWS.d/3.9.0a5.rst
Please reload this pagehttps://github.com/python/cpython/pull/23235
vstinnerhttps://github.com/vstinner
Nov 13, 2020https://github.com/python/cpython/pull/23235#discussion_r522992819
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
shihai1991https://github.com/shihai1991
Nov 13, 2020https://github.com/python/cpython/pull/23235#discussion_r523004763
Please reload this pagehttps://github.com/python/cpython/pull/23235
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
Include/cpython/object.hhttps://github.com/python/cpython/pull/23235/files/b288c3ed8fe67606dc332c1c5e87dc3da2156730#diff-7c8590641fc0d835bdab9395a95dbacfb2abb056cec4217466c0f3ca6cca8270
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/shihai1991
apply victor's commenthttps://github.com/python/cpython/pull/23235/commits/a0c82d7bf4fd53cca29556c3e293e2dc73a1a144
a0c82d7https://github.com/python/cpython/pull/23235/commits/a0c82d7bf4fd53cca29556c3e293e2dc73a1a144
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 13, 2020 https://github.com/python/cpython/pull/23235#pullrequestreview-530017248
View reviewed changes https://github.com/python/cpython/pull/23235/files/a0c82d7bf4fd53cca29556c3e293e2dc73a1a144
Objects/object.chttps://github.com/python/cpython/pull/23235/files/a0c82d7bf4fd53cca29556c3e293e2dc73a1a144#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/shihai1991
apply victor's commenthttps://github.com/python/cpython/pull/23235/commits/3d2f872aac9a1c269d1db886c715359de21c5f28
3d2f872https://github.com/python/cpython/pull/23235/commits/3d2f872aac9a1c269d1db886c715359de21c5f28
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 13, 2020 https://github.com/python/cpython/pull/23235#pullrequestreview-530136664
View reviewed changes https://github.com/python/cpython/pull/23235/files/3d2f872aac9a1c269d1db886c715359de21c5f28
Objects/object.chttps://github.com/python/cpython/pull/23235/files/3d2f872aac9a1c269d1db886c715359de21c5f28#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/shihai1991
apply victor's commenthttps://github.com/python/cpython/pull/23235/commits/db2d98cf58237fe8ddbb186927c65649173e7ce1
db2d98chttps://github.com/python/cpython/pull/23235/commits/db2d98cf58237fe8ddbb186927c65649173e7ce1
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Nov 24, 2020https://github.com/python/cpython/pull/23235#issuecomment-733090807
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 24, 2020 https://github.com/python/cpython/pull/23235#pullrequestreview-537749168
View reviewed changes https://github.com/python/cpython/pull/23235/files/db2d98cf58237fe8ddbb186927c65649173e7ce1
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/23235#pullrequestreview-537749168
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
Objects/object.chttps://github.com/python/cpython/pull/23235/files/db2d98cf58237fe8ddbb186927c65649173e7ce1#diff-ba56d44ce0dd731d979970b966fde9d8dd15d12a82f727a052a8ad48d4a49363
vstinnerhttps://github.com/vstinner
Nov 24, 2020https://github.com/python/cpython/pull/23235#discussion_r529754155
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
shihai1991https://github.com/shihai1991
Nov 24, 2020https://github.com/python/cpython/pull/23235#discussion_r529778886
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 24, 2020https://github.com/python/cpython/pull/23235#event-4034027513
https://github.com/shihai1991
apply victor's commenthttps://github.com/python/cpython/pull/23235/commits/477dbd8ba29d9b6063e7ecc7c07e1c366a98773c
477dbd8https://github.com/python/cpython/pull/23235/commits/477dbd8ba29d9b6063e7ecc7c07e1c366a98773c
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
ed1a5a5https://github.com/python/cpython/commit/ed1a5a5baca8f61e9a99c5be3adc16b1801514fe
Nov 24, 2020https://github.com/python/cpython/pull/23235#event-4035003349
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Nov 24, 2020https://github.com/python/cpython/pull/23235#event-4035003483
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 24, 2020https://github.com/python/cpython/pull/23235#issuecomment-733259122
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/shihai1991
shihai1991https://github.com/shihai1991
Nov 25, 2020https://github.com/python/cpython/pull/23235#issuecomment-733398686
Please reload this pagehttps://github.com/python/cpython/pull/23235
adorilsonhttps://github.com/adorilson
Mar 13, 2021 https://github.com/python/cpython/pull/23235#ref-commit-14bfdb2
https://github.com/shihai1991
https://github.com/adorilson
bpo-40170: Hide impl detail of Py_TRASHCAN_BEGIN macro (https://github.com/adorilson/cpython/commit/14bfdb27a114cf60abc8dbc4827457cfe76e2925
pythonGH-23235https://github.com/python/cpython/pull/23235
)https://github.com/adorilson/cpython/commit/14bfdb27a114cf60abc8dbc4827457cfe76e2925
14bfdb2https://github.com/adorilson/cpython/commit/14bfdb27a114cf60abc8dbc4827457cfe76e2925
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23235
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/23235/files/db2d98cf58237fe8ddbb186927c65649173e7ce1
Please reload this pagehttps://github.com/python/cpython/pull/23235
https://github.com/shihai1991
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.