| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:cc62018a-17c3-b64a-8d98-367d6420571f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D398:2A6639:DB4D3B:11D1E49:696B2BCF |
| html-safe-nonce | 29bcd16449c3fd4f7a6eb55d5e2f7ee91430f245b3508cd303c421662d3c8503 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzk4OjJBNjYzOTpEQjREM0I6MTFEMUU0OTo2OTZCMkJDRiIsInZpc2l0b3JfaWQiOiI1MTkyMjkzMDUyMzIyNjIyNDE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 4aef6f09ac0bed9ce26339686c3c4a5ed40e174859e0c315bd5e4064bb420fd0 |
| hovercard-subject-tag | pull_request:517651752 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/23205/files |
| twitter:image | https://avatars.githubusercontent.com/u/2975991?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2975991?s=400&v=4 |
| og:image:alt | Process explicit doc argument of property(...) in the same manner as docstring of getter function in property subclasses.
This eliminates behavior differences between dummy class Property(property)... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/23205/files#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23205%2Ffiles |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23205%2Ffiles |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/23205/files |
| Reload | https://github.com/python/cpython/pull/23205/files |
| Reload | https://github.com/python/cpython/pull/23205/files |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/23205/files |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/23205/files |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| JelleZijlstra | https://github.com/JelleZijlstra |
| python:main | https://github.com/python/cpython/tree/main |
| sizmailov:fix-issue41287 | https://github.com/sizmailov/cpython/tree/fix-issue41287 |
|
Conversation
47
| https://github.com/python/cpython/pull/23205 |
|
Commits
19
| https://github.com/python/cpython/pull/23205/commits |
|
Checks
0
| https://github.com/python/cpython/pull/23205/checks |
|
Files changed
| https://github.com/python/cpython/pull/23205/files |
| Please reload this page | https://github.com/python/cpython/pull/23205/files |
|
bpo-41287: Handle doc argument of property.__init__ in subclasses
| https://github.com/python/cpython/pull/23205/files#top |
|
Show all changes
19 commits
| https://github.com/python/cpython/pull/23205/files |
|
b19523a
Handle `doc` argument of `property.__init__` in subclasses
sizmailov Nov 9, 2020
| https://github.com/python/cpython/pull/23205/commits/b19523aa70aae30611e59f8461d25391620b9967 |
|
0745f70
Add NEWS entry
sizmailov Apr 3, 2022
| https://github.com/python/cpython/pull/23205/commits/0745f700dbf906b77dd9cec2678d95c59c3088c4 |
|
ebec602
Update Misc/NEWS.d/next/Library/2022-04-03-11-25-02.bpo-41287.8CTdwf.rst
sizmailov Apr 5, 2022
| https://github.com/python/cpython/pull/23205/commits/ebec602f432fa4dd522de46d64f5a1b96ce98307 |
|
f09e6ac
Move test to test_property.py
sizmailov Apr 5, 2022
| https://github.com/python/cpython/pull/23205/commits/f09e6acf396c4728cef810a1a675a9d60c0ad2fa |
|
dcab455
Rename local get_doc -> prop_doc
sizmailov Apr 5, 2022
| https://github.com/python/cpython/pull/23205/commits/dcab455a9055238174fd972933b3e977678a148d |
|
de2c3c0
Add prop_doc != NULL check
sizmailov Apr 5, 2022
| https://github.com/python/cpython/pull/23205/commits/de2c3c0a29a119c68da8a53c538db6add0cf7656 |
|
bd4cdca
Add more tests
sizmailov Apr 5, 2022
| https://github.com/python/cpython/pull/23205/commits/bd4cdca9ec312bae3aa053ac3d3f7ce0bcc070f0 |
|
1a1247e
Fix test
sizmailov Apr 5, 2022
| https://github.com/python/cpython/pull/23205/commits/1a1247e3aaf7e9c22c5c6b5b8e0d192970131a8b |
|
009a9f3
Fix introduced refleak
sizmailov Apr 7, 2022
| https://github.com/python/cpython/pull/23205/commits/009a9f3ef8799a53fda9b2bda235099f7cbbf32f |
|
d2aa925
Merge branch 'main' into fix-issue41287
JelleZijlstra May 2, 2022
| https://github.com/python/cpython/pull/23205/commits/d2aa925ed42327e25d3a7be2cf0d4294ffc2c539 |
|
8730abc
Test vanila property too
sizmailov May 22, 2022
| https://github.com/python/cpython/pull/23205/commits/8730abc81abbae2023718a4a3a8af942e5416694 |
|
0302ffb
Fix __doc__ assignment in property subclass
sizmailov May 22, 2022
| https://github.com/python/cpython/pull/23205/commits/0302ffbf1e7cba30e8a646d9f340d321de4963c5 |
|
e1ec1dc
Merge remote-tracking branch 'upstream/main' into fix-issue41287
sizmailov May 22, 2022
| https://github.com/python/cpython/pull/23205/commits/e1ec1dcba1fea0af3ee46fa4e963d286067e1a5a |
|
fb8c2d4
Fix Py_None ref leak
sizmailov May 22, 2022
| https://github.com/python/cpython/pull/23205/commits/fb8c2d4908d3f8ac992a404c2baa38090c33611e |
|
f8fb254
Add a comment
sizmailov May 22, 2022
| https://github.com/python/cpython/pull/23205/commits/f8fb254ad15c11da45df45d8f4d0cab87172e58c |
|
fc16ab9
Remove unnecessary check
sizmailov May 22, 2022
| https://github.com/python/cpython/pull/23205/commits/fc16ab974fb5d0e564478ed845ac18843bc70758 |
|
4943868
Add test for property copy doc
sizmailov May 26, 2022
| https://github.com/python/cpython/pull/23205/commits/4943868df7fe79049c9b1e6443e44f993655f5ef |
|
36fc1b0
Assign getter_doc only for non-null prop_doc
sizmailov May 26, 2022
| https://github.com/python/cpython/pull/23205/commits/36fc1b09e78bb954b9f2d49e214749bac30e5085 |
|
14bdd86
Apply suggestions from code review
sizmailov May 28, 2022
| https://github.com/python/cpython/pull/23205/commits/14bdd862dae123e5291ab3682831d0c765ef91f0 |
|
Clear filters
| https://github.com/python/cpython/pull/23205/files |
| Please reload this page | https://github.com/python/cpython/pull/23205/files |
| Please reload this page | https://github.com/python/cpython/pull/23205/files |
|
test_property.py
| https://github.com/python/cpython/pull/23205/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3 |
|
2022-04-03-11-25-02.bpo-41287.8CTdwf.rst
| https://github.com/python/cpython/pull/23205/files#diff-e8868cd4dfa25369acdb9f0a23fbdf28f3f35a4d715e9af84ce038a2297beaad |
|
descrobject.c
| https://github.com/python/cpython/pull/23205/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264 |
| Lib/test/test_property.py | https://github.com/python/cpython/pull/23205/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3 |
|
View file
| https://github.com/sizmailov/cpython/blob/14bdd862dae123e5291ab3682831d0c765ef91f0/Lib/test/test_property.py |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/23205/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/23205/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3 |
|
| https://github.com/python/cpython/pull/23205/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3 |
|
| https://github.com/python/cpython/pull/23205/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3 |
|
| https://github.com/python/cpython/pull/23205/files#diff-510a022afde6dbb437080870cced7548f338fb8654a4df10c425e5105a83b2e3 |
| Misc/NEWS.d/next/Library/2022-04-03-11-25-02.bpo-41287.8CTdwf.rst | https://github.com/python/cpython/pull/23205/files#diff-e8868cd4dfa25369acdb9f0a23fbdf28f3f35a4d715e9af84ce038a2297beaad |
|
View file
| https://github.com/sizmailov/cpython/blob/14bdd862dae123e5291ab3682831d0c765ef91f0/Misc/NEWS.d/next/Library/2022-04-03-11-25-02.bpo-41287.8CTdwf.rst |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/23205/{{ revealButtonHref }} |
| Objects/descrobject.c | https://github.com/python/cpython/pull/23205/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264 |
|
View file
| https://github.com/sizmailov/cpython/blob/14bdd862dae123e5291ab3682831d0c765ef91f0/Objects/descrobject.c |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/23205/{{ revealButtonHref }} |
|
| https://github.com/python/cpython/pull/23205/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264 |
| Please reload this page | https://github.com/python/cpython/pull/23205/files |
|
| https://github.com/python/cpython/pull/23205/files#diff-7952643fe36a8662b3e4be2c6478b06b1af5b5754fc25eaf3eb4b46569659264 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |