| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a815b083-aa61-3608-5e4c-45a4d6306a92 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E23A:165250:1BDEC7:2587E6:6A4D870F |
| html-safe-nonce | e7231b387f211aba8181a078a97be360f5cd1ce0091790ae560cadb15a7433d4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjNBOjE2NTI1MDoxQkRFQzc6MjU4N0U2OjZBNEQ4NzBGIiwidmlzaXRvcl9pZCI6IjkxMzc3OTg5NjQyMDM4NDk0ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 762c49e917c0405f35328dd66366258b4a76c7e4214ac57b8c23cf79dcd77ed1 |
| hovercard-subject-tag | pull_request:126869966 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/2318/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/2b9ad89afd52e277124d033874e9dbe595003d2d59f864c516718e119a4633c6/python/cpython/pull/2318 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/2b9ad89afd52e277124d033874e9dbe595003d2d59f864c516718e119a4633c6/python/cpython/pull/2318 |
| og:image:alt | We are getting this warnings:
Warning C4996 'inet_addr': Use inet_pton() or InetPton() instead or define _WINSOCK_DEPRECATED_NO_WARNINGS to disable deprecated API warnings _socket C:\Users\... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | segevfiner |
| hostname | github.com |
| expected-hostname | github.com |
| None | 9f8758a3953dfe943439713a6fa4f90d542a3431f10e861ca03dd7f39009f320 |
| turbo-cache-control | no-cache |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | bffd5484f01713a661b03469b77678f72b6574ed |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/2318#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2318 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2318 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/2318 |
| Reload | https://github.com/python/cpython/pull/2318 |
| Reload | https://github.com/python/cpython/pull/2318 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
34.8k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
73.6k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.3k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
0
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security and quality
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| zooba | https://github.com/zooba |
| python:master | https://github.com/python/cpython/tree/master |
| segevfiner:bpo-23451-socket-deprecation-warnings | https://github.com/segevfiner/cpython/tree/bpo-23451-socket-deprecation-warnings |
| Conversation | https://github.com/python/cpython/pull/2318 |
| Commits10 (10) | https://github.com/python/cpython/pull/2318/commits |
| Checks | https://github.com/python/cpython/pull/2318/checks |
| Files changed | https://github.com/python/cpython/pull/2318/files |
| bpo-23451: Fix socket deprecation warnings in socketmodule.c | https://github.com/python/cpython/pull/2318#top |
| zooba | https://github.com/zooba |
| python:master | https://github.com/python/cpython/tree/master |
| segevfiner:bpo-23451-socket-deprecation-warnings | https://github.com/segevfiner/cpython/tree/bpo-23451-socket-deprecation-warnings |
|
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 21, 2017 | https://github.com/python/cpython/pull/2318#issue-237676552 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| Modules/socketmodule.c:1067 | https://github.com/python/cpython/blob/c90e96015085784df86632b26059b19c80cbfc97/Modules/socketmodule.c#L1067 |
| InetPton function (Windows) | https://msdn.microsoft.com/en-us/library/windows/desktop/cc805844(v=vs.85).aspx |
| @zware | https://github.com/zware |
| @zooba | https://github.com/zooba |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| segevfiner | https://github.com/segevfiner |
| June 22, 2017 00:02 | https://github.com/python/cpython/pull/2318#commits-pushed-4201fbf |
|
| https://github.com/segevfiner |
| bpo-23451: Fix WSASocket and WSADuplicateSocket deprecation warnings | https://github.com/python/cpython/pull/2318/commits/4201fbf48f1f1003c928a3d6ddf0ebca59f84989 |
| 4201fbf | https://github.com/python/cpython/pull/2318/commits/4201fbf48f1f1003c928a3d6ddf0ebca59f84989 |
|
| https://github.com/segevfiner |
| bpo-23451: Add backwards compatibility note about socket share/fromshare | https://github.com/python/cpython/pull/2318/commits/91a611db99895a5e551f82c5546d6963f5a53a60 |
| 91a611d | https://github.com/python/cpython/pull/2318/commits/91a611db99895a5e551f82c5546d6963f5a53a60 |
|
| https://github.com/segevfiner |
| bpo-23451: Fixed WSAAddressToString/WSAStringToAddress deprecatio… | https://github.com/python/cpython/pull/2318/commits/81a8b4e6d11361039145bd7c4dd4dc6a62ea2be6 |
| 81a8b4e | https://github.com/python/cpython/pull/2318/commits/81a8b4e6d11361039145bd7c4dd4dc6a62ea2be6 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jun 21, 2017 | https://github.com/python/cpython/pull/2318#event-1133757216 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 21, 2017 | https://github.com/python/cpython/pull/2318#event-1133757455 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 21, 2017 | https://github.com/python/cpython/pull/2318#event-1133757755 |
|
| https://github.com/segevfiner |
| bpo-23451: Use inet_pton/inet_ntop instead of `WSAAddressToString… | https://github.com/python/cpython/pull/2318/commits/e0cdb939d8cb24ef9099b9feefd16c2ce9909bb1 |
| e0cdb93 | https://github.com/python/cpython/pull/2318/commits/e0cdb939d8cb24ef9099b9feefd16c2ce9909bb1 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 22, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-310450588 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
|
Jun 22, 2017
| https://github.com/python/cpython/pull/2318#pullrequestreview-45820736 |
|
View reviewed changes
| https://github.com/python/cpython/pull/2318/files/e0cdb939d8cb24ef9099b9feefd16c2ce9909bb1 |
| zooba | https://github.com/zooba |
| https://github.com/python/cpython/pull/2318#pullrequestreview-45820736 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #pragma warning | https://msdn.microsoft.com/en-us/library/2c8f766e.aspx |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| PCbuild/_socket.vcxproj | https://github.com/python/cpython/pull/2318/files/e0cdb939d8cb24ef9099b9feefd16c2ce9909bb1#diff-cf98e7214712cabc8ce9423abcb08400c701874b6ee7579e6ce3e71c3840d91c |
| zooba | https://github.com/zooba |
| Jun 22, 2017 | https://github.com/python/cpython/pull/2318#discussion_r123600125 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
|
| https://github.com/segevfiner |
| bpo-23451: Move HAVE_INET_PTON from _socket.vcxproj to pyconfig.h | https://github.com/python/cpython/pull/2318/commits/1043798fa3c0b5e206907c6c4c07a18c316542bd |
| 1043798 | https://github.com/python/cpython/pull/2318/commits/1043798fa3c0b5e206907c6c4c07a18c316542bd |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 23, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-310603063 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| @zooba | https://github.com/zooba |
| https://msdn.microsoft.com/en-us/library/d9x1s805.aspx | https://msdn.microsoft.com/en-us/library/d9x1s805.aspx |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 23, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-310611837 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| Jun 23, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-310794682 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 24, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-310829009 |
| @zooba | https://github.com/zooba |
| Fix exception in Python 3.7 due to bad re.sub replacement escapes pytest-dev/py#125 | https://github.com/pytest-dev/py/pull/125 |
| https://github.com/kiorky/SOAPpy/issues/26 | https://github.com/kiorky/SOAPpy/issues/26 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| segevfiner | https://github.com/segevfiner |
| June 24, 2017 13:05 | https://github.com/python/cpython/pull/2318#commits-pushed-c316d1e |
|
| https://github.com/segevfiner |
| Merge remote-tracking branch 'upstream/master' into bpo-23451-socket-… | https://github.com/python/cpython/pull/2318/commits/c316d1e8d11a8868f50959956f37ab7cf8c832f2 |
| c316d1e | https://github.com/python/cpython/pull/2318/commits/c316d1e8d11a8868f50959956f37ab7cf8c832f2 |
|
| https://github.com/segevfiner |
| bpo-23451: Add SUPPRESS_DEPRECATED_CALL to socketmodule.c | https://github.com/python/cpython/pull/2318/commits/ad12653dac3d3a927024a06af865ec08dc03589e |
| ad12653 | https://github.com/python/cpython/pull/2318/commits/ad12653dac3d3a927024a06af865ec08dc03589e |
| https://github.com/zware |
| zware | https://github.com/zware |
|
Jun 25, 2017
| https://github.com/python/cpython/pull/2318#ref-pullrequest-238358395 |
|
bpo-27523: Silence Socket Depreciation Warnings.
#2389
| https://github.com/python/cpython/pull/2389 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| Jun 26, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-311190661 |
| @segevfiner | https://github.com/segevfiner |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 26, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-311196354 |
| @zooba | https://github.com/zooba |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| Jun 26, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-311202102 |
| https://docs.python.org/devguide/committing.html#what-s-new-and-news-entries | https://docs.python.org/devguide/committing.html#what-s-new-and-news-entries |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| segevfiner | https://github.com/segevfiner |
| June 27, 2017 07:05 | https://github.com/python/cpython/pull/2318#commits-pushed-9f8513e |
|
| https://github.com/segevfiner |
| bpo-23451: Add a NEWS.d entry | https://github.com/python/cpython/pull/2318/commits/9f8513eea18bdbdc59549cb618cad280ef9c5051 |
| 9f8513e | https://github.com/python/cpython/pull/2318/commits/9f8513eea18bdbdc59549cb618cad280ef9c5051 |
|
| https://github.com/segevfiner |
| bpo-23451: Corrected NEWS.d entry | https://github.com/python/cpython/pull/2318/commits/bc040f3f23f0420c17df1ec80f0a3d17b01179d7 |
| bc040f3 | https://github.com/python/cpython/pull/2318/commits/bc040f3f23f0420c17df1ec80f0a3d17b01179d7 |
|
| https://github.com/zooba |
| Merge branch 'master' into bpo-23451-socket-deprecation-warnings | https://github.com/python/cpython/pull/2318/commits/a2080556f313a38976493ccccb32facf0af2befe |
| a208055 | https://github.com/python/cpython/pull/2318/commits/a2080556f313a38976493ccccb32facf0af2befe |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| Jun 28, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-311782865 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| 9f3bdcb | https://github.com/python/cpython/commit/9f3bdcb643623e07497af2fc35f0496c2302f1be |
| Jun 28, 2017 | https://github.com/python/cpython/pull/2318#event-1143130627 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| Jun 28, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-311786463 |
| http://buildbot.python.org/all/waterfall?category=3.x.stable | http://buildbot.python.org/all/waterfall?category=3.x.stable |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/zooba |
| zooba | https://github.com/zooba |
| Jun 28, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-311794759 |
| http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/816/steps/compile/logs/warnings%20%2832%29 | http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/816/steps/compile/logs/warnings%20%2832%29 |
| http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/817/steps/compile/logs/warnings%20%288%29 | http://buildbot.python.org/all/builders/x86%20Windows7%203.x/builds/817/steps/compile/logs/warnings%20%288%29 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| Jun 28, 2017 | https://github.com/python/cpython/pull/2318#issuecomment-311795571 |
| @zooba | https://github.com/zooba |
| #2375 | https://github.com/python/cpython/pull/2375 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
| June 28, 2017 21:25 | https://github.com/python/cpython/pull/2318#event-1143185230 |
| https://github.com/segevfiner |
| segevfiner | https://github.com/segevfiner |
|
Jul 21, 2017
| https://github.com/python/cpython/pull/2318#ref-pullrequest-244794952 |
|
bpo-30986: Add --include-py argument to Tools/msi/make_zip.py
#2806
| https://github.com/python/cpython/pull/2806 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F2318 |
|
| https://github.com/zooba |
|
zooba
| https://github.com/zooba |
|
| https://github.com/python/cpython/pull/2318/files/e0cdb939d8cb24ef9099b9feefd16c2ce9909bb1 |
| Please reload this page | https://github.com/python/cpython/pull/2318 |
|
| https://github.com/segevfiner |
|
| https://github.com/zooba |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |