René's URL Explorer Experiment


Title: bpo-1635741: sqlite3 now uses Py_NewRef and Py_XNewRef by erlend-aasland · Pull Request #23170 · python/cpython · GitHub

Open Graph Title: bpo-1635741: sqlite3 now uses Py_NewRef and Py_XNewRef by erlend-aasland · Pull Request #23170 · python/cpython

X Title: bpo-1635741: sqlite3 now uses Py_NewRef and Py_XNewRef by erlend-aasland · Pull Request #23170 · python/cpython

Description: Thanks for GH-23152, @vstinner! Fewer lines, improved readability: 7 files changed, 40 insertions, 87 deletions :) Would you mind reviewing? https://bugs.python.org/issue1635741

Open Graph Description: Thanks for GH-23152, @vstinner! Fewer lines, improved readability: 7 files changed, 40 insertions, 87 deletions :) Would you mind reviewing? https://bugs.python.org/issue1635741

X Description: Thanks for GH-23152, @vstinner! Fewer lines, improved readability: 7 files changed, 40 insertions, 87 deletions :) Would you mind reviewing? https://bugs.python.org/issue1635741

Opengraph URL: https://github.com/python/cpython/pull/23170

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9d97709d-ab6d-da34-8d7c-8e763fd9f129
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB336:11D37A:18B1EC:22E14E:696A04D7
html-safe-noncecfa4b50814ca725a37edb854f8d7fe1c23fc91cb17179dd72686cb3a42ef9f96
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMzM2OjExRDM3QToxOEIxRUM6MjJFMTRFOjY5NkEwNEQ3IiwidmlzaXRvcl9pZCI6IjE2MTM2NzQzNjY1NTA4MDM2NzEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd8009a254aa25d816d50c585187b0c48e5d6774342c93169aa4f6c680647af06
hovercard-subject-tagpull_request:516268523
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/23170/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6ac8194196402225414e4245c83d264812a57b5f50452b5ad18aa19ddf2c0ac1/python/cpython/pull/23170
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6ac8194196402225414e4245c83d264812a57b5f50452b5ad18aa19ddf2c0ac1/python/cpython/pull/23170
og:image:altThanks for GH-23152, @vstinner! Fewer lines, improved readability: 7 files changed, 40 insertions, 87 deletions :) Would you mind reviewing? https://bugs.python.org/issue1635741
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameerlend-aasland
hostnamegithub.com
expected-hostnamegithub.com
None578c119ff0247c8b2f2491fbf4fc0395cdf909d4df66598cebdc96ddfc4418dc
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release671c2f67171dbced24284331f3133a613d08c366
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/23170#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23170
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23170
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/23170
Reloadhttps://github.com/python/cpython/pull/23170
Reloadhttps://github.com/python/cpython/pull/23170
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/23170
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/23170
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/23170#issue-comment-box
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
erlend-aasland:bpo-1635741/sqlite-new-refhttps://github.com/erlend-aasland/cpython/tree/bpo-1635741/sqlite-new-ref
bpo-1635741: sqlite3 now uses Py_NewRef and Py_XNewRef https://github.com/python/cpython/pull/23170#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
erlend-aasland:bpo-1635741/sqlite-new-refhttps://github.com/erlend-aasland/cpython/tree/bpo-1635741/sqlite-new-ref
Conversation 17 https://github.com/python/cpython/pull/23170
Commits 6 https://github.com/python/cpython/pull/23170/commits
Checks 0 https://github.com/python/cpython/pull/23170/checks
Files changed https://github.com/python/cpython/pull/23170/files
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Nov 5, 2020https://github.com/python/cpython/pull/23170#issue-737182027
Please reload this pagehttps://github.com/python/cpython/pull/23170
GH-23152https://github.com/python/cpython/pull/23152
@vstinnerhttps://github.com/vstinner
https://bugs.python.org/issue1635741https://bugs.python.org/issue1635741
Please reload this pagehttps://github.com/python/cpython/pull/23170
Use Py_NewRef and Py_XNewRef in sqlite3https://github.com/python/cpython/pull/23170/commits/dc6486d46c49d28575da128e09adb4cf99a4fbe8
dc6486dhttps://github.com/python/cpython/pull/23170/commits/dc6486d46c49d28575da128e09adb4cf99a4fbe8
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
berkerpeksaghttps://github.com/berkerpeksag
code ownerhttps://github.com/python/cpython/blob/dc42af8fd16b10127ce1fc93c13bc1bfd2674aa2/.github/CODEOWNERS#L88
November 5, 2020 18:51https://github.com/python/cpython/pull/23170#event-3963899918
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Nov 5, 2020https://github.com/python/cpython/pull/23170#event-3963900104
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 5, 2020https://github.com/python/cpython/pull/23170#event-3963900391
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Nov 5, 2020https://github.com/python/cpython/pull/23170#issuecomment-722604012
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 6, 2020https://github.com/python/cpython/pull/23170#issuecomment-723161124
https://bugs.python.org/issue42142https://bugs.python.org/issue42142
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 6, 2020 https://github.com/python/cpython/pull/23170#pullrequestreview-525290452
View reviewed changes https://github.com/python/cpython/pull/23170/files/dc6486d46c49d28575da128e09adb4cf99a4fbe8
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/23170#pullrequestreview-525290452
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23170
Modules/_sqlite/connection.chttps://github.com/python/cpython/pull/23170/files/dc6486d46c49d28575da128e09adb4cf99a4fbe8#diff-f405d0da477c184cd4afb94ce52dfd7fcd4980500a3a5ffe753d0e8cd57638a2
Please reload this pagehttps://github.com/python/cpython/pull/23170
Modules/_sqlite/statement.chttps://github.com/python/cpython/pull/23170/files/dc6486d46c49d28575da128e09adb4cf99a4fbe8#diff-517a9c73ccad12dd55f0beb930416fee87cade1b2abbb84a73ed8e39cc696c39
Please reload this pagehttps://github.com/python/cpython/pull/23170
Address review comment: Split nested callshttps://github.com/python/cpython/pull/23170/commits/8528bf636a08fe0ba035cd4484649ab2b7fbfd88
8528bf6https://github.com/python/cpython/pull/23170/commits/8528bf636a08fe0ba035cd4484649ab2b7fbfd88
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Nov 6, 2020https://github.com/python/cpython/pull/23170#issuecomment-723260694
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.com/Jongy
Jongyhttps://github.com/Jongy
Nov 8, 2020https://github.com/python/cpython/pull/23170#issuecomment-723515153
https://bugs.python.org/issue42287https://bugs.python.org/issue42287
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/23170
Address Victor's review: Restore INCREF/XSETREF in Connection.__init__https://github.com/python/cpython/pull/23170/commits/68e044f2d3110b05f4095a7248b0454b04964850
68e044fhttps://github.com/python/cpython/pull/23170/commits/68e044f2d3110b05f4095a7248b0454b04964850
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
vstinnerhttps://github.com/vstinner
November 8, 2020 08:14https://github.com/python/cpython/pull/23170#event-3970539701
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Nov 20, 2020https://github.com/python/cpython/pull/23170#issuecomment-731340945
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 23, 2020 https://github.com/python/cpython/pull/23170#pullrequestreview-536241873
View reviewed changes https://github.com/python/cpython/pull/23170/files/68e044f2d3110b05f4095a7248b0454b04964850
Modules/_sqlite/connection.chttps://github.com/python/cpython/pull/23170/files/68e044f2d3110b05f4095a7248b0454b04964850#diff-f405d0da477c184cd4afb94ce52dfd7fcd4980500a3a5ffe753d0e8cd57638a2
Please reload this pagehttps://github.com/python/cpython/pull/23170
Address reviewhttps://github.com/python/cpython/pull/23170/commits/dd7d4e797bfeb11558259f8f7a3e875e7295e507
dd7d4e7https://github.com/python/cpython/pull/23170/commits/dd7d4e797bfeb11558259f8f7a3e875e7295e507
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
vstinnerhttps://github.com/vstinner
November 23, 2020 10:08https://github.com/python/cpython/pull/23170#event-4026817391
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Nov 23, 2020https://github.com/python/cpython/pull/23170#event-4026833622
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 23, 2020 https://github.com/python/cpython/pull/23170#pullrequestreview-536328488
View reviewed changes https://github.com/python/cpython/pull/23170/files/dd7d4e797bfeb11558259f8f7a3e875e7295e507
vstinnerhttps://github.com/vstinner
https://github.com/python/cpython/pull/23170#pullrequestreview-536328488
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Nov 23, 2020https://github.com/python/cpython/pull/23170#event-4026834304
December 18, 2020 23:52https://github.com/python/cpython/pull/23170#commits-pushed-29c93db
Merge branch 'master' into bpo-1635741/sqlite-new-refhttps://github.com/python/cpython/pull/23170/commits/29c93dbdc8bc2d187c66291e7d8ecddc7c31bf78
29c93dbhttps://github.com/python/cpython/pull/23170/commits/29c93dbdc8bc2d187c66291e7d8ecddc7c31bf78
Fix mergehttps://github.com/python/cpython/pull/23170/commits/b7b4b780904f356e178ad2f4edfc4a8970421515
b7b4b78https://github.com/python/cpython/pull/23170/commits/b7b4b780904f356e178ad2f4edfc4a8970421515
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Dec 26, 2020https://github.com/python/cpython/pull/23170#issuecomment-751387975
@vstinnerhttps://github.com/vstinner
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
bf64d90https://github.com/python/cpython/commit/bf64d9064ab641b1ef9a0c4bda097ebf1204faf4
Dec 27, 2020https://github.com/python/cpython/pull/23170#event-4150199734
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Dec 27, 2020https://github.com/python/cpython/pull/23170#event-4150199781
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
December 27, 2020 11:06https://github.com/python/cpython/pull/23170#event-4150200194
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Dec 27, 2020 https://github.com/python/cpython/pull/23170#ref-pullrequest-775123232
bpo-1635741: Fix ref. leak introduced by bf64d90 #23972 https://github.com/python/cpython/pull/23972
adorilsonhttps://github.com/adorilson
Mar 13, 2021 https://github.com/python/cpython/pull/23170#ref-commit-103cbfa
https://github.com/adorilson
bpo-1635741: sqlite3 uses Py_NewRef/Py_XNewRef (https://github.com/adorilson/cpython/commit/103cbfa267e7e22e413601088a9b58edd76c4c60
pythonGH-23170https://github.com/python/cpython/pull/23170
)https://github.com/adorilson/cpython/commit/103cbfa267e7e22e413601088a9b58edd76c4c60
103cbfahttps://github.com/adorilson/cpython/commit/103cbfa267e7e22e413601088a9b58edd76c4c60
https://github.com/python/cpython/pull/23170
kylotanhttps://github.com/python/cpython/pull/23170
Sep 19, 2022 https://github.com/python/cpython/pull/23170#ref-issue-1198820210
Py_Finalize() doesn't clear all Python objects at exit #44470 https://github.com/python/cpython/issues/44470
https://github.com/erlend-aasland
erlend-aaslandhttps://github.com/erlend-aasland
Nov 14, 2022 https://github.com/python/cpython/pull/23170#ref-issue-1442769606
Replace Py_INCREF()/Py_XINCREF() usage with Py_NewRef()/Py_XNewRef() #99300 https://github.com/python/cpython/issues/99300
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23170
https://github.com/vstinner
vstinner https://github.com/vstinner
https://github.com/python/cpython/pull/23170/files/dd7d4e797bfeb11558259f8f7a3e875e7295e507
https://github.com/berkerpeksag
berkerpeksag https://github.com/berkerpeksag
https://github.com/Jongy
Jongy https://github.com/Jongy
https://github.com/python/cpython/pull/23170/files/8528bf636a08fe0ba035cd4484649ab2b7fbfd88
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/23170
https://github.com/erlend-aasland
https://github.com/vstinner
https://github.com/Jongy
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.