René's URL Explorer Experiment


Title: bpo-1635741: _warnings uses PyModule_AddObjectRef() by vstinner · Pull Request #23151 · python/cpython · GitHub

Open Graph Title: bpo-1635741: _warnings uses PyModule_AddObjectRef() by vstinner · Pull Request #23151 · python/cpython

X Title: bpo-1635741: _warnings uses PyModule_AddObjectRef() by vstinner · Pull Request #23151 · python/cpython

Description: Replace PyModule_AddObject() with PyModule_AddObjectRef() in the _warnings module to fix a reference leak on error. Also use PyModule_AddObjectRef() in importdl.c. https://bugs.python.org/issue16...

Open Graph Description: Replace PyModule_AddObject() with PyModule_AddObjectRef() in the _warnings module to fix a reference leak on error. Also use PyModule_AddObjectRef() in importdl.c. https://bugs.python.org/issue16...

X Description: Replace PyModule_AddObject() with PyModule_AddObjectRef() in the _warnings module to fix a reference leak on error. Also use PyModule_AddObjectRef() in importdl.c. https://bugs.python.org/issue16...

Opengraph URL: https://github.com/python/cpython/pull/23151

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:5b3bd356-e08b-b011-1cc3-0736f75d3efb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC42C:341673:820FAA:AE91CB:6969BD5B
html-safe-nonce7e14cbac40eaffc300eea7d06c6b813b933f491ab7685a235c19f76d5fc995a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDJDOjM0MTY3Mzo4MjBGQUE6QUU5MUNCOjY5NjlCRDVCIiwidmlzaXRvcl9pZCI6IjIzNTA4MzI0MTk3NDU2NzY2MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaceea7228a80c407a46fc0bb4bf46e1b6123cc6a145b2d81354d892c2c8f4a178b
hovercard-subject-tagpull_request:515470687
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/23151/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/90bebf23dfd42bc4df9d17238567cebc24b0f4a10bace8ebd37b138acef08626/python/cpython/pull/23151
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/90bebf23dfd42bc4df9d17238567cebc24b0f4a10bace8ebd37b138acef08626/python/cpython/pull/23151
og:image:altReplace PyModule_AddObject() with PyModule_AddObjectRef() in the _warnings module to fix a reference leak on error. Also use PyModule_AddObjectRef() in importdl.c. https://bugs.python.org/issue16...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noneacedec8b5f975d9e3d494ddd8f949b0b8a0de59d393901e26f73df9dcba80056
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release83c08c21cdda978090dc44364b71aa5bc6dcea79
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/23151#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23151
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23151
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/23151
Reloadhttps://github.com/python/cpython/pull/23151
Reloadhttps://github.com/python/cpython/pull/23151
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/23151
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/23151
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/23151#issue-comment-box
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
bpo-1635741: _warnings uses PyModule_AddObjectRef() https://github.com/python/cpython/pull/23151#top
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
Conversation 1 https://github.com/python/cpython/pull/23151
Commits 1 https://github.com/python/cpython/pull/23151/commits
Checks 0 https://github.com/python/cpython/pull/23151/checks
Files changed https://github.com/python/cpython/pull/23151/files
Please reload this pagehttps://github.com/python/cpython/pull/23151
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 4, 2020https://github.com/python/cpython/pull/23151#issue-736218565
Please reload this pagehttps://github.com/python/cpython/pull/23151
https://bugs.python.org/issue1635741https://bugs.python.org/issue1635741
Please reload this pagehttps://github.com/python/cpython/pull/23151
https://github.com/vstinner
bpo-1635741https://bugs.python.org/issue?@action=redirect&bpo=1635741
: _warnings uses PyModule_AddObjectRef()https://github.com/python/cpython/pull/23151/commits/8c8339dc72b2dfe20fffca84a6f621b026d2d528
8c8339dhttps://github.com/python/cpython/pull/23151/commits/8c8339dc72b2dfe20fffca84a6f621b026d2d528
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
brettcannonhttps://github.com/brettcannon
encukouhttps://github.com/encukou
ericsnowcurrentlyhttps://github.com/ericsnowcurrently
ncoghlanhttps://github.com/ncoghlan
warsawhttps://github.com/warsaw
code ownershttps://github.com/python/cpython/blob/18ce7f1d0a3d65f34f25c5964da588743a1bfe3c/.github/CODEOWNERS#L50
November 4, 2020 15:44https://github.com/python/cpython/pull/23151#event-3958219039
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Nov 4, 2020https://github.com/python/cpython/pull/23151#event-3958219270
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 4, 2020https://github.com/python/cpython/pull/23151#event-3958219619
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Nov 4, 2020https://github.com/python/cpython/pull/23151#event-3958221360
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Nov 4, 2020https://github.com/python/cpython/pull/23151#issuecomment-721809450
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/23151
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
58ca33bhttps://github.com/python/cpython/commit/58ca33b4674f39189b03c9a39fa7b676b43b3d08
Nov 4, 2020https://github.com/python/cpython/pull/23151#event-3958446788
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Nov 4, 2020https://github.com/python/cpython/pull/23151#event-3958446988
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
November 4, 2020 16:33https://github.com/python/cpython/pull/23151#event-3958447051
shihai1991https://github.com/shihai1991
Nov 5, 2020 https://github.com/python/cpython/pull/23151#ref-commit-c267e35
https://github.com/shihai1991
Merge branch 'master' into bpo_41832https://github.com/shihai1991/cpython/commit/c267e353be72dc87326ac16d71cc0bc36ca0ed5e
c267e35https://github.com/shihai1991/cpython/commit/c267e353be72dc87326ac16d71cc0bc36ca0ed5e
pythonGH-23158https://github.com/python/cpython/pull/23158
pythonGH-23141https://github.com/python/cpython/pull/23141
pythonGH-23148https://github.com/python/cpython/pull/23148
pythonGH-22489https://github.com/python/cpython/pull/22489
pythonGH-23150https://github.com/python/cpython/pull/23150
pythonGH-23151https://github.com/python/cpython/pull/23151
pythonGH-23146https://github.com/python/cpython/pull/23146
pythonGH-23147https://github.com/python/cpython/pull/23147
pythonGH-23149https://github.com/python/cpython/pull/23149
pythonGH-23122https://github.com/python/cpython/pull/23122
pythonGH-23119https://github.com/python/cpython/pull/23119
pythonGH-23125https://github.com/python/cpython/pull/23125
pythonGH-23132https://github.com/python/cpython/pull/23132
pythonGH-23017https://github.com/python/cpython/pull/23017
pythonGH-22835https://github.com/python/cpython/pull/22835
pythonGH-23131https://github.com/python/cpython/pull/23131
pythonGH-23121https://github.com/python/cpython/pull/23121
pythonGH-23108https://github.com/python/cpython/pull/23108
adorilsonhttps://github.com/adorilson
Mar 13, 2021 https://github.com/python/cpython/pull/23151#ref-commit-23eb723
https://github.com/vstinner
https://github.com/adorilson
bpo-1635741: Fix ref leak in _PyWarnings_Init() error path (https://github.com/adorilson/cpython/commit/23eb723de10d1c1f75cd272597bfd267782fc7d2
pythonGH-…https://github.com/python/cpython/pull/23151
23eb723https://github.com/adorilson/cpython/commit/23eb723de10d1c1f75cd272597bfd267782fc7d2
…23151https://github.com/python/cpython/pull/23151
https://github.com/python/cpython/pull/23151
kylotanhttps://github.com/python/cpython/pull/23151
Sep 19, 2022 https://github.com/python/cpython/pull/23151#ref-issue-1198820210
Py_Finalize() doesn't clear all Python objects at exit #44470 https://github.com/python/cpython/issues/44470
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F23151
https://github.com/brettcannon
brettcannon https://github.com/brettcannon
https://github.com/encukou
encukou https://github.com/encukou
https://github.com/ericsnowcurrently
ericsnowcurrently https://github.com/ericsnowcurrently
https://github.com/ncoghlan
ncoghlan https://github.com/ncoghlan
https://github.com/warsaw
warsaw https://github.com/warsaw
skip news https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22
Please reload this pagehttps://github.com/python/cpython/pull/23151
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.