Title: [3.9] bpo-37193: remove thread objects which finished process its request (GH-13893) by miss-islington · Pull Request #23087 · python/cpython · GitHub
Open Graph Title: [3.9] bpo-37193: remove thread objects which finished process its request (GH-13893) by miss-islington · Pull Request #23087 · python/cpython
X Title: [3.9] bpo-37193: remove thread objects which finished process its request (GH-13893) by miss-islington · Pull Request #23087 · python/cpython
Description: bpo-37193: remove the thread which finished process request from threads list rename variable t to thread. don't remove thread from list if it is daemon. use lock to protect self._threads. use finally block in case of exception from shutdown_request(). check "not thread.daemon" before lock to avoid holding the lock if it's unnecessary. fix the place of _threads_lock. separate code to remove a current thread into a function. check ValueError when removing thread. fix wrong code which all instance shared same lock. Extract thread management into a _Threads class to encapsulate atomic operations and separate concerns. Replace multiple references of 'block_on_close' with one, avoiding the possibility that 'block_on_close' could change during the course of processing requests. Now, there's exactly one _threads object with behavior fixed for the duration. Add docstrings to private classes. Add test to ensure that a ThreadingTCPServer can be closed without serving any requests. Use _NoThreads as the default value. Fixes AttributeError when server is closed without serving any requests. Add blurb Add test capturing failure. Co-authored-by: Jason R. Coombs jaraco@jaraco.com (cherry picked from commit c415590) Co-authored-by: MARUYAMA Norihiro norihiro.maruyama@gmail.com https://bugs.python.org/issue37193
Open Graph Description: bpo-37193: remove the thread which finished process request from threads list rename variable t to thread. don't remove thread from list if it is daemon. use lock to protect self._threads...
X Description: bpo-37193: remove the thread which finished process request from threads list rename variable t to thread. don't remove thread from list if it is daemon. use lock to protect self._thr...
Opengraph URL: https://github.com/python/cpython/pull/23087
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:674f9c39-d3fc-e46c-1b35-6df637562b4c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D4A4:2FC742:1D8A809:27AE402:6A53728B |
| html-safe-nonce | 88addf4ea236896e3979b3fe5e68e4a79c3291ff99cb012cf6c46b67815cc0e2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEE0OjJGQzc0MjoxRDhBODA5OjI3QUU0MDI6NkE1MzcyOEIiLCJ2aXNpdG9yX2lkIjoiMTI1ODMxOTM2ODE3OTM4MDg3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 12938e2e4c1850c955ed525c4bd503d8a304881bb1fe061fc5d93a971740a819 |
| hovercard-subject-tag | pull_request:513715860 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/python/cpython/pull/23087/files |
| twitter:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/31488909?s=400&v=4 |
| og:image:alt | bpo-37193: remove the thread which finished process request from threads list rename variable t to thread. don't remove thread from list if it is daemon. use lock to protect self._threads... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width