René's URL Explorer Experiment


Title: bpo-41818: Updated tests for the standard pty library by 8vasu · Pull Request #22962 · python/cpython · GitHub

Open Graph Title: bpo-41818: Updated tests for the standard pty library by 8vasu · Pull Request #22962 · python/cpython

X Title: bpo-41818: Updated tests for the standard pty library by 8vasu · Pull Request #22962 · python/cpython

Description: This converts the test for pty.master_open() to a test for pty.openpty() with additional tests such as checking slave termios, slave winsize; these additional tests are expected to fail. This also adds a small test that is expected to fail on FreeBSD and should pass on Linux; reflecting pty.spawn()'s FreeBSD hang issue [ bpo-26228 ]. Solutions to these problems have been implemented here: https://github.com/8vasu/pypty2 If and when these tests are acknowledged, the solutions will be submitted in parts. This follows the conversation here: #21861 Signed-off-by: Soumendra Ganguly soumendraganguly@gmail.com https://bugs.python.org/issue41818

Open Graph Description: This converts the test for pty.master_open() to a test for pty.openpty() with additional tests such as checking slave termios, slave winsize; these additional tests are expected to fail. This also ...

X Description: This converts the test for pty.master_open() to a test for pty.openpty() with additional tests such as checking slave termios, slave winsize; these additional tests are expected to fail. This also ...

Opengraph URL: https://github.com/python/cpython/pull/22962

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:77c9f957-b00c-1a72-0fcd-cb9720ef3576
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD8DA:2CBE2A:1ECEE4A:2B2E74F:696A5B5F
html-safe-nonce804c8c0c71b450388bd44bd9aa7f9d5fef040bb1f28c76d7411facb27fbdae27
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEOERBOjJDQkUyQToxRUNFRTRBOjJCMkU3NEY6Njk2QTVCNUYiLCJ2aXNpdG9yX2lkIjoiNTAwNTU1MTM2NjEwMDkwMDcwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfde48ec53c48f738f936efb56354f71a9924b13d2ec746dea8c8a6c14f3f6c02
hovercard-subject-tagpull_request:509546540
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/22962/files
twitter:imagehttps://avatars.githubusercontent.com/u/67527439?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/67527439?s=400&v=4
og:image:altThis converts the test for pty.master_open() to a test for pty.openpty() with additional tests such as checking slave termios, slave winsize; these additional tests are expected to fail. This also ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3f871c8e07f0ae1886fa8dac284166d28b09ad5bada6476fc10b674e489788ef
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release63c426b30d262aba269ef14c40e3c817b384cd61
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/22962/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22962%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22962%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/22962/files
Reloadhttps://github.com/python/cpython/pull/22962/files
Reloadhttps://github.com/python/cpython/pull/22962/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/22962/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/22962/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
asvetlovhttps://github.com/asvetlov
python:masterhttps://github.com/python/cpython/tree/master
8vasu:new_pty_testshttps://github.com/8vasu/cpython/tree/new_pty_tests
Conversation 41 https://github.com/python/cpython/pull/22962
Commits 10 https://github.com/python/cpython/pull/22962/commits
Checks 0 https://github.com/python/cpython/pull/22962/checks
Files changed https://github.com/python/cpython/pull/22962/files
Please reload this pagehttps://github.com/python/cpython/pull/22962/files
bpo-41818: Updated tests for the standard pty library https://github.com/python/cpython/pull/22962/files#top
Show all changes 10 commits https://github.com/python/cpython/pull/22962/files
323fc9c Updated tests for the pty standard library 8vasu Oct 25, 2020 https://github.com/python/cpython/pull/22962/commits/323fc9c9d07c6a87e6453ff8ea0b083ec319d804
4bb22ca In Lib/test/test_pty.py, wrap @expectedFailure to check if pty.STDIN_… 8vasu Oct 25, 2020 https://github.com/python/cpython/pull/22962/commits/4bb22ca70e8ca10a11d3c403ba57bd50d0687d2b
a8723e7 In Lib/test/test_pty.py, add a check for "Darwin" in expectedFailureO… 8vasu Oct 25, 2020 https://github.com/python/cpython/pull/22962/commits/a8723e7f03ec12b8b57de65eb94ed176be4059f2
26c0928 Remove some comments. 8vasu Oct 26, 2020 https://github.com/python/cpython/pull/22962/commits/26c092820366ba417027109ca98c0ce1cf44f165
9a6e70f Restructure the tests, perform cleanup. 8vasu Nov 2, 2020 https://github.com/python/cpython/pull/22962/commits/9a6e70fc9c9d6108357583344a416d7c84159ed9
f6d01f8 Restructure test_openpty(). 8vasu Nov 2, 2020 https://github.com/python/cpython/pull/22962/commits/f6d01f880083221d6abb2e6f8ead1077f57d52e3
85f173b Restructure test_openpty(). 8vasu Nov 2, 2020 https://github.com/python/cpython/pull/22962/commits/85f173b5ec29bf01ba23d314f8cd5683e0a613e1
6546938 Restructure test_openpty(). 8vasu Nov 2, 2020 https://github.com/python/cpython/pull/22962/commits/654693818afd24d3d614440ac953c44d6e54de22
0cde3f2 Remove/change some comments. 8vasu Nov 20, 2020 https://github.com/python/cpython/pull/22962/commits/0cde3f28ff866af19da331c1aace5439846dd21a
e990b79 📜🤖 Added by blurb_it. blurb-it[bot] Nov 20, 2020 https://github.com/python/cpython/pull/22962/commits/e990b7980043f06789777f970111c11c41fe2588
Clear filters https://github.com/python/cpython/pull/22962/files
Please reload this pagehttps://github.com/python/cpython/pull/22962/files
Please reload this pagehttps://github.com/python/cpython/pull/22962/files
test_pty.py https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
2020-11-20-14-44-07.bpo-41818.33soAw.rst https://github.com/python/cpython/pull/22962/files#diff-e29fd6317aa00c617f607be7afe9928da40289d1c01caf99eec3aff5b2366b23
Lib/test/test_pty.pyhttps://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
View file https://github.com/8vasu/cpython/blob/e990b7980043f06789777f970111c11c41fe2588/Lib/test/test_pty.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22962/{{ revealButtonHref }}
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
Please reload this pagehttps://github.com/python/cpython/pull/22962/files
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
Please reload this pagehttps://github.com/python/cpython/pull/22962/files
https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d
Misc/NEWS.d/next/Library/2020-11-20-14-44-07.bpo-41818.33soAw.rsthttps://github.com/python/cpython/pull/22962/files#diff-e29fd6317aa00c617f607be7afe9928da40289d1c01caf99eec3aff5b2366b23
View file https://github.com/8vasu/cpython/blob/e990b7980043f06789777f970111c11c41fe2588/Misc/NEWS.d/next/Library/2020-11-20-14-44-07.bpo-41818.33soAw.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22962/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.