| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:31d866b2-3e79-4f29-8b38-9bd9d53c5b8b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF2E:AA79F:B89042:1028D1C:696A1FA6 |
| html-safe-nonce | fa72971a87d75d937563174a0d059e4a3dda7c83d04bdd197f0e5730f515a755 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjJFOkFBNzlGOkI4OTA0MjoxMDI4RDFDOjY5NkExRkE2IiwidmlzaXRvcl9pZCI6IjQwNDgxMjE0NTI2NTk2MTM2MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 51e62a7259a0b27ce2fbea4457344f1ffa9ba63efed8ac6c71f0ad5e82bf22a5 |
| hovercard-subject-tag | pull_request:509546540 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/22962/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/a717a2a7cef02c0880e28575e86dcbca7e7f5eb670fced773e78fdf01343e5fe/python/cpython/pull/22962 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a717a2a7cef02c0880e28575e86dcbca7e7f5eb670fced773e78fdf01343e5fe/python/cpython/pull/22962 |
| og:image:alt | This converts the test for pty.master_open() to a test for pty.openpty() with additional tests such as checking slave termios, slave winsize; these additional tests are expected to fail.
This also ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | 8vasu |
| hostname | github.com |
| expected-hostname | github.com |
| None | 014f3d193f36b7d393f88ca22d06fbacd370800b40a547c1ea67291e02dc8ea3 |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | d515f6f09fa57a93bf90355cb894eb84ca4f458f |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/22962#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22962 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22962 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/22962 |
| Reload | https://github.com/python/cpython/pull/22962 |
| Reload | https://github.com/python/cpython/pull/22962 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/22962#issue-comment-box |
| asvetlov | https://github.com/asvetlov |
| python:master | https://github.com/python/cpython/tree/master |
| 8vasu:new_pty_tests | https://github.com/8vasu/cpython/tree/new_pty_tests |
|
bpo-41818: Updated tests for the standard pty library
| https://github.com/python/cpython/pull/22962#top |
| asvetlov | https://github.com/asvetlov |
| python:master | https://github.com/python/cpython/tree/master |
| 8vasu:new_pty_tests | https://github.com/8vasu/cpython/tree/new_pty_tests |
|
Conversation
41
| https://github.com/python/cpython/pull/22962 |
|
Commits
10
| https://github.com/python/cpython/pull/22962/commits |
|
Checks
0
| https://github.com/python/cpython/pull/22962/checks |
|
Files changed
| https://github.com/python/cpython/pull/22962/files |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| Oct 25, 2020 | https://github.com/python/cpython/pull/22962#issue-728954928 |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| bpo-26228 | https://bugs.python.org/issue26228 |
| https://github.com/8vasu/pypty2 | https://github.com/8vasu/pypty2 |
| #21861 | https://github.com/python/cpython/pull/21861 |
| https://bugs.python.org/issue41818 | https://bugs.python.org/issue41818 |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
|
| https://github.com/8vasu |
| Updated tests for the pty standard library | https://github.com/python/cpython/pull/22962/commits/323fc9c9d07c6a87e6453ff8ea0b083ec319d804 |
| 323fc9c | https://github.com/python/cpython/pull/22962/commits/323fc9c9d07c6a87e6453ff8ea0b083ec319d804 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Oct 25, 2020 | https://github.com/python/cpython/pull/22962#event-3917520007 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Oct 25, 2020 | https://github.com/python/cpython/pull/22962#event-3917520028 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
|
Oct 25, 2020
| https://github.com/python/cpython/pull/22962#ref-pullrequest-678624342 |
|
bpo-41541: Make pty.spawn set window size
#21861
| https://github.com/python/cpython/pull/21861 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| Oct 25, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-716104457 |
| @ethanfurman | https://github.com/ethanfurman |
| @aeros | https://github.com/aeros |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
|
| https://github.com/8vasu |
| In Lib/test/test_pty.py, wrap | https://github.com/python/cpython/pull/22962/commits/4bb22ca70e8ca10a11d3c403ba57bd50d0687d2b |
| @expectedfailure | https://github.com/expectedfailure |
| to check if pty.STDIN_… | https://github.com/python/cpython/pull/22962/commits/4bb22ca70e8ca10a11d3c403ba57bd50d0687d2b |
| 4bb22ca | https://github.com/python/cpython/pull/22962/commits/4bb22ca70e8ca10a11d3c403ba57bd50d0687d2b |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| force-pushed | https://github.com/python/cpython/compare/057f14b4bec6ab75cb4937f7d20bdaf5ad1ca264..4bb22ca70e8ca10a11d3c403ba57bd50d0687d2b |
| 057f14b | https://github.com/python/cpython/commit/057f14b4bec6ab75cb4937f7d20bdaf5ad1ca264 |
| 4bb22ca | https://github.com/python/cpython/commit/4bb22ca70e8ca10a11d3c403ba57bd50d0687d2b |
|
Compare
| https://github.com/python/cpython/compare/057f14b4bec6ab75cb4937f7d20bdaf5ad1ca264..4bb22ca70e8ca10a11d3c403ba57bd50d0687d2b |
| October 25, 2020 07:36 | https://github.com/python/cpython/pull/22962#event-3917547762 |
|
| https://github.com/8vasu |
| In Lib/test/test_pty.py, add a check for "Darwin" in expectedFailureO… | https://github.com/python/cpython/pull/22962/commits/a8723e7f03ec12b8b57de65eb94ed176be4059f2 |
| a8723e7 | https://github.com/python/cpython/pull/22962/commits/a8723e7f03ec12b8b57de65eb94ed176be4059f2 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| force-pushed | https://github.com/python/cpython/compare/10f2db481f36db4bf6b1e67c63189cc913bb9571..a8723e7f03ec12b8b57de65eb94ed176be4059f2 |
| 10f2db4 | https://github.com/python/cpython/commit/10f2db481f36db4bf6b1e67c63189cc913bb9571 |
| a8723e7 | https://github.com/python/cpython/commit/a8723e7f03ec12b8b57de65eb94ed176be4059f2 |
|
Compare
| https://github.com/python/cpython/compare/10f2db481f36db4bf6b1e67c63189cc913bb9571..a8723e7f03ec12b8b57de65eb94ed176be4059f2 |
| October 25, 2020 08:37 | https://github.com/python/cpython/pull/22962#event-3917587897 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#event-3918986103 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-716325583 |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
🔨 test-with-buildbots
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22%3Ahammer%3A%20test-with-buildbots%22 |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#event-3918986189 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
|
Oct 26, 2020
| https://github.com/python/cpython/pull/22962#pullrequestreview-516483894 |
|
View reviewed changes
| https://github.com/python/cpython/pull/22962/files |
| gpshead | https://github.com/gpshead |
| https://github.com/python/cpython/pull/22962#pullrequestreview-516483894 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/gpshead |
| gpshead | https://github.com/gpshead |
| aeros | https://github.com/aeros |
| ethanfurman | https://github.com/ethanfurman |
| October 26, 2020 06:10 | https://github.com/python/cpython/pull/22962#event-3918999584 |
|
| https://github.com/8vasu |
| Remove some comments. | https://github.com/python/cpython/pull/22962/commits/26c092820366ba417027109ca98c0ce1cf44f165 |
| 26c0928 | https://github.com/python/cpython/pull/22962/commits/26c092820366ba417027109ca98c0ce1cf44f165 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| force-pushed | https://github.com/python/cpython/compare/2a3cba4d8e906af233fc22b1be648bae05e7f08b..26c092820366ba417027109ca98c0ce1cf44f165 |
| 2a3cba4 | https://github.com/python/cpython/commit/2a3cba4d8e906af233fc22b1be648bae05e7f08b |
| 26c0928 | https://github.com/python/cpython/commit/26c092820366ba417027109ca98c0ce1cf44f165 |
|
Compare
| https://github.com/python/cpython/compare/2a3cba4d8e906af233fc22b1be648bae05e7f08b..26c092820366ba417027109ca98c0ce1cf44f165 |
| October 26, 2020 14:16 | https://github.com/python/cpython/pull/22962#event-3920950981 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-716578847 |
| @gpshead | https://github.com/gpshead |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
|
Oct 26, 2020
| https://github.com/python/cpython/pull/22962#pullrequestreview-517156349 |
|
View reviewed changes
| https://github.com/python/cpython/pull/22962/files |
| aeros | https://github.com/aeros |
| https://github.com/python/cpython/pull/22962#pullrequestreview-517156349 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ethanfurman | https://github.com/ethanfurman |
| @Yhg1s | https://github.com/Yhg1s |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| aeros | https://github.com/aeros |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512262333 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512378793 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| aeros | https://github.com/aeros |
| Oct 30, 2020 | https://github.com/python/cpython/pull/22962#discussion_r515287206 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| aeros | https://github.com/aeros |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512264187 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512382328 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Misc/NEWS.d/next/Library/2020-10-26-14-17-44.bpo-41818.5MgaEc.rst | https://github.com/python/cpython/pull/22962/files#diff-1995b35c3c10c81a401449e0f02b93fb8a073650439801e9aa9d95d2fdd8dcfa |
| aeros | https://github.com/aeros |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512265078 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512382431 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| aeros | https://github.com/aeros |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512265419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512380285 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| aeros | https://github.com/aeros |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512266387 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @ethanfurman | https://github.com/ethanfurman |
| @Yhg1s | https://github.com/Yhg1s |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512379445 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512379928 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Nov 2, 2020 | https://github.com/python/cpython/pull/22962#discussion_r516174512 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| aeros | https://github.com/aeros |
| Oct 26, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512268312 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#discussion_r512377649 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| Oct 27, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-716947821 |
| @aeros | https://github.com/aeros |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/aeros |
| aeros | https://github.com/aeros |
| Yhg1s | https://github.com/Yhg1s |
| October 30, 2020 18:03 | https://github.com/python/cpython/pull/22962#event-3942495484 |
|
| https://github.com/8vasu |
| Restructure the tests, perform cleanup. | https://github.com/python/cpython/pull/22962/commits/9a6e70fc9c9d6108357583344a416d7c84159ed9 |
| 9a6e70f | https://github.com/python/cpython/pull/22962/commits/9a6e70fc9c9d6108357583344a416d7c84159ed9 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| force-pushed | https://github.com/python/cpython/compare/c431bd0c364db1d46458a46f0b06aa39cfa7a77c..9a6e70fc9c9d6108357583344a416d7c84159ed9 |
| c431bd0 | https://github.com/python/cpython/commit/c431bd0c364db1d46458a46f0b06aa39cfa7a77c |
| 9a6e70f | https://github.com/python/cpython/commit/9a6e70fc9c9d6108357583344a416d7c84159ed9 |
|
Compare
| https://github.com/python/cpython/compare/c431bd0c364db1d46458a46f0b06aa39cfa7a77c..9a6e70fc9c9d6108357583344a416d7c84159ed9 |
| November 2, 2020 21:47 | https://github.com/python/cpython/pull/22962#event-3950212320 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| Nov 2, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-720753600 |
| @aeros | https://github.com/aeros |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| November 2, 2020 16:16 | https://github.com/python/cpython/pull/22962#commits-pushed-f6d01f8 |
|
| https://github.com/8vasu |
| Restructure test_openpty(). | https://github.com/python/cpython/pull/22962/commits/f6d01f880083221d6abb2e6f8ead1077f57d52e3 |
| f6d01f8 | https://github.com/python/cpython/pull/22962/commits/f6d01f880083221d6abb2e6f8ead1077f57d52e3 |
|
| https://github.com/8vasu |
| Restructure test_openpty(). | https://github.com/python/cpython/pull/22962/commits/85f173b5ec29bf01ba23d314f8cd5683e0a613e1 |
| 85f173b | https://github.com/python/cpython/pull/22962/commits/85f173b5ec29bf01ba23d314f8cd5683e0a613e1 |
|
| https://github.com/8vasu |
| Restructure test_openpty(). | https://github.com/python/cpython/pull/22962/commits/654693818afd24d3d614440ac953c44d6e54de22 |
| 6546938 | https://github.com/python/cpython/pull/22962/commits/654693818afd24d3d614440ac953c44d6e54de22 |
| https://github.com/ethanfurman |
| ethanfurman | https://github.com/ethanfurman |
|
Nov 17, 2020
| https://github.com/python/cpython/pull/22962#pullrequestreview-532851824 |
|
View reviewed changes
| https://github.com/python/cpython/pull/22962/files |
| Lib/test/test_pty.py | https://github.com/python/cpython/pull/22962/files#diff-818ac3490d7146a2dcd2d9add58f5e8f12cc3c1fe752d4e5eb7986852f6bb80d |
| ethanfurman | https://github.com/ethanfurman |
| Nov 17, 2020 | https://github.com/python/cpython/pull/22962#discussion_r525555826 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Nov 19, 2020 | https://github.com/python/cpython/pull/22962#discussion_r526809064 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://pubs.opengroup.org/onlinepubs/9699919799/ | https://pubs.opengroup.org/onlinepubs/9699919799/ |
| https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/posix/isatty.c | https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/posix/isatty.c |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| ethanfurman | https://github.com/ethanfurman |
| Nov 20, 2020 | https://github.com/python/cpython/pull/22962#discussion_r527320071 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/8vasu |
| Nov 20, 2020 | https://github.com/python/cpython/pull/22962#discussion_r527736903 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
|
| https://github.com/8vasu |
| Remove/change some comments. | https://github.com/python/cpython/pull/22962/commits/0cde3f28ff866af19da331c1aace5439846dd21a |
| 0cde3f2 | https://github.com/python/cpython/pull/22962/commits/0cde3f28ff866af19da331c1aace5439846dd21a |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
| force-pushed | https://github.com/python/cpython/compare/4a3c962780f18d1513a206615920171f23fc1b92..0cde3f28ff866af19da331c1aace5439846dd21a |
| 4a3c962 | https://github.com/python/cpython/commit/4a3c962780f18d1513a206615920171f23fc1b92 |
| 0cde3f2 | https://github.com/python/cpython/commit/0cde3f28ff866af19da331c1aace5439846dd21a |
|
Compare
| https://github.com/python/cpython/compare/4a3c962780f18d1513a206615920171f23fc1b92..0cde3f28ff866af19da331c1aace5439846dd21a |
| November 20, 2020 14:39 | https://github.com/python/cpython/pull/22962#event-4021195861 |
|
| https://github.com/apps/blurb-it |
| 📜🤖 Added by blurb_it. | https://github.com/python/cpython/pull/22962/commits/e990b7980043f06789777f970111c11c41fe2588 |
| e990b79 | https://github.com/python/cpython/pull/22962/commits/e990b7980043f06789777f970111c11c41fe2588 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
|
Nov 24, 2020
| https://github.com/python/cpython/pull/22962#pullrequestreview-537119718 |
|
View reviewed changes
| https://github.com/python/cpython/pull/22962/files/e990b7980043f06789777f970111c11c41fe2588 |
| asvetlov | https://github.com/asvetlov |
| https://github.com/python/cpython/pull/22962#pullrequestreview-537119718 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @8vasu | https://github.com/8vasu |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Nov 24, 2020 | https://github.com/python/cpython/pull/22962#event-4031092433 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
| c13d899 | https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136 |
| Nov 25, 2020 | https://github.com/python/cpython/pull/22962#event-4038140002 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Nov 25, 2020 | https://github.com/python/cpython/pull/22962#event-4038140256 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Nov 25, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-733737565 |
| c13d899 | https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136 |
| the buildbot page in the devguide | https://devguide.python.org/buildbots/ |
| https://buildbot.python.org/all/#builders/464/builds/445 | https://buildbot.python.org/all/#builders/464/builds/445 |
| c13d899 | https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136 |
| https://buildbot.python.org/all/#builders/464/builds/445 | https://buildbot.python.org/all/#builders/464/builds/445 |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Nov 25, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-733744754 |
| c13d899 | https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136 |
| the buildbot page in the devguide | https://devguide.python.org/buildbots/ |
| https://buildbot.python.org/all/#builders/58/builds/442 | https://buildbot.python.org/all/#builders/58/builds/442 |
| c13d899 | https://github.com/python/cpython/commit/c13d89955d9a2942c6355d6839d7096323244136 |
| https://buildbot.python.org/all/#builders/58/builds/442 | https://buildbot.python.org/all/#builders/58/builds/442 |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
| Nov 25, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-733752255 |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/ethanfurman |
| ethanfurman | https://github.com/ethanfurman |
| Nov 25, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-733753187 |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
|
Nov 25, 2020
| https://github.com/python/cpython/pull/22962#ref-pullrequest-750896563 |
|
bpo-41818: test_openpty succeed on Gentoo, don't expect to fail on this platform
#23514
| https://github.com/python/cpython/pull/23514 |
| https://github.com/asvetlov |
| asvetlov | https://github.com/asvetlov |
| Nov 25, 2020 | https://github.com/python/cpython/pull/22962#issuecomment-733763131 |
| #23514 | https://github.com/python/cpython/pull/23514 |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
|
Nov 26, 2020
| https://github.com/python/cpython/pull/22962#ref-pullrequest-751889990 |
|
bpo-41818: Make test_openpty() avoid unexpected success due to number of rows and/or number of columns being == 0.
#23526
| https://github.com/python/cpython/pull/23526 |
| adorilson | https://github.com/adorilson |
|
Mar 13, 2021
| https://github.com/python/cpython/pull/22962#ref-commit-267725e |
|
| https://github.com/8vasu |
|
| https://github.com/adorilson |
| bpo-41818: Updated tests for the standard pty library ( | https://github.com/adorilson/cpython/commit/267725ebcef045f507b2ade86444db6ea9bdb15d |
| pythonGH-22962 | https://github.com/python/cpython/pull/22962 |
| ) | https://github.com/adorilson/cpython/commit/267725ebcef045f507b2ade86444db6ea9bdb15d |
| 267725e | https://github.com/adorilson/cpython/commit/267725ebcef045f507b2ade86444db6ea9bdb15d |
| https://github.com/8vasu |
| 8vasu | https://github.com/8vasu |
|
Aug 12, 2021
| https://github.com/python/cpython/pull/22962#ref-pullrequest-758972916 |
|
bpo-41818: Add termios.tcgetwinsize(), termios.tcsetwinsize(). Update docs.
#23686
| https://github.com/python/cpython/pull/23686 |
| https://github.com/python/cpython/pull/22962 |
| 8vasu | https://github.com/python/cpython/pull/22962 |
|
May 5, 2022
| https://github.com/python/cpython/pull/22962#ref-issue-1199043825 |
|
Lib/pty.py major revision
#85984
| https://github.com/python/cpython/issues/85984 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22962 |
|
| https://github.com/gpshead |
|
gpshead
| https://github.com/gpshead |
|
| https://github.com/python/cpython/pull/22962/files/2a3cba4d8e906af233fc22b1be648bae05e7f08b |
|
| https://github.com/ethanfurman |
|
ethanfurman
| https://github.com/ethanfurman |
|
| https://github.com/python/cpython/pull/22962/files/4a3c962780f18d1513a206615920171f23fc1b92 |
|
| https://github.com/asvetlov |
|
asvetlov
| https://github.com/asvetlov |
|
| https://github.com/python/cpython/pull/22962/files/e990b7980043f06789777f970111c11c41fe2588 |
|
| https://github.com/Yhg1s |
|
Yhg1s
| https://github.com/Yhg1s |
|
| https://github.com/aeros |
|
aeros
| https://github.com/aeros |
|
| https://github.com/python/cpython/pull/22962/files/c431bd0c364db1d46458a46f0b06aa39cfa7a77c |
|
tests
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3Atests |
| Please reload this page | https://github.com/python/cpython/pull/22962 |
|
| https://github.com/8vasu |
|
| https://github.com/bedevere-bot |
|
| https://github.com/asvetlov |
|
| https://github.com/ethanfurman |
|
| https://github.com/gpshead |
|
| https://github.com/aeros |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |