René's URL Explorer Experiment


Title: [3.9] bpo-27321 Fix email.generator.py to not replace a non-existent header. (GH-18074) by miss-islington · Pull Request #22796 · python/cpython · GitHub

Open Graph Title: [3.9] bpo-27321 Fix email.generator.py to not replace a non-existent header. (GH-18074) by miss-islington · Pull Request #22796 · python/cpython

X Title: [3.9] bpo-27321 Fix email.generator.py to not replace a non-existent header. (GH-18074) by miss-islington · Pull Request #22796 · python/cpython

Description: This PR replaces GH-1977. The reason for the replacement is two-fold. The fix itself is different is that if the CTE header doesn't exist in the original message, it is inserted. This is important because the new CTE could be quoted-printable whereas the original is implicit 8bit. Also the tests are different. The test_nonascii_as_string_without_cte test in GH-1977 doesn't actually test the issue in that it passes without the fix. The test_nonascii_as_string_without_content_type_and_cte test is improved here, and even though it doesn't fail without the fix, it is included for completeness. Automerge-Triggered-By: @warsaw (cherry picked from commit bf83822) Co-authored-by: Mark Sapiro mark@msapiro.net https://bugs.python.org/issue27321 Automerge-Triggered-By: @warsaw

Open Graph Description: This PR replaces GH-1977. The reason for the replacement is two-fold. The fix itself is different is that if the CTE header doesn't exist in the original message, it is inserted. This is import...

X Description: This PR replaces GH-1977. The reason for the replacement is two-fold. The fix itself is different is that if the CTE header doesn't exist in the original message, it is inserted. This is im...

Opengraph URL: https://github.com/python/cpython/pull/22796

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2982c750-cea6-9ad9-694b-f44c4a5b5de2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA8F8:308E6B:1CB42A:2941CC:6A4E66C7
html-safe-noncef4130a08c8645f07e68ba738867bd5060661ecf1af1e9dda4468b40e125576a1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEY4OjMwOEU2QjoxQ0I0MkE6Mjk0MUNDOjZBNEU2NkM3IiwidmlzaXRvcl9pZCI6Ijk4MjMxNDY1MDc5NTE0MDgwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7e47f2c77a8335913e5e24e37deb51db4d3027b49cb1181975eda91179ec187a
hovercard-subject-tagpull_request:506325376
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/22796/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altThis PR replaces GH-1977. The reason for the replacement is two-fold. The fix itself is different is that if the CTE header doesn't exist in the original message, it is inserted. This is import...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None41b6ab3ba6d20a71766ac245b5a4a94c6fc672a9cd4da7d44c1b33ab8bf6a21c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasee6a744804e8e70f97b4d5a18a94dcc63db22f97a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/22796/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22796%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22796%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/22796/files
Reloadhttps://github.com/python/cpython/pull/22796/files
Reloadhttps://github.com/python/cpython/pull/22796/files
Please reload this pagehttps://github.com/python/cpython/pull/22796/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/22796/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
miss-islingtonhttps://github.com/miss-islington
python:3.9https://github.com/python/cpython/tree/3.9
miss-islington:backport-bf83822-3.9https://github.com/miss-islington/cpython/tree/backport-bf83822-3.9
Conversation 1 https://github.com/python/cpython/pull/22796
Commits 1 https://github.com/python/cpython/pull/22796/commits
Checks 0 https://github.com/python/cpython/pull/22796/checks
Files changed https://github.com/python/cpython/pull/22796/files
Please reload this pagehttps://github.com/python/cpython/pull/22796/files
[3.9] bpo-27321 Fix email.generator.py to not replace a non-existent header. (GH-18074) https://github.com/python/cpython/pull/22796/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/22796/files
cab7a18 bpo-27321 Fix email.generator.py to not replace a non-existent header… msapiro Oct 19, 2020 https://github.com/python/cpython/pull/22796/commits/cab7a18c3c3fdef8bcb37d4c7f48a43fbff0b45a
Clear filters https://github.com/python/cpython/pull/22796/files
Please reload this pagehttps://github.com/python/cpython/pull/22796/files
Please reload this pagehttps://github.com/python/cpython/pull/22796/files
generator.py https://github.com/python/cpython/pull/22796/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
test_email.py https://github.com/python/cpython/pull/22796/files#diff-c145f46304ff3106c4dfb8e0d836ad084081f55b9fcaada70796ba5f1ff8cee0
2020-01-19-18-40-26.bpo-27321.8e6SpM.rst https://github.com/python/cpython/pull/22796/files#diff-fe4b946ae7ef1729af47cec57e45dfab37072b7383638d6b7774a6e6d35edf39
https://github.com/python/cpython/blob/3.9/.github/CODEOWNERS#L65
Lib/email/generator.pyhttps://github.com/python/cpython/pull/22796/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
View file https://github.com/miss-islington/cpython/blob/cab7a18c3c3fdef8bcb37d4c7f48a43fbff0b45a/Lib/email/generator.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22796/{{ revealButtonHref }}
https://github.com/python/cpython/pull/22796/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
https://github.com/python/cpython/pull/22796/files#diff-f3456051a56ce9da075c457c0db3a708d03973338ba5419e77fe0a80c10c50c3
https://github.com/python/cpython/blob/3.9/.github/CODEOWNERS#L65
Lib/test/test_email/test_email.pyhttps://github.com/python/cpython/pull/22796/files#diff-c145f46304ff3106c4dfb8e0d836ad084081f55b9fcaada70796ba5f1ff8cee0
View file https://github.com/miss-islington/cpython/blob/cab7a18c3c3fdef8bcb37d4c7f48a43fbff0b45a/Lib/test/test_email/test_email.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22796/{{ revealButtonHref }}
https://github.com/python/cpython/pull/22796/files#diff-c145f46304ff3106c4dfb8e0d836ad084081f55b9fcaada70796ba5f1ff8cee0
https://github.com/python/cpython/pull/22796/files#diff-c145f46304ff3106c4dfb8e0d836ad084081f55b9fcaada70796ba5f1ff8cee0
Misc/NEWS.d/next/Library/2020-01-19-18-40-26.bpo-27321.8e6SpM.rsthttps://github.com/python/cpython/pull/22796/files#diff-fe4b946ae7ef1729af47cec57e45dfab37072b7383638d6b7774a6e6d35edf39
View file https://github.com/miss-islington/cpython/blob/cab7a18c3c3fdef8bcb37d4c7f48a43fbff0b45a/Misc/NEWS.d/next/Library/2020-01-19-18-40-26.bpo-27321.8e6SpM.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22796/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.