René's URL Explorer Experiment


Title: [3.9] bpo-41631: _ast module uses again a global state (GH-21961) by pablogsal · Pull Request #22258 · python/cpython · GitHub

Open Graph Title: [3.9] bpo-41631: _ast module uses again a global state (GH-21961) by pablogsal · Pull Request #22258 · python/cpython

X Title: [3.9] bpo-41631: _ast module uses again a global state (GH-21961) by pablogsal · Pull Request #22258 · python/cpython

Description: Partially revert commit ac46eb4: "bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)". Using a module state per module instance is causing subtle practical problems. For example, the Mercurial project replaces the import() function to implement lazy import, whereas Python expected that "import _ast" always return a fully initialized _ast module. Add _PyAST_Fini() to clear the state at exit. The _ast module has no state (set _astmodule.m_size to 0). Remove astmodule_traverse(), astmodule_clear() and astmodule_free() functions.. (cherry picked from commit e5fbe0c) Co-authored-by: Victor Stinner vstinner@python.org https://bugs.python.org/issue41631

Open Graph Description: Partially revert commit ac46eb4: "bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)". Using a module state per module instance is causing subtle practical problems. For ex...

X Description: Partially revert commit ac46eb4: "bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)". Using a module state per module instance is causing subtle practical problems...

Opengraph URL: https://github.com/python/cpython/pull/22258

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:30d547f1-8dc8-cde7-0b82-941df24662fb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8CDE:1C7E2D:FF0ED7:1617294:696A94A9
html-safe-nonce0f8312a1903f4f706f48a784a9987f598c09ed91ace7f3d400afdfb0c6d89302
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0RFOjFDN0UyRDpGRjBFRDc6MTYxNzI5NDo2OTZBOTRBOSIsInZpc2l0b3JfaWQiOiIxMjc0OTI4NDAxODM0NzQyOTUzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac170e3420c321016f04b1257601118a8d8481f39b58f335f09998c97599e440a6
hovercard-subject-tagpull_request:487465863
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/22258/files
twitter:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/11718525?s=400&v=4
og:image:altPartially revert commit ac46eb4: "bpo-38113: Update the Python-ast.c generator to PEP384 (gh-15957)". Using a module state per module instance is causing subtle practical problems. For ex...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4dd496afc954da9c207b2d9fbe86e3074619f565754aa1d9274aec30d9e5b8d7
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release31496a13b80a2f6ad77d6c617ee2255a3545b539
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/22258/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22258%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F22258%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/22258/files
Reloadhttps://github.com/python/cpython/pull/22258/files
Reloadhttps://github.com/python/cpython/pull/22258/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/22258/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/22258/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:3.9https://github.com/python/cpython/tree/3.9
pablogsal:backport-e5fbe0c-3.9https://github.com/pablogsal/cpython/tree/backport-e5fbe0c-3.9
Conversation 0 https://github.com/python/cpython/pull/22258
Commits 1 https://github.com/python/cpython/pull/22258/commits
Checks 0 https://github.com/python/cpython/pull/22258/checks
Files changed https://github.com/python/cpython/pull/22258/files
Please reload this pagehttps://github.com/python/cpython/pull/22258/files
[3.9] bpo-41631: _ast module uses again a global state (GH-21961) https://github.com/python/cpython/pull/22258/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/22258/files
e4b2ec3 [3.9] bpo-41631: _ast module uses again a global state (GH-21961) vstinner Sep 15, 2020 https://github.com/python/cpython/pull/22258/commits/e4b2ec3d1069a563d180563284d675757b3f480a
Clear filters https://github.com/python/cpython/pull/22258/files
Please reload this pagehttps://github.com/python/cpython/pull/22258/files
Please reload this pagehttps://github.com/python/cpython/pull/22258/files
pycore_pylifecycle.h https://github.com/python/cpython/pull/22258/files#diff-654f110e8bb3ccaa35433482309c4552cd8d74958bfb8b780daa6222f8ab2859
ast.py https://github.com/python/cpython/pull/22258/files#diff-abeeed217a24ce3c21e15c2e32e2f0886cea69986c2641455c1eefc983c1f977
test_ast.py https://github.com/python/cpython/pull/22258/files#diff-3f516b60719dd445d33225e4f316b36e85c9c51a843a0147349d11a005c55937
2020-08-26-11-23-31.bpo-41631.3jZcd9.rst https://github.com/python/cpython/pull/22258/files#diff-749db0c679fbb07c07d2d034c607fcc39cc90bedb1123bf1d8972a55b9acb9e9
asdl_c.py https://github.com/python/cpython/pull/22258/files#diff-c4dd13901c011c278fe5b6d175fdd23ed94e51568fe6b2ee4215d5ab376be9a8
Python-ast.c https://github.com/python/cpython/pull/22258/files#diff-0258ad568d1bc0a5fa1c949351df0cc72a0a63441a1ed78c77d59f5695704857
pylifecycle.c https://github.com/python/cpython/pull/22258/files#diff-69223f5bb01f359a23246afbbf75b45c622e719424418d658674fbb6c2b36fad
Include/internal/pycore_pylifecycle.hhttps://github.com/python/cpython/pull/22258/files#diff-654f110e8bb3ccaa35433482309c4552cd8d74958bfb8b780daa6222f8ab2859
View file https://github.com/pablogsal/cpython/blob/e4b2ec3d1069a563d180563284d675757b3f480a/Include/internal/pycore_pylifecycle.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22258/{{ revealButtonHref }}
https://github.com/python/cpython/pull/22258/files#diff-654f110e8bb3ccaa35433482309c4552cd8d74958bfb8b780daa6222f8ab2859
https://github.com/python/cpython/pull/22258/files#diff-654f110e8bb3ccaa35433482309c4552cd8d74958bfb8b780daa6222f8ab2859
Lib/ast.pyhttps://github.com/python/cpython/pull/22258/files#diff-abeeed217a24ce3c21e15c2e32e2f0886cea69986c2641455c1eefc983c1f977
View file https://github.com/pablogsal/cpython/blob/e4b2ec3d1069a563d180563284d675757b3f480a/Lib/ast.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22258/{{ revealButtonHref }}
https://github.com/python/cpython/pull/22258/files#diff-abeeed217a24ce3c21e15c2e32e2f0886cea69986c2641455c1eefc983c1f977
https://github.com/python/cpython/pull/22258/files#diff-abeeed217a24ce3c21e15c2e32e2f0886cea69986c2641455c1eefc983c1f977
https://github.com/python/cpython/pull/22258/files#diff-abeeed217a24ce3c21e15c2e32e2f0886cea69986c2641455c1eefc983c1f977
https://github.com/python/cpython/pull/22258/files#diff-abeeed217a24ce3c21e15c2e32e2f0886cea69986c2641455c1eefc983c1f977
Lib/test/test_ast.pyhttps://github.com/python/cpython/pull/22258/files#diff-3f516b60719dd445d33225e4f316b36e85c9c51a843a0147349d11a005c55937
View file https://github.com/pablogsal/cpython/blob/e4b2ec3d1069a563d180563284d675757b3f480a/Lib/test/test_ast.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22258/{{ revealButtonHref }}
https://github.com/python/cpython/pull/22258/files#diff-3f516b60719dd445d33225e4f316b36e85c9c51a843a0147349d11a005c55937
https://github.com/python/cpython/pull/22258/files#diff-3f516b60719dd445d33225e4f316b36e85c9c51a843a0147349d11a005c55937
https://github.com/python/cpython/pull/22258/files#diff-3f516b60719dd445d33225e4f316b36e85c9c51a843a0147349d11a005c55937
Misc/NEWS.d/next/Core and Builtins/2020-08-26-11-23-31.bpo-41631.3jZcd9.rsthttps://github.com/python/cpython/pull/22258/files#diff-749db0c679fbb07c07d2d034c607fcc39cc90bedb1123bf1d8972a55b9acb9e9
View file https://github.com/pablogsal/cpython/blob/e4b2ec3d1069a563d180563284d675757b3f480a/Misc/NEWS.d/next/Core%20and%20Builtins/2020-08-26-11-23-31.bpo-41631.3jZcd9.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22258/{{ revealButtonHref }}
Parser/asdl_c.pyhttps://github.com/python/cpython/pull/22258/files#diff-c4dd13901c011c278fe5b6d175fdd23ed94e51568fe6b2ee4215d5ab376be9a8
View file https://github.com/pablogsal/cpython/blob/e4b2ec3d1069a563d180563284d675757b3f480a/Parser/asdl_c.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/22258/{{ revealButtonHref }}
https://github.com/python/cpython/pull/22258/files#diff-c4dd13901c011c278fe5b6d175fdd23ed94e51568fe6b2ee4215d5ab376be9a8
https://github.com/python/cpython/pull/22258/files#diff-c4dd13901c011c278fe5b6d175fdd23ed94e51568fe6b2ee4215d5ab376be9a8
https://github.com/python/cpython/pull/22258/files#diff-c4dd13901c011c278fe5b6d175fdd23ed94e51568fe6b2ee4215d5ab376be9a8
https://github.com/python/cpython/pull/22258/files#diff-c4dd13901c011c278fe5b6d175fdd23ed94e51568fe6b2ee4215d5ab376be9a8
Please reload this pagehttps://github.com/python/cpython/pull/22258/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.