René's URL Explorer Experiment


Title: bpo-41631: Check that importing _ast returns the right module by encukou · Pull Request #21973 · python/cpython · GitHub

Open Graph Title: bpo-41631: Check that importing _ast returns the right module by encukou · Pull Request #21973 · python/cpython

X Title: bpo-41631: Check that importing _ast returns the right module by encukou · Pull Request #21973 · python/cpython

Description: Hopefully #21961 will be OK, but if not: here is a relatively minimal fix for bpo-41631, which basically makes compiling to/from AST fail gracefully (with a proper exception rather than a NULL with...

Open Graph Description: Hopefully #21961 will be OK, but if not: here is a relatively minimal fix for bpo-41631, which basically makes compiling to/from AST fail gracefully (with a proper exception rather than a NULL with...

X Description: Hopefully #21961 will be OK, but if not: here is a relatively minimal fix for bpo-41631, which basically makes compiling to/from AST fail gracefully (with a proper exception rather than a NULL with...

Opengraph URL: https://github.com/python/cpython/pull/21973

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d5062177-adb5-36cb-86b8-2659cd46e8a4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id83AA:1D772C:8B3CB:BCA00:696A9E83
html-safe-nonce3af1c92b3833b30bb7bebe29f0d6eb47890fdc757c0127bbc655d1d3b9de3b32
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4M0FBOjFENzcyQzo4QjNDQjpCQ0EwMDo2OTZBOUU4MyIsInZpc2l0b3JfaWQiOiIxNzUyMDEwNTczMDUwNzE1Nzc5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac46aaa96ccb9c5fdccefcfb12cdeb57288297eb68b81ddefd3aaa18d133c7d47a
hovercard-subject-tagpull_request:474360785
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/21973/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5e3900e9ef95b7324b5bc560968eaee90c664a49530285117059d21ab7e7d541/python/cpython/pull/21973
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5e3900e9ef95b7324b5bc560968eaee90c664a49530285117059d21ab7e7d541/python/cpython/pull/21973
og:image:altHopefully #21961 will be OK, but if not: here is a relatively minimal fix for bpo-41631, which basically makes compiling to/from AST fail gracefully (with a proper exception rather than a NULL with...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
Nonec0d8175e41e0e55b9e984c935b24b808cabab919dd3174aa45dac3ef503ed1af
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release99aab454e5ddc8df30805fb76c114c3008a15842
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/21973#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21973
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21973
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/21973
Reloadhttps://github.com/python/cpython/pull/21973
Reloadhttps://github.com/python/cpython/pull/21973
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/21973
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/21973
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/21973#issue-comment-box
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:check-ast-module-def_masterhttps://github.com/encukou/cpython/tree/check-ast-module-def_master
bpo-41631: Check that importing _ast returns the right module https://github.com/python/cpython/pull/21973#top
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:check-ast-module-def_masterhttps://github.com/encukou/cpython/tree/check-ast-module-def_master
Conversation 4 https://github.com/python/cpython/pull/21973
Commits 4 https://github.com/python/cpython/pull/21973/commits
Checks 0 https://github.com/python/cpython/pull/21973/checks
Files changed https://github.com/python/cpython/pull/21973/files
Please reload this pagehttps://github.com/python/cpython/pull/21973
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
Aug 26, 2020https://github.com/python/cpython/pull/21973#issue-686835143
Please reload this pagehttps://github.com/python/cpython/pull/21973
#21961https://github.com/python/cpython/pull/21961
bpo-41631https://bugs.python.org/issue41631
https://bugs.python.org/issue41631https://bugs.python.org/issue41631
Please reload this pagehttps://github.com/python/cpython/pull/21973
encukouhttps://github.com/encukou
August 27, 2020 01:00https://github.com/python/cpython/pull/21973#commits-pushed-08486b2
https://github.com/encukou
bpo-41631: Check that importing _ast returns the right modulehttps://github.com/python/cpython/pull/21973/commits/08486b2423332cc20becde6f24359872685eb64a
08486b2https://github.com/python/cpython/pull/21973/commits/08486b2423332cc20becde6f24359872685eb64a
https://github.com/encukou
Work around a hack in pegen's tests, an extension that must be treate…https://github.com/python/cpython/pull/21973/commits/2c36b77cd1a4f3908851c40ae8171fc2e65f3ace
2c36b77https://github.com/python/cpython/pull/21973/commits/2c36b77cd1a4f3908851c40ae8171fc2e65f3ace
https://github.com/encukou
encukouhttps://github.com/encukou
lysnikolaouhttps://github.com/lysnikolaou
pablogsalhttps://github.com/pablogsal
code ownershttps://github.com/python/cpython/blob/82e79480d6e61940d7007d9026fbff0b1a11ad9a/.github/CODEOWNERS#L76
August 26, 2020 23:58https://github.com/python/cpython/pull/21973#event-3697019265
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 26, 2020https://github.com/python/cpython/pull/21973#event-3697019356
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 26, 2020https://github.com/python/cpython/pull/21973#event-3697019421
https://github.com/encukou
encukouhttps://github.com/encukou
Sep 8, 2020https://github.com/python/cpython/pull/21973#issuecomment-688810005
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/21973
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Sep 8, 2020https://github.com/python/cpython/pull/21973#issuecomment-689091420
@pablogsalhttps://github.com/pablogsal
Please reload this pagehttps://github.com/python/cpython/pull/21973
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Sep 8, 2020 https://github.com/python/cpython/pull/21973#pullrequestreview-484436696
View reviewed changes https://github.com/python/cpython/pull/21973/files/2c36b77cd1a4f3908851c40ae8171fc2e65f3ace
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Sep 8, 2020https://github.com/python/cpython/pull/21973#event-3742514464
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
Sep 8, 2020 https://github.com/python/cpython/pull/21973#pullrequestreview-484437334
View reviewed changes https://github.com/python/cpython/pull/21973/files/2c36b77cd1a4f3908851c40ae8171fc2e65f3ace
Tools/peg_generator/pegen/build.pyhttps://github.com/python/cpython/pull/21973/files/2c36b77cd1a4f3908851c40ae8171fc2e65f3ace#diff-476cab90bd9f052e2ca52fc323d61913145493cfabeda68fff8feeb086728a9a
Please reload this pagehttps://github.com/python/cpython/pull/21973
encukouhttps://github.com/encukou
September 9, 2020 10:38https://github.com/python/cpython/pull/21973#commits-pushed-be66256
https://github.com/encukou
https://github.com/pablogsal
Update Tools/peg_generator/pegen/build.pyhttps://github.com/python/cpython/pull/21973/commits/be66256655114d353763a7b2ecd1f5e8d5581d5b
be66256https://github.com/python/cpython/pull/21973/commits/be66256655114d353763a7b2ecd1f5e8d5581d5b
https://github.com/encukou
Don't mention "segfault" from the blurbhttps://github.com/python/cpython/pull/21973/commits/a95c6f73fa5daadfe882242261a697cf7f468058
a95c6f7https://github.com/python/cpython/pull/21973/commits/a95c6f73fa5daadfe882242261a697cf7f468058
https://github.com/encukou
encukouhttps://github.com/encukou
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
Sep 10, 2020https://github.com/python/cpython/pull/21973#event-3750957448
https://github.com/encukou
encukouhttps://github.com/encukou
vstinnerhttps://github.com/vstinner
September 10, 2020 13:11https://github.com/python/cpython/pull/21973#event-3750960599
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 11, 2020 https://github.com/python/cpython/pull/21973#ref-pullrequest-686163380
bpo-41631: _ast module uses again a global state #21961 https://github.com/python/cpython/pull/21961
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 16, 2020https://github.com/python/cpython/pull/21973#issuecomment-693306046
Please reload this pagehttps://github.com/python/cpython/pull/21973
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Sep 16, 2020https://github.com/python/cpython/pull/21973#event-3772402736
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21973
https://github.com/pablogsal
pablogsal https://github.com/pablogsal
https://github.com/python/cpython/pull/21973/files/2c36b77cd1a4f3908851c40ae8171fc2e65f3ace
https://github.com/lysnikolaou
lysnikolaou https://github.com/lysnikolaou
https://github.com/vstinner
vstinner https://github.com/vstinner
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Please reload this pagehttps://github.com/python/cpython/pull/21973
https://github.com/encukou
https://github.com/pablogsal
https://github.com/vstinner
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.