René's URL Explorer Experiment


Title: [3.5] bpo-39603: Prevent header injection in http methods (GH-18485) by vstinner · Pull Request #21946 · python/cpython · GitHub

Open Graph Title: [3.5] bpo-39603: Prevent header injection in http methods (GH-18485) by vstinner · Pull Request #21946 · python/cpython

X Title: [3.5] bpo-39603: Prevent header injection in http methods (GH-18485) by vstinner · Pull Request #21946 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: reject control chars in http method in http.client.putrequest to prevent http header injection (cherry picked from commit 8ca8a2e) https://bugs.python.org/issue39603

X Description: reject control chars in http method in http.client.putrequest to prevent http header injection (cherry picked from commit 8ca8a2e) https://bugs.python.org/issue39603

Opengraph URL: https://github.com/python/cpython/pull/21946

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:46c7f8ce-f735-3711-a543-96c045aa6b9f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBECC:1FFDFF:67B7417:9178BC2:6A505253
html-safe-noncecedb5bf5801e75c72bf02b18d1c592ea1af66cb3269b9bc4a2093728097a6478
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUNDOjFGRkRGRjo2N0I3NDE3OjkxNzhCQzI6NkE1MDUyNTMiLCJ2aXNpdG9yX2lkIjoiODkzNDQwNzMyNjE1ODMxMjAxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace4d817640a286593f008b32d83482bc1f8e012658fef5f42e4e7682044c1c497
hovercard-subject-tagpull_request:472611458
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/21946/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/8ecd2a0da998318b61a3bcc36960ac581572bd3c0128d9bc6c30d81d19d7ae56/python/cpython/pull/21946
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8ecd2a0da998318b61a3bcc36960ac581572bd3c0128d9bc6c30d81d19d7ae56/python/cpython/pull/21946
og:image:altreject control chars in http method in http.client.putrequest to prevent http header injection (cherry picked from commit 8ca8a2e) https://bugs.python.org/issue39603
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevstinner
hostnamegithub.com
expected-hostnamegithub.com
Noned6dc8294eb500fa36bbc57472d61fe87c522f9c3c1d64f70f4926f66a66a7efb
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release5741a45fe07e5f377d0d4c524a92e3056acc51bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/21946#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21946
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21946
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/21946
Reloadhttps://github.com/python/cpython/pull/21946
Reloadhttps://github.com/python/cpython/pull/21946
Please reload this pagehttps://github.com/python/cpython/pull/21946
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/21946
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
larryhastingshttps://github.com/larryhastings
python:3.5https://github.com/python/cpython/tree/3.5
Conversationhttps://github.com/python/cpython/pull/21946
Commits1 (1)https://github.com/python/cpython/pull/21946/commits
Checkshttps://github.com/python/cpython/pull/21946/checks
Files changedhttps://github.com/python/cpython/pull/21946/files
[3.5] bpo-39603: Prevent header injection in http methods (GH-18485)https://github.com/python/cpython/pull/21946#top
larryhastingshttps://github.com/larryhastings
python:3.5https://github.com/python/cpython/tree/3.5
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 24, 2020https://github.com/python/cpython/pull/21946#issue-684779051
Please reload this pagehttps://github.com/python/cpython/pull/21946
8ca8a2ehttps://github.com/python/cpython/commit/8ca8a2e8fb068863c1138f07e3098478ef8be12e
https://bugs.python.org/issue39603https://bugs.python.org/issue39603
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/amiremohamadi
https://github.com/vstinner
bpo-39603https://bugs.python.org/issue?@action=redirect&bpo=39603
: Prevent header injection in http methods (https://github.com/python/cpython/pull/21946/commits/20d60478628e43c933b9262acb3b6fdd061be206
GH-18485https://github.com/python/cpython/pull/18485
)https://github.com/python/cpython/pull/21946/commits/20d60478628e43c933b9262acb3b6fdd061be206
20d6047https://github.com/python/cpython/pull/21946/commits/20d60478628e43c933b9262acb3b6fdd061be206
8ca8a2ehttps://github.com/python/cpython/commit/8ca8a2e8fb068863c1138f07e3098478ef8be12e
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 24, 2020https://github.com/python/cpython/pull/21946#event-3686104826
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 24, 2020https://github.com/python/cpython/pull/21946#event-3686105084
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 24, 2020 https://github.com/python/cpython/pull/21946#ref-pullrequest-564015860
bpo-39603: Prevent header injection in http methods #18485 https://github.com/python/cpython/pull/18485
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 24, 2020https://github.com/python/cpython/pull/21946#issuecomment-679211935
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/alex
alexhttps://github.com/alex
Aug 24, 2020 https://github.com/python/cpython/pull/21946#pullrequestreview-473635708
View reviewed changes https://github.com/python/cpython/pull/21946/files/20d60478628e43c933b9262acb3b6fdd061be206
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Aug 24, 2020https://github.com/python/cpython/pull/21946#event-3686118844
https://github.com/jaraco
jaracohttps://github.com/jaraco
Aug 24, 2020 https://github.com/python/cpython/pull/21946#pullrequestreview-473636254
View reviewed changes https://github.com/python/cpython/pull/21946/files/20d60478628e43c933b9262acb3b6fdd061be206
jaracohttps://github.com/jaraco
https://github.com/python/cpython/pull/21946#pullrequestreview-473636254
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/orsenthil
orsenthilhttps://github.com/orsenthil
Aug 24, 2020 https://github.com/python/cpython/pull/21946#pullrequestreview-473651417
View reviewed changes https://github.com/python/cpython/pull/21946/files/20d60478628e43c933b9262acb3b6fdd061be206
orsenthilhttps://github.com/orsenthil
https://github.com/python/cpython/pull/21946#pullrequestreview-473651417
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
Aug 24, 2020https://github.com/python/cpython/pull/21946#issuecomment-679228622
@larryhastingshttps://github.com/larryhastings
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/larryhastings
larryhastingshttps://github.com/larryhastings
524b8dehttps://github.com/python/cpython/commit/524b8de630036a29ca340bc2ae6fd6dc7dda8f40
Sep 4, 2020https://github.com/python/cpython/pull/21946#event-3727361124
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Sep 4, 2020https://github.com/python/cpython/pull/21946#issuecomment-686837603
@larryhastingshttps://github.com/larryhastings
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Sep 4, 2020https://github.com/python/cpython/pull/21946#event-3727361204
https://github.com/larryhastings
larryhastingshttps://github.com/larryhastings
Sep 4, 2020https://github.com/python/cpython/pull/21946#issuecomment-686837681
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/vstinner
vstinnerhttps://github.com/vstinner
September 4, 2020 09:44https://github.com/python/cpython/pull/21946#event-3728918400
https://github.com/stratakis
stratakishttps://github.com/stratakis
Sep 29, 2020 https://github.com/python/cpython/pull/21946#ref-pullrequest-711177795
2.7: Switch to importpatches fedora-python/cpython#17 https://github.com/fedora-python/cpython/pull/17
encukouhttps://github.com/encukou
Sep 30, 2020 https://github.com/python/cpython/pull/21946#ref-commit-2da5f0e
https://github.com/amiremohamadi
https://github.com/encukou
00354-https://github.com/encukou/cpython/commit/2da5f0eb5fbcde721fef36ff7e9d1f67c18bcdf7
cve-2020-26116https://github.com/advisories/GHSA-w7gf-rpqw-gx4f
-http-request-method-crlf-injection-in-httplib.patchhttps://github.com/encukou/cpython/commit/2da5f0eb5fbcde721fef36ff7e9d1f67c18bcdf7
2da5f0ehttps://github.com/encukou/cpython/commit/2da5f0eb5fbcde721fef36ff7e9d1f67c18bcdf7
https://bugs.python.org/issue39603https://bugs.python.org/issue39603
python#18485https://github.com/python/cpython/pull/18485
python#21946https://github.com/python/cpython/pull/21946
hroncokhttps://github.com/hroncok
Apr 19, 2021 https://github.com/python/cpython/pull/21946#ref-commit-4190ca2
https://github.com/amiremohamadi
https://github.com/hroncok
00354-https://github.com/fedora-python/cpython/commit/4190ca263b3092f35e9c3a328cf0d29ca1e20691
cve-2020-26116https://github.com/advisories/GHSA-w7gf-rpqw-gx4f
-http-request-method-crlf-injection-in-httplib.patchhttps://github.com/fedora-python/cpython/commit/4190ca263b3092f35e9c3a328cf0d29ca1e20691
4190ca2https://github.com/fedora-python/cpython/commit/4190ca263b3092f35e9c3a328cf0d29ca1e20691
https://bugs.python.org/issue39603https://bugs.python.org/issue39603
python#18485https://github.com/python/cpython/pull/18485
python#21946https://github.com/python/cpython/pull/21946
hroncokhttps://github.com/hroncok
May 19, 2021 https://github.com/python/cpython/pull/21946#ref-commit-4c025e5
https://github.com/amiremohamadi
https://github.com/hroncok
00354-https://github.com/fedora-python/cpython/commit/4c025e5f936beb3ea651d68039f574330220f6bf
cve-2020-26116https://github.com/advisories/GHSA-w7gf-rpqw-gx4f
-http-request-method-crlf-injection-in-httplib.patchhttps://github.com/fedora-python/cpython/commit/4c025e5f936beb3ea651d68039f574330220f6bf
4c025e5https://github.com/fedora-python/cpython/commit/4c025e5f936beb3ea651d68039f574330220f6bf
https://bugs.python.org/issue39603https://bugs.python.org/issue39603
python#18485https://github.com/python/cpython/pull/18485
python#21946https://github.com/python/cpython/pull/21946
stratakishttps://github.com/stratakis
Jul 18, 2022 https://github.com/python/cpython/pull/21946#ref-commit-b8ea6b6
https://github.com/amiremohamadi
https://github.com/stratakis
00354-https://github.com/stratakis/cpython/commit/b8ea6b6721af0bc5382bd265fbc0f5e0d67f725f
cve-2020-26116https://github.com/advisories/GHSA-w7gf-rpqw-gx4f
-http-request-method-crlf-injection-in-httplib.patchhttps://github.com/stratakis/cpython/commit/b8ea6b6721af0bc5382bd265fbc0f5e0d67f725f
b8ea6b6https://github.com/stratakis/cpython/commit/b8ea6b6721af0bc5382bd265fbc0f5e0d67f725f
https://bugs.python.org/issue39603https://bugs.python.org/issue39603
python#18485https://github.com/python/cpython/pull/18485
python#21946https://github.com/python/cpython/pull/21946
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21946
https://github.com/alex
alex https://github.com/alex
https://github.com/python/cpython/pull/21946/files/20d60478628e43c933b9262acb3b6fdd061be206
https://github.com/jaraco
jaraco https://github.com/jaraco
https://github.com/python/cpython/pull/21946/files/20d60478628e43c933b9262acb3b6fdd061be206
https://github.com/orsenthil
orsenthil https://github.com/orsenthil
https://github.com/python/cpython/pull/21946/files/20d60478628e43c933b9262acb3b6fdd061be206
Please reload this pagehttps://github.com/python/cpython/pull/21946
https://github.com/vstinner
https://github.com/bedevere-bot
https://github.com/larryhastings
https://github.com/alex
https://github.com/jaraco
https://github.com/orsenthil
https://github.com/the-knights-who-say-ni
https://github.com/amiremohamadi
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.