René's URL Explorer Experiment


Title: bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0 by elprans · Pull Request #21895 · python/cpython · GitHub

Open Graph Title: bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0 by elprans · Pull Request #21895 · python/cpython

X Title: bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0 by elprans · Pull Request #21895 · python/cpython

Description: The Python programming language. Contribute to python/cpython development by creating an account on GitHub.

Open Graph Description: When I was fixing bpo-32751 back in GH-7216 I missed the case when timeout is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency. https://bugs.python.o...

X Description: When I was fixing bpo-32751 back in GH-7216 I missed the case when timeout is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency. https://bugs.python.o...

Opengraph URL: https://github.com/python/cpython/pull/21895

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c8da18e-1112-98ba-87b3-b459746fc4bb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80F6:37A47B:8D731:E99A9:6A59EF4B
html-safe-nonceac0cf5db15ca8bb06509699406ea7a3f03911e4cef1acf30d22791c90e57a0d2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MEY2OjM3QTQ3Qjo4RDczMTpFOTlBOTo2QTU5RUY0QiIsInZpc2l0b3JfaWQiOiI4NjI5MjUwNjI5OTIyNTgyMzQ3IiwicmVnaW9uX2VkZ2UiOiJ3ZXN0dXMyIiwicmVnaW9uX3JlbmRlciI6Indlc3R1czIifQ==
visitor-hmacc9282a4488a6eb69b9ae40771261152ca610b7a95c5c89bf128d36f37aedc6f6
hovercard-subject-tagpull_request:468373159
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/21895/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/af94b3c66173212fe6d87719bd5b4b0e6c6678100386e2c2ad74575e5dc49e4b/python/cpython/pull/21895
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/af94b3c66173212fe6d87719bd5b4b0e6c6678100386e2c2ad74575e5dc49e4b/python/cpython/pull/21895
og:image:altWhen I was fixing bpo-32751 back in GH-7216 I missed the case when timeout is zero or negative. This takes care of that. Props to @aaliddell for noticing the inconsistency. https://bugs.python.o...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelprans
hostnamegithub.com
expected-hostnamegithub.com
Noneba3976babb66479b1c943a8edc0777d96157da48fadc0161f9ddb219deee8353
turbo-cache-controlno-cache
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release32bf0b7849e1b6561059cca2cb03568251960859
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/21895#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21895
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21895
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/21895
Reloadhttps://github.com/python/cpython/pull/21895
Reloadhttps://github.com/python/cpython/pull/21895
Please reload this pagehttps://github.com/python/cpython/pull/21895
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/21895
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
elprans:asyncio-fix-wait-for-cancellation-timeout-0https://github.com/elprans/cpython/tree/asyncio-fix-wait-for-cancellation-timeout-0
Conversationhttps://github.com/python/cpython/pull/21895
Commits1 (1)https://github.com/python/cpython/pull/21895/commits
Checkshttps://github.com/python/cpython/pull/21895/checks
Files changedhttps://github.com/python/cpython/pull/21895/files
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0https://github.com/python/cpython/pull/21895#top
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
elprans:asyncio-fix-wait-for-cancellation-timeout-0https://github.com/elprans/cpython/tree/asyncio-fix-wait-for-cancellation-timeout-0
https://github.com/elprans
elpranshttps://github.com/elprans
Aug 15, 2020https://github.com/python/cpython/pull/21895#issue-679654874
Please reload this pagehttps://github.com/python/cpython/pull/21895
bpo-32751https://bugs.python.org/issue32751
GH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
https://bugs.python.org/issue32751https://bugs.python.org/issue32751
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/elprans
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <= 0https://github.com/python/cpython/pull/21895/commits/debcf3e86545499258b6a55bee97f351760a9f14
debcf3ehttps://github.com/python/cpython/pull/21895/commits/debcf3e86545499258b6a55bee97f351760a9f14
pythonGH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
https://github.com/elprans
elpranshttps://github.com/elprans
1st1https://github.com/1st1
asvetlovhttps://github.com/asvetlov
code ownershttps://github.com/python/cpython/blob/39dab24621122338d01c1219bb0acc46ba9c9956/.github/CODEOWNERS#L8
August 15, 2020 22:54https://github.com/python/cpython/pull/21895#event-3658887184
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
Aug 15, 2020https://github.com/python/cpython/pull/21895#event-3658887209
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 15, 2020https://github.com/python/cpython/pull/21895#event-3658887231
https://github.com/1st1
1st1https://github.com/1st1
Aug 18, 2020 https://github.com/python/cpython/pull/21895#pullrequestreview-469714707
View reviewed changes https://github.com/python/cpython/pull/21895/files/debcf3e86545499258b6a55bee97f351760a9f14
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22
Aug 18, 2020https://github.com/python/cpython/pull/21895#event-3667588043
https://github.com/1st1
1st1https://github.com/1st1
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Aug 18, 2020https://github.com/python/cpython/pull/21895#event-3667588482
https://github.com/1st1
1st1https://github.com/1st1
Aug 18, 2020https://github.com/python/cpython/pull/21895#event-3667588769
https://github.com/1st1
1st1https://github.com/1st1
Aug 18, 2020https://github.com/python/cpython/pull/21895#event-3667588919
https://github.com/1st1
1st1https://github.com/1st1
Aug 18, 2020https://github.com/python/cpython/pull/21895#issuecomment-675639843
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/1st1
1st1https://github.com/1st1
c517fc7https://github.com/python/cpython/commit/c517fc712105c8e5930cb42baaebdbe37fc3e15f
Aug 26, 2020https://github.com/python/cpython/pull/21895#event-3695697788
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 26, 2020https://github.com/python/cpython/pull/21895#issuecomment-680994628
@elpranshttps://github.com/elprans
@1st1https://github.com/1st1
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 26, 2020https://github.com/python/cpython/pull/21895#issuecomment-680994629
@1st1https://github.com/1st1
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
Aug 26, 2020https://github.com/python/cpython/pull/21895#event-3695698015
miss-islingtonhttps://github.com/miss-islington
Aug 26, 2020 https://github.com/python/cpython/pull/21895#ref-commit-28b017a
https://github.com/elprans
https://github.com/miss-islington
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <=…https://github.com/miss-islington/cpython/commit/28b017a1423f70a63c8da7ae0c785b2d440e6529
28b017ahttps://github.com/miss-islington/cpython/commit/28b017a1423f70a63c8da7ae0c785b2d440e6529
pythonGH-21895https://github.com/python/cpython/pull/21895
pythonGH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
c517fc7https://github.com/miss-islington/cpython/commit/c517fc712105c8e5930cb42baaebdbe37fc3e15f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 26, 2020https://github.com/python/cpython/pull/21895#issuecomment-680994886
GH-21963https://github.com/python/cpython/pull/21963
3.9 branchhttps://github.com/python/cpython/tree/3.9
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
Aug 26, 2020https://github.com/python/cpython/pull/21895#event-3695699993
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 26, 2020https://github.com/python/cpython/pull/21895#issuecomment-680994914
@elpranshttps://github.com/elprans
@1st1https://github.com/1st1
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
1st1https://github.com/1st1
Aug 26, 2020https://github.com/python/cpython/pull/21895#event-3695700292
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
Aug 26, 2020https://github.com/python/cpython/pull/21895#issuecomment-680994938
@elpranshttps://github.com/elprans
@1st1https://github.com/1st1
cherry_pickerhttps://pypi.org/project/cherry-picker/
Please reload this pagehttps://github.com/python/cpython/pull/21895
ambvhttps://github.com/ambv
Aug 26, 2020 https://github.com/python/cpython/pull/21895#ref-commit-1036ccb
https://github.com/miss-islington
https://github.com/elprans
bpo-32751https://bugs.python.org/issue?@action=redirect&bpo=32751
: Wait for task cancel in asyncio.wait_for() when timeout <=…https://github.com/python/cpython/commit/1036ccb55de4abc70837cb46a72ddbb370b8fc94
1036ccbhttps://github.com/python/cpython/commit/1036ccb55de4abc70837cb46a72ddbb370b8fc94
GH-21895https://github.com/python/cpython/pull/21895
GH-21963https://github.com/python/cpython/pull/21963
bpo-32751https://bugs.python.org/issue?@action=redirect&bpo=32751
GH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
c517fc7https://github.com/python/cpython/commit/c517fc712105c8e5930cb42baaebdbe37fc3e15f
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 26, 2020https://github.com/python/cpython/pull/21895#issuecomment-681059425
GH-21967https://github.com/python/cpython/pull/21967
3.8 branchhttps://github.com/python/cpython/tree/3.8
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.8 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.8%22
Aug 26, 2020https://github.com/python/cpython/pull/21895#event-3696166594
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
Aug 26, 2020https://github.com/python/cpython/pull/21895#issuecomment-681063594
GH-21968https://github.com/python/cpython/pull/21968
3.7 branchhttps://github.com/python/cpython/tree/3.7
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
Aug 26, 2020https://github.com/python/cpython/pull/21895#event-3696197057
elpranshttps://github.com/elprans
Aug 26, 2020 https://github.com/python/cpython/pull/21895#ref-commit-e248174
https://github.com/elprans
[3.7] bpo-32751: Wait for task cancel in asyncio.wait_for() when time…https://github.com/elprans/cpython/commit/e248174ca4a34d492bb375cf9bec14fa4205c3d6
e248174https://github.com/elprans/cpython/commit/e248174ca4a34d492bb375cf9bec14fa4205c3d6
pythonGH-21895https://github.com/python/cpython/pull/21895
pythonGH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
c517fc7https://github.com/elprans/cpython/commit/c517fc712105c8e5930cb42baaebdbe37fc3e15f
elpranshttps://github.com/elprans
Aug 26, 2020 https://github.com/python/cpython/pull/21895#ref-commit-e6387ad
https://github.com/elprans
[3.8] bpo-32751: Wait for task cancel in asyncio.wait_for() when time…https://github.com/elprans/cpython/commit/e6387ad23af621044ca560a076ef44d392feabca
e6387adhttps://github.com/elprans/cpython/commit/e6387ad23af621044ca560a076ef44d392feabca
pythonGH-21895https://github.com/python/cpython/pull/21895
pythonGH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
c517fc7https://github.com/elprans/cpython/commit/c517fc712105c8e5930cb42baaebdbe37fc3e15f
1st1https://github.com/1st1
Aug 26, 2020 https://github.com/python/cpython/pull/21895#ref-commit-57b6988
https://github.com/elprans
[3.8]https://github.com/python/cpython/commit/57b698886b47bb81c782c2ba80a8a72fe66c7aad
bpo-32751https://bugs.python.org/issue?@action=redirect&bpo=32751
: Wait for task cancel in asyncio.wait_for() when time…https://github.com/python/cpython/commit/57b698886b47bb81c782c2ba80a8a72fe66c7aad
57b6988https://github.com/python/cpython/commit/57b698886b47bb81c782c2ba80a8a72fe66c7aad
GH-21895https://github.com/python/cpython/pull/21895
#21967https://github.com/python/cpython/pull/21967
bpo-32751https://bugs.python.org/issue?@action=redirect&bpo=32751
GH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
c517fc7https://github.com/python/cpython/commit/c517fc712105c8e5930cb42baaebdbe37fc3e15f
xzy3https://github.com/xzy3
Oct 18, 2020 https://github.com/python/cpython/pull/21895#ref-commit-21285ef
https://github.com/elprans
https://github.com/xzy3-cdc
bpo-32751: Wait for task cancel in asyncio.wait_for() when timeout <=…https://github.com/xzy3/cpython/commit/21285efd6ea603fa9b9c2bd25e3d750090b2b952
21285efhttps://github.com/xzy3/cpython/commit/21285efd6ea603fa9b9c2bd25e3d750090b2b952
python#21895https://github.com/python/cpython/pull/21895
pythonGH-7216https://github.com/python/cpython/pull/7216
@aaliddellhttps://github.com/aaliddell
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21895
https://github.com/1st1
1st1 https://github.com/1st1
https://github.com/python/cpython/pull/21895/files/debcf3e86545499258b6a55bee97f351760a9f14
https://github.com/asvetlov
asvetlov https://github.com/asvetlov
https://github.com/1st1
1st1 https://github.com/1st1
Please reload this pagehttps://github.com/python/cpython/pull/21895
https://github.com/elprans
https://github.com/1st1
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.