René's URL Explorer Experiment


Title: bpo-41306: Allow scale value to not be rounded by E-Paine · Pull Request #21715 · python/cpython · GitHub

Open Graph Title: bpo-41306: Allow scale value to not be rounded by E-Paine · Pull Request #21715 · python/cpython

X Title: bpo-41306: Allow scale value to not be rounded by E-Paine · Pull Request #21715 · python/cpython

Description: This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the from, to and tickinterval arguments. This PR uses noconv if the patchlevel is greater than or equal to 8.6.10 (credit to Serhiy for this idea as it is much simpler than what I previously proposed). Going into more detail for those who want it, the Tk change was made in commit 591f68c and means that the arguments listed above are rounded relative to the value of from. However, when rounding the from argument (line 623), it is rounded relative to itself (i.e. rounding 0) and therefore the assigned value for from is always what is given (no matter what values of from and resolution). https://bugs.python.org/issue41306 Automerge-Triggered-By: @pablogsal

Open Graph Description: This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the from, to and tickinterval arguments. This PR uses noconv if the patchlevel is greater than or equal to 8.6...

X Description: This fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the from, to and tickinterval arguments. This PR uses noconv if the patchlevel is greater than or equal to 8.6...

Opengraph URL: https://github.com/python/cpython/pull/21715

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0e9a1595-ae8a-5140-79a6-37eb8c1f6390
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA432:297F82:16D22F3:1F7F36C:696AA9F0
html-safe-nonceba6149ed2e1b40fb0737dddc098e2f0e97dae838ce0f9be9b0d03e250aa31033
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDMyOjI5N0Y4MjoxNkQyMkYzOjFGN0YzNkM6Njk2QUE5RjAiLCJ2aXNpdG9yX2lkIjoiMzI5NzIxNzgzMzM3NTI3OTYwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac079778e238bbb3b2808d614c2cd98701d12c1e893108369bebe59890cc487492
hovercard-subject-tagpull_request:462164126
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/21715/files
twitter:imagehttps://avatars.githubusercontent.com/u/63801254?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/63801254?s=400&v=4
og:image:altThis fixes the test failure with Tk 6.8.10 which is caused by changes to how Tk rounds the from, to and tickinterval arguments. This PR uses noconv if the patchlevel is greater than or equal to 8.6...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None3eaf9b8cf1badcd7041a8ad480b9d9b28bea0ef1cc821ca9ff20f2cc7f4fe4b9
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasedd9a979046e6382bd084e2bd873bf65f797125ff
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/21715/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21715%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21715%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/21715/files
Reloadhttps://github.com/python/cpython/pull/21715/files
Reloadhttps://github.com/python/cpython/pull/21715/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/21715/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/21715/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
miss-islingtonhttps://github.com/miss-islington
python:masterhttps://github.com/python/cpython/tree/master
E-Paine:test_fromhttps://github.com/E-Paine/cpython/tree/test_from
Conversation 24 https://github.com/python/cpython/pull/21715
Commits 9 https://github.com/python/cpython/pull/21715/commits
Checks 0 https://github.com/python/cpython/pull/21715/checks
Files changed https://github.com/python/cpython/pull/21715/files
Please reload this pagehttps://github.com/python/cpython/pull/21715/files
bpo-41306: Allow scale value to not be rounded https://github.com/python/cpython/pull/21715/files#top
Show all changes 9 commits https://github.com/python/cpython/pull/21715/files
1c8759c Allow scale value to not be rounded E-Paine Aug 3, 2020 https://github.com/python/cpython/pull/21715/commits/1c8759c2c07869adf96e12b5ba1c86d16f5253e4
fc07de8 Reverted 'allow_not_rounded' changes and action Serhiy's recommendation E-Paine Aug 3, 2020 https://github.com/python/cpython/pull/21715/commits/fc07de802f399c89d0fe89d52aff7cb8b8f36fe1
e184ad8 📜🤖 Added by blurb_it. blurb-it[bot] Aug 3, 2020 https://github.com/python/cpython/pull/21715/commits/e184ad8dc6fef878d6cceac0fae4cf5fade0e5ce
bdd3cb5 Put "conv" kwarg on new line E-Paine Aug 3, 2020 https://github.com/python/cpython/pull/21715/commits/bdd3cb5ed731623a121f23339948e76a5ee46d7e
a8ac6bd Merge 'master' into test_from E-Paine Sep 17, 2020 https://github.com/python/cpython/pull/21715/commits/a8ac6bd095afe4ada01ed54f2ba9fe2f9f5074be
8b8060e Use @terryjreedy's conv kwarg suggestion E-Paine Sep 26, 2020 https://github.com/python/cpython/pull/21715/commits/8b8060e9daa33eb65d156d04c88390c9c635f2be
3f9147a Update Misc/NEWS.d/next/Tests/2020-08-03-13-44-37.bpo-41306.VDoWXI.rst pablogsal Oct 8, 2020 https://github.com/python/cpython/pull/21715/commits/3f9147a82bd65ae953017da1a4e27ed67d55b6f9
42ec16e Update Lib/tkinter/test/test_tkinter/test_widgets.py pablogsal Oct 8, 2020 https://github.com/python/cpython/pull/21715/commits/42ec16eba2d200480e2e71baf8906a50f65c785b
e3403c0 Update Lib/tkinter/test/test_tkinter/test_widgets.py pablogsal Oct 8, 2020 https://github.com/python/cpython/pull/21715/commits/e3403c0c7d5cc304a404e8f133f72c57549b6269
Clear filters https://github.com/python/cpython/pull/21715/files
Please reload this pagehttps://github.com/python/cpython/pull/21715/files
Please reload this pagehttps://github.com/python/cpython/pull/21715/files
test_widgets.py https://github.com/python/cpython/pull/21715/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
2020-08-03-13-44-37.bpo-41306.VDoWXI.rst https://github.com/python/cpython/pull/21715/files#diff-ef676f95a1d35548e7efae97155c417aa6c0d20d69686361951bf752011d6c0b
Lib/tkinter/test/test_tkinter/test_widgets.pyhttps://github.com/python/cpython/pull/21715/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
View file https://github.com/E-Paine/cpython/blob/e3403c0c7d5cc304a404e8f133f72c57549b6269/Lib/tkinter/test/test_tkinter/test_widgets.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/21715/{{ revealButtonHref }}
https://github.com/python/cpython/pull/21715/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
https://github.com/python/cpython/pull/21715/files#diff-6a62833393c58f2ef4d0e2b428e35040cf4b538df31cab7de484c1728d39d90c
Misc/NEWS.d/next/Tests/2020-08-03-13-44-37.bpo-41306.VDoWXI.rsthttps://github.com/python/cpython/pull/21715/files#diff-ef676f95a1d35548e7efae97155c417aa6c0d20d69686361951bf752011d6c0b
View file https://github.com/E-Paine/cpython/blob/e3403c0c7d5cc304a404e8f133f72c57549b6269/Misc/NEWS.d/next/Tests/2020-08-03-13-44-37.bpo-41306.VDoWXI.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/21715/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.