| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:7e1260da-9167-d646-6917-a88b7b585f23 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9956:22165:258B1DE:34FB89D:69691A65 |
| html-safe-nonce | 21a80a4c5461fea413781f96b655397df4196e649f1a3e12e4a48a41038ef3b0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTU2OjIyMTY1OjI1OEIxREU6MzRGQjg5RDo2OTY5MUE2NSIsInZpc2l0b3JfaWQiOiIyNDMxMjU4MTI2MTk5NjI2MzQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | bcd66572308997a6d3226de8720cecbd59a1768accc56c93178cc6db4b9a1b00 |
| hovercard-subject-tag | pull_request:438902471 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/21104/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/3c3a8ac9f11d09df02a7e773ef5b605921e4ee9d8c2aed1ef1754f588bc583e0/python/cpython/pull/21104 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/3c3a8ac9f11d09df02a7e773ef5b605921e4ee9d8c2aed1ef1754f588bc583e0/python/cpython/pull/21104 |
| og:image:alt | Issue: inspect. _signature_fromstr has unused code #99815 |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | asottile |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e60568924309a021b51adabdce15c2a2f285b556f3130d1a2fa2a5bce11c55f |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | dd206f7ed6207863172be4a783826e86bd2375c3 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/21104#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21104 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21104 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/21104 |
| Reload | https://github.com/python/cpython/pull/21104 |
| Reload | https://github.com/python/cpython/pull/21104 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/21104 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/21104 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/21104#issue-comment-box |
| iritkatriel | https://github.com/iritkatriel |
| python:main | https://github.com/python/cpython/tree/main |
| asottile:inspect_signature_simplify | https://github.com/asottile/cpython/tree/inspect_signature_simplify |
|
gh-99815: remove unused 'invalid' sentinel value and code that checks for it in inspect.signature parsing
| https://github.com/python/cpython/pull/21104#top |
| iritkatriel | https://github.com/iritkatriel |
| python:main | https://github.com/python/cpython/tree/main |
| asottile:inspect_signature_simplify | https://github.com/asottile/cpython/tree/inspect_signature_simplify |
|
Conversation
1
| https://github.com/python/cpython/pull/21104 |
|
Commits
2
| https://github.com/python/cpython/pull/21104/commits |
|
Checks
0
| https://github.com/python/cpython/pull/21104/checks |
|
Files changed
| https://github.com/python/cpython/pull/21104/files |
| Please reload this page | https://github.com/python/cpython/pull/21104 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| Jun 24, 2020 | https://github.com/python/cpython/pull/21104#issue-644245229 |
| Please reload this page | https://github.com/python/cpython/pull/21104 |
| inspect. _signature_fromstr has unused code #99815 | https://github.com/python/cpython/issues/99815 |
| Please reload this page | https://github.com/python/cpython/pull/21104 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jun 24, 2020 | https://github.com/python/cpython/pull/21104#event-3475365138 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jun 24, 2020 | https://github.com/python/cpython/pull/21104#event-3475365189 |
| https://github.com/eamanu |
| eamanu | https://github.com/eamanu |
|
Jun 24, 2020
| https://github.com/python/cpython/pull/21104#pullrequestreview-436277467 |
|
View reviewed changes
| https://github.com/python/cpython/pull/21104/files |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| Jun 24, 2020 | https://github.com/python/cpython/pull/21104#event-3475478888 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| force-pushed | https://github.com/python/cpython/compare/5309efaf9828646baec35b948269b7da427163c4..847fd9f8e6c30b4b10e0a5741a093c62c785392d |
| 5309efa | https://github.com/python/cpython/commit/5309efaf9828646baec35b948269b7da427163c4 |
| 847fd9f | https://github.com/python/cpython/commit/847fd9f8e6c30b4b10e0a5741a093c62c785392d |
|
Compare
| https://github.com/python/cpython/compare/5309efaf9828646baec35b948269b7da427163c4..847fd9f8e6c30b4b10e0a5741a093c62c785392d |
| September 3, 2020 18:10 | https://github.com/python/cpython/pull/21104#event-3725971558 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| force-pushed | https://github.com/python/cpython/compare/847fd9f8e6c30b4b10e0a5741a093c62c785392d..e56916939a5f95ee2ca11b1900d96cb7ebf7f39c |
| 847fd9f | https://github.com/python/cpython/commit/847fd9f8e6c30b4b10e0a5741a093c62c785392d |
| e569169 | https://github.com/python/cpython/commit/e56916939a5f95ee2ca11b1900d96cb7ebf7f39c |
|
Compare
| https://github.com/python/cpython/compare/847fd9f8e6c30b4b10e0a5741a093c62c785392d..e56916939a5f95ee2ca11b1900d96cb7ebf7f39c |
| November 2, 2021 02:24 | https://github.com/python/cpython/pull/21104#event-5552410552 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| force-pushed | https://github.com/python/cpython/compare/e56916939a5f95ee2ca11b1900d96cb7ebf7f39c..477c2eb84b4a0f2ffc7e60339276677f2fa5f6c0 |
| e569169 | https://github.com/python/cpython/commit/e56916939a5f95ee2ca11b1900d96cb7ebf7f39c |
| 477c2eb | https://github.com/python/cpython/commit/477c2eb84b4a0f2ffc7e60339276677f2fa5f6c0 |
|
Compare
| https://github.com/python/cpython/compare/e56916939a5f95ee2ca11b1900d96cb7ebf7f39c..477c2eb84b4a0f2ffc7e60339276677f2fa5f6c0 |
| July 8, 2022 16:27 | https://github.com/python/cpython/pull/21104#event-6961401600 |
| https://github.com/ezio-melotti |
| ezio-melotti | https://github.com/ezio-melotti |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| Jul 13, 2022 | https://github.com/python/cpython/pull/21104#event-6988862717 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| force-pushed | https://github.com/python/cpython/compare/477c2eb84b4a0f2ffc7e60339276677f2fa5f6c0..83f9192225903ac947cc24959dd152454cb70699 |
| 477c2eb | https://github.com/python/cpython/commit/477c2eb84b4a0f2ffc7e60339276677f2fa5f6c0 |
| 83f9192 | https://github.com/python/cpython/commit/83f9192225903ac947cc24959dd152454cb70699 |
|
Compare
| https://github.com/python/cpython/compare/477c2eb84b4a0f2ffc7e60339276677f2fa5f6c0..83f9192225903ac947cc24959dd152454cb70699 |
| August 5, 2022 20:22 | https://github.com/python/cpython/pull/21104#event-7138564428 |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| Aug 29, 2022 | https://github.com/python/cpython/pull/21104#issuecomment-1230336247 |
| @1st1 | https://github.com/1st1 |
| Please reload this page | https://github.com/python/cpython/pull/21104 |
|
| https://github.com/asottile |
| Simplify routine in inspect.signature parsing | https://github.com/python/cpython/pull/21104/commits/e6eaf8e2f2dd738de8c880d259a286dba3d31e6c |
| e6eaf8e | https://github.com/python/cpython/pull/21104/commits/e6eaf8e2f2dd738de8c880d259a286dba3d31e6c |
| https://github.com/asottile |
| asottile | https://github.com/asottile |
| force-pushed | https://github.com/python/cpython/compare/83f9192225903ac947cc24959dd152454cb70699..e6eaf8e2f2dd738de8c880d259a286dba3d31e6c |
| 83f9192 | https://github.com/python/cpython/commit/83f9192225903ac947cc24959dd152454cb70699 |
| e6eaf8e | https://github.com/python/cpython/commit/e6eaf8e2f2dd738de8c880d259a286dba3d31e6c |
|
Compare
| https://github.com/python/cpython/compare/83f9192225903ac947cc24959dd152454cb70699..e6eaf8e2f2dd738de8c880d259a286dba3d31e6c |
| October 5, 2022 21:16 | https://github.com/python/cpython/pull/21104#event-7528591615 |
|
| https://github.com/iritkatriel |
| Merge branch 'main' into inspect_signature_simplify | https://github.com/python/cpython/pull/21104/commits/9841a063790a595a91f3c52cc9c6c4d2aadaf399 |
| 9841a06 | https://github.com/python/cpython/pull/21104/commits/9841a063790a595a91f3c52cc9c6c4d2aadaf399 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
|
Nov 27, 2022
| https://github.com/python/cpython/pull/21104#pullrequestreview-1194963074 |
|
View reviewed changes
| https://github.com/python/cpython/pull/21104/files/9841a063790a595a91f3c52cc9c6c4d2aadaf399 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting core review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22 |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897360078 |
| https://github.com/kumaraditya303 |
| kumaraditya303 | https://github.com/kumaraditya303 |
|
skip issue
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897360248 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897361927 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897362332 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897365800 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
|
skip issue
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20issue%22 |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897366086 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
Nov 27, 2022
| https://github.com/python/cpython/pull/21104#ref-issue-1465399298 |
|
inspect. _signature_fromstr has unused code
#99815
| https://github.com/python/cpython/issues/99815 |
| https://github.com/iritkatriel |
| iritkatriel | https://github.com/iritkatriel |
| ac115b5 | https://github.com/python/cpython/commit/ac115b51e71c24374682e2a9e6663f99d2faf000 |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897387267 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Nov 27, 2022 | https://github.com/python/cpython/pull/21104#event-7897387316 |
| https://github.com/JelleZijlstra |
| JelleZijlstra | https://github.com/JelleZijlstra |
|
Dec 12, 2022
| https://github.com/python/cpython/pull/21104#ref-pullrequest-1426802478 |
|
gh-85267: Improvements to inspect.signature __text_signature__ handling
#98796
| https://github.com/python/cpython/pull/98796 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F21104 |
|
| https://github.com/iritkatriel |
|
iritkatriel
| https://github.com/iritkatriel |
|
| https://github.com/python/cpython/pull/21104/files/9841a063790a595a91f3c52cc9c6c4d2aadaf399 |
|
| https://github.com/eamanu |
|
eamanu
| https://github.com/eamanu |
|
| https://github.com/python/cpython/pull/21104/files/5309efaf9828646baec35b948269b7da427163c4 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/21104 |
|
| https://github.com/asottile |
|
| https://github.com/iritkatriel |
|
| https://github.com/eamanu |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com/ezio-melotti |
|
| https://github.com/bedevere-bot |
|
| https://github.com/kumaraditya303 |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |