René's URL Explorer Experiment


Title: [3.9] bpo-40924: Remove protocol for supplying Traversable objects from loaders by jaraco · Pull Request #20820 · python/cpython · GitHub

Open Graph Title: [3.9] bpo-40924: Remove protocol for supplying Traversable objects from loaders by jaraco · Pull Request #20820 · python/cpython

X Title: [3.9] bpo-40924: Remove protocol for supplying Traversable objects from loaders by jaraco · Pull Request #20820 · python/cpython

Description: As discovered in this comment, the protocol for soliciting a files() method on loaders is inadequate as some loaders do not have the context about the package with which they're associated, and although GH-20576 (and importlib_resources 2.x) attempted to address this concern while continuing to supply native support on ResourceReaders, it also brought unintended consequences, reported in bpo-40924. This change selectively removes that behavior to avoid tempting custom loader implementers from implementing this protocol. A different fix should be applied in master. https://bugs.python.org/issue40924

Open Graph Description: As discovered in this comment, the protocol for soliciting a files() method on loaders is inadequate as some loaders do not have the context about the package with which they're associated, and...

X Description: As discovered in this comment, the protocol for soliciting a files() method on loaders is inadequate as some loaders do not have the context about the package with which they're associated,...

Opengraph URL: https://github.com/python/cpython/pull/20820

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9112c932-49f6-3c67-3a0a-5d61f1d756fa
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA4A2:6456C:117EC2F:181BE5E:6A4DDB13
html-safe-nonce6d68feb42fdb4aebe06778d291f840277b9b5f0e9781dc9bf7a7b969b153fc21
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEEyOjY0NTZDOjExN0VDMkY6MTgxQkU1RTo2QTREREIxMyIsInZpc2l0b3JfaWQiOiI3NjY2NDc3OTE4ODk4MjE1Njk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac506ecbf9d9a83ad84a3e079b2f9e3625a17d4cd170dc890c8b4709b7c84a2286
hovercard-subject-tagpull_request:433384847
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20820/files
twitter:imagehttps://avatars.githubusercontent.com/u/308610?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/308610?s=400&v=4
og:image:altAs discovered in this comment, the protocol for soliciting a files() method on loaders is inadequate as some loaders do not have the context about the package with which they're associated, and...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None06b8a6144231bf3a234f1c2e9993861e07ce98a905912b114aa386c2d7e84b33
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release1d344bdb7547fe6bca17a59bb2b8aac3dc9532a0
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20820/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20820%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20820%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20820/files
Reloadhttps://github.com/python/cpython/pull/20820/files
Reloadhttps://github.com/python/cpython/pull/20820/files
Please reload this pagehttps://github.com/python/cpython/pull/20820/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20820/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 34.8k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 73.6k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.3k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality 0 https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security and quality https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
ambvhttps://github.com/ambv
python:3.9https://github.com/python/cpython/tree/3.9
Conversation 0 https://github.com/python/cpython/pull/20820
Commits 2 https://github.com/python/cpython/pull/20820/commits
Checks 0 https://github.com/python/cpython/pull/20820/checks
Files changed https://github.com/python/cpython/pull/20820/files
Please reload this pagehttps://github.com/python/cpython/pull/20820/files
[3.9] bpo-40924: Remove protocol for supplying Traversable objects from loaders https://github.com/python/cpython/pull/20820/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/20820/files
f34b8d9 bpo-40924: Remove protocol that loaders can present a files method as… jaraco Jun 11, 2020 https://github.com/python/cpython/pull/20820/commits/f34b8d931e68e27aa4bc71fc0cc6486949f474df
89eaf60 📜🤖 Added by blurb_it. blurb-it[bot] Jun 11, 2020 https://github.com/python/cpython/pull/20820/commits/89eaf60a2b2964dba9c370b9e0fccab9307cf602
Clear filters https://github.com/python/cpython/pull/20820/files
Please reload this pagehttps://github.com/python/cpython/pull/20820/files
Please reload this pagehttps://github.com/python/cpython/pull/20820/files
importlib.rst https://github.com/python/cpython/pull/20820/files#diff-023b9cd2ff76dd1b2a7117a363f1789d5d192c09d632872934b86e8d3fbe5f3e
_common.py https://github.com/python/cpython/pull/20820/files#diff-1ef5ecbe5a3ea8b796cb8a134dd6ae4f8f3bc5f208b987145b27650b37d774d9
2020-06-11-23-41-50.bpo-40924.m17Fkm.rst https://github.com/python/cpython/pull/20820/files#diff-52ac9d058f1b7ae242f9c2c36b2da0b027fcf63b1425ae18c8d0d210f1acece8
Doc/library/importlib.rsthttps://github.com/python/cpython/pull/20820/files#diff-023b9cd2ff76dd1b2a7117a363f1789d5d192c09d632872934b86e8d3fbe5f3e
View file https://github.com/python/cpython/blob/89eaf60a2b2964dba9c370b9e0fccab9307cf602/Doc/library/importlib.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20820/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20820/files#diff-023b9cd2ff76dd1b2a7117a363f1789d5d192c09d632872934b86e8d3fbe5f3e
https://github.com/python/cpython/pull/20820/files#diff-023b9cd2ff76dd1b2a7117a363f1789d5d192c09d632872934b86e8d3fbe5f3e
Lib/importlib/_common.pyhttps://github.com/python/cpython/pull/20820/files#diff-1ef5ecbe5a3ea8b796cb8a134dd6ae4f8f3bc5f208b987145b27650b37d774d9
View file https://github.com/python/cpython/blob/89eaf60a2b2964dba9c370b9e0fccab9307cf602/Lib/importlib/_common.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20820/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20820/files#diff-1ef5ecbe5a3ea8b796cb8a134dd6ae4f8f3bc5f208b987145b27650b37d774d9
https://github.com/python/cpython/pull/20820/files#diff-1ef5ecbe5a3ea8b796cb8a134dd6ae4f8f3bc5f208b987145b27650b37d774d9
Misc/NEWS.d/next/Library/2020-06-11-23-41-50.bpo-40924.m17Fkm.rsthttps://github.com/python/cpython/pull/20820/files#diff-52ac9d058f1b7ae242f9c2c36b2da0b027fcf63b1425ae18c8d0d210f1acece8
View file https://github.com/python/cpython/blob/89eaf60a2b2964dba9c370b9e0fccab9307cf602/Misc/NEWS.d/next/Library/2020-06-11-23-41-50.bpo-40924.m17Fkm.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20820/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.