René's URL Explorer Experiment


Title: bpo-39943: Fix MSVC warnings in sre extension by ammaraskar · Pull Request #20508 · python/cpython · GitHub

Open Graph Title: bpo-39943: Fix MSVC warnings in sre extension by ammaraskar · Pull Request #20508 · python/cpython

X Title: bpo-39943: Fix MSVC warnings in sre extension by ammaraskar · Pull Request #20508 · python/cpython

Description: While the PyMem_Del change seems harmless enough, I'm a little bit uneasy about the memcpy one. This file is pretty old and unlikely to change in the future but it seems like it opens up the possibility of someone making a mistake like DATA_STACK_POP(state, 5, ...) and have it not caught by the type checker because of the explicit cast. For that particular one we could guard the explicitly casted version with #ifdef _MSC_VER or something so it's harder to make that mistake and not have it be caught by the CI. https://bugs.python.org/issue39943

Open Graph Description: While the PyMem_Del change seems harmless enough, I'm a little bit uneasy about the memcpy one. This file is pretty old and unlikely to change in the future but it seems like it opens up the po...

X Description: While the PyMem_Del change seems harmless enough, I'm a little bit uneasy about the memcpy one. This file is pretty old and unlikely to change in the future but it seems like it opens up th...

Opengraph URL: https://github.com/python/cpython/pull/20508

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:371d0afa-a824-053c-166c-a1eb3f766b77
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDF4A:159D04:A815AC:DC5820:696B56B5
html-safe-noncec4e1af6b3e8ea813977916fd4de036aa8383194553101236967aa935152107d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjRBOjE1OUQwNDpBODE1QUM6REM1ODIwOjY5NkI1NkI1IiwidmlzaXRvcl9pZCI6Ijc2OTUyNjQ0MjE3ODg3MzUxNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac921ae2145355dc8fb2cede809f5363232dc6adf46494a5fb06989022abcaf8b1
hovercard-subject-tagpull_request:424989403
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20508/files
twitter:imagehttps://avatars.githubusercontent.com/u/773529?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/773529?s=400&v=4
og:image:altWhile the PyMem_Del change seems harmless enough, I'm a little bit uneasy about the memcpy one. This file is pretty old and unlikely to change in the future but it seems like it opens up the po...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20508/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20508%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20508%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20508/files
Reloadhttps://github.com/python/cpython/pull/20508/files
Reloadhttps://github.com/python/cpython/pull/20508/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20508/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20508/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
vstinnerhttps://github.com/vstinner
python:masterhttps://github.com/python/cpython/tree/master
ammaraskar:sre_msvc_warningshttps://github.com/ammaraskar/cpython/tree/sre_msvc_warnings
Conversation 9 https://github.com/python/cpython/pull/20508
Commits 1 https://github.com/python/cpython/pull/20508/commits
Checks 0 https://github.com/python/cpython/pull/20508/checks
Files changed https://github.com/python/cpython/pull/20508/files
Please reload this pagehttps://github.com/python/cpython/pull/20508/files
bpo-39943: Fix MSVC warnings in sre extension https://github.com/python/cpython/pull/20508/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/20508/files
e9d75be bpo-39943: Fix MSVC warnings in sre extension ammaraskar May 29, 2020 https://github.com/python/cpython/pull/20508/commits/e9d75beb969fc33488f5d18d2f1116d2f7593f95
Clear filters https://github.com/python/cpython/pull/20508/files
Please reload this pagehttps://github.com/python/cpython/pull/20508/files
Please reload this pagehttps://github.com/python/cpython/pull/20508/files
_sre.c https://github.com/python/cpython/pull/20508/files#diff-aaff088141c53a1b4b5f0d9d35d0bbd0406bac50c73be47328df26f46c9fe41c
sre_lib.h https://github.com/python/cpython/pull/20508/files#diff-4e6d447ab468fcfdf1a5a9d8343c00af6d8f79eafc3ff2886eac8409bfc05df6
Modules/_sre.chttps://github.com/python/cpython/pull/20508/files#diff-aaff088141c53a1b4b5f0d9d35d0bbd0406bac50c73be47328df26f46c9fe41c
View file https://github.com/ammaraskar/cpython/blob/e9d75beb969fc33488f5d18d2f1116d2f7593f95/Modules/_sre.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20508/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20508/files#diff-aaff088141c53a1b4b5f0d9d35d0bbd0406bac50c73be47328df26f46c9fe41c
https://github.com/python/cpython/pull/20508/files#diff-aaff088141c53a1b4b5f0d9d35d0bbd0406bac50c73be47328df26f46c9fe41c
https://github.com/python/cpython/pull/20508/files#diff-aaff088141c53a1b4b5f0d9d35d0bbd0406bac50c73be47328df26f46c9fe41c
Modules/sre_lib.hhttps://github.com/python/cpython/pull/20508/files#diff-4e6d447ab468fcfdf1a5a9d8343c00af6d8f79eafc3ff2886eac8409bfc05df6
View file https://github.com/ammaraskar/cpython/blob/e9d75beb969fc33488f5d18d2f1116d2f7593f95/Modules/sre_lib.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20508/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20508/files#diff-4e6d447ab468fcfdf1a5a9d8343c00af6d8f79eafc3ff2886eac8409bfc05df6
https://github.com/python/cpython/pull/20508/files#diff-4e6d447ab468fcfdf1a5a9d8343c00af6d8f79eafc3ff2886eac8409bfc05df6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.