| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:88736784-afbd-9bb1-1a2b-1ab2676fe0a6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C7D6:2706BA:45F909:5CA553:696B3EF9 |
| html-safe-nonce | b15a24cd5170ffb202a40213494ad9a7d4246cc4fc9cab4c73e131bd3830511d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDN0Q2OjI3MDZCQTo0NUY5MDk6NUNBNTUzOjY5NkIzRUY5IiwidmlzaXRvcl9pZCI6IjEyMjUzMDg5MDIzNjIxMzYzMTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 778ebdb4fde3232e9503c3cfc8793469db4d14b9d47050566ba147b8bcfec576 |
| hovercard-subject-tag | pull_request:424989403 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/20508/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/d9050efbde7a41bb22d57c72b4ef928e17f4c512e7ca6be2de4aee7a1ea3abb1/python/cpython/pull/20508 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/d9050efbde7a41bb22d57c72b4ef928e17f4c512e7ca6be2de4aee7a1ea3abb1/python/cpython/pull/20508 |
| og:image:alt | While the PyMem_Del change seems harmless enough, I'm a little bit uneasy about the memcpy one. This file is pretty old and unlikely to change in the future but it seems like it opens up the po... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ammaraskar |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d |
| turbo-cache-control | no-preview |
| go-import | github.com/python/cpython git https://github.com/python/cpython.git |
| octolytics-dimension-user_id | 1525981 |
| octolytics-dimension-user_login | python |
| octolytics-dimension-repository_id | 81598961 |
| octolytics-dimension-repository_nwo | python/cpython |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 81598961 |
| octolytics-dimension-repository_network_root_nwo | python/cpython |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 82560a55c6b2054555076f46e683151ee28a19bc |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/python/cpython/pull/20508#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20508 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub SparkBuild and deploy intelligent apps | https://github.com/features/spark |
| GitHub ModelsManage and compare prompts | https://github.com/features/models |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| GitHub SponsorsFund open source developers | https://github.com/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/accelerator |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20508 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython |
| Reload | https://github.com/python/cpython/pull/20508 |
| Reload | https://github.com/python/cpython/pull/20508 |
| Reload | https://github.com/python/cpython/pull/20508 |
|
python
| https://github.com/python |
| cpython | https://github.com/python/cpython |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
|
Notifications
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Fork
33.9k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Star
71.1k
| https://github.com/login?return_to=%2Fpython%2Fcpython |
|
Code
| https://github.com/python/cpython |
|
Issues
5k+
| https://github.com/python/cpython/issues |
|
Pull requests
2.1k
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
31
| https://github.com/python/cpython/projects |
|
Security
Uh oh!
There was an error while loading. Please reload this page.
| https://github.com/python/cpython/security |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
|
Insights
| https://github.com/python/cpython/pulse |
|
Code
| https://github.com/python/cpython |
|
Issues
| https://github.com/python/cpython/issues |
|
Pull requests
| https://github.com/python/cpython/pulls |
|
Actions
| https://github.com/python/cpython/actions |
|
Projects
| https://github.com/python/cpython/projects |
|
Security
| https://github.com/python/cpython/security |
|
Insights
| https://github.com/python/cpython/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose |
| Jump to bottom | https://github.com/python/cpython/pull/20508#issue-comment-box |
| vstinner | https://github.com/vstinner |
| python:master | https://github.com/python/cpython/tree/master |
| ammaraskar:sre_msvc_warnings | https://github.com/ammaraskar/cpython/tree/sre_msvc_warnings |
|
bpo-39943: Fix MSVC warnings in sre extension
| https://github.com/python/cpython/pull/20508#top |
| vstinner | https://github.com/vstinner |
| python:master | https://github.com/python/cpython/tree/master |
| ammaraskar:sre_msvc_warnings | https://github.com/ammaraskar/cpython/tree/sre_msvc_warnings |
|
Conversation
9
| https://github.com/python/cpython/pull/20508 |
|
Commits
1
| https://github.com/python/cpython/pull/20508/commits |
|
Checks
0
| https://github.com/python/cpython/pull/20508/checks |
|
Files changed
| https://github.com/python/cpython/pull/20508/files |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.co/hiddenchars |
| https://github.com/python/cpython/pull/{{ revealButtonHref }} |
|
| https://github.com/ammaraskar |
| ammaraskar | https://github.com/ammaraskar |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#issue-627128126 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://bugs.python.org/issue39943 | https://bugs.python.org/issue39943 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/the-knights-who-say-ni |
| the-knights-who-say-ni | https://github.com/the-knights-who-say-ni |
|
CLA signed
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22 |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#event-3386370087 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#event-3386370269 |
| https://github.com/ammaraskar |
| ammaraskar | https://github.com/ammaraskar |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#event-3386371164 |
| https://github.com/ammaraskar |
| ammaraskar | https://github.com/ammaraskar |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| vstinner | https://github.com/vstinner |
| May 29, 2020 09:22 | https://github.com/python/cpython/pull/20508#event-3386372655 |
| https://github.com/ammaraskar |
| ammaraskar | https://github.com/ammaraskar |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#issuecomment-635871380 |
| @petdance | https://github.com/petdance |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
May 29, 2020
| https://github.com/python/cpython/pull/20508#pullrequestreview-420795599 |
|
View reviewed changes
| https://github.com/python/cpython/pull/20508/files |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
|
awaiting review
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20review%22 |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#event-3386397486 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
|
May 29, 2020
| https://github.com/python/cpython/pull/20508#pullrequestreview-421104005 |
|
View reviewed changes
| https://github.com/python/cpython/pull/20508/files |
| Modules/sre_lib.h | https://github.com/python/cpython/pull/20508/files#diff-4e6d447ab468fcfdf1a5a9d8343c00af6d8f79eafc3ff2886eac8409bfc05df6 |
| vstinner | https://github.com/vstinner |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#discussion_r432597526 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| ammaraskar | https://github.com/ammaraskar |
| May 29, 2020 | https://github.com/python/cpython/pull/20508#discussion_r432662981 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/ammaraskar |
| ammaraskar | https://github.com/ammaraskar |
| force-pushed | https://github.com/python/cpython/compare/e021e4924d5ba149de5d790552df148f5bb60c96..0f5ec740a837151b0a148530d95e11515aad0967 |
| e021e49 | https://github.com/python/cpython/commit/e021e4924d5ba149de5d790552df148f5bb60c96 |
| 0f5ec74 | https://github.com/python/cpython/commit/0f5ec740a837151b0a148530d95e11515aad0967 |
|
Compare
| https://github.com/python/cpython/compare/e021e4924d5ba149de5d790552df148f5bb60c96..0f5ec740a837151b0a148530d95e11515aad0967 |
| May 29, 2020 18:27 | https://github.com/python/cpython/pull/20508#event-3388343382 |
|
| https://github.com/ammaraskar |
| bpo-39943: Fix MSVC warnings in sre extension | https://github.com/python/cpython/pull/20508/commits/e9d75beb969fc33488f5d18d2f1116d2f7593f95 |
| e9d75be | https://github.com/python/cpython/pull/20508/commits/e9d75beb969fc33488f5d18d2f1116d2f7593f95 |
| https://github.com/ammaraskar |
| ammaraskar | https://github.com/ammaraskar |
| force-pushed | https://github.com/python/cpython/compare/0f5ec740a837151b0a148530d95e11515aad0967..e9d75beb969fc33488f5d18d2f1116d2f7593f95 |
| 0f5ec74 | https://github.com/python/cpython/commit/0f5ec740a837151b0a148530d95e11515aad0967 |
| e9d75be | https://github.com/python/cpython/commit/e9d75beb969fc33488f5d18d2f1116d2f7593f95 |
|
Compare
| https://github.com/python/cpython/compare/0f5ec740a837151b0a148530d95e11515aad0967..e9d75beb969fc33488f5d18d2f1116d2f7593f95 |
| May 29, 2020 18:28 | https://github.com/python/cpython/pull/20508#event-3388347726 |
| https://github.com/petdance |
| petdance | https://github.com/petdance |
| May 30, 2020 | https://github.com/python/cpython/pull/20508#issuecomment-636246221 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
May 30, 2020
| https://github.com/python/cpython/pull/20508#pullrequestreview-421387083 |
|
View reviewed changes
| https://github.com/python/cpython/pull/20508/files/e9d75beb969fc33488f5d18d2f1116d2f7593f95 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| Jun 1, 2020 | https://github.com/python/cpython/pull/20508#issuecomment-636998093 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/vstinner |
| vstinner | https://github.com/vstinner |
| 06e3a27 | https://github.com/python/cpython/commit/06e3a27a3c863495390a07c695171a8e62a6e0d2 |
| Jun 1, 2020 | https://github.com/python/cpython/pull/20508#event-3394124790 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
awaiting merge
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22 |
| Jun 1, 2020 | https://github.com/python/cpython/pull/20508#event-3394124955 |
| https://github.com/ammaraskar |
| ammaraskar | https://github.com/ammaraskar |
|
Jun 2, 2020
| https://github.com/python/cpython/pull/20508#ref-pullrequest-566024197 |
|
[workflow] Use MSVC problem matcher for Windows action build
#18532
| https://github.com/python/cpython/pull/18532 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
|
needs backport to 3.9
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22 |
| Mar 14, 2021 | https://github.com/python/cpython/pull/20508#event-4455174501 |
| https://github.com/miss-islington |
| miss-islington | https://github.com/miss-islington |
| Mar 14, 2021 | https://github.com/python/cpython/pull/20508#issuecomment-798894045 |
| @ammaraskar | https://github.com/ammaraskar |
| @vstinner | https://github.com/vstinner |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
| Mar 14, 2021 | https://github.com/python/cpython/pull/20508#issuecomment-798894079 |
| GH-24856 | https://github.com/python/cpython/pull/24856 |
| 3.9 branch | https://github.com/python/cpython/tree/3.9 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/bedevere-bot |
| bedevere-bot | https://github.com/bedevere-bot |
|
needs backport to 3.9
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22 |
| Mar 14, 2021 | https://github.com/python/cpython/pull/20508#event-4455174717 |
| miss-islington | https://github.com/miss-islington |
|
Mar 14, 2021
| https://github.com/python/cpython/pull/20508#ref-commit-d3e81f3 |
|
| https://github.com/ammaraskar |
|
| https://github.com/miss-islington |
| bpo-39943: Fix MSVC warnings in sre extension ( | https://github.com/miss-islington/cpython/commit/d3e81f33994ed85c1887aa751906d85ca5b9c64c |
| pythonGH-20508 | https://github.com/python/cpython/pull/20508 |
| ) | https://github.com/miss-islington/cpython/commit/d3e81f33994ed85c1887aa751906d85ca5b9c64c |
| d3e81f3 | https://github.com/miss-islington/cpython/commit/d3e81f33994ed85c1887aa751906d85ca5b9c64c |
| 06e3a27 | https://github.com/miss-islington/cpython/commit/06e3a27a3c863495390a07c695171a8e62a6e0d2 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Mar 14, 2021 | https://github.com/python/cpython/pull/20508#issuecomment-798894192 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| miss-islington | https://github.com/miss-islington |
|
Mar 14, 2021
| https://github.com/python/cpython/pull/20508#ref-commit-cf8d6ef |
|
| https://github.com/miss-islington |
|
| https://github.com/ammaraskar |
| bpo-39943 | https://bugs.python.org/issue?@action=redirect&bpo=39943 |
| : Fix MSVC warnings in sre extension ( | https://github.com/python/cpython/commit/cf8d6ef9629dc1bffadfcec251a2ffe30d5addaa |
| GH-20508 | https://github.com/python/cpython/pull/20508 |
| ) | https://github.com/python/cpython/commit/cf8d6ef9629dc1bffadfcec251a2ffe30d5addaa |
| cf8d6ef | https://github.com/python/cpython/commit/cf8d6ef9629dc1bffadfcec251a2ffe30d5addaa |
| 06e3a27 | https://github.com/python/cpython/commit/06e3a27a3c863495390a07c695171a8e62a6e0d2 |
| https://github.com/serhiy-storchaka |
| serhiy-storchaka | https://github.com/serhiy-storchaka |
| Mar 16, 2021 | https://github.com/python/cpython/pull/20508#issuecomment-800383835 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| bpo-43499 | https://bugs.python.org/issue43499 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
| https://github.com/python/cpython/pull/20508 |
| petdance | https://github.com/python/cpython/pull/20508 |
|
May 30, 2022
| https://github.com/python/cpython/pull/20508#ref-issue-1199032330 |
|
Meta: Clean up various issues in C internals
#84124
| https://github.com/python/cpython/issues/84124 |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20508 |
|
| https://github.com/vstinner |
|
vstinner
| https://github.com/vstinner |
|
| https://github.com/python/cpython/pull/20508/files/e021e4924d5ba149de5d790552df148f5bb60c96 |
|
| https://github.com/serhiy-storchaka |
|
serhiy-storchaka
| https://github.com/serhiy-storchaka |
|
| https://github.com/python/cpython/pull/20508/files/e9d75beb969fc33488f5d18d2f1116d2f7593f95 |
|
skip news
| https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22skip%20news%22 |
| Please reload this page | https://github.com/python/cpython/pull/20508 |
|
| https://github.com/ammaraskar |
|
| https://github.com/petdance |
|
| https://github.com/vstinner |
|
| https://github.com/miss-islington |
|
| https://github.com/bedevere-bot |
|
| https://github.com/serhiy-storchaka |
|
| https://github.com/the-knights-who-say-ni |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |