René's URL Explorer Experiment


Title: bpo-34689: Prevent sysconfig._parse_makefile from expanding $${variables} by lepaperwan · Pull Request #20439 · python/cpython · GitHub

Open Graph Title: bpo-34689: Prevent sysconfig._parse_makefile from expanding $${variables} by lepaperwan · Pull Request #20439 · python/cpython

X Title: bpo-34689: Prevent sysconfig._parse_makefile from expanding $${variables} by lepaperwan · Pull Request #20439 · python/cpython

Description: As described in [bpo-34689](https://www.bugs.python.org/issue34689), sysconfig._parse_makefile recognizes $${variable} as a variable to expand in the second half of the _parse_makefile function. This pull-request aims to fix that by splitting strings on $$ before looking for variables in them and restoring the $$ in values that require more processing. There is no change to the documentation as this is a bug-fix. https://bugs.python.org/issue34689 Supersedes #9362

Open Graph Description: As described in [bpo-34689](https://www.bugs.python.org/issue34689), sysconfig._parse_makefile recognizes $${variable} as a variable to expand in the second half of the _parse_makefile function. Th...

X Description: As described in [bpo-34689](https://www.bugs.python.org/issue34689), sysconfig._parse_makefile recognizes $${variable} as a variable to expand in the second half of the _parse_makefile function. Th...

Opengraph URL: https://github.com/python/cpython/pull/20439

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:06b40819-fc81-8f63-87b4-d57e067f8db7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDD2E:8D103:E75823:1364ED6:696AC8F5
html-safe-nonce4fb5885cb89ca53576b07de97c8739bc1c178cc7e4839d1c11b0efe6d328774f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDJFOjhEMTAzOkU3NTgyMzoxMzY0RUQ2OjY5NkFDOEY1IiwidmlzaXRvcl9pZCI6IjgwMzkyMzgzNjI0MzE0MDgzNzMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd89afcdc61785e091d20ce95d627bdaefd74de07b5663d51eda504d0c264c1e3
hovercard-subject-tagpull_request:423470003
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20439/files
twitter:imagehttps://avatars.githubusercontent.com/u/8627131?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8627131?s=400&v=4
og:image:altAs described in [bpo-34689](https://www.bugs.python.org/issue34689), sysconfig._parse_makefile recognizes $${variable} as a variable to expand in the second half of the _parse_makefile function. Th...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonec785f4ce187e9e7331257791b36ddee01625bb8e292a9b4fe2c16d4c006abf5d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec718a376fcf780eb22089171adb84a543f660bf7
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20439/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20439%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20439%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20439/files
Reloadhttps://github.com/python/cpython/pull/20439/files
Reloadhttps://github.com/python/cpython/pull/20439/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20439/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20439/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
lepaperwanhttps://github.com/lepaperwan
python:mainhttps://github.com/python/cpython/tree/main
lepaperwan:bpo-34689https://github.com/lepaperwan/cpython/tree/bpo-34689
Conversation 5 https://github.com/python/cpython/pull/20439
Commits 4 https://github.com/python/cpython/pull/20439/commits
Checks 0 https://github.com/python/cpython/pull/20439/checks
Files changed https://github.com/python/cpython/pull/20439/files
Please reload this pagehttps://github.com/python/cpython/pull/20439/files
bpo-34689: Prevent sysconfig._parse_makefile from expanding $${variables} https://github.com/python/cpython/pull/20439/files#top
Show all changes 4 commits https://github.com/python/cpython/pull/20439/files
b365592 bpo-34689: _parse_makefile no longer expands $${} lepaperwan Sep 17, 2018 https://github.com/python/cpython/pull/20439/commits/b365592777245343156e701d311ae5a1ecd10fb5
00fbdbd Merge branch 'master' into bpo-34689 lepaperwan May 26, 2020 https://github.com/python/cpython/pull/20439/commits/00fbdbdfd8cf681418174eded5c2ba95bacc9817
e15e47c Fix formatting issues lepaperwan Jul 6, 2020 https://github.com/python/cpython/pull/20439/commits/e15e47c724bd861d0a91411408f9650f5e8c1bb7
f2b7053 Merge branch 'master' into bpo-34689 lepaperwan Jul 6, 2020 https://github.com/python/cpython/pull/20439/commits/f2b70538a733ccdb21617a4bc7fb71d2e7bd7f3a
Clear filters https://github.com/python/cpython/pull/20439/files
Please reload this pagehttps://github.com/python/cpython/pull/20439/files
Please reload this pagehttps://github.com/python/cpython/pull/20439/files
sysconfig.py https://github.com/python/cpython/pull/20439/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
test_sysconfig.py https://github.com/python/cpython/pull/20439/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
2018-09-17-19-11-17.bpo-34689.RtyOE3.rst https://github.com/python/cpython/pull/20439/files#diff-69934c96fdd25e090223619d842d0580792a996dd1d6f8c825a4cbfae5e1542a
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L574
Lib/sysconfig.pyhttps://github.com/python/cpython/pull/20439/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
View file https://github.com/lepaperwan/cpython/blob/f2b70538a733ccdb21617a4bc7fb71d2e7bd7f3a/Lib/sysconfig.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20439/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20439/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
https://github.com/python/cpython/pull/20439/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
https://github.com/python/cpython/pull/20439/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
https://github.com/python/cpython/pull/20439/files#diff-d593bd299ba58e440ba411ffa0640ccd9d20d518b0cf2644ed4bdb75a82a3e70
https://github.com/python/cpython/blob/main/.github/CODEOWNERS#L574
Lib/test/test_sysconfig.pyhttps://github.com/python/cpython/pull/20439/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
View file https://github.com/lepaperwan/cpython/blob/f2b70538a733ccdb21617a4bc7fb71d2e7bd7f3a/Lib/test/test_sysconfig.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20439/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20439/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
https://github.com/python/cpython/pull/20439/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
https://github.com/python/cpython/pull/20439/files#diff-365f96442d242edc27cd09ce48da3cd6f81d1b47c9baf8f1b7bbbe5b1d2e7bda
Misc/NEWS.d/next/Library/2018-09-17-19-11-17.bpo-34689.RtyOE3.rsthttps://github.com/python/cpython/pull/20439/files#diff-69934c96fdd25e090223619d842d0580792a996dd1d6f8c825a4cbfae5e1542a
View file https://github.com/lepaperwan/cpython/blob/f2b70538a733ccdb21617a4bc7fb71d2e7bd7f3a/Misc/NEWS.d/next/Library/2018-09-17-19-11-17.bpo-34689.RtyOE3.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20439/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.