René's URL Explorer Experiment


Title: bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros by mdickinson · Pull Request #20435 · python/cpython · GitHub

Open Graph Title: bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros by mdickinson · Pull Request #20435 · python/cpython

X Title: bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros by mdickinson · Pull Request #20435 · python/cpython

Description: The dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add regression tests. EDIT: tests added https://bugs.python.org/issue40780

Open Graph Description: The dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add reg...

X Description: The dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add...

Opengraph URL: https://github.com/python/cpython/pull/20435

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a3c4ec17-99eb-c60a-3ac4-179d827942c8
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAFCA:134C26:154D23A:1C7CDE1:696ADEC1
html-safe-nonce759980240ca04b1671c0f3c2bc318e26134297a4ee85b418dc8ebf2790b7acb4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRkNBOjEzNEMyNjoxNTREMjNBOjFDN0NERTE6Njk2QURFQzEiLCJ2aXNpdG9yX2lkIjoiMjE4MDc2MjA5MTQ2NTEzNzg1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ac8b789ef24a554394e8de956aa9a4f9ff94b3a96b30225e6ee74172dd46c7d
hovercard-subject-tagpull_request:423314681
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20435/files
twitter:imagehttps://avatars.githubusercontent.com/u/662003?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/662003?s=400&v=4
og:image:altThe dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add reg...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release524a93f2c1f36522a3b4be4c110467ee4172245d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20435/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20435%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20435%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20435/files
Reloadhttps://github.com/python/cpython/pull/20435/files
Reloadhttps://github.com/python/cpython/pull/20435/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20435/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20435/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
mdickinsonhttps://github.com/mdickinson
python:masterhttps://github.com/python/cpython/tree/master
mdickinson:fix-g-mode-trailing-zerohttps://github.com/mdickinson/cpython/tree/fix-g-mode-trailing-zero
Conversation 14 https://github.com/python/cpython/pull/20435
Commits 5 https://github.com/python/cpython/pull/20435/commits
Checks 0 https://github.com/python/cpython/pull/20435/checks
Files changed https://github.com/python/cpython/pull/20435/files
Please reload this pagehttps://github.com/python/cpython/pull/20435/files
bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros https://github.com/python/cpython/pull/20435/files#top
Show all changes 5 commits https://github.com/python/cpython/pull/20435/files
b6ffd2e Fix failure of _Py_dg_dtoa to remove trailing zeros mdickinson May 26, 2020 https://github.com/python/cpython/pull/20435/commits/b6ffd2e58da312b31df8a68814013f8a47804cc2
589da50 Add regression test and news entry mdickinson May 26, 2020 https://github.com/python/cpython/pull/20435/commits/589da50d7ffe71c7ffadfdd2b0a4b1c8be16fb12
e9a13a1 Add explanation about why it's safe to strip trailing zeros mdickinson May 26, 2020 https://github.com/python/cpython/pull/20435/commits/e9a13a1d4c6f384ab2e4f7e069e77b8fecd38f9c
5773e56 Make code safer, clean up comments, add change note at top of file mdickinson May 27, 2020 https://github.com/python/cpython/pull/20435/commits/5773e56d03c7d964fc974c836334b8d6bdf3b0b8
556f7dd Nitpick: avoid implicit int-to-float conversion in tests mdickinson May 27, 2020 https://github.com/python/cpython/pull/20435/commits/556f7dd89b21a3dca868aed4148c17db3093152e
Clear filters https://github.com/python/cpython/pull/20435/files
Please reload this pagehttps://github.com/python/cpython/pull/20435/files
Please reload this pagehttps://github.com/python/cpython/pull/20435/files
test_format.py https://github.com/python/cpython/pull/20435/files#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
2020-05-26-17-43-58.bpo-40780.3Ckdgm.rst https://github.com/python/cpython/pull/20435/files#diff-7cc77ae8e35967dbc00002a50fb58b975cef8e980885be2b5021c427fed8f220
dtoa.c https://github.com/python/cpython/pull/20435/files#diff-1fd9f5e35c869584aa0c81075787ace75275a57783bc3920fa0e10a324c2ad11
Lib/test/test_format.pyhttps://github.com/python/cpython/pull/20435/files#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
View file https://github.com/mdickinson/cpython/blob/556f7dd89b21a3dca868aed4148c17db3093152e/Lib/test/test_format.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20435/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20435/files#diff-abdba5791a8f0143685a423eba82d53f951df55e45d87b5bea45a1e3acd43351
Misc/NEWS.d/next/Core and Builtins/2020-05-26-17-43-58.bpo-40780.3Ckdgm.rsthttps://github.com/python/cpython/pull/20435/files#diff-7cc77ae8e35967dbc00002a50fb58b975cef8e980885be2b5021c427fed8f220
View file https://github.com/mdickinson/cpython/blob/556f7dd89b21a3dca868aed4148c17db3093152e/Misc/NEWS.d/next/Core%20and%20Builtins/2020-05-26-17-43-58.bpo-40780.3Ckdgm.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20435/{{ revealButtonHref }}
Python/dtoa.chttps://github.com/python/cpython/pull/20435/files#diff-1fd9f5e35c869584aa0c81075787ace75275a57783bc3920fa0e10a324c2ad11
View file https://github.com/mdickinson/cpython/blob/556f7dd89b21a3dca868aed4148c17db3093152e/Python/dtoa.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20435/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20435/files#diff-1fd9f5e35c869584aa0c81075787ace75275a57783bc3920fa0e10a324c2ad11
https://github.com/python/cpython/pull/20435/files#diff-1fd9f5e35c869584aa0c81075787ace75275a57783bc3920fa0e10a324c2ad11
https://github.com/python/cpython/pull/20435/files#diff-1fd9f5e35c869584aa0c81075787ace75275a57783bc3920fa0e10a324c2ad11
https://github.com/python/cpython/pull/20435/files#diff-1fd9f5e35c869584aa0c81075787ace75275a57783bc3920fa0e10a324c2ad11
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.