René's URL Explorer Experiment


Title: bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros by mdickinson · Pull Request #20435 · python/cpython · GitHub

Open Graph Title: bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros by mdickinson · Pull Request #20435 · python/cpython

X Title: bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros by mdickinson · Pull Request #20435 · python/cpython

Description: The dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add regress...

Open Graph Description: The dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add reg...

X Description: The dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add...

Opengraph URL: https://github.com/python/cpython/pull/20435

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:498d572a-6184-1df6-b391-bb4b2475868f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE9CC:2265AE:1E7EF29:29ACBFF:696AC02B
html-safe-nonce3863b453c54f7bb64f949fddab55ecd3a828a45e8ab4dbdbdf18ed293626d0ec
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUNDOjIyNjVBRToxRTdFRjI5OjI5QUNCRkY6Njk2QUMwMkIiLCJ2aXNpdG9yX2lkIjoiMjQzNDAxMzY1MjY2Mjc5NjMzMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc90616684149824ea2df78f084ce4eb99fe7cb74c10d23222bd2ad0d31cf101b
hovercard-subject-tagpull_request:423314681
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/20435/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/1d2eee01cdab2dd6b6129e208d3120e8522293ecd3eb89bb1c7fe1c7494e8973/python/cpython/pull/20435
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/1d2eee01cdab2dd6b6129e208d3120e8522293ecd3eb89bb1c7fe1c7494e8973/python/cpython/pull/20435
og:image:altThe dtoa.c code underlying string formatting wasn't stripping trailing zeros in some cases where it should have been. This PR fixes that. Making this a draft PR for now; I still need to add reg...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemdickinson
hostnamegithub.com
expected-hostnamegithub.com
None46ce962e0e18113ea447391b6ace8b02d4d2861e57b4fbab3658698f73d8855b
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release30300f30bb3949de255e84a146706a3bdb5c19c9
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20435#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20435
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20435
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20435
Reloadhttps://github.com/python/cpython/pull/20435
Reloadhttps://github.com/python/cpython/pull/20435
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20435
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20435
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/20435#issue-comment-box
mdickinsonhttps://github.com/mdickinson
python:masterhttps://github.com/python/cpython/tree/master
mdickinson:fix-g-mode-trailing-zerohttps://github.com/mdickinson/cpython/tree/fix-g-mode-trailing-zero
bpo-40780: Fix failure of _Py_dg_dtoa to remove trailing zeros https://github.com/python/cpython/pull/20435#top
mdickinsonhttps://github.com/mdickinson
python:masterhttps://github.com/python/cpython/tree/master
mdickinson:fix-g-mode-trailing-zerohttps://github.com/mdickinson/cpython/tree/fix-g-mode-trailing-zero
Conversation 14 https://github.com/python/cpython/pull/20435
Commits 5 https://github.com/python/cpython/pull/20435/commits
Checks 0 https://github.com/python/cpython/pull/20435/checks
Files changed https://github.com/python/cpython/pull/20435/files
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 26, 2020https://github.com/python/cpython/pull/20435#issue-625016377
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://bugs.python.org/issue40780https://bugs.python.org/issue40780
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/mdickinson
Fix failure of _Py_dg_dtoa to remove trailing zeroshttps://github.com/python/cpython/pull/20435/commits/b6ffd2e58da312b31df8a68814013f8a47804cc2
b6ffd2ehttps://github.com/python/cpython/pull/20435/commits/b6ffd2e58da312b31df8a68814013f8a47804cc2
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 26, 2020https://github.com/python/cpython/pull/20435#event-3374367169
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 26, 2020https://github.com/python/cpython/pull/20435#event-3374367315
https://github.com/mdickinson
Add regression test and news entryhttps://github.com/python/cpython/pull/20435/commits/589da50d7ffe71c7ffadfdd2b0a4b1c8be16fb12
589da50https://github.com/python/cpython/pull/20435/commits/589da50d7ffe71c7ffadfdd2b0a4b1c8be16fb12
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 26, 2020 https://github.com/python/cpython/pull/20435#pullrequestreview-418493784
View reviewed changes https://github.com/python/cpython/pull/20435/files/589da50d7ffe71c7ffadfdd2b0a4b1c8be16fb12
Python/dtoa.chttps://github.com/python/cpython/pull/20435/files/589da50d7ffe71c7ffadfdd2b0a4b1c8be16fb12#diff-1fd9f5e35c869584aa0c81075787ace75275a57783bc3920fa0e10a324c2ad11
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/mdickinson
Add explanation about why it's safe to strip trailing zeroshttps://github.com/python/cpython/pull/20435/commits/e9a13a1d4c6f384ab2e4f7e069e77b8fecd38f9c
e9a13a1https://github.com/python/cpython/pull/20435/commits/e9a13a1d4c6f384ab2e4f7e069e77b8fecd38f9c
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 26, 2020 17:28https://github.com/python/cpython/pull/20435#event-3374608287
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
May 26, 2020https://github.com/python/cpython/pull/20435#event-3374631311
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
May 26, 2020 https://github.com/python/cpython/pull/20435#pullrequestreview-418528713
View reviewed changes https://github.com/python/cpython/pull/20435/files/e9a13a1d4c6f384ab2e4f7e069e77b8fecd38f9c
ericvsmithhttps://github.com/ericvsmith
https://github.com/python/cpython/pull/20435#pullrequestreview-418528713
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@mdickinsonhttps://github.com/mdickinson
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 26, 2020https://github.com/python/cpython/pull/20435#issuecomment-634177567
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
needs backport to 3.7 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.7%22
May 27, 2020https://github.com/python/cpython/pull/20435#event-3378037411
https://github.com/mdickinson
Make code safer, clean up comments, add change note at top of filehttps://github.com/python/cpython/pull/20435/commits/5773e56d03c7d964fc974c836334b8d6bdf3b0b8
5773e56https://github.com/python/cpython/pull/20435/commits/5773e56d03c7d964fc974c836334b8d6bdf3b0b8
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 27, 2020https://github.com/python/cpython/pull/20435#issuecomment-634669564
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/mdickinson
Nitpick: avoid implicit int-to-float conversion in testshttps://github.com/python/cpython/pull/20435/commits/556f7dd89b21a3dca868aed4148c17db3093152e
556f7ddhttps://github.com/python/cpython/pull/20435/commits/556f7dd89b21a3dca868aed4148c17db3093152e
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 27, 2020https://github.com/python/cpython/pull/20435#issuecomment-634690603
http://www.netlib.org/fp/dtoa.chttp://www.netlib.org/fp/dtoa.c
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/davidchambers
davidchambershttps://github.com/davidchambers
May 27, 2020https://github.com/python/cpython/pull/20435#issuecomment-634865980
@mdickinsonhttps://github.com/mdickinson
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
ericvsmithhttps://github.com/ericvsmith
May 29, 2020 10:19https://github.com/python/cpython/pull/20435#event-3386568348
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 29, 2020https://github.com/python/cpython/pull/20435#issuecomment-635896795
@ericvsmithhttps://github.com/ericvsmith
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/ericvsmith
ericvsmithhttps://github.com/ericvsmith
May 29, 2020 https://github.com/python/cpython/pull/20435#pullrequestreview-420870423
View reviewed changes https://github.com/python/cpython/pull/20435/files/556f7dd89b21a3dca868aed4148c17db3093152e
ericvsmithhttps://github.com/ericvsmith
https://github.com/python/cpython/pull/20435#pullrequestreview-420870423
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 29, 2020https://github.com/python/cpython/pull/20435#event-3386789455
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
895c9c1https://github.com/python/cpython/commit/895c9c1d438367722f74f437fda96767d770662b
May 29, 2020https://github.com/python/cpython/pull/20435#event-3387168463
https://github.com/miss-islington
miss-islingtonhttps://github.com/miss-islington
May 29, 2020https://github.com/python/cpython/pull/20435#issuecomment-635970385
@mdickinsonhttps://github.com/mdickinson
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting merge https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20merge%22
May 29, 2020https://github.com/python/cpython/pull/20435#event-3387168607
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
May 29, 2020https://github.com/python/cpython/pull/20435#issuecomment-635970524
GH-20514https://github.com/python/cpython/pull/20514
3.9 branchhttps://github.com/python/cpython/tree/3.9
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
needs backport to 3.9 https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22needs%20backport%20to%203.9%22
May 29, 2020https://github.com/python/cpython/pull/20435#event-3387169688
mdickinsonhttps://github.com/mdickinson
May 29, 2020 https://github.com/python/cpython/pull/20435#ref-commit-ad088ca
https://github.com/miss-islington
https://github.com/mdickinson
bpo-40780https://bugs.python.org/issue?@action=redirect&bpo=40780
: Fix failure of _Py_dg_dtoa to remove trailing zeros (https://github.com/python/cpython/commit/ad088ca5c6adc4a107411cad62b83f5c6e06b5ed
GH-20435https://github.com/python/cpython/pull/20435
ad088cahttps://github.com/python/cpython/commit/ad088ca5c6adc4a107411cad62b83f5c6e06b5ed
https://github.com/python/cpython/pull/20435
GH-20514https://github.com/python/cpython/pull/20514
895c9c1https://github.com/python/cpython/commit/895c9c1d438367722f74f437fda96767d770662b
https://github.com/mdickinson
mdickinsonhttps://github.com/mdickinson
May 29, 2020 13:47https://github.com/python/cpython/pull/20435#event-3387260385
CuriousLearnerhttps://github.com/CuriousLearner
May 30, 2020 https://github.com/python/cpython/pull/20435#ref-commit-d3d7100
https://github.com/CuriousLearner
Merge branch 'master' of github.com:python/cpython into bpo-26543https://github.com/CuriousLearner/cpython/commit/d3d710010cf15a9210861757e8526291b7389b32
d3d7100https://github.com/CuriousLearner/cpython/commit/d3d710010cf15a9210861757e8526291b7389b32
pythonGH-19748https://github.com/python/cpython/pull/19748
pythonGH-20483https://github.com/python/cpython/pull/20483
pythonGH-20149https://github.com/python/cpython/pull/20149
pythonGH-18951https://github.com/python/cpython/pull/18951
python#771https://github.com/python/cpython/pull/771
python#20499https://github.com/python/cpython/pull/20499
pythonGH-20435https://github.com/python/cpython/pull/20435
pythonGH-20509https://github.com/python/cpython/pull/20509
pythongh-17620https://github.com/python/cpython/pull/17620
pythonGH-20448https://github.com/python/cpython/pull/20448
pythonGH-20494https://github.com/python/cpython/pull/20494
pythonGH-19732https://github.com/python/cpython/pull/19732
python#19851https://github.com/python/cpython/pull/19851
pythonGH-20492https://github.com/python/cpython/pull/20492
pythonGH-20332https://github.com/python/cpython/pull/20332
pythonGH-20489https://github.com/python/cpython/pull/20489
pythonGH-20493https://github.com/python/cpython/pull/20493
pythonGH-20339https://github.com/python/cpython/pull/20339
pythonGH-20177https://github.com/python/cpython/pull/20177
pythonGH-20488https://github.com/python/cpython/pull/20488
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20435
https://github.com/ericvsmith
ericvsmith https://github.com/ericvsmith
https://github.com/python/cpython/pull/20435/files/556f7dd89b21a3dca868aed4148c17db3093152e
Please reload this pagehttps://github.com/python/cpython/pull/20435
https://github.com/mdickinson
https://github.com/davidchambers
https://github.com/miss-islington
https://github.com/bedevere-bot
https://github.com/ericvsmith
https://github.com/the-knights-who-say-ni
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.