René's URL Explorer Experiment


Title: bpo-40217: Make heap types always visit Py_TYPE(self) from tp_traverse by encukou · Pull Request #20433 · python/cpython · GitHub

Open Graph Title: bpo-40217: Make heap types always visit Py_TYPE(self) from tp_traverse by encukou · Pull Request #20433 · python/cpython

X Title: bpo-40217: Make heap types always visit Py_TYPE(self) from tp_traverse by encukou · Pull Request #20433 · python/cpython

Description: This builds on top of @pablogsal's #20264, see discussion there. See the proposed docs for what is changing. There is a reference leak in test_interpreters that I haven't yet been able to track dow...

Open Graph Description: This builds on top of @pablogsal's #20264, see discussion there. See the proposed docs for what is changing. There is a reference leak in test_interpreters that I haven't yet been able to t...

X Description: This builds on top of @pablogsal's #20264, see discussion there. See the proposed docs for what is changing. There is a reference leak in test_interpreters that I haven't yet been a...

Opengraph URL: https://github.com/python/cpython/pull/20433

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:0da5a848-3053-8690-f607-31757979b121
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE276:FC316:18115A6:1FE45C8:696AE910
html-safe-noncea53fbfd51a3f35edfe1cd9aec3a9fbffed63158d8c75be3d8c38bd8150e9c7f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMjc2OkZDMzE2OjE4MTE1QTY6MUZFNDVDODo2OTZBRTkxMCIsInZpc2l0b3JfaWQiOiIzMDMyNzgwMjIzMTI4NzI1Nzc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacde14352c1ba997dcfd9f3fc4efc068a551ce763126bd719ee3c74aec0220e1c4
hovercard-subject-tagpull_request:423292013
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/python/cpython/20433/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6c0c49f1e2921f93604f8dc2d1432a7b9111719dc22a3d30b5c1e6f2ff40e67e/python/cpython/pull/20433
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6c0c49f1e2921f93604f8dc2d1432a7b9111719dc22a3d30b5c1e6f2ff40e67e/python/cpython/pull/20433
og:image:altThis builds on top of @pablogsal's #20264, see discussion there. See the proposed docs for what is changing. There is a reference leak in test_interpreters that I haven't yet been able to t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameencukou
hostnamegithub.com
expected-hostnamegithub.com
None5f99f7c1d70f01da5b93e5ca90303359738944d8ab470e396496262c66e60b8d
turbo-cache-controlno-preview
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release82560a55c6b2054555076f46e683151ee28a19bc
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20433#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20433
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20433
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20433
Reloadhttps://github.com/python/cpython/pull/20433
Reloadhttps://github.com/python/cpython/pull/20433
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20433
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20433
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
Jump to bottomhttps://github.com/python/cpython/pull/20433#issue-comment-box
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:bpo-40217https://github.com/encukou/cpython/tree/bpo-40217
bpo-40217: Make heap types always visit Py_TYPE(self) from tp_traverse https://github.com/python/cpython/pull/20433#top
encukouhttps://github.com/encukou
python:masterhttps://github.com/python/cpython/tree/master
encukou:bpo-40217https://github.com/encukou/cpython/tree/bpo-40217
Conversation 4 https://github.com/python/cpython/pull/20433
Commits 4 https://github.com/python/cpython/pull/20433/commits
Checks 0 https://github.com/python/cpython/pull/20433/checks
Files changed https://github.com/python/cpython/pull/20433/files
Please reload this pagehttps://github.com/python/cpython/pull/20433
https://github.co/hiddenchars
https://github.com/python/cpython/pull/{{ revealButtonHref }}
https://github.com/encukou
encukouhttps://github.com/encukou
May 26, 2020https://github.com/python/cpython/pull/20433#issue-624988749
Please reload this pagehttps://github.com/python/cpython/pull/20433
@pablogsalhttps://github.com/pablogsal
#20264https://github.com/python/cpython/pull/20264
https://bugs.python.org/issue40217https://bugs.python.org/issue40217
Please reload this pagehttps://github.com/python/cpython/pull/20433
pablogsalhttps://github.com/pablogsal
May 23, 2020 01:46https://github.com/python/cpython/pull/20433#commits-pushed-3bc77ee
https://github.com/pablogsal
Revert "bpo-40217: Ensure Py_VISIT(Py_TYPE(self)) is always called fo…https://github.com/python/cpython/pull/20433/commits/3bc77ee98c48eb9cafc80ad8ce40e8d35b36b301
3bc77eehttps://github.com/python/cpython/pull/20433/commits/3bc77ee98c48eb9cafc80ad8ce40e8d35b36b301
pythonGH-19414https://github.com/python/cpython/pull/19414
0169d30https://github.com/encukou/cpython/commit/0169d3003be3d072751dd14a5c84748ab63a249f
https://github.com/pablogsal
Fix heap types in the stdlib to correctly visit its parenthttps://github.com/python/cpython/pull/20433/commits/a7ccd4dab2227804cd454d7b5477a49942503395
a7ccd4dhttps://github.com/python/cpython/pull/20433/commits/a7ccd4dab2227804cd454d7b5477a49942503395
https://github.com/pablogsal
Add documentation about the changehttps://github.com/python/cpython/pull/20433/commits/2cff2b5155c4a452307aa9bb3c6d2cb27244d4c3
2cff2b5https://github.com/python/cpython/pull/20433/commits/2cff2b5155c4a452307aa9bb3c6d2cb27244d4c3
https://github.com/encukou
subtype_traverse: Don't visit the type if base is a heap type.https://github.com/python/cpython/pull/20433/commits/28189cbdac1b2b11e2ed455241383d831b12c0ef
28189cbhttps://github.com/python/cpython/pull/20433/commits/28189cbdac1b2b11e2ed455241383d831b12c0ef
https://github.com/the-knights-who-say-ni
the-knights-who-say-nihttps://github.com/the-knights-who-say-ni
CLA signed https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22CLA%20signed%22
May 26, 2020https://github.com/python/cpython/pull/20433#event-3374198396
https://github.com/bedevere-bot
bedevere-bothttps://github.com/bedevere-bot
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
May 26, 2020https://github.com/python/cpython/pull/20433#event-3374198601
https://github.com/encukou
encukouhttps://github.com/encukou
May 26, 2020 https://github.com/python/cpython/pull/20433#ref-pullrequest-621904618
bpo-40217: Ensure Py_VISIT(Py_TYPE(self)) is always called for PyType_FromSpec types (reverts GH-19414) #20264 https://github.com/python/cpython/pull/20264
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 26, 2020https://github.com/python/cpython/pull/20433#issuecomment-634133051
https://buildbot.python.org/all/#/builders/394/builds/94https://buildbot.python.org/all/#/builders/394/builds/94
Please reload this pagehttps://github.com/python/cpython/pull/20433
https://github.com/pablogsal
pablogsalhttps://github.com/pablogsal
May 26, 2020https://github.com/python/cpython/pull/20433#issuecomment-634167844
@encukouhttps://github.com/encukou
#20264https://github.com/python/cpython/pull/20264
Please reload this pagehttps://github.com/python/cpython/pull/20433
https://github.com/encukou
encukouhttps://github.com/encukou
May 27, 2020https://github.com/python/cpython/pull/20433#issuecomment-634496108
Please reload this pagehttps://github.com/python/cpython/pull/20433
https://github.com/encukou
encukouhttps://github.com/encukou
May 27, 2020https://github.com/python/cpython/pull/20433#issuecomment-634517701
Please reload this pagehttps://github.com/python/cpython/pull/20433
https://github.com/encukou
encukouhttps://github.com/encukou
May 27, 2020https://github.com/python/cpython/pull/20433#event-3377044820
https://github.com/encukou
encukouhttps://github.com/encukou
May 28, 2020 15:39https://github.com/python/cpython/pull/20433#event-3383411653
https://github.com/encukou
encukouhttps://github.com/encukou
May 28, 2020 15:40https://github.com/python/cpython/pull/20433#event-3383412188
https://github.com/encukou
encukouhttps://github.com/encukou
May 28, 2020 15:42https://github.com/python/cpython/pull/20433#event-3383423753
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20433
awaiting core review https://github.com/python/cpython/issues?q=state%3Aopen%20label%3A%22awaiting%20core%20review%22
Please reload this pagehttps://github.com/python/cpython/pull/20433
https://github.com/encukou
https://github.com/pablogsal
https://github.com/the-knights-who-say-ni
https://github.com/bedevere-bot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.