René's URL Explorer Experiment


Title: bpo-30064: Fix asyncio loop.sock_* race condition issue by fantix · Pull Request #20369 · python/cpython · GitHub

Open Graph Title: bpo-30064: Fix asyncio loop.sock_* race condition issue by fantix · Pull Request #20369 · python/cpython

X Title: bpo-30064: Fix asyncio loop.sock_* race condition issue by fantix · Pull Request #20369 · python/cpython

Description: https://bugs.python.org/issue30064 This is reproducible by a cancel() followed directly by a retry: done, pending = await asyncio.wait([loop.sock_recv(sock, 1024)], timeout=0.1) if done: data = await done.pop() else: pending.pop().cancel() data = await loop.sock_recv(sock, 1024) This issue applies to all the loop.sock_* methods. Without this PR, users could work it around by adding a sleep(0): done, pending = await asyncio.wait([loop.sock_recv(sock, 1024)], timeout=0.1) if done: data = await done.pop() else: pending.pop().cancel() await asyncio.sleep(0) # <---- this ensures that the right reader is removed data = await loop.sock_recv(sock, 1024)

Open Graph Description: https://bugs.python.org/issue30064 This is reproducible by a cancel() followed directly by a retry: done, pending = await asyncio.wait([loop.sock_recv(sock, 1024)], timeout=0.1) if done: data ...

X Description: https://bugs.python.org/issue30064 This is reproducible by a cancel() followed directly by a retry: done, pending = await asyncio.wait([loop.sock_recv(sock, 1024)], timeout=0.1) if done: data ...

Opengraph URL: https://github.com/python/cpython/pull/20369

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:67b01060-bbb0-23f9-e38e-9cf99d51c6f7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDC6:14C034:E67786:13C8964:6969F393
html-safe-nonce3a85475a803f90c64ea9d68938b608c2bae1f8043a6995d2c853b5713c288bd1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREM2OjE0QzAzNDpFNjc3ODY6MTNDODk2NDo2OTY5RjM5MyIsInZpc2l0b3JfaWQiOiIzNDY5OTY3MjAzMzQxMzAwNjI3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac70624a281325765ffd12548600125c3258cb3a78f55da2ade693221afb2c97d7
hovercard-subject-tagpull_request:422482704
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20369/files
twitter:imagehttps://avatars.githubusercontent.com/u/1751601?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1751601?s=400&v=4
og:image:althttps://bugs.python.org/issue30064 This is reproducible by a cancel() followed directly by a retry: done, pending = await asyncio.wait([loop.sock_recv(sock, 1024)], timeout=0.1) if done: data ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7b32f1c7c4549428ee399213e8345494fc55b5637195d3fc5f493657579235e8
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasebdde15ad1b403e23b08bbd89b53fbe6bdf688cad
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20369/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20369%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20369%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20369/files
Reloadhttps://github.com/python/cpython/pull/20369/files
Reloadhttps://github.com/python/cpython/pull/20369/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20369/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20369/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
1st1https://github.com/1st1
python:masterhttps://github.com/python/cpython/tree/master
fantix:fix-issue-30064https://github.com/fantix/cpython/tree/fix-issue-30064
Conversation 8 https://github.com/python/cpython/pull/20369
Commits 2 https://github.com/python/cpython/pull/20369/commits
Checks 0 https://github.com/python/cpython/pull/20369/checks
Files changed https://github.com/python/cpython/pull/20369/files
Please reload this pagehttps://github.com/python/cpython/pull/20369/files
bpo-30064: Fix asyncio loop.sock_* race condition issue https://github.com/python/cpython/pull/20369/files#top
Show all changes 2 commits https://github.com/python/cpython/pull/20369/files
ee75018 bpo-30064: Fix asyncio loop.sock_* race condition issue fantix May 24, 2020 https://github.com/python/cpython/pull/20369/commits/ee75018ca94b9eec05bcf5287d2c7b5ce67d65eb
a7636c6 Keep returning None for `loop.add_reader/writer` fantix May 25, 2020 https://github.com/python/cpython/pull/20369/commits/a7636c6aaf16f2a01fe7d63b405a489fa5b6cb05
Clear filters https://github.com/python/cpython/pull/20369/files
Please reload this pagehttps://github.com/python/cpython/pull/20369/files
Please reload this pagehttps://github.com/python/cpython/pull/20369/files
selector_events.py https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
test_sock_lowlevel.py https://github.com/python/cpython/pull/20369/files#diff-80001b2e1f4874e8d3bb4ff5cb5726de0453614831d477b6d7ef36dfa437d17c
2020-05-25-11-52-23.bpo-30064.6CICsH.rst https://github.com/python/cpython/pull/20369/files#diff-9619f0db34e8e50803ca7670f1e711b112c86cf43f170b9390ee07e4826927f9
Lib/asyncio/selector_events.pyhttps://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
View file https://github.com/fantix/cpython/blob/a7636c6aaf16f2a01fe7d63b405a489fa5b6cb05/Lib/asyncio/selector_events.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20369/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
Please reload this pagehttps://github.com/python/cpython/pull/20369/files
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
https://github.com/python/cpython/pull/20369/files#diff-905d4384eaa0f1d54083b6d643e90b9404e32339f2c151e880491cb2e595f207
Lib/test/test_asyncio/test_sock_lowlevel.pyhttps://github.com/python/cpython/pull/20369/files#diff-80001b2e1f4874e8d3bb4ff5cb5726de0453614831d477b6d7ef36dfa437d17c
View file https://github.com/fantix/cpython/blob/a7636c6aaf16f2a01fe7d63b405a489fa5b6cb05/Lib/test/test_asyncio/test_sock_lowlevel.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20369/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20369/files#diff-80001b2e1f4874e8d3bb4ff5cb5726de0453614831d477b6d7ef36dfa437d17c
https://github.com/python/cpython/pull/20369/files#diff-80001b2e1f4874e8d3bb4ff5cb5726de0453614831d477b6d7ef36dfa437d17c
https://github.com/python/cpython/pull/20369/files#diff-80001b2e1f4874e8d3bb4ff5cb5726de0453614831d477b6d7ef36dfa437d17c
Misc/NEWS.d/next/Library/2020-05-25-11-52-23.bpo-30064.6CICsH.rsthttps://github.com/python/cpython/pull/20369/files#diff-9619f0db34e8e50803ca7670f1e711b112c86cf43f170b9390ee07e4826927f9
View file https://github.com/fantix/cpython/blob/a7636c6aaf16f2a01fe7d63b405a489fa5b6cb05/Misc/NEWS.d/next/Library/2020-05-25-11-52-23.bpo-30064.6CICsH.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20369/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.