René's URL Explorer Experiment


Title: [3.9] bpo-40334: Produce better error messages for non-parenthesized genexps (GH-20153) by miss-islington · Pull Request #20307 · python/cpython · GitHub

Open Graph Title: [3.9] bpo-40334: Produce better error messages for non-parenthesized genexps (GH-20153) by miss-islington · Pull Request #20307 · python/cpython

X Title: [3.9] bpo-40334: Produce better error messages for non-parenthesized genexps (GH-20153) by miss-islington · Pull Request #20307 · python/cpython

Description: The error message, generated for a non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the first argument in the call. With this patch, even on input like f(a, b, c for c in d, e), the correct error message gets produced. (cherry picked from commit ae14583) Co-authored-by: Lysandros Nikolaou lisandrosnik@gmail.com https://bugs.python.org/issue40334

Open Graph Description: The error message, generated for a non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the first ar...

X Description: The error message, generated for a non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the firs...

Opengraph URL: https://github.com/python/cpython/pull/20307

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:4bad6597-f100-a76b-0096-15d03a6af316
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9C68:28C591:1373D39:1B334DF:696A3460
html-safe-nonce397544f5640fc3ca42cea9b056954432e83ce42f40ae5f34c4f8cec7ed0da051
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzY4OjI4QzU5MToxMzczRDM5OjFCMzM0REY6Njk2QTM0NjAiLCJ2aXNpdG9yX2lkIjoiMjkwNDcyNjA0Mzc4MTM3OTE2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd165bb48ec165c816370105e600386ac10c968a90c1352c2b8d62cce2d057025
hovercard-subject-tagpull_request:421658763
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/python/cpython/pull/20307/files
twitter:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/31488909?s=400&v=4
og:image:altThe error message, generated for a non-parenthesized generator expression in function calls, was still the generic invalid syntax, when the generator expression wasn't appearing as the first ar...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None321736bfdb3f591415ae895a0459bec204b26a76caf47ba5c980634cfacc4538
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/python/cpython git https://github.com/python/cpython.git
octolytics-dimension-user_id1525981
octolytics-dimension-user_loginpython
octolytics-dimension-repository_id81598961
octolytics-dimension-repository_nwopython/cpython
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id81598961
octolytics-dimension-repository_network_root_nwopython/cpython
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7a9163cefd1ea4bd06f8eb7c082f43e4e53f626f
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/python/cpython/pull/20307/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20307%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub SparkBuild and deploy intelligent appshttps://github.com/features/spark
GitHub ModelsManage and compare promptshttps://github.com/features/models
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
GitHub SponsorsFund open source developershttps://github.com/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/accelerator
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fpython%2Fcpython%2Fpull%2F20307%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=python%2Fcpython
Reloadhttps://github.com/python/cpython/pull/20307/files
Reloadhttps://github.com/python/cpython/pull/20307/files
Reloadhttps://github.com/python/cpython/pull/20307/files
python https://github.com/python
cpythonhttps://github.com/python/cpython
Please reload this pagehttps://github.com/python/cpython/pull/20307/files
Notifications https://github.com/login?return_to=%2Fpython%2Fcpython
Fork 33.9k https://github.com/login?return_to=%2Fpython%2Fcpython
Star 71.1k https://github.com/login?return_to=%2Fpython%2Fcpython
Code https://github.com/python/cpython
Issues 5k+ https://github.com/python/cpython/issues
Pull requests 2.1k https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects 31 https://github.com/python/cpython/projects
Security Uh oh! There was an error while loading. Please reload this page. https://github.com/python/cpython/security
Please reload this pagehttps://github.com/python/cpython/pull/20307/files
Insights https://github.com/python/cpython/pulse
Code https://github.com/python/cpython
Issues https://github.com/python/cpython/issues
Pull requests https://github.com/python/cpython/pulls
Actions https://github.com/python/cpython/actions
Projects https://github.com/python/cpython/projects
Security https://github.com/python/cpython/security
Insights https://github.com/python/cpython/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fpython%2Fcpython%2Fissues%2Fnew%2Fchoose
miss-islingtonhttps://github.com/miss-islington
python:3.9https://github.com/python/cpython/tree/3.9
miss-islington:backport-ae14583-3.9https://github.com/miss-islington/cpython/tree/backport-ae14583-3.9
Conversation 3 https://github.com/python/cpython/pull/20307
Commits 1 https://github.com/python/cpython/pull/20307/commits
Checks 0 https://github.com/python/cpython/pull/20307/checks
Files changed https://github.com/python/cpython/pull/20307/files
Please reload this pagehttps://github.com/python/cpython/pull/20307/files
[3.9] bpo-40334: Produce better error messages for non-parenthesized genexps (GH-20153) https://github.com/python/cpython/pull/20307/files#top
Show all changes 1 commit https://github.com/python/cpython/pull/20307/files
9f7992d bpo-40334: Produce better error messages for non-parenthesized genexp… lysnikolaou May 22, 2020 https://github.com/python/cpython/pull/20307/commits/9f7992d8364158e5f8fd82bd37a048fc2934fd07
Clear filters https://github.com/python/cpython/pull/20307/files
Please reload this pagehttps://github.com/python/cpython/pull/20307/files
Please reload this pagehttps://github.com/python/cpython/pull/20307/files
python.gram https://github.com/python/cpython/pull/20307/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
test_syntax.py https://github.com/python/cpython/pull/20307/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
parse.c https://github.com/python/cpython/pull/20307/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
pegen.c https://github.com/python/cpython/pull/20307/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
pegen.h https://github.com/python/cpython/pull/20307/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
Grammar/python.gramhttps://github.com/python/cpython/pull/20307/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
View file https://github.com/miss-islington/cpython/blob/9f7992d8364158e5f8fd82bd37a048fc2934fd07/Grammar/python.gram
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20307/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
https://github.com/python/cpython/pull/20307/files#diff-2973ca53337859793077e9bdc1a1623063379f0fdfcb788836fd82ebb66b763b
Lib/test/test_syntax.pyhttps://github.com/python/cpython/pull/20307/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
View file https://github.com/miss-islington/cpython/blob/9f7992d8364158e5f8fd82bd37a048fc2934fd07/Lib/test/test_syntax.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20307/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/pull/20307/files#diff-985c9f5237c42a342864f5cbdb35dc56bc0017f44d5dfa561ecbef72e4a7ad4f
https://github.com/python/cpython/blob/3.9/.github/CODEOWNERS#L77
Parser/pegen/parse.chttps://github.com/python/cpython/pull/20307/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
View file https://github.com/miss-islington/cpython/blob/9f7992d8364158e5f8fd82bd37a048fc2934fd07/Parser/pegen/parse.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20307/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/pull/20307/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/pull/20307/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/pull/20307/files#diff-a0066ba71aaf2e4958c42c8af79b77a0954bb7af0592adbbd62cc858c4bdb6c9
https://github.com/python/cpython/blob/3.9/.github/CODEOWNERS#L77
Parser/pegen/pegen.chttps://github.com/python/cpython/pull/20307/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
View file https://github.com/miss-islington/cpython/blob/9f7992d8364158e5f8fd82bd37a048fc2934fd07/Parser/pegen/pegen.c
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20307/files#diff-0ed7ec9eb1c1598c607560250c03d68b5231d62b6ff651bea09bf4af41f1544d
https://github.com/python/cpython/blob/3.9/.github/CODEOWNERS#L77
Parser/pegen/pegen.hhttps://github.com/python/cpython/pull/20307/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
View file https://github.com/miss-islington/cpython/blob/9f7992d8364158e5f8fd82bd37a048fc2934fd07/Parser/pegen/pegen.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/python/cpython/pull/20307/{{ revealButtonHref }}
https://github.com/python/cpython/pull/20307/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/20307/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/20307/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com/python/cpython/pull/20307/files#diff-d4a9f49107c909c0f1e57dd99583f66009864915bf543994535f4d87139b79f6
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.